29573 Commits

Author SHA1 Message Date
skia-flutter-autoroll
6a607df41e Roll Fuchsia Mac SDK from JewrT71vAzyDs8qRt... to fdtK_FqpscIVvbb_j... (flutter/engine#42997)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-20 10:43:06 +00:00
skia-flutter-autoroll
2173c6032e Roll Dart SDK from d87670619414 to dc6691ef755c (1 revision) (flutter/engine#42996)
https://dart.googlesource.com/sdk.git/+log/d87670619414..dc6691ef755c

2023-06-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-231.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-20 08:01:04 +00:00
skia-flutter-autoroll
8db025d6d2 Roll Skia from 60385192e512 to 1d6ca884ed77 (3 revisions) (flutter/engine#42995)
https://skia.googlesource.com/skia.git/+log/60385192e512..1d6ca884ed77

2023-06-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 24f4007b93e0 to 84379a529407 (9 revisions)
2023-06-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from ab08126079d3 to 850bcdd8dfed
2023-06-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from b32ce543bca1 to ab08126079d3 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-20 07:45:27 +00:00
skia-flutter-autoroll
d19dcc9340 Roll Skia from abcc292f8afe to 60385192e512 (1 revision) (flutter/engine#42993)
https://skia.googlesource.com/skia.git/+log/abcc292f8afe..60385192e512

2023-06-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from fc6011e89acd to 0d5e76a2427f (24 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-20 05:51:36 +00:00
skia-flutter-autoroll
7b402c36f0 Roll Fuchsia Linux SDK from lG2K667BLaS_haUZg... to jzCJwD297aRZtdakZ... (flutter/engine#42990)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-19 23:59:17 +00:00
skia-flutter-autoroll
dd81225c44 Roll Skia from 9c2148cd1c82 to abcc292f8afe (1 revision) (flutter/engine#42989)
https://skia.googlesource.com/skia.git/+log/9c2148cd1c82..abcc292f8afe

2023-06-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 9ed904489a9a to 37334fcf8703 (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-19 22:43:32 +00:00
skia-flutter-autoroll
8435b90b4b Roll Fuchsia Mac SDK from gX0QkT_dMBCTbiAHY... to JewrT71vAzyDs8qRt... (flutter/engine#42988)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-19 21:37:23 +00:00
skia-flutter-autoroll
3c0336db57 Roll Skia from 41689ff01f97 to 9c2148cd1c82 (1 revision) (flutter/engine#42987)
https://skia.googlesource.com/skia.git/+log/41689ff01f97..9c2148cd1c82

2023-06-19 johnstiles@google.com Fix fuzzer-discovered error with inlined arrays.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-19 20:08:15 +00:00
skia-flutter-autoroll
a3765b1e50 Roll Dart SDK from 60adb12ffc30 to d87670619414 (1 revision) (flutter/engine#42986)
https://dart.googlesource.com/sdk.git/+log/60adb12ffc30..d87670619414

2023-06-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-230.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-19 20:04:52 +00:00
skia-flutter-autoroll
4fddeed704 Roll Skia from 455d7306b951 to 41689ff01f97 (1 revision) (flutter/engine#42983)
https://skia.googlesource.com/skia.git/+log/455d7306b951..41689ff01f97

2023-06-19 johnstiles@google.com Fix fuzzer-discovered error with void variables.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-19 16:21:12 +00:00
skia-flutter-autoroll
07ad0d9e44 Roll Dart SDK from 3d07173415e8 to 60adb12ffc30 (1 revision) (flutter/engine#42982)
https://dart.googlesource.com/sdk.git/+log/3d07173415e8..60adb12ffc30

2023-06-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-229.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-19 16:01:18 +00:00
skia-flutter-autoroll
36ccc5c664 Roll Fuchsia Linux SDK from fgS2avQGq4x_sbZHU... to lG2K667BLaS_haUZg... (flutter/engine#42981)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-19 11:00:25 +00:00
skia-flutter-autoroll
159547f733 Roll Skia from c90c7dec5c18 to 455d7306b951 (1 revision) (flutter/engine#42980)
https://skia.googlesource.com/skia.git/+log/c90c7dec5c18..455d7306b951

2023-06-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4aa38765aadb to 9ed904489a9a (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-19 10:20:10 +00:00
skia-flutter-autoroll
205568a280 Roll Skia from d182b694a670 to c90c7dec5c18 (1 revision) (flutter/engine#42979)
https://skia.googlesource.com/skia.git/+log/d182b694a670..c90c7dec5c18

2023-06-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from edf58105d695 to 24f4007b93e0 (9 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-19 09:20:15 +00:00
skia-flutter-autoroll
c0060cf84f Roll Dart SDK from b2ec326cc4f3 to 3d07173415e8 (1 revision) (flutter/engine#42978)
https://dart.googlesource.com/sdk.git/+log/b2ec326cc4f3..3d07173415e8

2023-06-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-228.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-19 08:20:18 +00:00
skia-flutter-autoroll
3a5a1386d8 Roll Skia from 24f2336d87f2 to d182b694a670 (2 revisions) (flutter/engine#42977)
https://skia.googlesource.com/skia.git/+log/24f2336d87f2..d182b694a670

2023-06-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from b32ce543bca1 to 15fb7caa7aea
2023-06-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from d044984a01de to b32ce543bca1 (29 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-19 06:54:16 +00:00
skia-flutter-autoroll
6f192cb503 Roll Fuchsia Mac SDK from BuzniDS9u_hdghV5f... to gX0QkT_dMBCTbiAHY... (flutter/engine#42976)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-19 06:26:24 +00:00
skia-flutter-autoroll
53ebbe2765 Roll Skia from f489be63a30a to 24f2336d87f2 (1 revision) (flutter/engine#42975)
https://skia.googlesource.com/skia.git/+log/f489be63a30a..24f2336d87f2

2023-06-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 4588fe12df3d to fc6011e89acd (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-19 05:45:08 +00:00
skia-flutter-autoroll
9d353fdd13 Roll Dart SDK from 5a9e97eebbed to b2ec326cc4f3 (1 revision) (flutter/engine#42974)
https://dart.googlesource.com/sdk.git/+log/5a9e97eebbed..b2ec326cc4f3

2023-06-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-227.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-19 03:59:23 +00:00
Jonah Williams
6ddcc5c032 Fix prefer_final_in_foreach analysis errors (flutter/engine#42971)
This is now failing the engine roll for some reason https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20analyze/58456/overview
2023-06-18 23:49:28 +00:00
skia-flutter-autoroll
9474fbd337 Roll Fuchsia Linux SDK from xS5RzQLfpMEK1rNEd... to fgS2avQGq4x_sbZHU... (flutter/engine#42973)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-18 21:45:33 +00:00
skia-flutter-autoroll
7baf327e24 Roll Fuchsia Mac SDK from aBEyk5N2HlwOqvpwo... to BuzniDS9u_hdghV5f... (flutter/engine#42970)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-18 17:21:23 +00:00
skia-flutter-autoroll
8e14cb2cbf Roll Skia from dc2e0ebbd045 to f489be63a30a (1 revision) (flutter/engine#42968)
https://skia.googlesource.com/skia.git/+log/dc2e0ebbd045..f489be63a30a

2023-06-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 3b886d2fc60b to 4aa38765aadb (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-18 12:49:21 +00:00
skia-flutter-autoroll
e3ef7be7b9 Roll Skia from 85b4788bc3f1 to dc2e0ebbd045 (1 revision) (flutter/engine#42967)
https://skia.googlesource.com/skia.git/+log/85b4788bc3f1..dc2e0ebbd045

2023-06-18 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-18 11:01:22 +00:00
skia-flutter-autoroll
a7d9ca22c1 Roll Fuchsia Linux SDK from -PsA0LDB2FdS_4_vK... to xS5RzQLfpMEK1rNEd... (flutter/engine#42966)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-18 08:35:29 +00:00
Brandon DeRosier
072ed208cf [Impeller] Use 32 bit for positional stuff in the rrect blur (flutter/engine#42797)
Resolves https://github.com/flutter/flutter/issues/128410.

16 bit floats aren't precise enough for positional computations, like
computing SDFs in the case of the RRect blur.
2023-06-17 22:57:14 -07:00
Jonah Williams
4114b30b01 Revert "[Impeller] correct default PSO pixel format and sample count." (flutter/engine#42962)
Reverts flutter/engine#42902

This is breaking iOS builds:

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8778085761769326737/+/u/run_platform_views_scroll_perf_non_intersecting_impeller_ios__timeline_summary/test_stdout
2023-06-18 04:39:22 +00:00
Jonah Williams
93351f1448 [Impeller] dont use concurrent runner to decode images on Android. (flutter/engine#42944)
Even with separate allocators and queues, I think that using the concurrent runner is just overloading the phone.

On Android force it all onto the I/O thread.

https://github.com/flutter/flutter/issues/128919
2023-06-18 03:54:04 +00:00
skia-flutter-autoroll
e0fb29293e Roll Fuchsia Mac SDK from I1G8Ll0KcxmAoMT8u... to aBEyk5N2HlwOqvpwo... (flutter/engine#42964)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-18 02:04:35 +00:00
skia-flutter-autoroll
3919e8f2c7 Roll Skia from c56f38d79fe0 to 85b4788bc3f1 (2 revisions) (flutter/engine#42963)
https://skia.googlesource.com/skia.git/+log/c56f38d79fe0..85b4788bc3f1

2023-06-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 067b742c990a to b32ce543bca1
2023-06-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 1f524f69ec88 to 3b886d2fc60b (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-18 01:10:31 +00:00
skia-flutter-autoroll
281d006dfe Roll Fuchsia Linux SDK from Au1gd3XLMuSt1Z4oh... to -PsA0LDB2FdS_4_vK... (flutter/engine#42959)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-17 19:23:14 +00:00
skia-flutter-autoroll
b610061f2c Roll Dart SDK from d1faf69c8253 to 5a9e97eebbed (1 revision) (flutter/engine#42958)
https://dart.googlesource.com/sdk.git/+log/d1faf69c8253..5a9e97eebbed

2023-06-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-226.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-17 19:03:05 +00:00
skia-flutter-autoroll
df01d381bf Roll Skia from 2a9e11fd9d37 to c56f38d79fe0 (1 revision) (flutter/engine#42955)
https://skia.googlesource.com/skia.git/+log/2a9e11fd9d37..c56f38d79fe0

2023-06-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 8ca65cb391f4 to 1f524f69ec88 (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-17 13:28:28 +00:00
skia-flutter-autoroll
be8e950db3 Roll Fuchsia Mac SDK from JMStJe6efcLuWMT_I... to I1G8Ll0KcxmAoMT8u... (flutter/engine#42954)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-17 13:03:18 +00:00
skia-flutter-autoroll
0b7038ed2f Roll Dart SDK from 1a04f451a934 to d1faf69c8253 (1 revision) (flutter/engine#42953)
https://dart.googlesource.com/sdk.git/+log/1a04f451a934..d1faf69c8253

2023-06-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-225.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-17 11:44:23 +00:00
skia-flutter-autoroll
6459419d89 Roll Dart SDK from b3bcbdf7de8d to 1a04f451a934 (1 revision) (flutter/engine#42951)
https://dart.googlesource.com/sdk.git/+log/b3bcbdf7de8d..1a04f451a934

2023-06-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-224.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-17 07:46:05 +00:00
skia-flutter-autoroll
f3177d6d6e Roll Skia from dc11c7ddb33f to 2a9e11fd9d37 (1 revision) (flutter/engine#42950)
https://skia.googlesource.com/skia.git/+log/dc11c7ddb33f..2a9e11fd9d37

2023-06-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from d044984a01de to 067b742c990a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-17 05:32:26 +00:00
Brandon DeRosier
080271007d [Impeller] Print malioc errors on CI (flutter/engine#42906)
Resolves https://github.com/flutter/flutter/issues/128989.

Also bumps the buildroot to head for:
https://github.com/flutter/buildroot/pull/744
2023-06-16 21:37:37 -07:00
skia-flutter-autoroll
256a5a9892 Roll Dart SDK from 8eaed3382237 to b3bcbdf7de8d (10 revisions) (flutter/engine#42949)
https://dart.googlesource.com/sdk.git/+log/8eaed3382237..b3bcbdf7de8d

2023-06-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-223.0.dev
2023-06-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-222.0.dev
2023-06-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-221.0.dev
2023-06-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-220.0.dev
2023-06-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-219.0.dev
2023-06-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-218.0.dev
2023-06-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-217.0.dev
2023-06-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-216.0.dev
2023-06-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-215.0.dev
2023-06-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-214.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-17 03:42:31 +00:00
skia-flutter-autoroll
3675e9050d Roll Fuchsia Linux SDK from -NW1eatBbmjvLaIcV... to Au1gd3XLMuSt1Z4oh... (flutter/engine#42948)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-17 03:07:10 +00:00
Siva
2c57a3f9fa Fix analyzer warnings (prefer_final_in_for_each is now the default) (flutter/engine#42943)
The analyzer option `prefer_final_in_for_each` has been made the default
and this has triggered new warnings.
2023-06-16 17:33:59 -07:00
skia-flutter-autoroll
02558bc5d3 Roll Fuchsia Mac SDK from fXVcR5tdj5wSd_OUz... to JMStJe6efcLuWMT_I... (flutter/engine#42942)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-16 23:47:27 +00:00
skia-flutter-autoroll
b00436f1bc Roll Skia from 64fa632d3b01 to dc11c7ddb33f (3 revisions) (flutter/engine#42939)
https://skia.googlesource.com/skia.git/+log/64fa632d3b01..dc11c7ddb33f

2023-06-16 johnstiles@google.com Fix some outdated comments.
2023-06-16 brianosman@google.com Stop suppressing divide-by-zero errors in SkScalarInvert
2023-06-16 herb@google.com Move SkPoint to base

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-16 23:10:31 +00:00
skia-flutter-autoroll
dec05499a1 Roll Skia from 01f3be45e0d6 to 64fa632d3b01 (3 revisions) (flutter/engine#42937)
https://skia.googlesource.com/skia.git/+log/01f3be45e0d6..64fa632d3b01

2023-06-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 58c6e1ea988a to 8ca65cb391f4 (6 revisions)
2023-06-16 johnstiles@google.com Factor apart Program::dump into a helper class.
2023-06-16 herb@google.com Use float for SkPoint's coordinates

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-16 22:00:19 +00:00
Hassan
5e05d8b967 [web] Fix for Safari autofill flickering bug (flutter/engine#42830)
Safari web autofill has an issue where the autofill dialog flickers and doesn't completely render and allow users to fill any forms. 

This is caused by a collision between default browser behavior on the `pointerdown` event and the programatic focusing of our inputs. 

### Problem

When we click into an input, the element is created, placed, and (explicitly) focused.  However, all of this is done before the `pointerdown` event can finish.  Since all `pointerdown` elements target the `flutter-view` (formerly `flt-glass-pane`), default browser behavior is to trigger a `blur` event since the target doesn't match what's currently focused, which is the input element.  This doesn't manifest into most text editing issues because we listen for `blur` events on the `input` and call `focus()`.  However, in Safari, this near-instant focus/blur results in the disappearance of the autofill popup. 

The current chain of events looks like: 

`pointerdown` event starts -> input is created + focused -> `pointerdown` event ends, and triggers a `blur` -> input refocuses on `blur`

### Solution

This change ensures that we don't focus the input until after the `pointerdown` event concludes, thus preventing any rapid-fire `blur` event from being emitted.  We do this via wrapping the focus logic within a zero-duration Timer.  

The new chain of events looks like:

`pointerdown` event starts -> `pointerdown` event ends ->  input is created + focused

### Alternative approach

Note: Another option was to call `preventDefault()` on the `pointerdown` event to prevent the `blur` from occurring that way.  There may be unintended side effects from that approach, especially as it relates to platform views.  The surface area of the chosen approach is much more contained and should result in no side effects outside of Safari Desktop's text editing strategy. 

<img width="699" alt="Screenshot 2023-06-15 at 7 34 02 PM" src="https://github.com/flutter/engine/assets/110993981/3548d1ea-65f7-412f-b3c7-f94db2658127">

Fixes https://github.com/flutter/flutter/issues/127960
2023-06-16 21:48:59 +00:00
Jonah Williams
68ce594530 [Impeller] correct default PSO pixel format and sample count. (flutter/engine#42902)
Despite compiling an initial PSO variant for every shader, in practice these were completely useless as they had a sample count of 1 (instead of 4 for MSAA) and an invalid pixel format.

Correct the defaults so they may be usful.

Not enough to fix https://github.com/flutter/flutter/issues/128963 , because we still have far too much state for Vulkan to handle
2023-06-16 20:53:02 +00:00
skia-flutter-autoroll
a6e9576963 Roll Skia from 90dae91b2242 to 01f3be45e0d6 (4 revisions) (flutter/engine#42934)
https://skia.googlesource.com/skia.git/+log/90dae91b2242..01f3be45e0d6

2023-06-16 robertphillips@google.com Convert rest of affected GMs and tests over to new tiled image API
2023-06-16 robertphillips@google.com Move tiling utility methods to shareable location
2023-06-16 brianosman@google.com Fix return type of Benchmark::getSize
2023-06-16 jvanverth@google.com [graphite] Add onCopyTextureToTexture for the Vulkan backend.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-16 20:49:46 +00:00
skia-flutter-autoroll
e8a1d6b948 Roll Skia from 20e9cc928715 to 90dae91b2242 (5 revisions) (flutter/engine#42932)
https://skia.googlesource.com/skia.git/+log/20e9cc928715..90dae91b2242

2023-06-16 brianosman@google.com Fix incorrect filename for WGSL ClampUInt
2023-06-16 johnstiles@google.com Add Type::slotType(n).
2023-06-16 johnstiles@google.com Add WGSL support for common-function intrinsics.
2023-06-16 jmbetancourt@google.com track Color and Opacity slots through new SlotManager
2023-06-16 lovisolo@google.com [gm] Make GPU backend dependency conditional on SK_GANESH constant.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-16 19:39:53 +00:00
skia-flutter-autoroll
10994cebdc Roll Skia from a4ad5b369313 to 20e9cc928715 (3 revisions) (flutter/engine#42926)
https://skia.googlesource.com/skia.git/+log/a4ad5b369313..20e9cc928715

2023-06-16 jvanverth@google.com [graphite] Set Vulkan viewport and scissor
2023-06-16 johnstiles@google.com Reject first-class arrays on initializers in strict-ES2 mode.
2023-06-16 johnstiles@google.com Use IRHelpers class to assemble matrix-multiply workaround.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-16 18:28:55 +00:00
gaaclarke
2b5c1f8d95 Revert "Add deprecations to PlatformMessage stuff" (flutter/engine#42921)
Reverts flutter/engine#42580
2023-06-16 10:54:40 -07:00