DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

[Impeller] Print malioc errors on CI (flutter/engine#42906)

Browse Source 
Resolves https://github.com/flutter/flutter/issues/128989.

Also bumps the buildroot to head for:
https://github.com/flutter/buildroot/pull/744
This commit is contained in:
Brandon DeRosier 2023-06-16 21:37:37 -07:00 committed by GitHub
parent 256a5a9892
commit 080271007d
3 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
DEPS
View File

@ -257,7 +257,7 @@ allowed_hosts = [
]
deps = {
'src': 'https://github.com/flutter/buildroot.git' + '@' + 'fabb92f0ada787444ad0be22638c80a6d5927a2c',
'src': 'https://github.com/flutter/buildroot.git' + '@' + '0ebf2593785cd440cbc35caced03fce2b99f750f',
# Fuchsia compatibility
#

5
engine/src/flutter/impeller/tools/malioc.gni
View File

@ -70,7 +70,7 @@ template("malioc_analyze_shaders") {
"script",
])
script = "//build/gn_run_binary.py"
script = "//build/gn_run_malioc.py"
pool = "//flutter/impeller/tools:malioc_pool"
# Nest all malioc output under its own subdirectory of root_gen_dir
@ -101,13 +101,12 @@ template("malioc_analyze_shaders") {
args = [
rebase_path(impeller_malioc_path, root_build_dir),
rebase_path(output_file),
"--format",
"json",
shader_kind_flag,
"--core",
core.core,
"--output",
rebase_path(output_file),
]
if (backend_ext == "vkspv") {

12
engine/src/flutter/impeller/tools/malioc_cores.py
View File

@ -40,7 +40,10 @@ def validate_args(args):
def malioc_core_list(malioc):
malioc_cores = subprocess.check_output([malioc, '--list', '--format', 'json'])
malioc_cores = subprocess.check_output(
[malioc, '--list', '--format', 'json'],
stderr=subprocess.STDOUT,
)
cores_json = json.loads(malioc_cores)
cores = []
for core in cores_json['cores']:
@ -49,9 +52,10 @@ def malioc_core_list(malioc):
def malioc_core_info(malioc, core):
malioc_info = subprocess.check_output([
malioc, '--info', '--core', core, '--format', 'json'
])
malioc_info = subprocess.check_output(
[malioc, '--info', '--core', core, '--format', 'json'],
stderr=subprocess.STDOUT,
)
info_json = json.loads(malioc_info)
apis = info_json['apis']