Matt2D
68dccebb48
Flutter iOS Interactive Keyboard: Fixing Behavior Issue ( flutter/engine#44586 )
...
This PR addresses an issue with the behavior of the keyboard. Originally the behavior of the keyboard was to see if the pointer was above or below the middle of the keyboards full size and then animate appropriately. However we found that the behavior is instead based on velocity. This PR adjust the code to match this behavior.
Design Document:
https://docs.google.com/document/d/1-T7_0mSkXzPaWxveeypIzzzAdyo-EEuP5V84161foL4/edit?pli=1
Issues Address:
https://github.com/flutter/flutter/issues/57609
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-08-10 19:02:08 +00:00
Brandon DeRosier
491ce39b6d
[Impeller] Flutter GPU: Add context override. ( flutter/engine#44566 )
...
Adds a way to inject a context override, which allows us to test the API
in the Dart playground without spinning up an Engine/Shell.
2023-08-10 11:54:56 -07:00
Brandon DeRosier
046361c1cb
[Impeller] External OpenGLES texture sampling. ( flutter/engine#44559 )
...
Allows for sampling from external textures in the OpenGLES backend.
DrawImageRect should Just Work if external textures are wrapped with the
new `kTextureExternalOES` type.
2023-08-10 11:54:37 -07:00
skia-flutter-autoroll
b742b2099d
Roll Fuchsia Linux SDK from 961_tJawsbLMdy5i0... to konJQZKk2qXc276iA... ( flutter/engine#44593 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-10 18:35:11 +00:00
skia-flutter-autoroll
7c2dd21178
Roll Skia from 364900538771 to 92e6f52b0fa8 (1 revision) ( flutter/engine#44592 )
...
https://skia.googlesource.com/skia.git/+log/364900538771..92e6f52b0fa8
2023-08-10 bungeman@google.com [skunicode] Remove unused LEN define
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-10 18:24:46 +00:00
skia-flutter-autoroll
11e1510420
Roll Skia from f39fd2de8f10 to 364900538771 (1 revision) ( flutter/engine#44590 )
...
https://skia.googlesource.com/skia.git/+log/f39fd2de8f10..364900538771
2023-08-10 kjlubick@google.com Remove deprecated emcc flags, and update emsdk to 2.1.44.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-10 17:29:10 +00:00
skia-flutter-autoroll
f65360c3f3
Roll Skia from 67bad75b41c2 to f39fd2de8f10 (1 revision) ( flutter/engine#44588 )
...
https://skia.googlesource.com/skia.git/+log/67bad75b41c2..f39fd2de8f10
2023-08-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from b026cfa16886 to 24c6e5d875d2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-10 16:31:57 +00:00
skia-flutter-autoroll
aae86b62d4
Roll Dart SDK from d89e4ead966d to 46da53e7abe2 (4 revisions) ( flutter/engine#44584 )
...
https://dart.googlesource.com/sdk.git/+log/d89e4ead966d..46da53e7abe2
2023-08-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-57.0.dev
2023-08-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-56.0.dev
2023-08-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-55.0.dev
2023-08-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-54.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-10 16:02:52 +00:00
skia-flutter-autoroll
80bf8b1d6e
Roll Skia from aac2d55d35eb to 67bad75b41c2 (1 revision) ( flutter/engine#44583 )
...
https://skia.googlesource.com/skia.git/+log/aac2d55d35eb..67bad75b41c2
2023-08-10 jamesgk@google.com Make sweep gradient zero-x test more forgiving
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-10 15:55:15 +00:00
skia-flutter-autoroll
c7257d207a
Roll Skia from 7a1fec6b197f to aac2d55d35eb (1 revision) ( flutter/engine#44582 )
...
https://skia.googlesource.com/skia.git/+log/7a1fec6b197f..aac2d55d35eb
2023-08-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 59b294f2797c to 66ccbc2fd928 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-10 15:14:04 +00:00
skia-flutter-autoroll
df0e7d967f
Roll Skia from a3975f2a9e79 to 7a1fec6b197f (1 revision) ( flutter/engine#44580 )
...
https://skia.googlesource.com/skia.git/+log/a3975f2a9e79..7a1fec6b197f
2023-08-10 brianosman@google.com Split out BlitRow opts into separate cpp files
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-10 14:30:55 +00:00
skia-flutter-autoroll
be5ab1a096
Roll Skia from d9e9b7073171 to a3975f2a9e79 (2 revisions) ( flutter/engine#44577 )
...
https://skia.googlesource.com/skia.git/+log/d9e9b7073171..a3975f2a9e79
2023-08-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 3ad8d9127acb to a990ba348457 (8 revisions)
2023-08-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 729e92f8ae07 to c315c894b9d5 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-10 09:20:34 +00:00
skia-flutter-autoroll
04ce9c275c
Roll Fuchsia Mac SDK from zoCGnScKZWbm5s9Hy... to SoKcmsZ5H8uHJXV1S... ( flutter/engine#44576 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-10 07:05:23 +00:00
skia-flutter-autoroll
c1c144eb63
Roll Skia from 7c5f6b17a998 to d9e9b7073171 (1 revision) ( flutter/engine#44573 )
...
https://skia.googlesource.com/skia.git/+log/7c5f6b17a998..d9e9b7073171
2023-08-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 6449131d4768 to d9b07bc44fbc (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-10 05:51:52 +00:00
skia-flutter-autoroll
36c2089a89
Roll Fuchsia Linux SDK from ZCP8LDbKF4LTBFz_W... to 961_tJawsbLMdy5i0... ( flutter/engine#44572 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-10 05:40:00 +00:00
Zachary Anderson
2ecdda61fa
Revert "Android a11y bridge sets importantness" ( flutter/engine#44569 )
...
Reverts flutter/engine#44452
Failing the roll to the framework on FTL tests:
https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20firebase_android_embedding_v2_smoke_test/58307/overview
2023-08-09 19:51:22 -07:00
skia-flutter-autoroll
45292c3ab7
Roll Skia from 491f67637e6e to 7c5f6b17a998 (2 revisions) ( flutter/engine#44568 )
...
https://skia.googlesource.com/skia.git/+log/491f67637e6e..7c5f6b17a998
2023-08-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 6449131d4768 to d9b07bc44fbc
2023-08-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 39b27fd481de to 59b294f2797c (6 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-10 02:22:05 +00:00
Matan Lurey
839d63312c
[Impeller] Replace Vulkan rotation checks with polling ( flutter/engine#44361 )
...
tl;dr: Reverts https://github.com/flutter/engine/pull/43214 . closes
https://github.com/flutter/flutter/issues/129459 .
---
In https://github.com/flutter/engine/pull/43214 , @jonahwilliams used
`vkQueuePresentKHR`[^1] [to
check](a0df46add1/impeller/renderer/backend/vulkan/swapchain_impl_vk.cc (L465-L467)https://github.com/flutter/flutter/issues/129459 (i.e. even with
https://github.com/flutter/engine/pull/43214 ).
This PR implements the polling technique recommended by Android[^2], in
this case on every frame. We should expect this to have a performance
penalty of ~`0.2`ms per frame, but should at least give us consistent
fidelity on Vulkan + Android for the time-being.
<details>
<summary>
Some additional screenshots generated while debugging
</summary>
<img src
="https://github.com/flutter/engine/assets/168174/900e02a8-aa51-4592-9690-c650092130a2 "
/>
<img
src="https://github.com/flutter/engine/assets/168174/e7b9e5c0-86b0-407f-aa51-2f76afda4f03 )"
/>
<img
src="https://github.com/flutter/engine/assets/168174/6b611090-97f5-4589-9ef9-6ba778efc6b7 "
/>
</details>
[^1]:
https://developer.android.com/games/optimize/vulkan-prerotation#detect_device_orientation_changes
[^2]:
https://developer.android.com/games/optimize/vulkan-prerotation#using_polling
2023-08-09 19:14:35 -07:00
LongCatIsLooong
e156901deb
Disable text rounding hack by default ( flutter/engine#44544 )
...
This depends on https://github.com/flutter/flutter/pull/132094 and customer_testing migration.
I'll announce this change and add a g3 fix after this lands.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-08-10 01:44:23 +00:00
skia-flutter-autoroll
8e687347b3
Roll Skia from 3d5a6138b7e5 to 491f67637e6e (4 revisions) ( flutter/engine#44563 )
...
https://skia.googlesource.com/skia.git/+log/3d5a6138b7e5..491f67637e6e
2023-08-09 johnstiles@google.com Disable sequence-expression test on old Adreno drivers.
2023-08-09 johnstiles@google.com Add layout flags for pixel formats.
2023-08-09 johnstiles@google.com Update SkSL memory layout for WGSL 1.0 limitations.
2023-08-09 johnstiles@google.com Revert "Speculative fix for Adreno shader error."
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-09 23:28:06 +00:00
skia-flutter-autoroll
e98deaae7e
Manual roll Dart SDK from f664f4b9c50d to d89e4ead966d (11 revisions) ( flutter/engine#44560 )
...
Manual roll requested by zra@google.com
https://dart.googlesource.com/sdk.git/+log/f664f4b9c50d..d89e4ead966d
2023-08-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-53.0.dev
2023-08-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-52.0.dev
2023-08-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-51.0.dev
2023-08-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-50.0.dev
2023-08-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-49.0.dev
2023-08-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-48.0.dev
2023-08-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-47.0.dev
2023-08-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-46.0.dev
2023-08-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-45.0.dev
2023-08-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-44.0.dev
2023-08-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-43.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-09 22:40:22 +00:00
Srujan Gaddam
b76eb03600
Make toJS'd function use JS types ( flutter/engine#44469 )
...
JSFunction's should only accept and return JS types.
Allows landing of external restrictions here:
https://dart-review.googlesource.com/c/sdk/+/316867/9
2023-08-09 14:39:12 -07:00
xuty
0c708f040f
[web] Fix rendering of gradients in html mode ( flutter/engine#40345 )
...
<details>
<summary> Code Example</summary>
```dart
import 'package:flutter/material.dart';
void main() {
runApp(const MyApp());
}
class DemoGradientTransform implements GradientTransform {
@override
Matrix4? transform(Rect bounds, {TextDirection? textDirection}) {
return Matrix4.identity()
..scale(1.2, 1.7)
..rotateZ(0.25);
}
}
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
var colors = <Color>[
Colors.red,
Colors.green,
Colors.blue,
Colors.yellow,
];
const stops = <double>[0.0, 0.25, 0.5, 1.0];
return MaterialApp(
debugShowCheckedModeBanner: false,
home: GridView(
gridDelegate: SliverGridDelegateWithFixedCrossAxisCount(
crossAxisCount: TileMode.values.length,
),
children: <Widget>[
for (final mode in TileMode.values)
DecoratedBox(
decoration: BoxDecoration(
gradient: LinearGradient(
colors: colors,
stops: stops,
tileMode: mode,
transform: DemoGradientTransform(),
),
),
),
for (final mode in TileMode.values)
DecoratedBox(
decoration: BoxDecoration(
gradient: RadialGradient(
center: Alignment.topLeft,
radius: 0.5,
colors: colors,
stops: stops,
tileMode: mode,
transform: DemoGradientTransform(),
),
),
),
for (final mode in TileMode.values)
DecoratedBox(
decoration: BoxDecoration(
gradient: SweepGradient(
center: Alignment.topLeft,
startAngle: 0.0,
endAngle: 3.14,
colors: colors,
stops: stops,
tileMode: mode,
transform: DemoGradientTransform(),
),
),
),
],
),
);
}
}
```
</details>
Fixes: https://github.com/flutter/flutter/issues/84245
2023-08-09 21:38:59 +00:00
Matt2D
9fb889d3a8
Flutter iOS Interactive Keyboard: Fixing Animation Issue ( flutter/engine#44514 )
...
This PR addresses an issue with the animation of the keyboard. In iOS 16.0 a delay was included in UIView becomeFirstResponder where the areAnimationsEnabled boolean is no longer immediately read. In response to this issue a delay is added that allows for the animation to be properly disabled.
Design Document:
https://docs.google.com/document/d/1-T7_0mSkXzPaWxveeypIzzzAdyo-EEuP5V84161foL4/edit?pli=1
Issues Address:
https://github.com/flutter/flutter/issues/57609
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-08-09 21:22:05 +00:00
skia-flutter-autoroll
28c180d181
Roll Skia from 8c9a8d3e073c to 3d5a6138b7e5 (4 revisions) ( flutter/engine#44557 )
...
https://skia.googlesource.com/skia.git/+log/8c9a8d3e073c..3d5a6138b7e5
2023-08-09 robertphillips@google.com Revise the Protected content slide to better test the bug
2023-08-09 jamesgk@google.com Don't run new gradient test on Graphite
2023-08-09 johnstiles@google.com Speculative fix for Adreno shader error.
2023-08-09 cmumford@google.com Update Windows RTX3060 and GTA960 drivers from 31.0.15.3667 to 31.0.15.3669
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-09 20:54:40 +00:00
skia-flutter-autoroll
89203c25cf
Roll Skia from d210bab77137 to 8c9a8d3e073c (1 revision) ( flutter/engine#44555 )
...
https://skia.googlesource.com/skia.git/+log/d210bab77137..8c9a8d3e073c
2023-08-09 jmbetancourt@google.com Add SlotManager APIs to CanvasKit for Color and Scalar slots
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-09 19:50:58 +00:00
skia-flutter-autoroll
4fe539399e
Roll Skia from 25aedb939915 to d210bab77137 (2 revisions) ( flutter/engine#44550 )
...
https://skia.googlesource.com/skia.git/+log/25aedb939915..d210bab77137
2023-08-09 robertphillips@google.com Fix two lingering Android protected content issues
2023-08-09 nicolettep@google.com Add explicit size & null checks to GrVkCommandBuffer::submitPipelineBarriers
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-09 18:55:04 +00:00
skia-flutter-autoroll
8229df2790
Roll Fuchsia Mac SDK from e7bMhkfY-RPMrSMhB... to zoCGnScKZWbm5s9Hy... ( flutter/engine#44548 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-09 18:25:18 +00:00
skia-flutter-autoroll
d884a965e3
Roll Skia from 17ba2122707b to 25aedb939915 (3 revisions) ( flutter/engine#44547 )
...
https://skia.googlesource.com/skia.git/+log/17ba2122707b..25aedb939915
2023-08-09 jamesgk@google.com [ganesh] Don't call atan2(*, 0) in sweep gradient shader
2023-08-09 bungeman@google.com [skunicode] Allow building more than one backend
2023-08-09 sharaks@google.com Merge 11 release notes into RELEASE_NOTES.md
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-09 17:50:42 +00:00
chunhtai
1cffdd164a
Android a11y bridge sets importantness ( flutter/engine#44452 )
...
Accessibility scanner uses isImportantForAccessibility to decide whether to scan the node. If not set, the isImportantForAccessibility is default to false, thus skips all node except for the rootview which defaults to true.
fixes https://github.com/flutter/flutter/issues/39531
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-08-09 16:58:01 +00:00
skia-flutter-autoroll
60347f4499
Roll Fuchsia Linux SDK from tO6r8iQqnmsYkLcvZ... to ZCP8LDbKF4LTBFz_W... ( flutter/engine#44545 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-09 16:49:07 +00:00
ftsui
f0d7c4c4c2
Request GLES version 2 interface. ( flutter/engine#44504 )
...
- SKIA requires at least GLES version 2.0
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-08-09 16:38:28 +00:00
Jonah Williams
31c639e955
[Impeller] Don't perform final layout transition on worker thread. ( flutter/engine#44510 )
...
This can lead to https://github.com/flutter/flutter/issues/131717 because the raster thread may access the Queue while the worker thread is doing the final layout transition. Moving the final layout transition back to the raster thread should be fine, its really the presentation that we want to run in a background worker.
Fixes https://github.com/flutter/flutter/issues/131717
2023-08-09 15:43:52 +00:00
skia-flutter-autoroll
af50beefbe
Roll Skia from 3e85749702f4 to 17ba2122707b (2 revisions) ( flutter/engine#44540 )
...
https://skia.googlesource.com/skia.git/+log/3e85749702f4..17ba2122707b
2023-08-09 johnstiles@google.com Add workaround for WebGL2 and void-typed sequence expressions.
2023-08-09 kjlubick@google.com Treat fontations ffi.rs.h as explicit output
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-09 15:35:14 +00:00
skia-flutter-autoroll
76df08d42f
Roll Skia from e892c300a7c4 to 3e85749702f4 (1 revision) ( flutter/engine#44539 )
...
https://skia.googlesource.com/skia.git/+log/e892c300a7c4..3e85749702f4
2023-08-09 robertphillips@google.com Propagate protected-ness to dependant draws
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-09 14:39:23 +00:00
skia-flutter-autoroll
6623c87167
Roll Skia from ff6d82573f69 to e892c300a7c4 (1 revision) ( flutter/engine#44538 )
...
https://skia.googlesource.com/skia.git/+log/ff6d82573f69..e892c300a7c4
2023-08-09 drott@chromium.org [Fontations] Roll Fontations libraries
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-09 13:47:55 +00:00
skia-flutter-autoroll
9dc38af4a6
Roll Skia from e2885a01f134 to ff6d82573f69 (3 revisions) ( flutter/engine#44536 )
...
https://skia.googlesource.com/skia.git/+log/e2885a01f134..ff6d82573f69
2023-08-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e970eb49de48 to 39b27fd481de (4 revisions)
2023-08-09 drott@chromium.org [Fontations] Fix Bazel-only build of viewer with fontations enabled
2023-08-09 lovisolo@google.com [bazel] Fix WASM tasks broken by ignoring //gm/png_codec.cpp.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-09 13:00:33 +00:00
Caroline Liu
4e424a605d
Remove GFX and Scenic dependencies from Fuchsia integration tests ( flutter/engine#44498 )
...
This change removes GFX and Scenic dependencies from Fuchsia integration
tests. Mainly, it:
- swaps out `fuchsia.ui.scenic.Scenic/GetDisplayInfo` for
`fuchsia.ui.display.singleton.Info/GetMetrics`
- removes the no longer necessary `fuchsia.ui.scenic.Scenic` connections
and component manifest declarations from tests
- removes any extraneous build deps tests have on `fuchsia.ui.gfx`,
`fuchsia.ui.policy`, and `scenic_cpp`
Related bug: fxbug.dev/64206
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
2023-08-09 08:54:09 -04:00
skia-flutter-autoroll
b935d318dc
Roll Skia from ac2b25fec6eb to e2885a01f134 (1 revision) ( flutter/engine#44534 )
...
https://skia.googlesource.com/skia.git/+log/ac2b25fec6eb..e2885a01f134
2023-08-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from f7d7be8d2ff0 to 3ad8d9127acb (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-09 07:15:15 +00:00
skia-flutter-autoroll
c345af5696
Roll Skia from d097852dc928 to ac2b25fec6eb (3 revisions) ( flutter/engine#44533 )
...
https://skia.googlesource.com/skia.git/+log/d097852dc928..ac2b25fec6eb
2023-08-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 333a87d1ef8a to 6449131d4768 (17 revisions)
2023-08-09 sharaks@google.com Update Skia milestone to 118
2023-08-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 333a87d1ef8a to 6449131d4768
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-09 06:33:04 +00:00
Bruno Leroux
8ee77cb321
[Windows] Return keyboard pressed state ( flutter/engine#43998 )
...
## Description
This PR updates the Windows engine in order to answer to keyboard pressed state queries from the framework (as implemented in https://github.com/flutter/flutter/pull/122885 ).
## Related Issue
Windows engine implementation for https://github.com/flutter/flutter/issues/87391 .
Similar to:
- Linux: https://github.com/flutter/engine/pull/42346
- Android: https://github.com/flutter/engine/pull/42758
- macOS: https://github.com/flutter/engine/pull/42878
## Tests
Adds 2 tests.
2023-08-09 06:31:05 +00:00
skia-flutter-autoroll
374023b37a
Roll Fuchsia Mac SDK from c18Y3Ga7cvdrmy8FQ... to e7bMhkfY-RPMrSMhB... ( flutter/engine#44531 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-09 05:43:19 +00:00
skia-flutter-autoroll
90c7da21fb
Roll Fuchsia Linux SDK from 9Pl8nd13UI8rrS3JD... to tO6r8iQqnmsYkLcvZ... ( flutter/engine#44529 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-09 04:02:49 +00:00
skia-flutter-autoroll
339b702930
Roll Skia from e904a9f2010e to d097852dc928 (1 revision) ( flutter/engine#44525 )
...
https://skia.googlesource.com/skia.git/+log/e904a9f2010e..d097852dc928
2023-08-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from cc5d2913cf83 to e970eb49de48 (8 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-09 03:22:14 +00:00
Matan Lurey
e996c123d4
[Impeller] Plumb Paint.enableDithering to backend ( flutter/engine#44522 )
...
Closes https://github.com/flutter/flutter/issues/131450 and
https://github.com/flutter/flutter/issues/118073 .
Example from https://github.com/flutter/flutter/issues/118073 :
```diff
import 'package:flutter/material.dart';
void main() {
+ Paint.enableDithering = true;
runApp(const MyApp());
}
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
title: 'Flutter Demo',
theme: ThemeData(
primarySwatch: Colors.blue,
),
home: const MyHomePage(title: 'Flutter Demo Home Page'),
);
}
}
class MyHomePage extends StatefulWidget {
const MyHomePage({super.key, required this.title});
final String title;
@override
State<MyHomePage> createState() => _MyHomePageState();
}
class _MyHomePageState extends State<MyHomePage> {
int _counter = 0;
void _incrementCounter() {
setState(() {
_counter++;
});
}
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(
title: Text(widget.title),
),
body: Center(
child: Container(
width: double.infinity,
decoration: const BoxDecoration(
gradient: LinearGradient(
colors: <Color>[Color(0xffcccccc), Color(0xff333333)])),
child: Column(
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
const Text(
'You have pushed the button this many times:',
),
Text(
'$_counter',
style: Theme.of(context).textTheme.headlineMedium,
),
],
),
),
),
floatingActionButton: FloatingActionButton(
onPressed: _incrementCounter,
tooltip: 'Increment',
child: const Icon(Icons.add),
), // This trailing comma makes auto-formatting nicer for build methods.
);
}
}
```
## Before
<img width="2028" alt="Screenshot 2023-08-08 at 5 15 40 PM"
src="https://github.com/flutter/engine/assets/168174/c58106bb-f588-4019-8cf0-3dd801f0b118 ">
## After
<img width="2028" alt="Screenshot 2023-08-08 at 5 15 01 PM"
src="https://github.com/flutter/engine/assets/168174/33c4fec8-db52-47c2-b215-c1988ce82416 ">
2023-08-08 18:05:33 -07:00
skia-flutter-autoroll
82fc1a6ba4
Roll Skia from 1fbe521b2c56 to e904a9f2010e (3 revisions) ( flutter/engine#44520 )
...
https://skia.googlesource.com/skia.git/+log/1fbe521b2c56..e904a9f2010e
2023-08-08 johnstiles@google.com Centralize HLSL compilation code.
2023-08-08 johnstiles@google.com Centralize GLSL compilation code.
2023-08-08 johnstiles@google.com Centralize SPIR-V, WGSL and MSL compilation code.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-08 23:39:06 +00:00
Matan Lurey
91526aaded
[Impeller] Add gradient dithering for Radial/Sweep/Conical gradients ( flutter/engine#44331 )
...
Partial work towards https://github.com/flutter/flutter/issues/131450
similar to https://github.com/flutter/engine/pull/44181 .
---
Run the Playground locally:
```bash
$ENGINE/out/host_debug_unopt/impeller_unittests \
--enable_playground \
--gtest_filter="*CanRender*GradientWithDithering*"
```
## Radial
### Before
<img width="1014" alt="Screenshot 2023-08-03 at 10 08 53 AM"
src="https://github.com/flutter/engine/assets/168174/d53f2c0e-5c48-4ecb-8e67-d4ab28bfe488 ">
### After
<img width="1018" alt="Screenshot 2023-08-03 at 10 13 57 AM"
src="https://github.com/flutter/engine/assets/168174/3b6e6e65-3dd3-4cb3-9950-36e2ba5c1da2 ">
## Sweep
### Before
<img width="1019" alt="Screenshot 2023-08-03 at 10 27 35 AM"
src="https://github.com/flutter/engine/assets/168174/4e3bc82d-c0d5-43dd-952a-c11cb586fb65 ">
### After
<img width="1018" alt="Screenshot 2023-08-03 at 10 33 11 AM"
src="https://github.com/flutter/engine/assets/168174/7e526391-cfd7-4920-89ff-fe26793b24fc "
## Conical
### Before
<img width="1019" alt="Screenshot 2023-08-08 at 11 55 43 AM"
src="https://github.com/flutter/engine/assets/168174/944709f4-8163-4de3-bfc5-eaf30b978529 ">
### After
<img width="1016" alt="Screenshot 2023-08-08 at 1 11 40 PM"
src="https://github.com/flutter/engine/assets/168174/60ad67a4-b409-4136-a753-b8608f46fbf2 ">
2023-08-08 16:23:38 -07:00
skia-flutter-autoroll
c43e7a8f2b
Roll Skia from 68b80f663be6 to 1fbe521b2c56 (2 revisions) ( flutter/engine#44518 )
...
https://skia.googlesource.com/skia.git/+log/68b80f663be6..1fbe521b2c56
2023-08-08 lovisolo@google.com [bazel] Add //gm/png_codec.cpp.
2023-08-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from be6bd0fc62ef to b026cfa16886
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-08 22:48:03 +00:00
Chris Bracken
551fe982eb
[macOS] Improve engine retain cycle testing ( flutter/engine#44509 )
...
Adds testing that verifies that the engine is not retained via the FlutterTextureRegistry that is returned from the FlutterTextureRegistrar returned by the engine.
This also simplifies the existing test for a retain cycle via the FlutterBinaryMessenger by avoiding manually casting the binary messenger to a FlutterBinaryMessengerRelay, or knowing any of its implementation details.
Issue: https://github.com/flutter/flutter/issues/116445
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-08-08 22:18:46 +00:00
Gray Mackall
8cce730f9b
Fix name in description of 'create_cipd_packages.sh' ( flutter/engine#44513 )
...
The description uses an old name.
This PR also partly exists to spread awareness that this script exists, for whenever we need to upload [android versions to CIPD](https://chrome-infra-packages.appspot.com/p/flutter/android/sdk/all/mac-arm64/+/ ).
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-08-08 21:49:48 +00:00
