DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Make toJS'd function use JS types (flutter/engine#44469)

Browse Source 
JSFunction's should only accept and return JS types.

Allows landing of external restrictions here:
https://dart-review.googlesource.com/c/sdk/+/316867/9
This commit is contained in:
Srujan Gaddam 2023-08-09 14:39:12 -07:00 committed by GitHub
parent 0c708f040f
commit b76eb03600
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
engine/src/flutter/lib/web_ui/lib/src/engine/canvaskit/native_memory.dart
View File

@ -21,7 +21,8 @@ import 'package:ui/src/engine.dart';
/// 5. The finalizer function is called with the SkPaint as the sole argument.
/// 6. We call `delete` on SkPaint.
DomFinalizationRegistry _finalizationRegistry = createDomFinalizationRegistry(
(UniqueRef<Object> uniq) {
(JSBoxedDartObject boxedUniq) {
final UniqueRef<Object> uniq = boxedUniq.toDart as UniqueRef<Object>;
uniq.collect();
}.toJS
);
@ -33,7 +34,7 @@ NativeMemoryFinalizationRegistry nativeMemoryFinalizationRegistry = NativeMemory
class NativeMemoryFinalizationRegistry {
void register(Object owner, UniqueRef<Object> ref) {
if (browserSupportsFinalizationRegistry) {
_finalizationRegistry.register(owner, ref);
_finalizationRegistry.register(owner, ref.toJSBox);
}
}
}