DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
34,382 Commits 882 Branches 1,069 Tags
Commit Graph

34382 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
skia-flutter-autoroll
67cc2ec0a3 Roll Dart SDK from a0e3c16eea3e to 1e6b559fae88 (1 revision) (flutter/engine#51025) 
https://dart.googlesource.com/sdk.git/+log/a0e3c16eea3e..1e6b559fae88

2024-02-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-184.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-28 01:09:35 +00:00
Loïc Sharma
9da5ed5312 [Windows] Reduce log level of unsupported accessibility event message (flutter/engine#51024) 
https://github.com/flutter/engine/pull/50975 made the Windows embedder a bit more defensive on accessibility event messages and introduced an error if it received an event it does not support. This change reduces that error to a warning as it can be triggered by hovering over the counter app's `+` button.

Fixes https://github.com/flutter/flutter/issues/144274

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-28 00:45:30 +00:00
skia-flutter-autoroll
f0f77d3764 Roll Skia from c8703c91675e to 84c60d70fbbd (4 revisions) (flutter/engine#51021) 
https://skia.googlesource.com/skia.git/+log/c8703c91675e..84c60d70fbbd

2024-02-27 jvanverth@google.com [graphite] RasterPathAtlas and SmallPathAtlas fixes.
2024-02-27 johnstiles@google.com Guard SkPerlinNoiseShader::onMakeContext with our new flag.
2024-02-27 johnstiles@google.com Fix turbulence calculation in RP Perlin noise.
2024-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll ANGLE from f0af4730d927 to 2fb425d2847f (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-28 00:06:05 +00:00
Loïc Sharma
12228ffd98 [Windows] Make the engine own a map of views (flutter/engine#51017) 
Updates Windows engine's data structures to use a map of views.

This is a refactoring with no semantic changes. Flutter Windows's APIs restrict users to 0 or 1 view only - it is not possible to create multiple views yet.

_One small step for Windows. One giant leap for multi-view._

Part of https://github.com/flutter/flutter/issues/143765
Part of https://github.com/flutter/flutter/issues/142845

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-27 23:28:00 +00:00
John McCutchan
cdeb8166a2 Rename some classes in the engine_build_configs package (flutter/engine#51016) 
- BuildConfig -> BuilderConfig
- GlobalBuild -> Build
 2024-02-27 15:12:10 -08:00
Zachary Anderson
e7b97723ec Remove rewrapper prefix from compiler commands for clang-tidy (flutter/engine#51001) 
This PR also enables RBE for builds for clang-tidy.
 2024-02-27 14:57:51 -08:00
Matan Lurey
5c4ce0e168 Improve, test, and fix a bug related to adb logcat filtering. (flutter/engine#51012) 
1. Write tests for the `AdbLogLine` extension/parsing, and run it on CI.
  Fixes https://github.com/flutter/flutter/issues/144164.

2. Improve the logging to include `androidemu`-related errors logs 
  Work towards https://github.com/flutter/flutter/issues/144164.

3. Clarified logic/fixed a bug related to handling `filterProcessId:
...`
 2024-02-27 14:31:08 -08:00
Jason Simmons
e017114099 Move vulkan-deps to //flutter/third_party/vulkan-deps (flutter/engine#51013) 
See https://github.com/flutter/flutter/issues/144205
 2024-02-27 21:59:00 +00:00
Loïc Sharma
becf9fb52f [Windows] Remove TODONE (flutter/engine#51005) 
This TODO is TODONE!

Part of https://github.com/flutter/flutter/issues/131616

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-27 21:15:06 +00:00
Loïc Sharma
218151583f [Windows] Introduce an accessibility plugin (flutter/engine#50975) 
_This is the same pull request as https://github.com/flutter/engine/pull/50898. GitHub broke on the previous pull request so I re-created it_

This moves the logic to handle `flutter/accessibility` messages to a new type, `AccessibilityPlugin`. 

Notable changes:

1. Windows app no longer crashes if it receives accessibility events it does not support
2. Windows app no longer crashes if it receives accessibility events while in headless mode

@yaakovschectman After playing around with this, I ended up using a different pattern than what what I suggested on https://github.com/flutter/engine/pull/50598#discussion_r1488728089. This message handler is simple enough that splitting into a child/base types felt like unnecessary boilerplate. The key thing is separating messaging and implementation logic, which was achieved through the `SetUp` method. Let me know what you think, and sorry for all my flip-flopping on this topic! 😅

This is preparation for: https://github.com/flutter/flutter/issues/143765

Sample app for manual testing: https://github.com/flutter/flutter/issues/113059

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-27 20:59:24 +00:00
skia-flutter-autoroll
c262bcf21c Roll Skia from 1beae57ea0dd to c8703c91675e (1 revision) (flutter/engine#51014) 
https://skia.googlesource.com/skia.git/+log/1beae57ea0dd..c8703c91675e

2024-02-27 jvanverth@google.com [graphite] Break out rect management in DrawAtlas.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-27 20:49:26 +00:00
Jonah Williams
edb8430817 [Impeller] various StC fixes for GPU -> CPU readback plus BufferBindingGLES error (flutter/engine#50951) 
More debugging for https://github.com/flutter/engine/pull/50856

Potentially related to https://github.com/flutter/flutter/issues/141472
 2024-02-27 20:35:18 +00:00
skia-flutter-autoroll
fde07188b2 Roll Dart SDK from be6be2b9ba6e to a0e3c16eea3e (3 revisions) (flutter/engine#51015) 
https://dart.googlesource.com/sdk.git/+log/be6be2b9ba6e..a0e3c16eea3e

2024-02-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-183.0.dev
2024-02-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-182.0.dev
2024-02-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-181.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-27 20:35:16 +00:00
skia-flutter-autoroll
3cb97ace80 Roll Fuchsia Linux SDK from JCdhkDSFXzHyPuP4I... to T1xAi_ww_mWEiDkVN... (flutter/engine#51011) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-27 20:15:04 +00:00
Robert Ancell
1aa5dbf113 Code consistency fixes in FlScrollingManager (flutter/engine#50959) 2024-02-28 09:06:20 +13:00
Matej Knopp
8ff01af723 [macOS] Use CVDisplayLink to drive repaint (flutter/engine#49159) 
Fixes https://github.com/flutter/flutter/issues/49757

This PR synchronises updates with display refresh allowing for true
120hz repaint. It also enforces frame pacing resulting in smoother
experience at both 60hz and 120hz.

*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-02-27 20:48:26 +01:00
Matan Lurey
75bfeb8fb0 Fail lazily when 1+ Skia gold comparions fail. (flutter/engine#51010) 
(Speculative) fix for https://github.com/flutter/flutter/issues/144238.

@zanderso Could you review from a CLI angle? I realize this code is not great, but could I do something better here?
 2024-02-27 19:08:18 +00:00
Zachary Anderson
186f661615 Adjust Android emulator test timeouts (flutter/engine#51004) 
This reduces the scenario app test timeout from 30 minutes to 15 minutes
(passing runs seem to take about 5 minutes), and limits the scenario app
tests from 2 retries to only 1 retry.

These changes will hopefully allow logs collection to be successful when
the tests timeout.
 2024-02-27 10:43:58 -08:00
skia-flutter-autoroll
1947128b4a Roll Skia from 636e136b0da9 to 1beae57ea0dd (3 revisions) (flutter/engine#51007) 
https://skia.googlesource.com/skia.git/+log/636e136b0da9..1beae57ea0dd

2024-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 996ab52aeac4 to 7b482f48e635 (2 revisions)
2024-02-27 johnstiles@google.com Revert "Delete legacy shadeSpan implementation of Perlin Noise."
2024-02-27 jvanverth@google.com Revert "[graphite] Enable SmallPathAtlas."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-27 18:37:27 +00:00
Jackson Gardner
3af9b7b3ba [skwasm] Clip pictures if they go beyond the bounds of the window. (flutter/engine#50887) 
This fixes https://github.com/flutter/flutter/issues/143800, where we are attempting to capture an image that is way too large. We only need to render the part of the image that will be visible in the window.
 2024-02-27 18:37:25 +00:00
Dan Field
1ba4c0735b GLES for scenario_app tests using Impeller (flutter/engine#51000) 
Follow up on #50977 - enables OpenGLES backend for that test harness.
 2024-02-27 17:59:22 +00:00
skia-flutter-autoroll
169507a42a Roll Skia from d5ca52bc7739 to 636e136b0da9 (8 revisions) (flutter/engine#51006) 
https://skia.googlesource.com/skia.git/+log/d5ca52bc7739..636e136b0da9

2024-02-27 jlavrova@google.com Reland "Implementing Fontations font scanner"
2024-02-27 johnstiles@google.com Manually roll Dawn to the latest version.
2024-02-27 johnstiles@google.com Delete legacy shadeSpan implementation of Perlin Noise.
2024-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from cc25d8806a33 to 32b3df0d7dd6 (5 revisions)
2024-02-27 kjlubick@google.com Minor clang tidy/format fixes
2024-02-27 michaelludwig@google.com Reland "[skif] Add transparent padding to source saveLayers"
2024-02-27 kjlubick@google.com Enforce IWYU on skottie and sksg
2024-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from acba61cb3e27 to f0af4730d927 (10 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-27 17:40:09 +00:00
zijiehe@
c274921fa6 [Fuchsia] Use shared gn-sdk from chromium (flutter/engine#50855) 
Fuchsia team is working on getting rid of non-versioned libraries and sysroot (see b/40935282), but flutter is using a fairly old version of in-house gn-sdk. It's hard to maintain it anymore.
So this change removes the in-house gn-sdk and replaces it with the gn-sdk from chromium.
This is a prerequisite to select the idk / sdk lib version according to the api-level.

This change contains three parts:
1) Replacing gn-sdk/ with gn-sdk/src/ since the chromium needs a README.chromium in gn-sdk/ folder.
2) Making the existing build rules work with the newer gn-sdk.
3) Drive-by replacing "gtest_runner.shard.cml" with "sys/testing/gtest_runner.shard.cml", it's in fuchsia sdk already.

Bug: [b/40935282](https://issues.chromium.org/issues/40935282?pli=1&authuser=0)

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-27 17:30:05 +00:00
Jackson Gardner
fce1fe5b2c Reland "Implement Frame Timing callbacks in Skwasm" (flutter/engine#50987) 
This is a reland of the previous PR, now that the blocking Dart SDK issue has been fixed (see https://github.com/dart-lang/sdk/issues/54991).

Also, I addressed an issue where the timings were incorrect due to different time origins on the main thread and web worker. The timings should be accurate now.

Notes from the original PR are as follows:

Fixes https://github.com/flutter/flutter/issues/140429

Some notes here:
* Refactored the frame timing systems so that we can deal with asynchronous rendering.
* Consolidated rendering of multiple pictures in skwasm into a single call, so that the rasterization can be properly measured.
* Pulled the frame timings tests into the `ui` test suite so that they run on all renderers (including skwasm).
 2024-02-27 16:42:25 +00:00
Zachary Anderson
827e920f48 Move protobuf to //flutter/third_party (flutter/engine#50997) 
For https://github.com/flutter/flutter/issues/67373

Currently the files in the secondary buildroot for protobuf are checked
out from their own git repo. Flutter owns a mirror of that repo. To move
protobuf to `//flutter/third_party`, we can land a change in that repo,
and then revert it after we're done with the buildmoot. Alternately, in
this PR, I've just copied the files into the flutter/engine repo under
the secondary buildroot and made the changes.
 2024-02-27 08:37:21 -08:00
skia-flutter-autoroll
70e24583ba Roll Skia from 2f2a718b27f7 to d5ca52bc7739 (3 revisions) (flutter/engine#51003) 
https://skia.googlesource.com/skia.git/+log/2f2a718b27f7..d5ca52bc7739

2024-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 34f900647879 to 73efb9ea35f6
2024-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from dd4b27ecbb53 to 34f900647879 (9 revisions)
2024-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 0f69b790c7a4 to bbe6452b420c (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-27 16:30:27 +00:00
skia-flutter-autoroll
bd20e42f14 Roll Dart SDK from 67b2a250747b to be6be2b9ba6e (1 revision) (flutter/engine#51002) 
https://dart.googlesource.com/sdk.git/+log/67b2a250747b..be6be2b9ba6e

2024-02-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-180.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-27 16:26:40 +00:00
Dan Field
3b99e7ab98 Actually use Impeller in scenario_app tests (flutter/engine#50977) 
Right now, the scenario_app tests that claim to use Impeller are not actually using Impeller. This is for a few reasons:

- The arguments passed via instrumentation do not end up by default on the `Intent` for the `Activity` that is under test.
- The arguments passed via instrumentation were in the wrong order and not getting sent to instrumentation at all.

This patch updates existing tests to use a new `@Rule` that reads the arguments from the instrumentation's argument `Bundle` and injects them into the `Intent` that we actually pass to the `Activity` under test. It also updates the argument order in the script and adds a verification that Impeller prints that it is being used at least once.
 2024-02-27 04:37:23 +00:00
Matan Lurey
539dc4eccc Respect SIGINT (Ctrl-C) for Android scenario_app. (flutter/engine#50989) 
Closes https://github.com/flutter/flutter/issues/144076.

I had to make some other cleanup changes in order to avoid the program
hanging.
 2024-02-26 19:17:44 -08:00
skia-flutter-autoroll
f279437b63 Roll Skia from aa28c3a30a98 to 2f2a718b27f7 (1 revision) (flutter/engine#50998) 
https://skia.googlesource.com/skia.git/+log/aa28c3a30a98..2f2a718b27f7

2024-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from dd6c2371c85d to cc25d8806a33 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-27 03:17:22 +00:00
skia-flutter-autoroll
6ba5eee587 Roll Dart SDK from 2876f5684ced to 67b2a250747b (1 revision) (flutter/engine#50996) 
https://dart.googlesource.com/sdk.git/+log/2876f5684ced..67b2a250747b

2024-02-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-179.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-27 02:36:15 +00:00
Matan Lurey
adc86fe60b Fix usage of --out-dir with a relative path. (flutter/engine#50992) 
@dnfield:

> it looks like the new dart script doesn't necessarily work well with
relative directories for the out dir
 2024-02-26 18:35:28 -08:00
Jason Simmons
09b4184372 Roll buildroot to 21b1b9f2645fada701885108e86aefbcb3b1cca0 (flutter/engine#50991) 2024-02-27 01:58:14 +00:00
skia-flutter-autoroll
9bb1d34f89 Roll Skia from ba3ed5998af3 to aa28c3a30a98 (12 revisions) (flutter/engine#50994) 
https://skia.googlesource.com/skia.git/+log/ba3ed5998af3..aa28c3a30a98

2024-02-26 brianosman@google.com Handle recursion limit gracefully in the stroker
2024-02-26 johnstiles@google.com Revert "[skif] Add transparent padding to source saveLayers"
2024-02-26 johnstiles@google.com Use nmad primitive in inverse and transcendental functions.
2024-02-26 herb@google.com Reland "Implement ARM only unpremul using SIMD"
2024-02-26 johnstiles@google.com Add Raster Pipeline fused negative multiply-add primitive.
2024-02-26 michaelludwig@google.com [skif] Add transparent padding to source saveLayers
2024-02-26 kjlubick@google.com Try adding a gn clean before building fontations
2024-02-26 herb@google.com Revert "Implement ARM only unpremul using SIMD"
2024-02-26 herb@google.com Implement ARM only unpremul using SIMD
2024-02-26 jvanverth@google.com [graphite] Enable SmallPathAtlas.
2024-02-26 michaelludwig@google.com Update legacy LCD ARGB32 blitter to match RP for transparent pixels
2024-02-26 johnstiles@google.com Add Perlin Noise Raster Pipeline implementation.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-27 01:58:11 +00:00
auto-submit[bot]
63614f6be8 Reverts "Migrate Android scenario_app to the SurfaceProducer API (#50993)" (flutter/engine#50995) 
Reverts flutter/engine#50993

Initiated by: matanlurey

Reason for reverting: The digests will come back negative, as this change shows bugs in the `ImageTexture` implementation.

Original PR Author: matanlurey

Reviewed By: {jonahwilliams, johnmccutchan}

This change reverts the following previous change:
Original Description:
Part of testing https://github.com/flutter/flutter/issues/139702.

Without this PR, the Impeller + Vulkan Scenario App will draw nothing/potentially crash, because there is no way to draw the (current) `SurfaceTexture`-based textures in Vulkan (and never will be).

This change does the following:
- Skia -> Nothing
- Impeller + OpenGLES -> On newer Android devices, uses `ImageReader` instead
- Impeller + Vulkan -> Always uses `ImageReader`

See also: https://api.flutter.dev/javadoc/io/flutter/view/TextureRegistry.SurfaceProducer.html.
 2024-02-27 01:49:26 +00:00
Matan Lurey
5b9bb4bacf Migrate Android scenario_app to the SurfaceProducer API (flutter/engine#50993) 
Part of testing https://github.com/flutter/flutter/issues/139702.

Without this PR, the Impeller + Vulkan Scenario App will draw nothing/potentially crash, because there is no way to draw the (current) `SurfaceTexture`-based textures in Vulkan (and never will be).

This change does the following:
- Skia -> Nothing
- Impeller + OpenGLES -> On newer Android devices, uses `ImageReader` instead
- Impeller + Vulkan -> Always uses `ImageReader`

See also: https://api.flutter.dev/javadoc/io/flutter/view/TextureRegistry.SurfaceProducer.html.
 2024-02-27 01:39:23 +00:00
Tong Mu
c139338825 Revert "Reland 4: Multiview pipeline (#50931)" (flutter/engine#50985) 
This reverts commit cb110ebc948c362cec5ac921cf8ef5e9ca530102.

Reason: Internal test failure blocking roll
OCL:610420483:BASE:610486571:1708978396098:f2c3c31

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-27 00:58:22 +00:00
Matan Lurey
71f9dec343 Refactor args parsing/environment constructor for scenario_app (flutter/engine#50980) 
This moves the ever-growing amount of options and defaults into it's own
class(es).

The test runner itself has no tests (yet), but this shim will make
writing tests easier. I tried to make no other real changes to how the
runner functions in this PR.
 2024-02-26 15:29:32 -08:00
Jonah Williams
9eca58ab36 [scenario] trigger firstFrameLatch on exception. (flutter/engine#50981) 
If we hit this exception (which we seem to do a lot), then we weren't triggering the first frame latch.
 2024-02-26 23:03:31 +00:00
Jason Simmons
36531a7209 [Impeller] Fix a misspelling and name mismatch in a shader test fixture (flutter/engine#50983) 2024-02-26 22:52:01 +00:00
skia-flutter-autoroll
aaa76eeaba Roll Dart SDK from c479735adcf9 to 2876f5684ced (2 revisions) (flutter/engine#50979) 
https://dart.googlesource.com/sdk.git/+log/c479735adcf9..2876f5684ced

2024-02-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-178.0.dev
2024-02-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-177.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-26 22:31:35 +00:00
Zachary Anderson
cae1c8dc3a Run engine unit tests on mac host_debug_unopt_arm64 (flutter/engine#50327) 
Related https://github.com/flutter/flutter/issues/142868
 2024-02-26 13:39:05 -08:00
Jonah Williams
00b8a0c043 [Impeller] disble render pass caches. (flutter/engine#50976) 
This is related to the crashes in https://github.com/flutter/flutter/issues/144116

> I'm going to disable this caching for now until I understand why its not working for tester. Potentially the cache itself was unsafe and validation is just missing, but I need to do some research. If I don't find anything then i'll consider conditionally disabling for flutter tester builds
 2024-02-26 21:09:16 +00:00
John McCutchan
a0e82bb991 Update Surface reference after resizing render target in VirtualDisplay based platform views (flutter/engine#50971) 
Fixes https://github.com/flutter/flutter/issues/142952
 2024-02-26 13:00:49 -08:00
Jason Simmons
24152a08d1 [Impeller] Fix a race that can abort the process if the Vulkan context is destroyed while pipeline creation tasks are pending (flutter/engine#50883) 
The Vulkan pipeline library queues pipeline creation tasks to a ConcurrentTaskRunner.  If the ContextVK is destroyed before these tasks execute, then the ConcurrentMessageLoop destructor will delete the pending tasks.

Each task lambda holds a reference to a promise that will be completed with the pipeline.  If the task was never run and its promise was never completed, then the promise destructor will complete it with an exception.  This will cause a std::abort because Flutter is built without exception support.

This PR wraps the promise in an object that completes it with a default value during destruction if the promise was never given a value.
 2024-02-26 20:06:29 +00:00
Matan Lurey
dec92d85f2 Better filtering for Android scenario_app runner. (flutter/engine#50937) 
_🍴 'd from https://github.com/flutter/engine/pull/50933, will rebase
when merged._

Closes https://github.com/flutter/flutter/issues/143458.

A picture is a 1000 words:

![Screenshot 2024-02-23 at 7 01
29 PM](https://github.com/flutter/engine/assets/168174/7254b3be-cc49-4bad-ae43-e61ac4a853ad)

This is still noisy, but at least all the output appears to be part of
the execution.

As you recall, the full logs are always available in the
FLUTTER_LOGS_DIR output.
 2024-02-26 11:36:10 -08:00
Jackson Gardner
d1d7c08ce9 Make sure to call setHeightOverride as well on TextStyle and StrutStyle (flutter/engine#50920) 
This fixes https://github.com/flutter/flutter/issues/143877

We apparently need to call `setHeightOverride(true)` on `TextStyle` and `StrutStyle` objects in order to properly apply the height.
 2024-02-26 18:52:59 +00:00
Jackson Gardner
45b0c5ef88 Correctly offset the cull rect of the opacity layer. (flutter/engine#50928) 
This fixes https://github.com/flutter/flutter/issues/140999. Previously, the cull rect would be misplaced causing many elements to not render at all.
 2024-02-26 18:52:56 +00:00
skia-flutter-autoroll
02449cd493 Roll Fuchsia Linux SDK from kLvCWEgbL1VTRW69e... to JCdhkDSFXzHyPuP4I... (flutter/engine#50970) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-26 18:09:18 +00:00
Zachary Anderson
8a4feb869c [et] Improve the logger for the ninja build, adds a spinner (flutter/engine#50952) 
For https://github.com/flutter/flutter/issues/132807

The spinner is mostly copied from the flutter_tool.
 2024-02-26 09:31:15 -08:00