DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fail lazily when 1+ Skia gold comparions fail. (flutter/engine#51010)

Browse Source 
(Speculative) fix for https://github.com/flutter/flutter/issues/144238.

@zanderso Could you review from a CLI angle? I realize this code is not great, but could I do something better here?
This commit is contained in:
Matan Lurey 2024-02-27 11:08:18 -08:00 committed by GitHub
parent 186f661615
commit 75bfeb8fb0
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
engine/src/flutter/testing/scenario_app/bin/run_android_tests.dart
View File

@ -157,6 +157,7 @@ Future<void> _run({
late final ServerSocket server;
final List<Future<void>> pendingComparisons = <Future<void>>[];
final List<Socket> pendingConnections = <Socket>[];
int comparisonsFailed = 0;
await step('Starting server...', () async {
server = await ServerSocket.bind(InternetAddress.anyIPv4, _tcpPort);
if (verbose) {
@ -186,8 +187,9 @@ Future<void> _run({
if (isSkiaGoldClientAvailable) {
final Future<void> comparison = skiaGoldClient!
.addImg(fileName, goldenFile, screenshotSize: screenshot.pixelCount)
.catchError((dynamic err) {
panic(<String>['skia gold comparison failed: $err']);
.catchError((Object error) {
logWarning('skia gold comparison failed: $error');
comparisonsFailed++;
});
pendingComparisons.add(comparison);
}
@ -354,6 +356,8 @@ Future<void> _run({
if (out.toString().contains('FAILURES!!!')) {
stdout.write(out);
panic(<String>['1 or more tests failed']);
} else if (comparisonsFailed > 0) {
panic(<String>['$comparisonsFailed Skia Gold comparisons failed']);
}
});
} finally {