30668 Commits

Author SHA1 Message Date
skia-flutter-autoroll
60e24c795d Roll Skia from fa30af9c2b80 to 68ea92de8f29 (2 revisions) (flutter/engine#44641)
https://skia.googlesource.com/skia.git/+log/fa30af9c2b80..68ea92de8f29

2023-08-11 johnstiles@google.com Add SkTHashMap::foreach(const Pair&).
2023-08-11 brianosman@google.com Split out Swizzler opts into separate cpp files

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-11 17:42:20 +00:00
gaaclarke
63b74f7869 [Impeller] Added benchmark for advanced blend. (flutter/engine#44450)
fixes: https://github.com/flutter/flutter/issues/131784

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-08-11 09:27:45 -07:00
Loïc Sharma
649b38752e [Embedder] Refactor how semantic updates are mapped (flutter/engine#44553)
This refactors how engine semantic updates are mapped to embedder semantic updates. There are no behavioral changes.

Part of https://github.com/flutter/flutter/issues/119970, https://github.com/flutter/flutter/issues/98948

Next PR: https://github.com/flutter/engine/pull/44616

## Background
For https://github.com/flutter/flutter/issues/119970, we will need to update the embedder API to add string attributes to semantic nodes' text values. There are multiple kinds of string attributes, and each text value can have multiple string attributes. This requires gnarly mapping code that's best kept out of `embedder.cc`.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-08-11 16:22:10 +00:00
skia-flutter-autoroll
bc3fc245e2 Roll Skia from cfb9844091fa to fa30af9c2b80 (1 revision) (flutter/engine#44639)
https://skia.googlesource.com/skia.git/+log/cfb9844091fa..fa30af9c2b80

2023-08-11 johnstiles@google.com Fix ambiguous evaluation order in WGSL codegen.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-11 16:12:34 +00:00
skia-flutter-autoroll
16b3abd655 Roll Skia from 416789a5e761 to cfb9844091fa (1 revision) (flutter/engine#44638)
https://skia.googlesource.com/skia.git/+log/416789a5e761..cfb9844091fa

2023-08-11 brianosman@google.com Reland "Remove SK_GL #ifdefs from GrBackendSurface"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-11 15:24:33 +00:00
skia-flutter-autoroll
4ea5095e82 Roll Skia from 723df2275d7b to 416789a5e761 (1 revision) (flutter/engine#44637)
https://skia.googlesource.com/skia.git/+log/723df2275d7b..416789a5e761

2023-08-11 brianosman@google.com SkAnySubclass: Holds any subclass of a given type that fits in a given size

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-11 14:28:23 +00:00
skia-flutter-autoroll
1ceb6f2857 Roll Dart SDK from 13317278a6fa to 83f96a990792 (1 revision) (flutter/engine#44633)
https://dart.googlesource.com/sdk.git/+log/13317278a6fa..83f96a990792

2023-08-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-61.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-11 12:21:05 +00:00
skia-flutter-autoroll
c00c022036 Roll Fuchsia Mac SDK from hdjihTvRxbNprHI9x... to 7DmdwgtGmIxyejFDl... (flutter/engine#44630)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-11 08:51:28 +00:00
John McCutchan
bcd2be5d8a Add support for HardwareBuffer backed Android Platform Views under Impeller/GLES (flutter/engine#44617)
- Implement Impeller/GLES code paths.
- A couple of fixes for EXTERNAL_OES textures via bdero@
2023-08-11 00:41:53 -07:00
skia-flutter-autoroll
e2129a4e3a Roll Fuchsia Linux SDK from konJQZKk2qXc276iA... to v33NyNdr6Y1sKZDze... (flutter/engine#44627)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-11 07:31:09 +00:00
skia-flutter-autoroll
ed8c72da27 Roll Skia from 41d099099095 to 723df2275d7b (1 revision) (flutter/engine#44626)
https://skia.googlesource.com/skia.git/+log/41d099099095..723df2275d7b

2023-08-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from a990ba348457 to d52046c499c0 (9 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-11 07:27:13 +00:00
skia-flutter-autoroll
f4ac8718df Roll Skia from f4080803ee69 to 41d099099095 (2 revisions) (flutter/engine#44624)
https://skia.googlesource.com/skia.git/+log/f4080803ee69..41d099099095

2023-08-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from d9b07bc44fbc to b411e7b47eec (4 revisions)
2023-08-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from c315c894b9d5 to 97bdc453fbed (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-11 06:13:26 +00:00
skia-flutter-autoroll
4f41657618 Roll Skia from 88d5e1daa3ba to f4080803ee69 (1 revision) (flutter/engine#44622)
https://skia.googlesource.com/skia.git/+log/88d5e1daa3ba..f4080803ee69

2023-08-11 lovisolo@google.com [bazel] Add task to run GM tests.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-11 05:13:26 +00:00
skia-flutter-autoroll
c41a1a24fc Roll Skia from b669a6cd29f7 to 88d5e1daa3ba (1 revision) (flutter/engine#44620)
https://skia.googlesource.com/skia.git/+log/b669a6cd29f7..88d5e1daa3ba

2023-08-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 66ccbc2fd928 to ce76478186bc (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-11 03:21:34 +00:00
skia-flutter-autoroll
79328a35d4 Roll Dart SDK from a2eac00da6b8 to 13317278a6fa (2 revisions) (flutter/engine#44618)
https://dart.googlesource.com/sdk.git/+log/a2eac00da6b8..13317278a6fa

2023-08-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-60.0.dev
2023-08-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-59.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-11 02:50:04 +00:00
skia-flutter-autoroll
1b720fe0aa Roll Skia from b001e0a5e46f to b669a6cd29f7 (1 revision) (flutter/engine#44615)
https://skia.googlesource.com/skia.git/+log/b001e0a5e46f..b669a6cd29f7

2023-08-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from d9b07bc44fbc to b411e7b47eec

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-11 01:06:20 +00:00
Matan Lurey
88a116a521 Update examples/** to provide --local-engine-host. (flutter/engine#44610)
Partial work towards https://github.com/flutter/flutter/issues/132245.
2023-08-10 17:47:38 -07:00
Chris Bracken
234063b3ae [shell] Add references to VsyncWaiter docs (flutter/engine#44607)
Point users in the direction of VsyncWaiterAndroid, VsyncWaiterEmbedder.

No new tests since this patch introduces no semantic changes.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-08-10 22:00:07 +00:00
skia-flutter-autoroll
11b183b90a Roll Skia from b6492f5ce8c3 to b001e0a5e46f (1 revision) (flutter/engine#44606)
https://skia.googlesource.com/skia.git/+log/b6492f5ce8c3..b001e0a5e46f

2023-08-10 johnstiles@google.com Write the WGSL entrypoint function after writing all ProgramElements.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-10 22:00:05 +00:00
skia-flutter-autoroll
0a88c105f0 Roll Fuchsia Mac SDK from SoKcmsZ5H8uHJXV1S... to hdjihTvRxbNprHI9x... (flutter/engine#44600)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-10 20:15:05 +00:00
skia-flutter-autoroll
92ba87ea43 Roll Dart SDK from 46da53e7abe2 to a2eac00da6b8 (1 revision) (flutter/engine#44601)
https://dart.googlesource.com/sdk.git/+log/46da53e7abe2..a2eac00da6b8

2023-08-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-58.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-10 20:08:05 +00:00
LoveJello
c309b2295b Fix unexpected pointer change issue and Add test case (flutter/engine#43949)
Fix issue 129765 and Add test case, see  issue
Fixes https://github.com/flutter/flutter/issues/129765

- [✓] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
- [✓] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
- [✓] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
- [✓] I listed at least one issue that this PR fixes in the description above.
- [✓] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests.
- [✓] I updated/added relevant documentation (doc comments with `///`).
- [✓] I signed the [CLA].
- [ ✓] All existing and new tests are passing.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-08-10 20:04:46 +00:00
chunhtai
e7cb4195f2 Reland "Android a11y bridge sets importantness" (flutter/engine#44589)
The previous pr was reverted due to test failures. The failure was due to API not supported in order android version. The fix is in the second commit.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-08-10 20:02:12 +00:00
John McCutchan
c3606872fb Support for Android Platform Views under Impeller/Vulkan (flutter/engine#44571)
- Introduce AndroidHardwareBufferTextureSourceVK.
- Enable the necessary Vulkan extensions to support
AndroidHardwareBufferTextureSourceVK.
- Refactor HardwareBufferExternalTextureGL into a base class and a GL
and VK specializations.
- Switch ImageReaderPlatformView to use the PRIVATE image format
(enables DRM'd content to be captured in the texture).
- Add a AHardwareBuffer_describe to NDKHelpers.
- Misc cleanups.
2023-08-10 12:54:47 -07:00
yaakovschectman
c2cc8508b6 Reintroduce Windows lifecycle with guard for posthumous OnWindowStateEvent (flutter/engine#44344)
Previously, destruction of `Window` called `DestroyWindow`, which may
send `WM_KILLFOCUS` to the to-be-destroyed window. Because `Window`'s
destructor is called after `FlutterWindow`'s, the `FlutterWindow` vtable
was already destroyed at this point, and the subsequent call to the
virtual method `OnWindowStateEvent` would cause a crash. This PR
reintroduces the reverted changes for Windows lifecycle with a check
before calling the virtual method that the `FlutterWindow` object has
not yet been destructed.

https://github.com/flutter/flutter/issues/131872

*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

---------

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
2023-08-10 15:37:04 -04:00
skia-flutter-autoroll
fb1851fe34 Roll Skia from 92e6f52b0fa8 to b6492f5ce8c3 (1 revision) (flutter/engine#44597)
https://skia.googlesource.com/skia.git/+log/92e6f52b0fa8..b6492f5ce8c3

2023-08-10 kjlubick@google.com [bazel] Make use of gcs_mirror_url()

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-10 19:18:49 +00:00
Matt2D
68dccebb48 Flutter iOS Interactive Keyboard: Fixing Behavior Issue (flutter/engine#44586)
This PR addresses an issue with the behavior of the keyboard. Originally the behavior of the keyboard was to see if the pointer was above or below the middle of the keyboards full size and then animate appropriately. However we found that the behavior is instead based on velocity. This PR adjust the code to match this behavior.

Design Document:
https://docs.google.com/document/d/1-T7_0mSkXzPaWxveeypIzzzAdyo-EEuP5V84161foL4/edit?pli=1

Issues Address:
https://github.com/flutter/flutter/issues/57609

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-08-10 19:02:08 +00:00
Brandon DeRosier
491ce39b6d [Impeller] Flutter GPU: Add context override. (flutter/engine#44566)
Adds a way to inject a context override, which allows us to test the API
in the Dart playground without spinning up an Engine/Shell.
2023-08-10 11:54:56 -07:00
Brandon DeRosier
046361c1cb [Impeller] External OpenGLES texture sampling. (flutter/engine#44559)
Allows for sampling from external textures in the OpenGLES backend.
DrawImageRect should Just Work if external textures are wrapped with the
new `kTextureExternalOES` type.
2023-08-10 11:54:37 -07:00
skia-flutter-autoroll
b742b2099d Roll Fuchsia Linux SDK from 961_tJawsbLMdy5i0... to konJQZKk2qXc276iA... (flutter/engine#44593)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-10 18:35:11 +00:00
skia-flutter-autoroll
7c2dd21178 Roll Skia from 364900538771 to 92e6f52b0fa8 (1 revision) (flutter/engine#44592)
https://skia.googlesource.com/skia.git/+log/364900538771..92e6f52b0fa8

2023-08-10 bungeman@google.com [skunicode] Remove unused LEN define

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-10 18:24:46 +00:00
skia-flutter-autoroll
11e1510420 Roll Skia from f39fd2de8f10 to 364900538771 (1 revision) (flutter/engine#44590)
https://skia.googlesource.com/skia.git/+log/f39fd2de8f10..364900538771

2023-08-10 kjlubick@google.com Remove deprecated emcc flags, and update emsdk to 2.1.44.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-10 17:29:10 +00:00
skia-flutter-autoroll
f65360c3f3 Roll Skia from 67bad75b41c2 to f39fd2de8f10 (1 revision) (flutter/engine#44588)
https://skia.googlesource.com/skia.git/+log/67bad75b41c2..f39fd2de8f10

2023-08-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from b026cfa16886 to 24c6e5d875d2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-10 16:31:57 +00:00
skia-flutter-autoroll
aae86b62d4 Roll Dart SDK from d89e4ead966d to 46da53e7abe2 (4 revisions) (flutter/engine#44584)
https://dart.googlesource.com/sdk.git/+log/d89e4ead966d..46da53e7abe2

2023-08-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-57.0.dev
2023-08-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-56.0.dev
2023-08-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-55.0.dev
2023-08-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-54.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-10 16:02:52 +00:00
skia-flutter-autoroll
80bf8b1d6e Roll Skia from aac2d55d35eb to 67bad75b41c2 (1 revision) (flutter/engine#44583)
https://skia.googlesource.com/skia.git/+log/aac2d55d35eb..67bad75b41c2

2023-08-10 jamesgk@google.com Make sweep gradient zero-x test more forgiving

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-10 15:55:15 +00:00
skia-flutter-autoroll
c7257d207a Roll Skia from 7a1fec6b197f to aac2d55d35eb (1 revision) (flutter/engine#44582)
https://skia.googlesource.com/skia.git/+log/7a1fec6b197f..aac2d55d35eb

2023-08-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 59b294f2797c to 66ccbc2fd928 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-10 15:14:04 +00:00
skia-flutter-autoroll
df0e7d967f Roll Skia from a3975f2a9e79 to 7a1fec6b197f (1 revision) (flutter/engine#44580)
https://skia.googlesource.com/skia.git/+log/a3975f2a9e79..7a1fec6b197f

2023-08-10 brianosman@google.com Split out BlitRow opts into separate cpp files

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-10 14:30:55 +00:00
skia-flutter-autoroll
be5ab1a096 Roll Skia from d9e9b7073171 to a3975f2a9e79 (2 revisions) (flutter/engine#44577)
https://skia.googlesource.com/skia.git/+log/d9e9b7073171..a3975f2a9e79

2023-08-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 3ad8d9127acb to a990ba348457 (8 revisions)
2023-08-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 729e92f8ae07 to c315c894b9d5 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-10 09:20:34 +00:00
skia-flutter-autoroll
04ce9c275c Roll Fuchsia Mac SDK from zoCGnScKZWbm5s9Hy... to SoKcmsZ5H8uHJXV1S... (flutter/engine#44576)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-10 07:05:23 +00:00
skia-flutter-autoroll
c1c144eb63 Roll Skia from 7c5f6b17a998 to d9e9b7073171 (1 revision) (flutter/engine#44573)
https://skia.googlesource.com/skia.git/+log/7c5f6b17a998..d9e9b7073171

2023-08-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 6449131d4768 to d9b07bc44fbc (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-10 05:51:52 +00:00
skia-flutter-autoroll
36c2089a89 Roll Fuchsia Linux SDK from ZCP8LDbKF4LTBFz_W... to 961_tJawsbLMdy5i0... (flutter/engine#44572)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-10 05:40:00 +00:00
Zachary Anderson
2ecdda61fa Revert "Android a11y bridge sets importantness" (flutter/engine#44569)
Reverts flutter/engine#44452

Failing the roll to the framework on FTL tests:
https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20firebase_android_embedding_v2_smoke_test/58307/overview
2023-08-09 19:51:22 -07:00
skia-flutter-autoroll
45292c3ab7 Roll Skia from 491f67637e6e to 7c5f6b17a998 (2 revisions) (flutter/engine#44568)
https://skia.googlesource.com/skia.git/+log/491f67637e6e..7c5f6b17a998

2023-08-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 6449131d4768 to d9b07bc44fbc
2023-08-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 39b27fd481de to 59b294f2797c (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-10 02:22:05 +00:00
Matan Lurey
839d63312c [Impeller] Replace Vulkan rotation checks with polling (flutter/engine#44361)
tl;dr: Reverts https://github.com/flutter/engine/pull/43214. closes
https://github.com/flutter/flutter/issues/129459.


![7v5zfd](https://github.com/flutter/engine/assets/168174/b87a0726-cddd-415e-a46c-2c65d6f5c9d5)

---

In https://github.com/flutter/engine/pull/43214, @jonahwilliams used
`vkQueuePresentKHR`[^1] [to
check](a0df46add1/impeller/renderer/backend/vulkan/swapchain_impl_vk.cc (L465-L467))
if device orientations had changed, and if so, the swap-chain was torn
down and replaced with a new instance (that would now have a correct
rotation for ... compositing reasons I don't quite understand).

Unfortunately `vkQueuePresentKHR` is (a) only present on Android 10+
_and_ (b) ... isn't implemented consistently across Android devices. For
example, the popular Samsung Galaxy S10 doesn't return
`VK_SUBOPTIMAL_KHR`, leading to the same rotation bugs described in
https://github.com/flutter/flutter/issues/129459 (i.e. even with
https://github.com/flutter/engine/pull/43214).

This PR implements the polling technique recommended by Android[^2], in
this case on every frame. We should expect this to have a performance
penalty of ~`0.2`ms per frame, but should at least give us consistent
fidelity on Vulkan + Android for the time-being.


![flutter_04](https://github.com/flutter/engine/assets/168174/969f5c5e-7f6a-4156-8de8-1351b32f2a2f)

<details>
<summary>
Some additional screenshots generated while debugging
</summary>
<img src
="https://github.com/flutter/engine/assets/168174/900e02a8-aa51-4592-9690-c650092130a2"
/>
<img
src="https://github.com/flutter/engine/assets/168174/e7b9e5c0-86b0-407f-aa51-2f76afda4f03)"
/>
<img
src="https://github.com/flutter/engine/assets/168174/6b611090-97f5-4589-9ef9-6ba778efc6b7"
/>
</details>


[^1]:
https://developer.android.com/games/optimize/vulkan-prerotation#detect_device_orientation_changes
[^2]:
https://developer.android.com/games/optimize/vulkan-prerotation#using_polling
2023-08-09 19:14:35 -07:00
LongCatIsLooong
e156901deb Disable text rounding hack by default (flutter/engine#44544)
This depends on https://github.com/flutter/flutter/pull/132094 and customer_testing migration.

I'll announce this change and add a g3 fix after this lands.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-08-10 01:44:23 +00:00
skia-flutter-autoroll
8e687347b3 Roll Skia from 3d5a6138b7e5 to 491f67637e6e (4 revisions) (flutter/engine#44563)
https://skia.googlesource.com/skia.git/+log/3d5a6138b7e5..491f67637e6e

2023-08-09 johnstiles@google.com Disable sequence-expression test on old Adreno drivers.
2023-08-09 johnstiles@google.com Add layout flags for pixel formats.
2023-08-09 johnstiles@google.com Update SkSL memory layout for WGSL 1.0 limitations.
2023-08-09 johnstiles@google.com Revert "Speculative fix for Adreno shader error."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-09 23:28:06 +00:00
skia-flutter-autoroll
e98deaae7e Manual roll Dart SDK from f664f4b9c50d to d89e4ead966d (11 revisions) (flutter/engine#44560)
Manual roll requested by zra@google.com

https://dart.googlesource.com/sdk.git/+log/f664f4b9c50d..d89e4ead966d

2023-08-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-53.0.dev
2023-08-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-52.0.dev
2023-08-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-51.0.dev
2023-08-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-50.0.dev
2023-08-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-49.0.dev
2023-08-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-48.0.dev
2023-08-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-47.0.dev
2023-08-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-46.0.dev
2023-08-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-45.0.dev
2023-08-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-44.0.dev
2023-08-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-43.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-09 22:40:22 +00:00
Srujan Gaddam
b76eb03600 Make toJS'd function use JS types (flutter/engine#44469)
JSFunction's should only accept and return JS types.

Allows landing of external restrictions here:
https://dart-review.googlesource.com/c/sdk/+/316867/9
2023-08-09 14:39:12 -07:00
xuty
0c708f040f [web] Fix rendering of gradients in html mode (flutter/engine#40345)
![CleanShot 2023-03-16 at 20 44 01@2x](https://user-images.githubusercontent.com/15033141/225620947-18fe19aa-c5e2-45a5-a0cc-151275844af7.png)

<details>
<summary> Code  Example</summary>

```dart
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class DemoGradientTransform implements GradientTransform {
  @override
  Matrix4? transform(Rect bounds, {TextDirection? textDirection}) {
    return Matrix4.identity()
      ..scale(1.2, 1.7)
      ..rotateZ(0.25);
  }
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    var colors = <Color>[
      Colors.red,
      Colors.green,
      Colors.blue,
      Colors.yellow,
    ];

    const stops = <double>[0.0, 0.25, 0.5, 1.0];

    return MaterialApp(
      debugShowCheckedModeBanner: false,
      home: GridView(
        gridDelegate: SliverGridDelegateWithFixedCrossAxisCount(
          crossAxisCount: TileMode.values.length,
        ),
        children: <Widget>[
          for (final mode in TileMode.values)
            DecoratedBox(
              decoration: BoxDecoration(
                gradient: LinearGradient(
                  colors: colors,
                  stops: stops,
                  tileMode: mode,
                  transform: DemoGradientTransform(),
                ),
              ),
            ),
          for (final mode in TileMode.values)
            DecoratedBox(
              decoration: BoxDecoration(
                gradient: RadialGradient(
                  center: Alignment.topLeft,
                  radius: 0.5,
                  colors: colors,
                  stops: stops,
                  tileMode: mode,
                  transform: DemoGradientTransform(),
                ),
              ),
            ),
          for (final mode in TileMode.values)
            DecoratedBox(
              decoration: BoxDecoration(
                gradient: SweepGradient(
                  center: Alignment.topLeft,
                  startAngle: 0.0,
                  endAngle: 3.14,
                  colors: colors,
                  stops: stops,
                  tileMode: mode,
                  transform: DemoGradientTransform(),
                ),
              ),
            ),
        ],
      ),
    );
  }
}
```
</details>

Fixes: https://github.com/flutter/flutter/issues/84245
2023-08-09 21:38:59 +00:00
Matt2D
9fb889d3a8 Flutter iOS Interactive Keyboard: Fixing Animation Issue (flutter/engine#44514)
This PR addresses an issue with the animation of the keyboard. In iOS 16.0 a delay was included in UIView becomeFirstResponder where the areAnimationsEnabled boolean is no longer immediately read. In response to this issue a delay is added that allows for the animation to be properly disabled. 

Design Document:
https://docs.google.com/document/d/1-T7_0mSkXzPaWxveeypIzzzAdyo-EEuP5V84161foL4/edit?pli=1

Issues Address:
https://github.com/flutter/flutter/issues/57609

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-08-09 21:22:05 +00:00