Jenn Magder
59cd6af303
Remove "gclient sync" warning call during pre-rebase ( flutter/engine#52342 )
...
Remove `pre-rebase` check from `gclient sync` warning, and instead remove the warning call from `pre_rebase_command`
Follow-up to https://github.com/flutter/engine/pull/52133#discussion_r1575447161
2024-04-25 23:12:03 +00:00
skia-flutter-autoroll
7f8d6a3cf3
Roll Dart SDK from f9c9894a2500 to 29afb0500d51 (1 revision) ( flutter/engine#52399 )
...
https://dart.googlesource.com/sdk.git/+log/f9c9894a2500..29afb0500d51
2024-04-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-102.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-25 22:24:23 +00:00
Jonah Williams
5935f48862
[Impeller] while we still have benchmarks, see if we're efficient enough for this to be faster. ( flutter/engine#52398 )
...
We don't need to decode images to a malloc'd buffer, but this benchmarked as faster because we did so much allocation during the frame. Maybe this is better now? Lets run the benchmarks
2024-04-25 21:12:10 +00:00
Jonah Williams
45d5af365f
[Impeller] Vulkan validation off by default. ( flutter/engine#52397 )
...
Fixes https://github.com/flutter/flutter/issues/142659
can be turned on via --enable-vulkan-validation cmd line flag.
2024-04-25 21:04:04 +00:00
skia-flutter-autoroll
67c113eb55
Roll Skia from cb32ad619678 to 52083c205016 (1 revision) ( flutter/engine#52396 )
...
https://skia.googlesource.com/skia.git/+log/cb32ad619678..52083c205016
2024-04-25 michaelludwig@google.com [graphite] Instantiate non-budgeted TextureProxies in Make()
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-25 20:52:22 +00:00
Jonah Williams
9dbe934a9b
[Impeller] kick off registration and initial PSO compilation of runtime effect earlier. ( flutter/engine#52381 )
...
I thought about changing this API so that it blocks on compilation, but I think that isn't necesasary as the workload can happen while the UI thread is building. Plus, even blocking on shader completion does not guarantee that we won't need to compile a variant anyway.
While I was at it I moved the descriptor sets computation to the runtime effect constructor.
With this change the pipleine variant used during the frame is produced much faster than the initial 12ms compilation.
Fixes https://github.com/flutter/flutter/issues/113719
Fixes https://github.com/flutter/flutter/issues/141222
2024-04-25 20:23:56 +00:00
Jonah Williams
b14463a57b
[Impeller] combine text shaders. ( flutter/engine#52392 )
...
Combine both text shaders into one. One more down!
https://github.com/flutter/flutter/issues/143540
2024-04-25 20:18:13 +00:00
skia-flutter-autoroll
8e9dd76646
Roll Skia from 67bba57bfe80 to cb32ad619678 (2 revisions) ( flutter/engine#52395 )
...
https://skia.googlesource.com/skia.git/+log/67bba57bfe80..cb32ad619678
2024-04-25 jvanverth@google.com [graphite] Fix edges of YUV images.
2024-04-25 fmalita@google.com [svg] Optional ellipse radii
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-25 18:42:05 +00:00
skia-flutter-autoroll
a36407757b
Roll Dart SDK from b5f51d886819 to f9c9894a2500 (1 revision) ( flutter/engine#52393 )
...
https://dart.googlesource.com/sdk.git/+log/b5f51d886819..f9c9894a2500
2024-04-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-101.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-25 17:58:26 +00:00
skia-flutter-autoroll
3a3e735e23
Roll Skia from b440433e2df5 to 67bba57bfe80 (1 revision) ( flutter/engine#52391 )
...
https://skia.googlesource.com/skia.git/+log/b440433e2df5..67bba57bfe80
2024-04-25 robertphillips@google.com [graphite] Swap the PrecompileShaders and Priv LocalMatrix factories
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-25 17:13:06 +00:00
Zachary Anderson
c04e13ac47
Remove goma support from impeller-cmake-example ( flutter/engine#52390 )
2024-04-25 10:05:23 -07:00
Jonah Williams
dc65cc62c1
[Impeller] delete specific vertices shader. ( flutter/engine#52360 )
...
Once https://github.com/flutter/engine/pull/52348 and https://github.com/flutter/engine/pull/52345 land we can delete this shader
Part of https://github.com/flutter/flutter/issues/143540
2024-04-25 16:48:13 +00:00
skia-flutter-autoroll
f9f053e8df
Roll Skia from 283d3e4e8e35 to b440433e2df5 (3 revisions) ( flutter/engine#52389 )
...
https://skia.googlesource.com/skia.git/+log/283d3e4e8e35..b440433e2df5
2024-04-25 michaelludwig@google.com [graphite] Add RenderPassDesc to pipeline labels and traces
2024-04-25 robertphillips@google.com Preserve presence/absence of optional matrices in CanvasKit
2024-04-25 brianosman@google.com Increase RescaleWithTransform tolerance slightly more for Pixel 4a
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-25 16:05:06 +00:00
skia-flutter-autoroll
8ef8dc0c10
Roll Dart SDK from 386cac001e2b to b5f51d886819 (1 revision) ( flutter/engine#52388 )
...
https://dart.googlesource.com/sdk.git/+log/386cac001e2b..b5f51d886819
2024-04-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-100.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-25 13:48:27 +00:00
skia-flutter-autoroll
3c350130eb
Roll Skia from 15da9c78ddbd to 283d3e4e8e35 (1 revision) ( flutter/engine#52386 )
...
https://skia.googlesource.com/skia.git/+log/15da9c78ddbd..283d3e4e8e35
2024-04-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from daa9d07a18bb to c771d4aa9a32 (3 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-25 10:05:15 +00:00
skia-flutter-autoroll
420610205f
Roll Skia from e1fbdd02b79b to 15da9c78ddbd (1 revision) ( flutter/engine#52385 )
...
https://skia.googlesource.com/skia.git/+log/e1fbdd02b79b..15da9c78ddbd
2024-04-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 72b1e50d159a to e6a1f0f0732a
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-25 06:48:21 +00:00
skia-flutter-autoroll
d8f17c0247
Roll Dart SDK from 4ec0cf16c47c to 386cac001e2b (1 revision) ( flutter/engine#52384 )
...
https://dart.googlesource.com/sdk.git/+log/4ec0cf16c47c..386cac001e2b
2024-04-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-99.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-25 06:29:26 +00:00
skia-flutter-autoroll
34ae8325a3
Roll Skia from 864f6d868ec0 to e1fbdd02b79b (1 revision) ( flutter/engine#52383 )
...
https://skia.googlesource.com/skia.git/+log/864f6d868ec0..e1fbdd02b79b
2024-04-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from b24132ef5cdf to e6a1f0f0732a (21 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-25 05:52:15 +00:00
Ian Hickson
b7117adf38
Document the new binding hooks for SceneBuilder, PictureRecorder, Canvas ( flutter/engine#52374 )
...
See https://github.com/flutter/flutter/pull/147271 for context.
Do not land until https://github.com/flutter/flutter/pull/147271 has landed.
2024-04-25 03:05:20 +00:00
skia-flutter-autoroll
897a8072ac
Roll Dart SDK from 9a0f141e9a67 to 4ec0cf16c47c (1 revision) ( flutter/engine#52382 )
...
https://dart.googlesource.com/sdk.git/+log/9a0f141e9a67..4ec0cf16c47c
2024-04-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-98.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-25 02:25:22 +00:00
Tong Mu
43fed272aa
[macOS] Remove extra setViewController and extra import ( flutter/engine#52255 )
...
This stub PR removes and extra `setViewController`, which is unnecessary because the view controller's initializer already attaches itself to the engine.
This PR also removes an extra import since `FlutterCompositor` is not used in the engine's definition. As a result, `FlutterEngineTest.mm` needs to import it explicitly.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-04-25 00:26:12 +00:00
Jonah Williams
3385d10982
[Impeller] only use porter duff or vertices.uber for drawVertices. ( flutter/engine#52345 )
...
Simplifcation that will allow us to remove the special case position_color.vert and vertices.frag shaders, not done here because drawAtlas also needs to be updated. This also fixes sparkle-party like rendering bugs where we incorrectly relied on a color filter.
The problem with doing advanced blends between the vertices with a color filters was three fold:
1. We would render incorrectly when vertices overlapped.
2. We had to disable MSAA to remove artifacts
3. The sub render pass was slow.
Below is an example of the incorrect rendering caused by overlapping vertices on the sparkle party app.
## Skia (Advanced blend)
## Impeller (ToT)
## Impeller w/ patch
Fixes https://github.com/flutter/flutter/issues/131345
2024-04-24 23:45:49 +00:00
skia-flutter-autoroll
b26ff455f5
Roll Fuchsia Linux SDK from le_-uFgRD5DjvvqgL... to PJBX8xxRnd5vCFnQM... ( flutter/engine#52376 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-24 23:21:29 +00:00
Jonah Williams
a9414aa74e
[Impeller] Remove additional shader bootstrap. ( flutter/engine#52368 )
...
Because these shaders must first acquire the prototype shader, it causes ContentContext creation to block. We can re-explore dealing with PSO generation in a different manner that isn't on the startup fast path.
https://github.com/flutter/flutter/issues/143540
2024-04-24 23:06:02 +00:00
Matan Lurey
b81845d228
Remove TODO I will never do: runIfNot is deprecated. ( flutter/engine#52308 )
...
🖖🏼
2024-04-24 15:40:57 -07:00
skia-flutter-autoroll
c9b48b4619
Roll Dart SDK from 38c43a01a51e to 9a0f141e9a67 (1 revision) ( flutter/engine#52373 )
...
https://dart.googlesource.com/sdk.git/+log/38c43a01a51e..9a0f141e9a67
2024-04-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-97.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-24 22:22:05 +00:00
Brandon DeRosier
524fc9e31b
[Impeller] Cleanup legacy StencilModes and document overdraw prevention. ( flutter/engine#52372 )
...
We don't need `kLegacyClipDecrement` or `kLegacyClipCompare` anymore, but we still need `kLegacyClipRestore` and `kLegacyClipIncrement`. So I renamed these to `kOverdrawPreventionRestore` and `kOverdrawPreventionIncrement` respectively and documented how they're used.
2024-04-24 21:58:59 +00:00
skia-flutter-autoroll
71f41387b7
Roll Skia from afcc1db27593 to 864f6d868ec0 (1 revision) ( flutter/engine#52371 )
...
https://skia.googlesource.com/skia.git/+log/afcc1db27593..864f6d868ec0
2024-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 8ff7d8bf1899 to daa9d07a18bb (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-24 21:48:47 +00:00
Jason Simmons
97993d97a3
Move zlib to //flutter/third_party ( flutter/engine#52366 )
...
Fixes https://github.com/flutter/flutter/issues/146598
2024-04-24 21:07:47 +00:00
Victoria Ashworth
f2c245f93e
Remove UIAccessibilityTraitKeyboardKey to fix touch typing ( flutter/engine#52333 )
...
`UIAccessibilityTraitKeyboardKey` was added in https://github.com/flutter/engine/pull/4575 so that `TextInputSemanticsObject` supported VoiceOver gestures for text editing features, such as pinch to select text, and up/down fling to move cursor. After experimenting with it, I found that those features were still available even after removing `UIAccessibilityTraitKeyboardKey`.
Fixes https://github.com/flutter/flutter/issues/94465 .
In Touch Typing Mode:
https://github.com/flutter/engine/assets/15619084/ccfe90ff-d3bc-427b-b1aa-9ec1242c0c89
In Standard Typing Mode:
https://github.com/flutter/engine/assets/15619084/c78b1fb0-0816-41fb-9dd5-ed8b8a4cda2d
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-04-24 21:05:13 +00:00
Brandon DeRosier
e8db04338d
[Impeller] Remove libtess2 from libflutter. ( flutter/engine#52357 )
...
- Move libtess-powered functionality into an `impeller::Tessellator` subclass called `impeller::TessellatorLibtess`.
- `impeller::Tessellator` now only contains `Tessellator::TessellateConvex` and utilities for fast circles/ellipses.
- Use `impeller::TessellatorLibtess` in geometry_benchmarks, renderer_unittests, and the C tessellator API implementation.
- Continue using `impeller::Tessellator` in Impeller, but without the libtess2 dependency.
2024-04-24 20:52:23 +00:00
skia-flutter-autoroll
5ec2bd8b2b
Roll Skia from 510b6766d907 to afcc1db27593 (2 revisions) ( flutter/engine#52367 )
...
https://skia.googlesource.com/skia.git/+log/510b6766d907..afcc1db27593
2024-04-24 egdaniel@google.com [Graphite] Add labels for buffer resources.
2024-04-24 robertphillips@google.com [graphite] Reduce shader variation due to LocalMatrixShaders
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-24 20:46:04 +00:00
Yegor
20e2de3a37
[web:tests] switch to new HTML DOM matcher ( flutter/engine#52354 )
...
Remove the over-architected and under-utilized `canonicalizeHtml` and `HtmlComparisonMode`. Replace with a new `hasHtml` matcher.
The new matcher produces considerably better error messages when matching fails (see `matchers_test.dart` for multiple examples). It also allows focusing on particular parts of the DOM rather than looking for a full match. This way a test can test just the functionality it cares about, and it can skip specifying what unrelated parts should look like (i.e. it prevents over-testing). For example, let's say you want to test that an `<flt-semantics>` element has an `aria-label` attribute. You can use a DOM pattern that specified just that:
```
expect(
element,
hasHtml('<flt-semantics aria-label="hello"></flt-semantics>'),
)
```
This will check for the existence of `<flt-semantics>` and `aria-label="hello"`. It will ignore everything else that's unrelated to ARIA labels. For example, the element may have its geometry specified in the `style` attribute, an `id` attribute, and many other things, but if the test doesn't care, it doesn't need to specify those things (it can, if needs to though). This also applies to `style` properties. See more examples in the `matchers_test.dart` file.
2024-04-24 20:40:06 +00:00
Jonah Williams
5360ab3084
[Impeller] use spec constant for gaussian shader, rename, and reuse vertex sources. ( flutter/engine#52361 )
...
Reduces shader count slightly, and reduces duplication of source code for vertex stages that are identical.
Part of https://github.com/flutter/flutter/issues/143540
2024-04-24 19:31:46 +00:00
Jonah Williams
6dca56fb0e
[Impeller] delete points compute shader. ( flutter/engine#52346 )
...
We only use this for drawPoints, a rarely used API. On local tests, this is just as fast with the CPU backend implementations.
While this was intended to be the first in a series of compute based rendering experiments, it hasn't really been worth the carrying cost. So lets shrink the complexity and and remove another shader to boot.
Fixes https://github.com/flutter/flutter/issues/147184
2024-04-24 18:24:06 +00:00
Byoungchan Lee
011c50a4c5
[darwin] Update pixel format handling in FlutterTexture ( flutter/engine#52326 )
...
CVPixelBuffers from the application can have arbitrary pixel formats. However, current implementation doesn't support all pixel formats. To address this, add a comment to the FlutterTexture class to clarify which pixel formats are supported. Also, reject unsupported pixel formats so that the application can handle them properly.
Fixes [#147242 ](https://github.com/flutter/flutter/issues/147242 ).
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-04-24 18:10:17 +00:00
Jonah Williams
15e063537f
[Impeller] make drawAtlas always use porterduff or vertices_uber shader ( flutter/engine#52348 )
...
The drawAtlas component of https://github.com/flutter/engine/pull/52345 . DrawAtlas did not have the same advanced blend/overlapping issues as draw vertices because of the sorting and generation of the sub-atlas, but given that the vertices uber shader exists we can just use that instead.
Will eventually allow deleting the other drawVertices special case shaders.
2024-04-24 17:58:08 +00:00
Jenn Magder
382620c0ef
Migrate ios_surface files to ARC ( flutter/engine#52139 )
...
Smart pointers support ARC as of https://github.com/flutter/engine/pull/47612 , and the unit tests were migrated in https://github.com/flutter/engine/pull/48162 .
Migrate `ios_surface` classes from MRC to ARC.
Decorate C functions that take or return Objective-C objects or structs containing Objective-C objects with [`cf_audited_transfer`](https://clang.llvm.org/docs/AutomaticReferenceCounting.html#auditing-of-c-retainable-pointer-interfaces ).
Part of https://github.com/flutter/flutter/issues/137801 .
2024-04-24 17:54:09 +00:00
skia-flutter-autoroll
75c44d60f9
Roll Dart SDK from f470eaaf6e6d to 38c43a01a51e (1 revision) ( flutter/engine#52365 )
...
https://dart.googlesource.com/sdk.git/+log/f470eaaf6e6d..38c43a01a51e
2024-04-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-96.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-24 17:54:06 +00:00
skia-flutter-autoroll
79e3ae8c6f
Roll Skia from b5dd23bd29df to 510b6766d907 (16 revisions) ( flutter/engine#52364 )
...
https://skia.googlesource.com/skia.git/+log/b5dd23bd29df..510b6766d907
2024-04-24 michaelludwig@google.com [graphite] Move YUVATextureProxies logic into Image_YUVA
2024-04-24 jamesgk@google.com [graphite][cleanup] Remove unused kIgnoreMaskFilter flag
2024-04-24 jcgregorio@google.com Remove Pixel3 and Intel BayTrail devices.
2024-04-24 brianosman@google.com Reland "Reland "Restore affine bitmap procs""
2024-04-24 kjlubick@google.com Add define to signal Android FontMgr is available
2024-04-24 jamesgk@google.com [graphite] Precalculation for analytic circle blur
2024-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from cbf986e97789 to edc6a51fe9de
2024-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from 24edbde4082b to e9508b902e1a
2024-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 822c202b73bc to b0e42fbd5e63
2024-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from 453d00b44c6b to c9b24124977b
2024-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f231db78374b to 8ff7d8bf1899 (3 revisions)
2024-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from b24132ef5cdf to 26741f478094
2024-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from eb81b28b0318 to b24132ef5cdf (11 revisions)
2024-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 9aec4b969291 to 76f7f8cfea80 (1 revision)
2024-04-24 armansito@google.com [graphite] compute-msaa8 atlas path rendering mode
2024-04-24 armansito@google.com [graphite][dawn] Ensure r8unorm storage usage is not advertised in WASM
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-24 17:48:05 +00:00
Jason Simmons
b84c057bfb
Fix some warnings reported by recent versions of clang-tidy ( flutter/engine#52349 )
...
* Invalid enum values in the embedder library
* Disable a check that warns about standard usage of GTK macros in the Linux embedder
2024-04-24 17:46:19 +00:00
skia-flutter-autoroll
608dcf5739
Roll Skia from e15464e6e982 to b5dd23bd29df (1 revision) ( flutter/engine#52353 )
...
https://skia.googlesource.com/skia.git/+log/e15464e6e982..b5dd23bd29df
2024-04-24 michaelludwig@google.com [graphite] Support one-time-only tasks in Recordings
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-24 15:50:21 +00:00
skia-flutter-autoroll
d0326c9d7d
Roll Dart SDK from 5227dc5103f6 to f470eaaf6e6d (1 revision) ( flutter/engine#52359 )
...
https://dart.googlesource.com/sdk.git/+log/5227dc5103f6..f470eaaf6e6d
2024-04-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-95.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-24 14:04:22 +00:00
skia-flutter-autoroll
7eb5f19f17
Roll Dart SDK from 60cb97ab64e6 to 5227dc5103f6 (1 revision) ( flutter/engine#52356 )
...
https://dart.googlesource.com/sdk.git/+log/60cb97ab64e6..5227dc5103f6
2024-04-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-94.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-24 06:31:16 +00:00
skia-flutter-autoroll
83a95410b8
Roll Dart SDK from cf9144942ca1 to 60cb97ab64e6 (1 revision) ( flutter/engine#52351 )
...
https://dart.googlesource.com/sdk.git/+log/cf9144942ca1..60cb97ab64e6
2024-04-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-93.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-24 02:37:13 +00:00
Jonah Williams
c428e84a76
[Impeller] delete unused geometry API. ( flutter/engine#52347 )
...
We don't use this!
2024-04-24 00:23:17 +00:00
Zachary Anderson
f1ac2c5650
[et] Don't require the --verbose flag when requesting a ci/ build ( flutter/engine#52339 )
...
https://github.com/flutter/engine/pull/52021 introduced a bug where `ci`
build could only be specified when also passing the `--verbose` flag.
This PR fixes the issue so that by default the `help` message will only
show `ci` builds when `--verbose` is passed to `help`, but the `ci`
builds can be specified even without the `--verbose` flag.
2024-04-23 16:46:11 -07:00
Chris Bracken
b0c35a4aca
[macOS] Disable FlutterEngineTest.BackgroundColor ( flutter/engine#52341 )
...
This was re-enabled in https://github.com/flutter/flutter/issues/124677 after fixing leaks in https://github.com/flutter/engine/pull/50832 . Since this test involves an NSWindow, there are separate fixes that should be landed to reduce flakes related to lack of NSWindow close calls in the tests. See related AppKit bug report filed at http://www.openradar.me/FB13291861 .
Issue: https://github.com/flutter/flutter/issues/145728
Related issue: https://github.com/flutter/flutter/issues/124677
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-04-23 23:21:05 +00:00
skia-flutter-autoroll
e90ec7a9b0
Roll Skia from cdede8e2e18b to e15464e6e982 (2 revisions) ( flutter/engine#52344 )
...
https://skia.googlesource.com/skia.git/+log/cdede8e2e18b..e15464e6e982
2024-04-23 brianosman@google.com Add isArc to SkPath
2024-04-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 99fa81c4c166 to 822c202b73bc
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 23:17:23 +00:00
skia-flutter-autoroll
61d1329e81
Roll Dart SDK from 6a670b60eb06 to cf9144942ca1 (1 revision) ( flutter/engine#52338 )
...
https://dart.googlesource.com/sdk.git/+log/6a670b60eb06..cf9144942ca1
2024-04-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-92.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 22:37:48 +00:00
