DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove "gclient sync" warning call during pre-rebase (flutter/engine#52342)

Browse Source 
Remove `pre-rebase` check from `gclient sync` warning, and instead remove the warning call from `pre_rebase_command`

Follow-up to https://github.com/flutter/engine/pull/52133#discussion_r1575447161
This commit is contained in:
Jenn Magder 2024-04-25 16:12:03 -07:00 committed by GitHub
parent 7f8d6a3cf3
commit 59cd6af303
2 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
engine/src/flutter/tools/githooks/lib/src/messages.dart
View File

@ -10,9 +10,6 @@ const String _reset = '\x1B[0m';
/// Prints a reminder to stdout to run `gclient sync -D`. Uses colors when
/// stdout supports ANSI escape codes.
void printGclientSyncReminder(String command) {
if (command == 'pre-rebase') {
return;
}
final String prefix = io.stdout.supportsAnsiEscapes ? _redBoldUnderline : '';
final String postfix = io.stdout.supportsAnsiEscapes ? _reset : '';
io.stderr.writeln('$command: The engine source tree has been updated.');

3
engine/src/flutter/tools/githooks/lib/src/pre_rebase_command.dart
View File

@ -4,8 +4,6 @@
import 'package:args/command_runner.dart';
import 'messages.dart';
/// The command that implements the pre-rebase githook
class PreRebaseCommand extends Command<bool> {
@override
@ -16,7 +14,6 @@ class PreRebaseCommand extends Command<bool> {
@override
Future<bool> run() async {
printGclientSyncReminder(name);
// Returning false here will block the rebase.
return true;
}