15230 Commits

Author SHA1 Message Date
George Wright
591d149f97
Make flutter_tester support multithreaded testing, and run all Dart tests in both single and multithreaded configurations (#13273)
Make flutter_tester support multithreaded testing, and run all Dart tests in both single and multithreaded configurations

This also modifies Shell::GetUIIsolateLastError() and Shell::EngineHasLivePorts() so that they must be called from the UI task runner.
2019-10-22 14:10:57 -07:00
gaaclarke
25fcf531fa
Made restarting the Engine remember the last entrypoint that was used. (#13289) 2019-10-22 14:01:52 -07:00
skia-flutter-autoroll
fc6ac96dcd
Roll src/third_party/skia f3f8ac37e468..2638f3d44b02 (12 commits) (#13291)
https://skia.googlesource.com/skia.git/+log/f3f8ac37e468..2638f3d44b02

git log f3f8ac37e468..2638f3d44b02 --date=short --no-merges --format='%ad %ae %s'
2019-10-22 bsalomon@google.com rename atlassize->atlasdimensions
2019-10-22 robertphillips@google.com Add creation-time POD memory pool for GrOps
2019-10-22 kjlubick@google.com [canvaskit] Expose various canvas features
2019-10-22 michaelludwig@google.com Revert "Enable Programs (formerly GLPrograms) test for other APIs"
2019-10-22 bsalomon@google.com More SkISizification in GPU code.
2019-10-22 herb@google.com Revert "Use common fallback code for drawing an SkGlyphRun"
2019-10-22 egdaniel@google.com Add SurfaceProxyView support to Surface/TextureContext.
2019-10-22 jvanverth@google.com Enable Programs (formerly GLPrograms) test for other APIs
2019-10-22 fmalita@chromium.org [skottie] Site update
2019-10-22 fmalita@chromium.org [skottie] Expose native frame rate and seekFrame() in WASM
2019-10-22 egdaniel@google.com Add GrSurfaceProxyView and add support for it on GrRenderTargetContext.
2019-10-22 kjlubick@google.com [canvaskit] Expose Malloc to save copies in some places

Created with:
  gclient setdep -r src/third_party/skia@2638f3d44b02

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=michaelludwig@google.com
2019-10-22 16:55:47 -04:00
Harry Terkelsen
2eaf62fdc8
Flesh out the CanvasKit backend some more (#13275)
* Flesh out the CanvasKit backend some more

- Implement `drawOval` and `addOval`
- Use the Canvas's own `getSaveCount`
- Implement `skew`
- Implement `saveLayerWithoutBounds`
- Document things which we don't plan to implement in the Skia backend

* Remove `rasterCache` fake support

* Remove saveCount setter
2019-10-22 13:15:35 -07:00
Ryan Macnak
f6900001eb
Roll Dart to 6a65ea9cad4b014f88d2f1be1b321db493725a1c. (#13294)
Remove dead shared snapshot arguments to Dart_CreateIsolateGroup.

6a65ea9cad4b [vm] Remove shared snapshot and reused instructions features.
db8370e36147 [gardening] Fix frontend-server dartdevc windows test.
4601bd7bffea Modified supertype check error message to be more descriptive.
0449905e2de6 [CFE] Add a serialization-and-unserialization step to strong test
c8b903c2f94f Update CHANGELOG.md
2a12a13d9684 [Test] Skips emit_aot_size_info_flag_test on crossword.
b26127fe01a5 [cfe] Add reachability test skeleton
2019-10-22 13:14:20 -07:00
Chinmay Garde
f77aa45eb4
Disable flaky test ShellTest_ReportTimingsIsCalled. (#13292)
Investigation is tracked in https://github.com/flutter/flutter/issues/43192
2019-10-22 11:56:31 -07:00
Jason Simmons
f0c9edcfa5
Do not request executable permission on Fuchsia file mappings unless it is required (#13290)
Fixes https://github.com/flutter/flutter/issues/43273
2019-10-22 11:24:51 -07:00
Ben Konyi
a554235978 Roll src/third_party/dart e1c409792c..5814319bf9 (9 commits)
dart-lang/sdk@5814319bf9 [infra] Remove support for run.json
dart-lang/sdk@cf3cb29dec [vm/bytecode] Do not emit inferred type if unreachable - fix comment
dart-lang/sdk@e2faac751e [vm/aot] Fully enable deduplication of instructions in bare mode
dart-lang/sdk@aeede3c1b0 Flow analysis: pass catch variables to tryCatchStatement_catchBegin.
dart-lang/sdk@1e7bfd6449 Sort declarations in flow_analysis_test.dart
dart-lang/sdk@9579c4bc3c Flow analysis: simplify use of isExpression_end.
dart-lang/sdk@a58d337bd3 [cfe] Add helper for creating binary expressions.
dart-lang/sdk@e76f6d49e4 [cfe] Implement null-shorting for most expressions
dart-lang/sdk@596eb91228 [kernel] Update smoke_test_quick after CFE rename of _test to _suite
2019-10-22 11:10:17 -07:00
gaaclarke
0d43469b40
Revert "Made restarting the Engine remember the last entrypoint that was used. (#13264)" (#13287)
This reverts commit 9dd585c463c35950a79471fab80023cfa9ce9c26.
2019-10-22 10:03:10 -07:00
gaaclarke
9dd585c463
Made restarting the Engine remember the last entrypoint that was used. (#13264) 2019-10-22 08:10:57 -07:00
Siva
a064063e3f Manual Roll of Dart from a61c775db8...e1c409792c (#13282)
dart-lang/sdk/@e1c409792c Revert "Reland "Update BoringSSL to 4dfd5af70191b068aebe567b8e29ce108cee85ce.""
dart-lang/sdk/@d0e35833b3 Remove UnitExplicitTopLevelAccessors, UnitExplicitTopLevelVariables.
dart-lang/sdk/@159e0b74bc Remove SourceContainer, Source_ContentReceiver.
dart-lang/sdk/@e85c98b1f9 Remove BuildLibraryElementUtils.
dart-lang/sdk/@4ce76d4d46 Remove AnalysisCache, CachePartition, SdkCachePartition.
dart-lang/sdk/@7d474c95bb Remove fixed GENERIC_FUNCTION_TYPED_PARAM_UNSUPPORTED.
dart-lang/sdk/@c3cd6b0c6e Remove VariableGatherer and related.
dart-lang/sdk/@de63b83b5b Remove TypeParameterSerializationContext.
dart-lang/sdk/@bf9cef0ab9 Remove two unused methods in ElementImpl.
dart-lang/sdk/@6de2f92033 [vm,bytecode] Allocate objects lazily in bytecode generator
dart-lang/sdk/@929a306bfc [tests] Fix missing space in failure message
dart-lang/sdk/@a0291729f5 Fix documentation for InternetAddress.lookup()
dart-lang/sdk/@b942142e9e [io] add testcases for link pointing to directory
dart-lang/sdk/@230f48d685 [vm,aot] Simple unreachable code elimination before type-flow analysis, take 3
dart-lang/sdk/@e8fa489242 [vm/bytecode] Store generated bytecodes more efficiently, add inline pragmas
dart-lang/sdk/@66ceec0e3d Fix redirecting constructor const check
dart-lang/sdk/@6f44e99f6e [vm/aot] Add test which passes both AOT size information flags --print-instructions-sizes-to/--write-v8-snapshot-profile-to
dart-lang/sdk/@354921f955 Update `runtime/docs/aot_binary_size_analysis.md` with paragraph about size comparison tool
dart-lang/sdk/@5706d13c06 [dartdevc] Update URI for libraries.json to use multi-root
dart-lang/sdk/@f77d7197b8 [vm/fuzzer] add --enable-asserts to AOT step
dart-lang/sdk/@199a42f3c1 [dartdevc] Cache the results of subtype checks
dart-lang/sdk/@2495c5ca9f [html] Avoid dynamic in Rectangle operator ==
dart-lang/sdk/@aa569dfff0 [vm] Enable non-nullable experiment when building platform dill with --nnbd flag.
dart-lang/sdk/@bf4d4b2461 [dart/fuzzer] re-enable spread at all depths in fuzzer
dart-lang/sdk/@13a5893d1c Update dart_style to 1.3.2.
dart-lang/sdk/@4e8d517f40 [vm,bytecode] Store offsets in bytecode declarations, remove putIfAbsent
dart-lang/sdk/@a170fc54b9 [vm] Fix DirectChainedHashMap iterator
dart-lang/sdk/@5d4cd6d589 Breaking changes for analyzer version 0.39.
dart-lang/sdk/@2423ffead6 [vm,bytecode] Correct assertion for source positions of yield points
dart-lang/sdk/@d0139e8e38 [VM] More cleanup in the loader code
dart-lang/sdk/@73dd5f766a [vm,aot,bytecode] Do not depend on presence of _AsyncAwaitCompleter
dart-lang/sdk/@7b39f438ed [benchmark] Test that precompiler2 --no-gen-bytecode continues to work.
dart-lang/sdk/@ed0cc81e81 Get DDC and DDK test builds working with the forked NNBD SDK.
dart-lang/sdk/@6c933a4488 [vm] Fix some TSAN failures. Migrate remaining uses of AtomicOperations to std::atomic.
dart-lang/sdk/@c26d5969f7 [flutter] JavaScript support to frontend_server
dart-lang/sdk/@b1b4f6b7e4 [cfe] Allow assignment to late final fields/variables
dart-lang/sdk/@f1ac6959ab [cfe] Handle mixed if map entries
dart-lang/sdk/@8b3d76dff1 [analyzer/ffi] Fix crash with dynamic field in struct
dart-lang/sdk/@74d0282179 [infra] Run test suites in pkg/front_end/test with custom test runner
dart-lang/sdk/@6b19f37b5a [infra] Change option name in modular test runner to be consistent with test.py
dart-lang/sdk/@d0cef92f05 Migration: refactor logic to match up type parameters between function types.
dart-lang/sdk/@15ec4a3803 [infra] Make front_end tests unapprovable using a blacklist
dart-lang/sdk/@22dbc7d748 Migration: FixBuilder support for function expression invocations.
dart-lang/sdk/@531aaa9ad2 [ddk] Emit variance modifiers for classes, mixins, mixin applications.
dart-lang/sdk/@064c3c7cf7 Get the DDK build working with NNBD.
dart-lang/sdk/@57a88fc33c Reland "[io] exclude links from isDirectory()"
dart-lang/sdk/@6c36630958 Update to latest package:yaml
dart-lang/sdk/@f6eb26dfb6 [dart/vm] add ability to pass VM flags to dart when running gen_kernel.dart in precompiler2 script
dart-lang/sdk/@2c1d405c15 [changelog/ffi] Document dart:ffi changes for D26
dart-lang/sdk/@9220890dc7 [vm/bytecode] Do not emit inferred type if unreachable
dart-lang/sdk/@fd0617bd98 Improve listToString and setToString documentation. Fixes #26529
dart-lang/sdk/@cb9eefca4f Issue 142793249. Never remove directive with unresolved URIs.
dart-lang/sdk/@4f0c8cba56 Add README for samples/sample_extension
dart-lang/sdk/@a9fc9f7fd4 [SDK] Fixes run_appended_aotsnapshot_test on Windows.
dart-lang/sdk/@22e249d4d5 update kernel worker to support -D environment defines
dart-lang/sdk/@ffcfab3093 [dartdevc] support null-check bang operator
dart-lang/sdk/@09b08f7b0e Add comment on non-negativity of periodic Timer and Stream.
dart-lang/sdk/@8c041c8f8f [parser] Don't clear extraneous covariant token
dart-lang/sdk/@46050115ab [vm/compiler] Arm64: Improve StoreIndexedInstr.
dart-lang/sdk/@3d67e7d6a7 [CFE] Don't try to infer fields not in the output program
dart-lang/sdk/@d40c8a0573 [kernel] Add 'leakingDebugToString' to nodes
dart-lang/sdk/@8d8faa7dea [SDK] Fixes loading appended snapshots when executed with PATH.
dart-lang/sdk/@c1599932f9 [CFE] Fix crash when serializing: "Type parameter #lib1::B::X is not indexed"
dart-lang/sdk/@b212403cf8 [cfe] Change integer values that encode nullability attributes
dart-lang/sdk/@9a829cc0b3 Remove 'strong' comments from Future.
dart-lang/sdk/@0c47a8529c [CFE] Fix "Type 'void' not found." bug
dart-lang/sdk/@e41086ef7c [vm] Enable timeline trace events with Fuchsia SDK
dart-lang/sdk/@cd95fcc810 [VM] Start the kernel isolate only when compilations are needed
dart-lang/sdk/@21972daf7d [analyzer] refactor the flutter assists menu
dart-lang/sdk/@50f9dd8941 Revert "[io] exclude links from isDirectory()"
dart-lang/sdk/@d9fa27a9ed Update ~48 doc comments to have one-sentence summaries
dart-lang/sdk/@8e7ffafbaf Reland "[vm, compiler] Reduce alignment of Instructions and remove some debugging trap instructions."
dart-lang/sdk/@eb9480daa5 Revert "[vm,aot] Simple unreachable code elimination before type-flow analysis, take 2"
dart-lang/sdk/@49d743f940 [io] exclude links from isDirectory()
dart-lang/sdk/@56991ad94b [vm,aot] Simple unreachable code elimination before type-flow analysis, take 2
dart-lang/sdk/@03d6e042af [dart2js] Fix printing of minified closures.
dart-lang/sdk/@8a92058226 Support omitted name args; fix as-expressions, refactor tests
dart-lang/sdk/@45358c5834 [vm] Implementation of NullCheck for bytecode
dart-lang/sdk/@62283b9d3f [vm] Bump ABI version to make vm-dartkb-linux-release-x64-abi green again
dart-lang/sdk/@20f9d4d456 [vm,bytecode] Omit initialization of delayed type arguments for non-generic closures
dart-lang/sdk/@1c2dc77f64 Issue 38947. Support for then/else widgets in ConditionalExpression.
dart-lang/sdk/@d2b39d1a07 [cfe/ffi] asFunction/fromFunction variance in CFE + regression test
dart-lang/sdk/@882a6b57d2 Enable bytecode in AOT compilation pipeline
dart-lang/sdk/@b4ad2f2545 [vm/compiler] ARM64: Improve shifts assembly instructions.
dart-lang/sdk/@9ae7b10cea [vm] Fix a bug in Utils::NBitMask.
dart-lang/sdk/@ba728b1368 [dartdevc] Copy nnbd subtype test to run on nnbd strong configurations
dart-lang/sdk/@4dc1901cdb [vm,bytecode] Write closure attributes separately
dart-lang/sdk/@ecd7977928 [vm] Fix gcc build.
dart-lang/sdk/@411bd6247b [isolate] Fix `delete ()` call to operator `delete` form.
dart-lang/sdk/@00dc546586 Migration: make more use of `.isNullAware` throughout migration engine.
dart-lang/sdk/@dce3d0591f Migration: Fix three broken FixBuilder unit tests.
dart-lang/sdk/@8eb28a4817 Migration: add simple MethodInvocation support to FixBuilder.
dart-lang/sdk/@7d4bc6a1df Fix handling of null awareness in cascade expressions.
dart-lang/sdk/@4e449069f2 [VM] Skip verbose_gc_to_bmu_test on precompiled configs
dart-lang/sdk/@ca9671f34d Migration: add isUpstreamTriggered getter
dart-lang/sdk/@7eeaeade6b Reland "Update BoringSSL to 4dfd5af70191b068aebe567b8e29ce108cee85ce."
dart-lang/sdk/@1f58504ee6 [vm/compiler] Do not initialize delayed_type_arguments_ for non-generic closures
dart-lang/sdk/@680a880c10 Move string utils from services/correction to utilities; more generally used
2019-10-22 07:49:12 -07:00
skia-flutter-autoroll
705418d5f9
Roll src/third_party/skia 4a152d340f06..f3f8ac37e468 (1 commits) (#13283)
https://skia.googlesource.com/skia.git/+log/4a152d340f06..f3f8ac37e468

git log 4a152d340f06..f3f8ac37e468 --date=short --no-merges --format='%ad %ae %s'
2019-10-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 4a80ba25e67b..5335faaece2a (2 commits)

Created with:
  gclient setdep -r src/third_party/skia@f3f8ac37e468

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=michaelludwig@google.com
2019-10-22 09:53:21 -04:00
skia-flutter-autoroll
95ebfd052e
Roll fuchsia/sdk/core/mac-amd64 from hALu4... to xGLLm... (#13284)
Roll fuchsia/sdk/core/mac-amd64 from hALu4... to xGLLm...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-22 09:51:12 -04:00
skia-flutter-autoroll
8959ab320a
Roll fuchsia/sdk/core/linux-amd64 from _e7Up... to _PqfD... (#13285)
Roll fuchsia/sdk/core/linux-amd64 from _e7Up... to _PqfD...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-22 09:49:12 -04:00
skia-flutter-autoroll
6a0f1fb716
Roll src/third_party/skia 81e8d3b29662..4a152d340f06 (2 commits) (#13281)
https://skia.googlesource.com/skia.git/+log/81e8d3b29662..4a152d340f06

git log 81e8d3b29662..4a152d340f06 --date=short --no-merges --format='%ad %ae %s'
2019-10-22 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps
2019-10-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 26c6c4a5eb83..23f9c25f60ee (2 commits)

Created with:
  gclient setdep -r src/third_party/skia@4a152d340f06

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=michaelludwig@google.com
2019-10-22 02:16:05 -04:00
vsmenon
a6fe7efc01 Enable/tweak web sdk source maps, take 2 (#13161)
Update outline step to remove absolute paths here as well.  See: https://dart-review.googlesource.com/c/sdk/+/122178/5/utils/dartdevc/BUILD.gn
2019-10-21 21:20:58 -07:00
skia-flutter-autoroll
ae0110d2e8
Roll src/third_party/skia 56f569d9bec2..81e8d3b29662 (7 commits) (#13277)
https://skia.googlesource.com/skia.git/+log/56f569d9bec2..81e8d3b29662

git log 56f569d9bec2..81e8d3b29662 --date=short --no-merges --format='%ad %ae %s'
2019-10-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-10-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-10-21 fmalita@chromium.org [skottie] fix clangtidy warning
2019-10-21 kjlubick@google.com [fuzzing] Add two fuzzers for SkDescriptor
2019-10-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-10-21 bsalomon@google.com Simplify sk_gpu_test::MakeTextureProxyFromData.
2019-10-21 halcanary@google.com SkPDF: simplify Producer metadata logic

Created with:
  gclient setdep -r src/third_party/skia@81e8d3b29662

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=michaelludwig@google.com
2019-10-21 22:22:46 -04:00
Matt Carroll
e6e35a90df
Forwards Activity result to FlutterFragment in FlutterFragmentActivity. (#13214) 2019-10-21 17:05:46 -07:00
George Wright
73c6a4a1e2
Ensure we call into Engine from the UI taskrunner in Shell::EngineHasLivePorts (#13265) 2019-10-21 15:56:03 -07:00
Kaushik Iska
39e6901e63
Add recipe changelog (#13270)
Also add sources to one of the fuchsia targets to make
sure that the files exist.
2019-10-21 15:41:27 -07:00
Jonah Williams
6ab23d37d5
fix NPE in accessibility bridge (#13255) 2019-10-21 15:35:34 -07:00
skia-flutter-autoroll
fd684c8173
Roll src/third_party/skia 9889d509ed9f..56f569d9bec2 (21 commits) (#13266)
https://skia.googlesource.com/skia.git/+log/9889d509ed9f..56f569d9bec2

git log 9889d509ed9f..56f569d9bec2 --date=short --no-merges --format='%ad %ae %s'
2019-10-21 kjlubick@google.com [canvaskit] roll to v0.8.0
2019-10-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-10-21 mtklein@google.com remove SkBitmapProcState::fInvKy
2019-10-21 senorblanco@chromium.org Dawn: fix rendering to mipmapped textures.
2019-10-21 mtklein@google.com remove SkBitmapProcState::fInvType
2019-10-21 kjlubick@google.com [canvaskit] Include CodeReviewSystem on JSON uploaded
2019-10-21 fmalita@chromium.org [skottie] Add DataURI image support in utils/tools
2019-10-21 mtklein@google.com remove unused SkBitmapProcState fields
2019-10-21 fmalita@chromium.org [skottie] Frame-index seek API (seekFrame)
2019-10-21 jvanverth@google.com Metal: adjust framebuffer size by contentsScale.
2019-10-21 herb@google.com Use common fallback code for drawing an SkGlyphRun
2019-10-21 kjlubick@google.com [CanvasKit] More Paragraph things
2019-10-21 senorblanco@chromium.org Dawn: don't pretend to support 565, 4444 or Gray_8 pixel configs.
2019-10-21 michaelludwig@google.com Track device coordinate space as matrix
2019-10-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-10-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-10-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 6dee176c8d7d..4a80ba25e67b (13 commits)
2019-10-21 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps
2019-10-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader a68a80a4dbf9..26c6c4a5eb83 (1 commits)
2019-10-20 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version
2019-10-20 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps

Created with:
  gclient setdep -r src/third_party/skia@56f569d9bec2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=michaelludwig@google.com
2019-10-21 18:28:35 -04:00
skia-flutter-autoroll
8412c8806c
Roll fuchsia/sdk/core/mac-amd64 from hc4p_... to hALu4... (#13252)
Roll fuchsia/sdk/core/mac-amd64 from hc4p_... to hALu4...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-21 18:26:32 -04:00
Mouad Debbar
4307a9b487
[web] Support input action (#13268) 2019-10-21 15:23:36 -07:00
Mouad Debbar
6a3baef78b
[web] Support -j to use goma in felt build (#13259) 2019-10-21 15:23:19 -07:00
skia-flutter-autoroll
6b721ca074
Roll fuchsia/sdk/core/linux-amd64 from 30Ua7... to _e7Up... (#13254)
Roll fuchsia/sdk/core/linux-amd64 from 30Ua7... to _e7Up...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-21 18:21:37 -04:00
Jason Simmons
4ecfa62735
Hold a reference to the Skia unref queue in UIDartState (#13239)
Obtaining the SkiaUnrefQueue through the IOManager is unsafe because
UIDartState has a weak pointer to the IOManager that can not be dereferenced
on the UI thread.
2019-10-21 14:15:03 -07:00
Jason Simmons
4f85010d21
Do not attempt to drain the SkiaUnrefQueue in the destructor (#13237)
SkiaUnrefQueue should be empty at destruction time.  If the queue is nonempty,
then there will be a pending drain task that will hold a reference to the
queue.  The queue can only be destructed after the drain completes and the
reference is dropped.

Drains must only be done on the queue's task runner thread, which may not be
the thread where the queue is destructed.
2019-10-21 14:14:18 -07:00
Ben Konyi
a16b0f9838
Updated license script to ignore testdata directories, which often contain object files and other compilation results (#13261) 2019-10-21 13:04:17 -07:00
Kaushik Iska
84a3365dcf
Add templates to generate fuchsia host bundles (#13158)
This is part of an effort to separate generation of
host artifacts and target artifacts for fuchsia. The
`fuchsia_host_bundle` template aims to capture all the
artifacts that are specific to a given host.

The next step would be to bundle these are separate CIPD
packages for mac and linux (only x64 hosts)

internal planning doc: go/flutter-fuchsia-packaging
2019-10-21 12:51:38 -07:00
Gary Qian
8318d5f386
Update ui.instantiateImageCodec docs to reflect what it does. (#13233) 2019-10-21 12:29:19 -07:00
Harry Terkelsen
5cc7416990
Update CanvasKit to 0.7.0 and flesh out painting (#13240)
* Update CanvasKit to 0.7.0 and flesh out painting

This allows us to fix some bugs in the CanvasKit backend.

- Implement RRect where the radii are different
- Implement drawDRRect
- Implement ColorFilter
- Implement the correct `arcTo` for `arcToPoint`

* update licenses

* Respond to review comments

- Add TODO to avoid unnecessary conversions
- Don't set CanvasKit to default
- Fix licenses file

* Add ==, hashCode, and toString back to ColorFilter API
2019-10-21 11:28:55 -07:00
skia-flutter-autoroll
5e654458cf
Roll fuchsia/sdk/core/linux-amd64 from CYDvx... to 30Ua7... (#13251)
Roll fuchsia/sdk/core/linux-amd64 from CYDvx... to 30Ua7...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-19 19:15:59 -04:00
skia-flutter-autoroll
c237a884b1
Roll fuchsia/sdk/core/mac-amd64 from 0JpMS... to hc4p_... (#13250)
Roll fuchsia/sdk/core/mac-amd64 from 0JpMS... to hc4p_...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-19 10:04:43 -04:00
skia-flutter-autoroll
0c3e055e7e
Roll fuchsia/sdk/core/linux-amd64 from bdTv5... to CYDvx... (#13249)
Roll fuchsia/sdk/core/linux-amd64 from bdTv5... to CYDvx...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-19 02:24:20 -04:00
skia-flutter-autoroll
4c70414303
Roll src/third_party/skia c65eb34d2f37..9889d509ed9f (1 commits) (#13248)
https://skia.googlesource.com/skia.git/+log/c65eb34d2f37..9889d509ed9f

git log c65eb34d2f37..9889d509ed9f --date=short --no-merges --format='%ad %ae %s'
2019-10-19 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps

Created with:
  gclient setdep -r src/third_party/skia@9889d509ed9f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC csmartdalton@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=csmartdalton@google.com
2019-10-19 02:19:21 -04:00
skia-flutter-autoroll
91e8df397d
Roll fuchsia/sdk/core/mac-amd64 from SevlL... to 0JpMS... (#13244)
Roll fuchsia/sdk/core/mac-amd64 from SevlL... to 0JpMS...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-18 21:26:53 -04:00
skia-flutter-autoroll
02d9a057d4
Roll src/third_party/skia 7605c89c00f7..c65eb34d2f37 (3 commits) (#13243)
https://skia.googlesource.com/skia.git/+log/7605c89c00f7..c65eb34d2f37

git log 7605c89c00f7..c65eb34d2f37 --date=short --no-merges --format='%ad %ae %s'
2019-10-18 herb@google.com Update for XCode 11 include system
2019-10-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-10-18 halcanary@google.com Docs: include/docs with doxygen

Created with:
  gclient setdep -r src/third_party/skia@c65eb34d2f37

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC csmartdalton@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=csmartdalton@google.com
2019-10-18 21:21:13 -04:00
Ben Konyi
0f75f194a7 Ignore *.obj files when gathering licenses (#13241)
* Ignore *.obj files when gathering licenses

* update license hash
2019-10-18 17:53:40 -07:00
Gary Qian
cf96ec3c9f
Roll buildroot to 994c6 (#13236) 2019-10-18 16:20:08 -07:00
Jason Simmons
8882bf3c73
Avoid dereferencing IO manager weak pointers on the UI thread (#13232)
UI thread APIs that need to access the IO thread's resource context should
obtain a weak pointer to the IO manager and pass that to the IO thread.
2019-10-18 16:01:55 -07:00
skia-flutter-autoroll
8aefcd8575
Roll src/third_party/skia f4b3d6b9f3d1..7605c89c00f7 (10 commits) (#13234)
https://skia.googlesource.com/skia.git/+log/f4b3d6b9f3d1..7605c89c00f7

git log f4b3d6b9f3d1..7605c89c00f7 --date=short --no-merges --format='%ad %ae %s'
2019-10-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial).
2019-10-18 halcanary@google.com Docs: Add links to header files.
2019-10-18 michaelludwig@google.com Rename SkDevice::ctm() to localToDevice()
2019-10-18 kjlubick@google.com [canvaskit] Roll chrome version for testing
2019-10-18 fmalita@chromium.org [skottie] Default camera for 3D layers
2019-10-18 jcgregorio@google.com [docs] - Add link to buildbot search.
2019-10-18 fmalita@chromium.org [skottie] Camera does not apply to regular/2D layers
2019-10-18 bungeman@google.com Add SkColorData.h to gn.
2019-10-18 jvanverth@google.com Use LazyProxy to set up Metal swapchain.
2019-10-18 senorblanco@chromium.org Dawn: allow CopySrc usage of swapchain texture.

Created with:
  gclient setdep -r src/third_party/skia@7605c89c00f7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC csmartdalton@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=csmartdalton@google.com
2019-10-18 17:26:14 -04:00
Matt Carroll
ee91881ccc
Adds Dark Mode support to new Android embedding (this was accidentally missed previously). (#13215) 2019-10-18 12:46:09 -07:00
Mouad Debbar
98e6d15663
Preserve stdout colors of subprocesses run by felt (#13209) 2019-10-18 10:41:44 -07:00
Ferhat
6d0f075709
[web] Fix canvas reuse metrics. Refactor drawVertices code. (#13190)
* Draw vertices to shared offscreen canvas on browsers that support OffscreenCanvas.
* Move gl rendering code to render_vertices.dart.
* Reuse shaders and program across calls.
2019-10-18 10:41:16 -07:00
Jacek Fedoryński
748b64049c Add repeatCount to FlutterKeyEvent (#13176)
Adds repeatCount field to KeyEventChannel.FlutterKeyEvent. We set it
to the value returned by KeyEvent.getRepeatCount() and add it to the
message passed through the channel with the intention of exposing it
in RawKeyEventDataAndroid on the framework side.

flutter/flutter#42855
2019-10-18 10:39:19 -07:00
Nurhan Turgut
dea7150f33
Adding firefox_installer.dart (#13185)
* adding firefox downloading functionality to felt

* Getting the location directly from the response
2019-10-18 10:35:21 -07:00
skia-flutter-autoroll
b7101d387d
Roll fuchsia/sdk/core/linux-amd64 from _G94w... to bdTv5... (#13228)
Roll fuchsia/sdk/core/linux-amd64 from _G94w... to bdTv5...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-18 13:35:03 -04:00
skia-flutter-autoroll
b1870dd852
Roll src/third_party/skia b80d31f8cbe2..f4b3d6b9f3d1 (1 commits) (#13229)
https://skia.googlesource.com/skia.git/+log/b80d31f8cbe2..f4b3d6b9f3d1

git log b80d31f8cbe2..f4b3d6b9f3d1 --date=short --no-merges --format='%ad %ae %s'
2019-10-18 senorblanco@chromium.org Dawn: fix single-sided stencil.

Created with:
  gclient setdep -r src/third_party/skia@f4b3d6b9f3d1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC csmartdalton@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=csmartdalton@google.com
2019-10-18 13:32:47 -04:00
skia-flutter-autoroll
67de0bf44b
Roll fuchsia/sdk/core/mac-amd64 from KNygX... to SevlL... (#13227)
Roll fuchsia/sdk/core/mac-amd64 from KNygX... to SevlL...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-18 08:51:48 -04:00