DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Do not request executable permission on Fuchsia file mappings unless it is required (#13290)

Browse Source 
Fixes https://github.com/flutter/flutter/issues/43273
This commit is contained in:
Jason Simmons 2019-10-22 11:24:51 -07:00 committed by GitHub
parent a554235978
commit f0c9edcfa5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
shell/platform/fuchsia/flutter/component.cc
View File

@ -99,9 +99,11 @@ static std::unique_ptr<fml::FileMapping> MakeFileMapping(const char* path,
using Protection = fml::FileMapping::Protection;
std::initializer_list<Protection> protection_execute = {Protection::kRead,
Protection::kExecute};
std::initializer_list<Protection> protection_read = {Protection::kRead};
auto mapping = std::make_unique<fml::FileMapping>(
fml::UniqueFD{fd}, std::initializer_list<Protection>{
Protection::kRead, Protection::kExecute});
fml::UniqueFD{fd}, executable ? protection_execute : protection_read);
if (!mapping->IsValid()) {
return nullptr;