DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
33,963 Commits 882 Branches 1,069 Tags
Commit Graph

33963 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Matan Lurey
4ed520b2af Skip flaking test on Windows nobody is fixing. (flutter/engine#50401) 
Filed https://github.com/flutter/flutter/issues/142991 to re-enable.
 2024-02-06 10:23:06 -08:00
auto-submit[bot]
911b1400ea Reverts "[web] Fix Scene clip bounds. Trigger resize on DPR Change." (flutter/engine#50404) 
Reverts flutter/engine#50161

Initiated by: jonahwilliams

Reason for reverting: This is causing what looks like bogus goldens on the framework -> engine roll: https://github.com/flutter/flutter/pull/142966

Original PR Author: ditman

Reviewed By: {yjbanov, mdebbar}

This change reverts the following previous change:
Original Description:
The Scene of the HTML renderer is passing incorrect size information to the engine, and when DPR<1, it can result in elements being culled off of the viewport.

In addition to that, when an app is embedded, not all changes in DPR cause a Resize event (only those some of the dimensions fails by a rounding error!), so this PR ensures that all DPR events in embedded trigger a resize event.

### Issues

Fixes https://github.com/flutter/flutter/issues/129182

### Testing

Looking good at: https://dit-astral-test.web.app

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-06 17:35:47 +00:00
zijiehe@
76dce91cf2 Revert "Revert "[Fuchsia] Execute most of the testing/fuchsia/test_suites.yaml on debug and release builds"" (flutter/engine#50295) 
Reverts flutter/engine#50291,
https://github.com/flutter/flutter/issues/142811

Following is the original change description.

This change implements a BundledTestRunner to run most of the tests in
testing/fuchsia/test_suites.yaml as ExecutableTestRunner.

- Tests with packages out of out/fuchsia_*_x64/ are ignored for now.
- Tests with extra test command line parameters are ignored for now.

The BundledTestRunner can share most of the logic in
ExecutableTestRunner and avoid reinventing the wheel.

This change also fixes the build break of fuchsia_tests in
fuchsia_release_x64 which allows tests to run on the build as well.

- Tests not built with AOT are filtered out with variant field in
test_suites.yaml.

Bug: https://github.com/flutter/flutter/issues/140179

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-02-06 09:34:53 -08:00
Chinmay Garde
9d32cac3ed [Impeller] Specify if Angle or SwiftShader is being used in the title. (flutter/engine#50376) 
Minor QOL improvement. Tried taking a frame capture unsuccessfully before realizing that I was using SwiftShader.
 2024-02-06 17:33:45 +00:00
Matan Lurey
5d1cc934ad Run all Android scenario_app tests, not just the smoke test. (flutter/engine#50400) 
I was making sure that I could get at least one test running and passing
on CI (as expected), now turn all of them on.
 2024-02-06 09:15:08 -08:00
skia-flutter-autoroll
473f0508b3 Roll Dart SDK from b62066b42af0 to 29265c94a6e8 (10 revisions) (flutter/engine#50398) 
https://dart.googlesource.com/sdk.git/+log/b62066b42af0..29265c94a6e8

2024-02-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-114.0.dev
2024-02-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-113.0.dev
2024-02-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-112.0.dev
2024-02-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-111.0.dev
2024-02-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-110.0.dev
2024-02-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-109.0.dev
2024-02-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-108.0.dev
2024-02-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-107.0.dev
2024-02-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-106.0.dev
2024-02-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-105.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-06 16:48:31 +00:00
Matan Lurey
8db41b6544 Capture FAILURES!!! when running Android scenario_app tests. (flutter/engine#50255) 
I expect `Linux linux_android_emulator_tests` and `Linux
linux_android_emulator_tests_api_33` to fail.

When they fail, I'll fix the assertion
(https://github.com/flutter/flutter/issues/142746) before merging this
PR.
 2024-02-06 08:42:14 -08:00
Jonny Wang
eb4b07ee1d [fuchsia] Bump Fuchsia's API level to 16 (flutter/engine#50358) 
Update Fuchsia's API level to 16.

b/322503140


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
 2024-02-06 15:34:37 +00:00
skia-flutter-autoroll
1f1f04cac9 Roll Skia from 9e68ed6caf6d to 44106ee8edea (1 revision) (flutter/engine#50393) 
https://skia.googlesource.com/skia.git/+log/9e68ed6caf6d..44106ee8edea

2024-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 83223ec30684 to 32051b1fe7ae (9 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-06 11:09:21 +00:00
skia-flutter-autoroll
fdf212b2fe Roll Skia from c29a20702356 to 9e68ed6caf6d (1 revision) (flutter/engine#50392) 
https://skia.googlesource.com/skia.git/+log/c29a20702356..9e68ed6caf6d

2024-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 5a0615588a1a to e62bd70a6c74 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-06 09:45:17 +00:00
Jonah Williams
a70478263d [Impeller] Cache RenderPass/Framebuffer objects on the resolve texture sources. (flutter/engine#50142) 
Cache vk::RenderPass and vk::Framebuffer objects on the resolve texture of any render target attachments. Use these on the next frame unconditionally.

Fixes https://github.com/flutter/flutter/issues/141750
 2024-02-06 04:35:05 +00:00
Jason Simmons
39a6ac669f [Impeller] Do not skip the GLES render pass if the command list is empty (flutter/engine#50381) 
The render pass may need to apply other changes such as painting the clear color.

See https://github.com/flutter/flutter/issues/142639
 2024-02-06 02:43:27 +00:00
skia-flutter-autoroll
dfd78684bd Roll Skia from cdf214adfb4d to c29a20702356 (54 revisions) (flutter/engine#50382) 
Roll Skia from cdf214adfb4d to c29a20702356 (54 revisions)

https://skia.googlesource.com/skia.git/+log/cdf214adfb4d..c29a20702356

2024-02-06 brianosman@google.com Bring back DISABLE_LOWP
2024-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from f8c06f103a1f to 5a0615588a1a (10 revisions)
2024-02-05 lokokung@google.com Migrates graphite's main wait mechanism from using Tick to ProcessEvents.
2024-02-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 3a55a3d5ee47 to 83223ec30684 (1 revision)
2024-02-05 fmalita@chromium.org [skottie] Fix supernormal spatial interpolation
2024-02-05 robertphillips@google.com [graphite] Add new Graphite Precompilation DMSink
2024-02-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from dd852a700405 to c9c20468546f (26 revisions)
2024-02-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 9a1a69ed50c4 to 5c8f3c7d6467
2024-02-05 kjlubick@google.com Fix skottie rules for G3
2024-02-05 kjlubick@google.com Temporarily disable animated_gif.cpp from Bazel test
2024-02-05 kjlubick@google.com Add bazel modules for Skottie and sksg
2024-02-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from a1def468c6b4 to 3a55a3d5ee47 (9 revisions)
2024-02-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 8af152c5f7ce to 9a1a69ed50c4
2024-02-02 kjlubick@google.com Fix copypasta in public.bzl
2024-02-02 kjlubick@google.com Guard some gms/tests that require Skottie code
2024-02-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from 969399a89649 to b575daa903da
2024-02-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from 9054c5988daf to 89826f3f6f5d
2024-02-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 9ce4d2efff0c to 906e4c4c9b17
2024-02-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from 54bf3755c837 to d2ed43ed5bb9
2024-02-02 bungeman@google.com [unicode] Fix SkBreakIterator_libgrapheme
2024-02-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 07589c29ccba to a1def468c6b4 (1 revision)
2024-02-02 kjlubick@google.com Make SVG backend explicitly depend on JPEG+PNG for OpenType
2024-02-02 kjlubick@google.com Add Bazel target for modular build of SkResources
2024-02-02 kjlubick@google.com Remove SkAnimCodecPlayer from the public API
2024-02-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 5b5661dc98c7 to 9ce4d2efff0c
2024-02-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from e7695f0fdff5 to 9054c5988daf
2024-02-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from f6c22747cda4 to 969399a89649
2024-02-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from 067d72e0dddf to 54bf3755c837
2024-02-02 johnstiles@google.com Fix fuzzer-discovered timeout by caching uniform information.
2024-02-02 bungeman@google.com [pdf] Properly handle drawing not on a page
2024-02-02 johnstiles@google.com Add method Type::isAllowedInUniform.
2024-02-02 brianosman@google.com Remove SK_DISABLE_LOWP_RASTER_PIPELINE
2024-02-02 drott@chromium.org [Fontations-backend] Minor: Remove return statement
2024-02-02 49699333+dependabot[bot]@users.noreply.github.com Bump follow-redirects from 1.14.8 to 1.15.5
2024-02-02 49699333+dependabot[bot]@users.noreply.github.com Bump socket.io-parser from 4.2.2 to 4.2.4 in /modules/canvaskit
2024-02-02 49699333+dependabot[bot]@users.noreply.github.com Bump jinja2 from 2.11.3 to 3.1.3
2024-02-02 kjlubick@google.com Update Bazel rules after vulkan_header update
2024-02-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 1abfdc37320f to f8c06f103a1f (3 revisions)
2024-02-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 82b9fb3ddb57 to 07589c29ccba (6 revisions)
2024-02-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from e83737e1d145 to b8aac8b590af
2024-02-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 6e97526ab534 to e83737e1d145 (14 revisions)
2024-02-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 78d1799ee43e to eb75201a4e03 (2 revisions)
2024-02-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 2c3a08ff64ba to dd852a700405 (8 revisions)
2024-02-02 bungeman@google.com Revert "[pdf] Properly handle drawing not on a page"
2024-02-02 johnstiles@google.com Add BUILD.gn cleanups to zlib.
2024-02-01 kjlubick@google.com Make SkScalarContext for Windows DirectWrite explicitly decode PNGs
...
 2024-02-06 02:09:20 +00:00
David Iglesias
76129ffb8f [web] Fix Scene clip bounds. Trigger resize on DPR Change. (flutter/engine#50161) 
The Scene of the HTML renderer is passing incorrect size information to the engine, and when DPR<1, it can result in elements being culled off of the viewport.

In addition to that, when an app is embedded, not all changes in DPR cause a Resize event (only those some of the dimensions fails by a rounding error!), so this PR ensures that all DPR events in embedded trigger a resize event.

### Issues

Fixes https://github.com/flutter/flutter/issues/129182

### Testing

Looking good at: https://dit-astral-test.web.app

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-06 01:48:00 +00:00
Xilai Zhang
db877dd92a [github actions] add cherry pick workflow for engine repo (flutter/engine#50265) 
Follow up from sync with @itsjustkevin : Add cherry pick github actions to flutter/engine repository.

Would have the same functionalities as https://github.com/flutter/flutter/blob/master/.github/workflows/easy-cp.yml.

@godofredoc would be great if we could add [actions bot token](https://valentine.corp.google.com/#/show/1702960394753966?tab=metadata) as a secret under the name FLUTTERACTIONSBOT_CP_TOKEN to the engine repository too. Thank you!
 2024-02-06 01:31:54 +00:00
gaaclarke
10c52df4fb [Impeller] blur: hold on to 1/8 downsample until the kernel overflows (flutter/engine#50363) 
issue: https://github.com/flutter/flutter/issues/142753

After https://github.com/flutter/engine/pull/50262 there were still some
sigmas that could show shimmering around the sigma [50, 100] range which
had a downsample amount of 1/16. This makes those ranges hang on to 1/8
for as long as possible. I'm unable to see any shimmering with
`AiksTest.GaussianBlurAnimatedBackdrop` after this PR. I've also
expanded that test so the clip region could be scaled to make sure that
there aren't sizes which cause it to reappear.

Testing: Expanded on manual testing. Since the error only manifests when
evaluating multiple frames of rendering we don't have infrastructure to
test that.

Here is the graph of `GaussianBlurFilterContents::CalculateScale` after
this change:

<img width="903" alt="Screenshot 2024-02-05 at 2 10 41 PM"
src="https://github.com/flutter/engine/assets/30870216/ac3b735a-95f0-4d7b-af12-58e1ae75278e">

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-02-05 16:32:44 -08:00
skia-flutter-autoroll
78a1d58555 Manual roll Dart SDK from 5a5d4c262200 to b62066b42af0 (5 revisions) (flutter/engine#50366) 
Manual roll requested by zra@google.com

https://dart.googlesource.com/sdk.git/+log/5a5d4c262200..b62066b42af0

2024-02-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.4.0-104.0.dev
2024-02-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.4.0-103.0.dev
2024-02-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.4.0-102.0.dev
2024-02-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.4.0-101.0.dev
2024-02-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.4.0-100.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

---------

Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
 2024-02-05 15:02:54 -08:00
Taha Tesser
5f93393312 Fix iOS password autofill prompt dismissal causes layout to resize (flutter/engine#50364) 
fixes [Save password prompt dismiss is pushing UI up and down](https://github.com/flutter/flutter/issues/112281)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      debugShowCheckedModeBanner: false,
      home: HomePage(),
    );
  }
}

class HomePage extends StatefulWidget {
  const HomePage({super.key});

  @override
  State<HomePage> createState() => _HomePageState();
}

class _HomePageState extends State<HomePage> {
  final TextEditingController controller1 = TextEditingController();
  final TextEditingController controller2 = TextEditingController();

  @override
  void dispose() {
    controller1.dispose();
    controller2.dispose();
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold( // Replace Scaffold with Material to fix glitch.
      body: Center(
        child: Column(
          mainAxisSize: MainAxisSize.min,
          children: <Widget>[
            const Text('Login (Without Scaffold)'),
            AutofillGroup(
              child: Column(
                children: <Widget>[
                  TextField(
                    controller: controller1,
                    autofillHints: const <String>[AutofillHints.username],
                  ),
                  TextField(
                    controller: controller2,
                    autofillHints: const <String>[AutofillHints.password],
                  ),
                ],
              ),
            ),
          ],
        ),
      ),
    );
  }
}
```

</details>

### Before

https://github.com/flutter/engine/assets/48603081/dfe36616-e1dd-4c6c-95b0-e4bd89bd3a6a

### After

https://github.com/flutter/engine/assets/48603081/cfb15252-10cd-4521-a1ef-2cace0004588

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-05 21:53:03 +00:00
LongCatIsLooong
0c52de1fda visiblePassword uses ASCII keyboard on iOS (flutter/engine#50293) 
Fixes https://github.com/flutter/flutter/issues/129113

The documentation states that the `visiblePassword` input type
> Requests a keyboard with ready access to both letters and numbers.

`UIKeyboardTypeASCIICapable` seems to be the closest match.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-05 21:34:09 +00:00
Dan Field
b763483b43 [Impeller] Do not reference this in the submit callback for Metal GPU Surfaces (flutter/engine#50361) 
Fixes https://github.com/flutter/flutter/issues/141351 (speculatively - I have not directly reproduced this in an application, but without this change the added test crashes with a segfault in the submit callback).

If the rasterizer gets torn down, the surface gets released and the submit callback may fire on a collected object. Capturing `this` isn't safe. I'm not quite sure how that could happen from the linked stack trace though, since the draw call and the teardown call should be happening on the raster thread, and if the surface was reset then the draw call should've failed earlier...

The added test causes a segfault without the change.
 2024-02-05 20:58:17 +00:00
gaaclarke
b3f6a88647 [Impeller] moved blur aiks tests to their own file (flutter/engine#50356) 
issue: https://github.com/flutter/flutter/issues/140106

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-05 19:02:21 +00:00
Chinmay Garde
8ac86e0177 Delete fml::ThreadLocalUniquePtr. (flutter/engine#50310) 
Fixes https://github.com/flutter/flutter/issues/141127
 2024-02-04 03:04:07 +00:00
Jonah Williams
a0f6d53a3f [Impeller] fix flake in compute unittests. (flutter/engine#50308) 
Locally I don't get a validation error about endEncoding.
 2024-02-03 00:27:50 +00:00
Chinmay Garde
dc87eb6768 [Impeller] Fix blown stack due to always out of date window dimensions on high-dpi devices. (flutter/engine#50307) 
This regression was introduced in 0682efb50f which made it so that the updated surface size would be provided to the swapchain impl out-of-band instead of being inferred from the surface properties (to avoid a lag between the reports of the two).

However, the playgrounds used the window size to report the updated size. This is fine where the window scale is 1. But fails on high-dpi devices. The patch replaces the call to get the window size with an equivalent call to get the framebuffer size.

The failure was a blown stack due to a new swapchain impl being created over and over again because the size was always out of date.

Fixes https://github.com/flutter/flutter/issues/142833
 2024-02-03 00:06:36 +00:00
Jason Simmons
3928bcf361 [Impeller] In advanced blends, unpremultiply and apply src_input_alpha only if there is no foreground color (flutter/engine#50260) 
See https://github.com/flutter/flutter/issues/142620
 2024-02-02 23:54:41 +00:00
gaaclarke
0c357591a8 [Impeller] new blur: clamp downsample scalar to 1/16 (flutter/engine#50262) 
fixes https://github.com/flutter/flutter/issues/142753

The theory here is that once you start throwing away more than 15/16th of the signal it's pretty noticable.  By looking at the blur under different circumstances that seems like a reasonable limit.

There is no automated test for this.  Doing so would be quite involved and would involve evaluating multiple rendered frames.  There is a manual test.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-02 23:47:20 +00:00
Chinmay Garde
959713ad30 [Impeller] Wire up Angle use to a command line flag and enable it by default on macOS. (flutter/engine#50304) 
Similar to --use_swiftshader in https://github.com/flutter/engine/pull/50298.
 2024-02-02 23:01:05 +00:00
Jason Simmons
d174418e2f Remove the skia_fontmgr_factory argument from the Web GN configuration (flutter/engine#50183) 
This was removed in Skia (see https://skia.googlesource.com/skia/+/38e85e85079f4140158a8f83c7bbceb7a1ac5ca5)
 2024-02-02 22:30:18 +00:00
Chinmay Garde
0c03fdf90c [Impeller] Allow playgrounds to use SwiftShader via a flag. (flutter/engine#50298) 
Specifying the `--use_swiftshader` flag will find an setup the SwiftShader ICD in the process. Allows switching between two Vulkan implementation (system and SwiftShader) quickly using a flag.

Following up on https://github.com/flutter/flutter/issues/127070
 2024-02-02 22:07:11 +00:00
gaaclarke
8a98a0be33 [Impeller] blur: removed ability to request out of bounds mip_counts (flutter/engine#50290) 
b/323402168

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-02 20:44:54 +00:00
auto-submit[bot]
35ff8e9b9e Reverts "Move linux_fuchsia to staging" (flutter/engine#50294) 
Reverts flutter/engine#50288
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
For https://github.com/flutter/flutter/issues/142811
 2024-02-02 19:41:45 +00:00
Zachary Anderson
c5eac677ca Revert "[Fuchsia] Execute most of the testing/fuchsia/test_suites.yaml on debug and release builds" (flutter/engine#50291) 
Reverts flutter/engine#50058 for
https://github.com/flutter/flutter/issues/142811
 2024-02-02 11:40:10 -08:00
Zachary Anderson
45c60db662 Move linux_fuchsia to staging (flutter/engine#50288) 
For https://github.com/flutter/flutter/issues/142811
 2024-02-02 18:23:05 +00:00
Juanjo Tugores
358d8b6229 Add the focus state related methods to the platform dispatcher (flutter/engine#50273) 
These changes were originally landed on
https://github.com/flutter/engine/pull/49841 but reverted in
64fe7b86c3.
I fixed the offending dart snippets and (think) they now will work
without issues (I think I was able to verify them locally by manually
patching my bin/cache/... copy of these files with these changes).

Relevant Issues are:
* Design doc link:
https://github.com/flutter/website/actions/runs/7560898849/job/20588395967
* Design doc: https://github.com/flutter/flutter/issues/141711
* Focus in web multiview:
https://github.com/flutter/flutter/issues/137443

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-02-02 10:13:00 -08:00
Ricardo Amador
1b4b809bf3 Add a link the different possible Android virtual device configs (flutter/engine#50267) 
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-02 16:13:38 +00:00
Bart Cone
1b95fed6c0 [Android] Fix TextInputType.none for devices with physical keyboard (flutter/engine#49980) 
## Description

This PR fixes an issue where keystrokes aren't received on Android
devices with physical keyboards (e.g. rugged Zebra devices) when
`keyboardType` is set to `TextInputType.none` on a `TextField`.

The logic in `setTextInputClient` and `canShowTextInput` created an
`inputTarget` with `InputTarget.Type.NO_TARGET` which caused the [input
connection to short
circuit](https://github.com/flutter/engine/blob/main/shell/platform/android/io/flutter/plugin/editing/TextInputPlugin.java#L296)
and not be established.

Bug introduction PR: https://github.com/flutter/engine/pull/26585

## Related Issue

https://github.com/flutter/flutter/issues/89983

## Unit Test Notes

- The existing `showTextInput_textInputTypeNone()` stays green after
update.
- `inputConnection_textInputTypeNone()` updated to `assertNotNull`. I
would make this more specific, but this is my first venture into the
Flutter engine and don't know enough about those connection attributes.

## Demo

Video below with Zebra MC9300 device. This issue can also be reproduced
in a standard android emulator. Simply add a `TextField`, configure
`keyboardType` to be `TextInputType.none` and attempt to enter text
after running and giving focus to textfield.

Before


https://github.com/flutter/engine/assets/1988098/348ca061-b8b9-4483-956e-0732c1238207

After


https://github.com/flutter/engine/assets/1988098/b65c7251-59b4-4c73-9b85-7ac03f47a7e4

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
 2024-02-01 23:24:39 -08:00
auto-submit[bot]
64fe7b86c3 Reverts "Add the focus state related methods to the platform dispatcher" (flutter/engine#50268) 
Reverts flutter/engine#49841
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
This change augments the platform dispatcher to allow the engine <===> framework to communicate flutter and platform focus changes.

Relevant Issues are:
* Design doc link: https://github.com/flutter/website/actions/runs/7560898849/job/20588395967
* Design doc: https://github.com/flutter/flutter/issues/141711
* Focus in web multiview: https://github.com/flutter/flutter/issues/137443

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-02 02:59:26 +00:00
skia-flutter-autoroll
0b311bcbdc Manual roll Dart SDK from 82936dcdaf4f to 5a5d4c262200 (2 revisions) (flutter/engine#50264) 
Manual roll requested by kevinjchisholm@google.com

https://dart.googlesource.com/sdk.git/+log/82936dcdaf4f..5a5d4c262200

2024-02-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-99.0.dev
2024-02-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-98.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,kevinjchisholm@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-02 01:56:09 +00:00
Tong Mu
be6209e136 Remove number of arguments from defining Dart FFI (flutter/engine#50153) 
The number of arguments are not used. 

And also, even if we need it in the future, they can be derived at compile time:

```cpp
template <typename T>
struct function_traits;

template <typename Ret, typename... Args>
struct function_traits<Ret(Args...)>
{
    using params = std::tuple<Args...>;
};

template <typename T>
constexpr std::size_t get_parameter_count() {
    return std::tuple_size<typename function_traits<T>::params>::value;
}

template <typename T>
struct member_function_traits;

template <typename C, typename Ret, typename... Args>
struct member_function_traits<Ret(C::*)(Args...)>
{
    using params = std::tuple<Args...>;
};

template <typename T>
constexpr std::size_t get_member_function_parameter_count() {
    return std::tuple_size<typename member_function_traits<T>::params>::value;
}

```

(I got the code above with ChatGPT but I verified that they work)

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-01 23:58:31 +00:00
Ricardo Amador
0946672e54 Refactor the linux_android targets to make use of recent changes to android virtual device params (flutter/engine#50099) 
Changes to use the proto.textpb config file as the version of the emulator device and show the cipd dependency version in the dependencies so devs know it can be updated.

This will not pass until recipe changes have landed.

*List which issues are fixed by this PR. You must list at least one issue.*
Fixes https://github.com/flutter/flutter/issues/142261

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-01 23:52:29 +00:00
Michael Goderbauer
2134c852b4 Re-add tests deleted on accident (flutter/engine#50223) 
This re-adds the tests from https://github.com/flutter/engine/pull/41998/files that were accidentally deleted in https://github.com/flutter/engine/pull/42418/files#diff-2cce780ae0f93b9230cbf44030048dbf9ef4c6e0fdb959a47cae440fac0350faL808, probably because of a bad merge.
 2024-02-01 21:51:51 +00:00
gaaclarke
5d0859ada0 [Impeller] updated todos from opengles golden work (flutter/engine#50218) 
followup from https://github.com/flutter/engine/pull/50146

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-01 21:36:52 +00:00
Jim Graham
50968b0324 Get bounds from RTree in DLBuilder::Build() (flutter/engine#50253) 
This optimization was discovered when reviewing the bounds accumulation code in DisplayListBuilder. There is trivially wasted work in the `Build()` method that can be easily avoided.

When a Builder is preparing an RTree, it accumulates a list of bounds for every rendering op, but doesn't union them up front. If you ask the Builder for the bounds of the accumulated ops, it will have to union all of the rectangles to produce an answer. But, if you ask the Builder to produce an RTree, that process will implicitly combine all of the rectangles as a side effect of creating the tree structure - and that RTree object has a bounds method that can return the result directly.

This change leverages the construction of the RTree to avoid having to union all of the rects twice which can only save time when constructing the majority of DisplayList objects used in a scene.
 2024-02-01 21:31:26 +00:00
Chinmay Garde
a018aebbe9 [Impeller] Remove unused define. (flutter/engine#50250) 
This define isn't used in a C++ TU. Only the build scripts (in `//flutter/shell/platform/android/BUILD.gn`) use the flag to decide whether to package the validation layers.

Remove the define that no one uses.
 2024-02-01 21:30:18 +00:00
Juanjo Tugores
9858aa35c2 Add the focus state related methods to the platform dispatcher (flutter/engine#49841) 
This change augments the platform dispatcher to allow the engine <===>
framework to communicate flutter and platform focus changes.

Relevant Issues are:
* Design doc link:
https://github.com/flutter/website/actions/runs/7560898849/job/20588395967
* Design doc: https://github.com/flutter/flutter/issues/141711
* Focus in web multiview:
https://github.com/flutter/flutter/issues/137443

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-02-01 13:20:30 -08:00
Jason Simmons
a337919d34 Fix the output paths of the Web esbuild GN template (flutter/engine#50188) 2024-02-01 21:17:32 +00:00
Chinmay Garde
336c5ca450 [Impeller] Delete unnecessary special casing for Vulkan in framebuffer fetch. (flutter/engine#50251) 
The code generated is functionally identical (http://tinyurl.com/yov6m8ac).
 2024-02-01 21:12:34 +00:00
Brandon DeRosier
5d6ea1d82f [Impeller] Replace stencil pipeline ops with enum. (flutter/engine#50231) 
Depends on https://github.com/flutter/engine/pull/49828.

No semantic change.

Also adds/documents stencil configurations that are needed for StC. Operations for the current stencil stack are labeled as "legacy".
 2024-02-01 19:13:41 +00:00
gaaclarke
ec74b5fbef [Impeller] new blur: round downsample to power of two (flutter/engine#50245) 
This makes the downsampling step of the new blur round to the nearest power of 2.  This makes the changes in downsampling less frequent and the output of downsampling hypothetically higher quality since downsampling by a power of 2 is easier.

issue: https://github.com/flutter/flutter/issues/141510

## before
https://github.com/flutter/engine/assets/30870216/73e78f02-1346-4dde-ad6e-8aaa7c910bac

## after
https://github.com/flutter/engine/assets/30870216/b4153ada-6a82-4d0a-a4c2-158134c7b74f

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-01 19:12:43 +00:00
John McCutchan
7c04b55f07 Provide a more helpful error message in the case of UnsatisfiedLinkError (flutter/engine#50247) 
Related https://github.com/flutter/flutter/issues/83596
 2024-02-01 11:04:45 -08:00