engine-flutter-autoroll
79a033bb15
Roll Dart SDK from 55cfa1d9f847 to 19c25afca603 (2 revisions) ( #167666 )
...
https://dart.googlesource.com/sdk.git/+log/55cfa1d9f847..19c25afca603
2025-04-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-46.0.dev
2025-04-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-45.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert
to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-23 18:48:13 +00:00
engine-flutter-autoroll
4b4b1dd483
Roll Fuchsia Linux SDK from 8ftPq5MhZkxE_XSi1... to kv7EzI7mADDgRbtmL... ( #167661 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-23 17:37:49 +00:00
Chinmay Garde
5896cefa18
[Impeller] Make incremental builds faster when tinkering on the compiler. ( #167492 )
...
GN set the Ninja `restat` argument to 1 by default. Which means that it
notes the modification timestamp when writing the contents. Its man page
states "Scripts can improve build performance by taking care not to
change the timstamp of the output file(s) if the contents have not
changed.".
Modifying the compiler will now still re-compile shaders. But if the
shaders have not changed, downstream edges will be culled.
This can be observed in the Ninja progress update after this change.
After editing any file in the compiler, Ninja start out with `(2/866)
LINK ./impellerc`. But as it culls edges, it skips tasks and ends with
`(454/455) ACTION //flutter/...`. Around half the edges are culled. More
importantly, the unit-tests edges are culled as well. For workflows
where only the changed tests are run, this saves a ton of test time in
addition to build time.
2025-04-23 17:36:20 +00:00
engine-flutter-autoroll
2ffcab0a18
Roll Dart SDK from 721dce1c9199 to 55cfa1d9f847 (1 revision) ( #167641 )
...
https://dart.googlesource.com/sdk.git/+log/721dce1c9199..55cfa1d9f847
2025-04-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-44.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert
to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-23 10:59:25 +00:00
engine-flutter-autoroll
26ebdca6b4
Roll Dart SDK from ba5acf1e38b1 to 721dce1c9199 (1 revision) ( #167611 )
...
https://dart.googlesource.com/sdk.git/+log/ba5acf1e38b1..721dce1c9199
2025-04-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-43.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert
to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-23 02:15:34 +00:00
engine-flutter-autoroll
0de0514761
Roll Skia from 1fb8f012de1b to be6f3563f1a0 (20 revisions) ( #167609 )
...
https://skia.googlesource.com/skia.git/+log/1fb8f012de1b..be6f3563f1a0
2025-04-22 thomsmit@google.com Reland "[graphite] Update DrawWriter to
minimize binds by using pending base offsets."
2025-04-22 borenet@google.com [infra] Remove old MacMini9.1 Mac13 tasks
2025-04-22 danieldilan@google.com Add necessary include to compile
RustPNG (with correct flag name)
2025-04-22 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
Dawn from 32c8fdb708ef to 9428adfc1d3b (25 revisions)
2025-04-22 jmbetancourt@google.com Update buildtools version
2025-04-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from c70bb7aae968 to 00949bebf147 (1 revision)
2025-04-22 jamesgk@google.com [graphite] Ignore no-op nodes when lifting
shader expressions
2025-04-22 kjlubick@google.com Remove old alias for making pinnable
images
2025-04-22 kjlubick@google.com Make tail pixel scratch pad be aligned
for possibly better performance
2025-04-22 kjlubick@google.com Remove alignment assumptions in highp
gather
2025-04-22 kjlubick@google.com Enable C++20 for Clang-Tidy job
2025-04-22 danieldilan@google.com Add necessary include to compile
RustPNG
2025-04-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from f355e2b37ed4 to 962e147a59f4 (2 revisions)
2025-04-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 1eef77795230 to c70bb7aae968 (6 revisions)
2025-04-21 lukasza@chromium.org [rust png] Remove non-granular `.gni`
file lists.
2025-04-21 kjlubick@google.com Avoid assumption of 32 bit aligned pixel
data in RP's lowp gather()
2025-04-21 michaelludwig@google.com [graphite] Use TextureFormat in
AttachmentDesc
2025-04-21 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
Dawn from fe0be9e4b4f9 to 32c8fdb708ef (1 revision)
2025-04-21 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
vulkan-deps from 61080f55d11e to 1eef77795230 (11 revisions)
2025-04-21 kjlubick@google.com Use c++20 when building Dawn
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
chinmaygarde@google.com ,jmbetancourt@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-23 01:29:26 +00:00
Loïc Sharma
08a59c2802
[iOS] Hide keyboard on hot restart ( #167013 )
...
This hides the keyboard and text input context menu if you hot restart
your iOS app.
Before | After
-- | --
<video
src="https://github.com/user-attachments/assets/7ca5dbfe-a809-478c-9b36-4c168527b176 "
/> | <video
src="https://github.com/user-attachments/assets/d1a48c16-f171-4d22-baa4-5c40488d055b "
/>
Part of https://github.com/flutter/flutter/issues/10713
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-22 23:33:02 +00:00
Hannah Jin
46144a2f4d
[a11y] Semanctis flag refactor step 1: engine part ( #167421 )
...
issue: https://github.com/flutter/flutter/issues/166101
**step 1:** Add struct SemanticsFlags in semantics_node.h and class
SemanticsFlags in dart:ui, it's still a bitmask in embedder and
framework.
TODO:
Other parts will be in other following PRs
* Embedder
add a struct FlutterSemanticsFlags
add FlutterSemanticsFlags* to FlutterSemanticsNode2
* web engine
use the new class
* SemanticsUpdateBuilder.updateNode
pass a list of bools instead of bitmask
* Framework
use the SemanticsFlags class instead of bitmask
* flutter_tester
use the SemanticsFlags class instead of bitmask
*
[apicheck_test.dart](https://github.com/flutter/flutter/pull/167421/files#diff-69aefaacf1041f639974044962123bfae0756ce86032ac1f26256099425d7a5a )
Add this test back
*Replace this paragraph with a description of what this PR is changing
or adding, and why. Consider including before/after screenshots.*
*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*
*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-22 22:25:31 +00:00
engine-flutter-autoroll
f47d55f59b
Roll Dart SDK from e596df519dce to ba5acf1e38b1 (9 revisions) ( #167585 )
...
https://dart.googlesource.com/sdk.git/+log/e596df519dce..ba5acf1e38b1
2025-04-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-42.0.dev
2025-04-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-41.0.dev
2025-04-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-40.0.dev
2025-04-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-39.0.dev
2025-04-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-38.0.dev
2025-04-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-37.0.dev
2025-04-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-36.0.dev
2025-04-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-35.0.dev
2025-04-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-34.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert
to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
---------
Co-authored-by: Alexander Aprelev <aam@google.com>
2025-04-22 22:03:10 +00:00
Jason Simmons
cddd4acaca
Ignore stdout in WindowsTest.LaunchMainHasNoOutput ( #167583 )
...
The stdout stream may receive expected output printed by Dart
(specifically the message announcing the URL where the Dart VM service
is listening)
See https://github.com/flutter/flutter/issues/167418
2025-04-22 21:57:46 +00:00
Reid Baker
cb3fd95ff6
Update mockito to 5.17.0 from 4.7.0, prework for android 36 support ( #167573 )
...
This updates all the dependencies in
engine/src/flutter/shell/platform/android/test_runner/build.gradle and
ignores the play store deprecration so I could get android studio to
give me other lint help.
This work is required to unblock @jesswrd's work to update the engine to
use android 36.
Deleted mockito-inline because it is automatically used after 5.2.0
according to Maven docs:
https://mvnrepository.com/artifact/org.mockito/mockito-inline/5.2.0 "
- **Remove config none annotations that have been deprecrated since
roboletrics 4.0.1**
- **Update all dependencies used in test runner, passes for
spellcheckplugintest**
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-04-22 20:02:12 +00:00
Jason Simmons
731d2d9e77
Reland "Reduce app startup latency by initializing the engine on a separate thread ( #166918 )" ( #167519 )
...
This includes a fix for a race seen in
EmbedderTest.PlatformThreadIsolatesWithCustomPlatformTaskRunner
The implementaion of MergedPlatformUIThread::kMergeAfterLaunch required
changing the interface of the TaskObserverAdd/TaskObserverRemove
callbacks so that TaskObserverAdd returned the TaskQueueId where the
observer was added. That TaskQueueId would later be given to
TaskObserverRemove.
The original implementation of this PR updated the embedder library's
implementation of TaskObserverAdd to return TaskQueueId::kInvalid to
signal that the observer was not added. However, this conflicted with
the embedder's EmbedderTaskRunner, whose implementation of
GetTaskQueueId returns TaskQueueId::kInvalid as a placeholder.
This PR reverts the embedder's TaskObserverAdd/TaskObserverRemove to the
original implementation which adds the observer to the current thread's
message loop and does not call GetTaskQueueId.
See https://github.com/flutter/flutter/issues/167418
2025-04-22 16:36:21 +00:00
Kaylee Lubick
4055380c5e
[skia] Use granular png source file lists ( #167550 )
...
The old file lists were removed in
https://skia-review.googlesource.com/c/skia/+/982376 but we missed
updating Flutter. This should get the Skia->Flutter roll working again
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-22 16:01:49 +00:00
Alexander Aprelev
6473b6abef
Roll dart 3.9.0-33.0.dev ( #167513 )
...
Roll dart sdk to 3.9.0-33.0.dev
Changes since last roll
```
e596df519dc (HEAD) Version 3.9.0-33.0.dev
4d298786022 Elements. Remove V1 MultiplyDefinedElement.
1b22cd0b15b Elements. Stop implementing V1 TypeDefiningElement in DynamicElementImpl and NeverElementImpl.
84be07364b1 Roll Fuchsia SDK from 27.20250417.3.1 to 27.20250418.3.1
5b123390cdc Elements. Remove V1 AugmentedXyz classes.
4f7eca8cc9b Elements. Remove V1 DartType.element
9fbed46b139 [DAS] Removes operators suggestions from `.` access and more considerations from extension suggestions
801b545cdbd Elements. Remove V1 lookupXyz methods.
04ec005e1e3 Elements. Remove V1 ConstructorElement.
969eeaadfb8 Roll BoringSSL from ef839bf397fb to 45a865d6682a (15 revisions)
```
Update license script to accommodate boringssl license change
2025-04-22 15:57:29 +00:00
engine-flutter-autoroll
92ff6df1cb
Roll Fuchsia Linux SDK from nggV-vSVM14nIXPsZ... to 8ftPq5MhZkxE_XSi1... ( #167556 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-22 15:32:21 +00:00
chunhtai
b9abb562f9
[Android] removes edge insets from a11y bound calculation ( #167136 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
fixes android part of https://github.com/flutter/flutter/issues/102725
After throughly tested various configurations from
arm64 API level 25 to API level 35
no cutout/Tall cutout/waterfall cutout
LAYOUT_IN_DISPLAY_CUTOUT_MODE_ALWAYS,
LAYOUT_IN_DISPLAY_CUTOUT_MODE_DEFAULT,
LAYOUT_IN_DISPLAY_CUTOUT_MODE_NEVER
Talkback 7 to talkback 15
none of the combinations would require additional left insets
calculation.
I am not sure why we need it in the first place, but it seems the best
course of action will be removing the code.
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-21 21:07:08 +00:00
ash2moon
8acfa88b77
Refine developer message for announcement use ( #167127 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
Updates the developer message to include the flutter topline tracking
bug to reduce confusion when using Flutter widgets that use announce.
Example output from logcat:
```
Using AnnounceSemanticsEvent for accessibility is deprecated on Android. Migrate to using semantic properties for a more robust and accessible user experience.
Flutter: If you are unsure why you are seeing this bug, it might be because you are using a widget that calls this method. See https://github.com/flutter/flutter/issues/165510 for more details.
Android documentation: https://developer.android.com/reference/android/view/View#announceForAccessibility(java.lang.CharSequence)
```
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-21 20:16:06 +00:00
gaaclarke
46b6668f42
Turned on preserve bindings to impellerc ( #167203 )
...
fixes https://github.com/flutter/flutter/issues/116900
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-21 20:16:06 +00:00
gbbosak
b574d40442
Add explicit dependency on the syslog shard ( #167210 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
Update routing in Flutter to prepare for the removal of the LogSink
shard from RealmBuilder.
https://fxbug.dev/404543928
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-21 19:37:23 +00:00
engine-flutter-autoroll
c169a17d85
Roll Skia from 93544b0c18ee to c91ea1a8fd3f (3 revisions) ( #167480 )
...
https://skia.googlesource.com/skia.git/+log/93544b0c18ee..c91ea1a8fd3f
2025-04-21 jvanverth@google.com [graphite] Re-enable ProxyCache for
ClipAtlasManager.
2025-04-21 kjlubick@google.com Export mac utils Bazel target
2025-04-21 robertphillips@google.com New Chrome Pipeline labels
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC codefu@google.com ,jmbetancourt@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-21 16:24:09 +00:00
engine-flutter-autoroll
e839c67f5d
Roll Fuchsia Linux SDK from RGmU4KeQhrxqE7hsr... to nggV-vSVM14nIXPsZ... ( #167473 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC codefu@google.com ,zra@google.com on the revert to ensure that
a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-21 13:30:26 +00:00
engine-flutter-autoroll
cfb887cd5f
Roll Fuchsia Linux SDK from 0U_vEALFF7qRJZ_cE... to RGmU4KeQhrxqE7hsr... ( #167447 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC codefu@google.com ,zra@google.com on the revert to ensure that
a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-20 08:08:17 +00:00
engine-flutter-autoroll
93e5d81201
Roll Fuchsia Linux SDK from MwYckh5OvwwmIYLx0... to 0U_vEALFF7qRJZ_cE... ( #167430 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC codefu@google.com ,zra@google.com on the revert to ensure that
a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-19 05:01:27 +00:00
Jason Simmons
c5864174d0
Revert "Reduce app startup latency by initializing the engine on a separate thread ( #166918 )" ( #167427 )
...
This reverts commit c53fdbdf24daba4bc81ccc6d274ce13d7d34d05e.
See https://github.com/flutter/flutter/issues/167418
2025-04-19 01:03:26 +00:00
auto-submit[bot]
8785fb357d
Reverts "Mark windows_host_engine_test flaky ( #167419 )" ( #167425 )
...
<!-- start_original_pr_link -->
Reverts: flutter/flutter#167419
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: loic-sharma
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Test should no longer be flaky now that
https://github.com/flutter/flutter/pull/167420 has landed.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: matanlurey
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {jtmcdole}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
See https://github.com/flutter/flutter/issues/167418 .
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
2025-04-18 23:09:48 +00:00
Loïc Sharma
66ecc88655
Revert "[Windows] Enable merged platform and UI thread by default" ( #167420 )
...
This reverts commit afdc861129d88fa298ab9952c2d8c4dfb2d74ac1.
See: https://github.com/flutter/flutter/issues/167418
2025-04-18 22:13:32 +00:00
Matan Lurey
7f136e2681
Mark windows_host_engine_test flaky ( #167419 )
...
See https://github.com/flutter/flutter/issues/167418 .
2025-04-18 21:02:42 +00:00
engine-flutter-autoroll
18f7f347c9
Roll Dart SDK from ab60afc99bcb to 0cfefe2a03fb (1 revision) ( #167414 )
...
https://dart.googlesource.com/sdk.git/+log/ab60afc99bcb..0cfefe2a03fb
2025-04-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-32.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-18 20:54:44 +00:00
Yegor
7ca63fadd7
[web] close input connection when window/iframe loses focus ( #166804 )
...
Fixes https://github.com/flutter/flutter/issues/155265
This includes 2 fixes:
* When the window/iframe loses focus, close the text input connection
instead of grabbing the focus again.
* Do not enable semantics using the placeholder when moving focus using
the "Tab" key.
Bonus: remove the no longer necessary `ViewFocusBinding.isEnabled`
(doesn't fix any issues, just a clean-up).
---------
Co-authored-by: Mouad Debbar <mdebbar@google.com>
2025-04-18 17:43:36 +00:00
engine-flutter-autoroll
810024f3c9
Roll Dart SDK from b1eb743f97f5 to ab60afc99bcb (1 revision) ( #167396 )
...
https://dart.googlesource.com/sdk.git/+log/b1eb743f97f5..ab60afc99bcb
2025-04-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-31.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-18 09:41:26 +00:00
engine-flutter-autoroll
b29d7bc42a
Roll Skia from a409d685a711 to acc910544da7 (10 revisions) ( #167388 )
...
https://skia.googlesource.com/skia.git/+log/a409d685a711..acc910544da7
2025-04-18 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
Dawn from 33862a3ffc8a to 971cc7345000 (191 revisions)
2025-04-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from f6ce0375d108 to da64cc98aa1f (7 revisions)
2025-04-17 robertphillips@google.com Fix ChromePrecompileTest for Intel
Macs
2025-04-17 borenet@google.com [infra] Add P30 jobs
2025-04-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
skottie-base from 868103199143 to f4a4eee934a3
2025-04-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
shaders-base from 64b9cec3c82d to 11837b5a53d7
2025-04-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
jsfiddle-base from 05716f858285 to 05b60ca904d9
2025-04-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
debugger-app-base from 9e80d6bc5f11 to f59c59370426
2025-04-17 nicolettep@google.com [graphite] Run precompile tests when
making changes to relevant files
2025-04-17 jvanverth@google.com [graphite] Use sk_sp<TextureProxy> for
PathAtlas instead of raw pointer.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,codefu@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-18 05:02:08 +00:00
engine-flutter-autoroll
40f25c9b19
Roll Dart SDK from 2bb85834e77e to b1eb743f97f5 (2 revisions) ( #167387 )
...
https://dart.googlesource.com/sdk.git/+log/2bb85834e77e..b1eb743f97f5
2025-04-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-30.0.dev
2025-04-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-29.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-18 04:32:31 +00:00
engine-flutter-autoroll
1db4930a43
Roll Fuchsia Linux SDK from m8Aln7fTF_8zy1V9N... to MwYckh5OvwwmIYLx0... ( #167385 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC codefu@google.com ,zra@google.com on the revert to ensure that
a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-18 02:06:36 +00:00
engine-flutter-autoroll
99c3d03758
Roll Skia from cc2b57434651 to a409d685a711 (3 revisions) ( #167347 )
...
https://skia.googlesource.com/skia.git/+log/cc2b57434651..a409d685a711
2025-04-17 michaelludwig@google.com Revert "[graphite] Update DrawWriter
to minimize binds by using pending base offsets."
2025-04-17 jvanverth@google.com [graphite] Use sk_sp<TextureProxy> for
ClipAtlas instead of raw pointer.
2025-04-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 3bc11f8f2d55 to f6ce0375d108 (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,codefu@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-17 21:43:48 +00:00
Jason Simmons
c53fdbdf24
Reduce app startup latency by initializing the engine on a separate thread ( #166918 )
...
If settings.merged_platform_ui_thread is set to kMergeAfterLaunch, then
the engine will be started on the UI thread. After engine setup
completes and the Dart isolate is loaded, the UI task runner will be
merged into the platform thread and all future Dart execution will run
on the platform thread.
This makes it possible for other work to run on the platform thread
while the engine starts.
See https://github.com/flutter/flutter/issues/163064
2025-04-17 21:40:08 +00:00
engine-flutter-autoroll
9f4fe843a7
Roll Dart SDK from 992221a362ec to 2bb85834e77e (7 revisions) ( #167361 )
...
https://dart.googlesource.com/sdk.git/+log/992221a362ec..2bb85834e77e
2025-04-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-28.0.dev
2025-04-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-27.0.dev
2025-04-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-26.0.dev
2025-04-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-25.0.dev
2025-04-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-24.0.dev
2025-04-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-23.0.dev
2025-04-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-22.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-17 21:38:52 +00:00
gaaclarke
ffa1891ab8
Added docstring for FilterInput::GetSnapshot ( #167226 )
...
fixes https://github.com/flutter/flutter/issues/137970
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-17 21:38:52 +00:00
gaaclarke
df5dfdba61
adds Entity docstrings ( #167228 )
...
fixes https://github.com/flutter/flutter/issues/144943
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-17 21:38:52 +00:00
gaaclarke
a23e4ca194
fixed impeller golden content scale ( #167308 )
...
fixes https://github.com/flutter/flutter/issues/162036
This fixes the problem my scaling the render texture by the content
scalar. This means locally you'll probably be generating 2048x1536
images. This matches the rendering that is happening in playgrounds. On
CI the content scalar should be one so there is no change there.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-17 21:37:00 +00:00
gaaclarke
0e4bebffa1
Added docstring for FilterContents::RenderFilter ( #167227 )
...
fixes https://github.com/flutter/flutter/issues/137704
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-17 21:35:41 +00:00
Matej Knopp
9d3d0dc0ed
[macOS] Enable merged platform and UI thread by default ( #166536 )
...
This enables running UI isolate on platform thread by default.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-17 15:30:40 +00:00
Matej Knopp
afdc861129
[Windows] Enable merged platform and UI thread by default ( #163726 )
...
This enables running UI isolate on platform thread by default.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
2025-04-17 15:30:29 +00:00
Victoria Ashworth
ecabb1a052
Hide error on mDNS registration failure and print warning in flutter attach ( #166782 )
...
Publishing an mDNS service stopped working on macOS 15.4 for the iOS
Simulator. `DNSServiceRegister` always returns a callback with error
code `kDNSServiceErr_PolicyDenied`, as if the user had rejected the
permissions popup (except no popup is ever shown). mDNS is used to
discover the Dart VM when running `flutter attach`.
This PR does not display the error message when `DNSServiceRegister`
fails for iOS Simulators. Instead, it prints a warning if `flutter
attach` takes too long with instructions to either use `--debug-url` or
to run `flutter attach` before running the app.
If `DNSServiceRegister` works again in a future macOS update, mDNS will
continue to work the way it did previously.
Workaround for https://github.com/flutter/flutter/issues/166333 .
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-17 14:20:23 +00:00
Bruno Leroux
fbed8a7194
Add support for language hints in TextFields (Android only) ( #165554 )
...
## Description
This PR adds support for language hints in TextFields.
This is supported only on Android for the moment and the property name,
aka `TextField.hintLocales`, is based on Android's
`EditorInfo.hintLocales` property, see
https://developer.android.com/reference/android/view/inputmethod/EditorInfo#hintLocales .
## Related Issue
Fixes [Support for language hints in
TextFields](https://github.com/flutter/flutter/issues/163698 )
## Tests
Adds 4 tests.
Updates several tests.
2025-04-17 10:58:38 +00:00
engine-flutter-autoroll
af2e73343a
Roll Skia from 3d6165b70199 to d8f13372549d (14 revisions) ( #167325 )
...
https://skia.googlesource.com/skia.git/+log/3d6165b70199..d8f13372549d
2025-04-16 robertphillips@google.com Revise ChromePrecompileTest
2025-04-16 bungeman@google.com [freetype] Check palette actually found
2025-04-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 729a70498186 to 3bc11f8f2d55 (2 revisions)
2025-04-16 vigneshv@google.com SkCrabbyAvifCodec: Use icc profile from
the decoded image
2025-04-16 thomsmit@google.com [graphite] Update DrawWriter to minimize
binds by using pending base offsets.
2025-04-16 faijur.rahman@imagination.corp-partner.google.com img-ddk:
Fix Driver Version Deduction for Unknown ANGLE Backend
2025-04-16 kjlubick@google.com Enforce IWYU on some graphite types
2025-04-16 coldpalelight@gmail.com Fix issue where drawArc loses endcaps
when stroke width is greater than or equal to oval size
2025-04-16 nicolettep@google.com [graphite] Add test to prove Vulkan
shares renderpasses when expected
2025-04-16 kjlubick@google.com Add thread-safe version of
SkResourceCache
2025-04-16 jvanverth@google.com Reland "[graphite] Add ProxyCache
support to RasterPathAtlas."
2025-04-16 jlavrova@google.com Small fix in Unicode CodeUnits API
2025-04-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from a3f2545f6bb3 to ca0457f68880 (12 revisions)
2025-04-16 jeongik@google.com Support GL texture for BGRA8 format
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,codefu@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-17 04:44:05 +00:00
engine-flutter-autoroll
83b2f7f57c
Manual roll Dart SDK from 87965ab4864e to 992221a362ec (35 revisions) ( #167243 )
...
Manual roll Dart SDK from 87965ab4864e to 992221a362ec (35 revisions)
Manual roll requested by codefu@google.com
https://dart.googlesource.com/sdk.git/+log/87965ab4864e..992221a362ec
2025-04-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-21.0.dev
2025-04-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-20.0.dev
2025-04-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-19.0.dev
2025-04-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-18.0.dev
2025-04-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-17.0.dev
2025-04-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-16.0.dev
2025-04-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-15.0.dev
2025-04-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-14.0.dev
2025-04-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-13.0.dev
2025-04-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-12.0.dev
2025-04-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-11.0.dev
2025-04-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-10.0.dev
2025-04-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-9.0.dev
2025-04-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-8.0.dev
2025-04-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-7.0.dev
2025-04-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-6.0.dev
2025-04-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-5.0.dev
2025-04-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-4.0.dev
2025-04-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-3.0.dev
2025-04-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-2.0.dev
2025-04-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-1.0.dev
2025-04-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-0.0.dev
2025-04-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-278.0.dev
2025-04-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-277.0.dev
2025-04-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-276.0.dev
2025-04-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-275.0.dev
2025-04-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-274.0.dev
2025-04-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-273.0.dev
2025-04-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-272.0.dev
2025-04-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-271.0.dev
2025-04-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-270.0.dev
2025-04-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-269.0.dev
2025-04-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-268.0.dev
2025-04-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-267.0.dev
2025-04-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-266.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
...
Co-authored-by: Siva <a-siva@users.noreply.github.com>
2025-04-17 00:31:14 +00:00
engine-flutter-autoroll
b747aeeb1f
Roll Fuchsia Linux SDK from 7bWzHwIPBTyU6R9nO... to m8Aln7fTF_8zy1V9N... ( #167312 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC codefu@google.com ,zra@google.com on the revert to ensure that
a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-16 23:57:14 +00:00
gaaclarke
3f0ff18e76
Updated docstrings for TextureContents ( #167221 )
...
fixes https://github.com/flutter/flutter/issues/139527
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-16 21:55:43 +00:00
gaaclarke
90b37bf053
Broke cyclical dependency with dlpath and typographer. ( #167293 )
...
fixes https://github.com/flutter/flutter/issues/166593
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-16 20:12:32 +00:00
Jason Simmons
c866944682
Revert "Removed superfluous copy in license checker ( #167146 )" ( #167246 )
...
This reverts commit b4dc23333c286bd6fb9b1aaeea63a933a2d62733.
The license script provides a RegExp wrapper that tracks the cost of the
script's regexes. Dart's RegExp.allMatches returns an Iterable whose
iterators lazily execute the regex. Calling toList will execute the
regex on the entire input within allMatches, allowing measurement of the
regex's cost. Returning the Iterable will instead shift the execution
cost to the caller.
Also, in local measurements I'm seeing significantly better performance
from finding all of the matches immediately with toList versus having
the caller use the lazy iterator.
2025-04-16 19:13:46 +00:00
