DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
32,816 Commits 882 Branches 1,069 Tags
Commit Graph

32816 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Mouad Debbar
3e7fea4e4f [web] Move scene DOM management to DomManager (flutter/engine#47460) 
- Move scene insertion logic to `DomManager`.
- Add TODOs in `Renderer` subclasses (cc @harryterkelsen).

Part of https://github.com/flutter/flutter/issues/134443
 2023-11-17 18:35:15 +00:00
gaaclarke
cb70984e12 [Impeller] Unify around "transform" (flutter/engine#48184) 
This replaces usage of "xformation" and "transformation".

test-exempt: refactor

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-17 18:03:23 +00:00
skia-flutter-autoroll
4d2b97c7eb Roll Dart SDK from a9c212f2f54b to 03cddb5d740d (1 revision) (flutter/engine#48182) 
https://dart.googlesource.com/sdk.git/+log/a9c212f2f54b..03cddb5d740d

2023-11-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-147.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-17 17:40:11 +00:00
Matan Lurey
6f19a763ec Actually make status_or.h compatible with .clang-tidy. (flutter/engine#48151) 
I needed to actually convince the checker I wasn't causing a value read
on a non-value. I think this is right?
 2023-11-17 09:07:05 -08:00
Jonah Williams
ea36645542 [Impeller] Cleanups to geometry interfaces. (flutter/engine#48180) 
* Removed virtual destructor. We only use Geometry types with std::shared_ptr which remembers the correct dtor, we'd only need the virtual destructor if we were using `free` ourselves.
* Remove std:unique_ptr. We had a mix on unique and shared ptrs, and were even doing some copies/conversions between the two. I made it consistently shared_ptr, I don't see the advantage of unique given that geometries are essentially immutable.
* made geometry classes have more const methods and final.
* Added some asserts on trivial destruction.
 2023-11-17 17:05:56 +00:00
Mouad Debbar
360c454b63 [web] Move all DOM creation to DomManager (flutter/engine#48123) 
- `FlutterViewEmbedder` doesn't create the DOM tree anymore (instead, `DomManager` does).
- `DomManager` only creates the DOM tree (with styles) but doesn't insert it into the document.
- `EngineFlutterView` takes the root element from `DomManager` and inserts it into the document.
- We finally can now create multiple Flutter views, each with its own DOM tree.

cc @yjbanov since I'm making a few changes that probably conflict with your semantics changes.

Part of https://github.com/flutter/flutter/issues/134443
Part of https://github.com/flutter/flutter/issues/137447
 2023-11-17 16:45:23 +00:00
Victoria Ashworth
cbd9e7a1fa Reenable UnobstructedPlatformViewTests testMultiplePlatformViewsWithOverlays (flutter/engine#48139) 
Renable test now that https://github.com/flutter/flutter/issues/138193 is fixed.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-17 16:08:02 +00:00
skia-flutter-autoroll
694e10a313 Roll Dart SDK from 46e8b18047eb to a9c212f2f54b (1 revision) (flutter/engine#48176) 
https://dart.googlesource.com/sdk.git/+log/46e8b18047eb..a9c212f2f54b

2023-11-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-146.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-17 13:35:04 +00:00
skia-flutter-autoroll
53370cb1a6 Roll Skia from bcd22e8f95bc to 8e9e168418a0 (1 revision) (flutter/engine#48173) 
https://skia.googlesource.com/skia.git/+log/bcd22e8f95bc..8e9e168418a0

2023-11-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from a0360cfd7fd5 to b5f778a99583 (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-17 09:48:38 +00:00
skia-flutter-autoroll
3c9ecd0323 Roll Fuchsia Linux SDK from M0zM3CJLIrd5lb0u0... to Bcq9TZdt-vtTSL5YH... (flutter/engine#48172) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-17 09:34:23 +00:00
skia-flutter-autoroll
be4383faba Roll Skia from c8ee25282849 to bcd22e8f95bc (1 revision) (flutter/engine#48170) 
https://skia.googlesource.com/skia.git/+log/c8ee25282849..bcd22e8f95bc

2023-11-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from c5eb810b941f to 8ae36a93bedc (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-17 07:37:24 +00:00
Brandon DeRosier
f553fe0023 [Flutter GPU] Add Textures. (flutter/engine#48118) 2023-11-16 22:28:54 -08:00
skia-flutter-autoroll
f87be71799 Roll Dart SDK from 12c5efc94edf to 46e8b18047eb (1 revision) (flutter/engine#48168) 
https://dart.googlesource.com/sdk.git/+log/12c5efc94edf..46e8b18047eb

2023-11-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-145.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-17 04:38:20 +00:00
skia-flutter-autoroll
3dc6bcbcc5 Roll Skia from c7d2a4933dfa to c8ee25282849 (2 revisions) (flutter/engine#48164) 
https://skia.googlesource.com/skia.git/+log/c7d2a4933dfa..c8ee25282849

2023-11-17 lovisolo@google.com [bazel] Housekeeper-PerCommit-GoLinters: Add errcheck step.
2023-11-16 lovisolo@google.com [bazel] New task: Housekeeper-PerCommit-GoLinters.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-17 02:28:06 +00:00
Dan Field
89ff1d0d8b Only run systrace test on API 29+, avoid building scenario app for 28 (flutter/engine#48163) 
The emulator tests I added yesterday are failing because the systrace python test script uses features introduced in API 29, which causes the `perfetto` invocation to fail.

It's not essential that we run this test on lower API levels, so instead I'm making the script bail out in this case.

Other than that, the shard seems to be consistently passing, so I'm removing bringup.
 2023-11-17 02:20:51 +00:00
Matan Lurey
7571e558d4 Make lib/ui/text/... compatible with .clang-tidy. (flutter/engine#48156) 2023-11-16 18:00:09 -08:00
Matan Lurey
c58953c1e4 Make flow/... compatible with .clang_tidy. (flutter/engine#48148) 2023-11-16 17:23:08 -08:00
Brandon DeRosier
f9b113e43c [Impeller] Add support for external GL textures to TiledTextureContents. (flutter/engine#47586) 2023-11-16 16:56:49 -08:00
skia-flutter-autoroll
b429c3008b Roll Dart SDK from 906f23c1cb20 to 12c5efc94edf (1 revision) (flutter/engine#48157) 
https://dart.googlesource.com/sdk.git/+log/906f23c1cb20..12c5efc94edf

2023-11-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-144.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-17 00:40:13 +00:00
skia-flutter-autoroll
90d8214c24 Roll Skia from 762d95ed65e0 to c7d2a4933dfa (1 revision) (flutter/engine#48159) 
https://skia.googlesource.com/skia.git/+log/762d95ed65e0..c7d2a4933dfa

2023-11-16 jlavrova@google.com Emoji font resolution fix

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-17 00:36:15 +00:00
Harry Terkelsen
c2749e93a3 [canvaskit] Size the PictureRecorder when calling Scene.toImage (flutter/engine#48142) 
When calling `flatten()` to produce a `Picture` of a `Scene`, size the
`PictureRecorder` to be the same size as the final image.

Fixes https://github.com/flutter/flutter/issues/138009

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-11-16 15:18:53 -08:00
Jonah Williams
6da29df7ee [Impeller] Clang tidy even more (flutter/engine#48102) 
Also removes alot of includes of fml macros, which I know is always safe to remove.
 2023-11-16 23:15:00 +00:00
gaaclarke
6f471e9027 [Impeller] Implements gaussian blur that scales down before applying the blur (flutter/engine#47576) 
A partial implementation of the new gaussian blur effect.  This should perform enough of the code to start getting some performance numbers.

Known outstanding problems:
  1) The edges of the blur are clipped.   I have notes on how I plan on expanding render space in the PR.
  1) Animating the sigma causes some "jumping around artifacts" resulting from the downsampling (maybe the discrete nature of texture pixel size?)
  1) Coverage hints are ignored.  I think depth tests will make that not much of an issue.
  1) We aren't ping ponging textures yet
  1) The snapshot's transform is ignored.

issue: https://github.com/flutter/flutter/issues/131580

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-16 22:34:22 +00:00
skia-flutter-autoroll
e7a2ce6fed Roll Skia from 4c099aaa259f to 762d95ed65e0 (2 revisions) (flutter/engine#48140) 
https://skia.googlesource.com/skia.git/+log/4c099aaa259f..762d95ed65e0

2023-11-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 8fa1b1b67aa7 to a0360cfd7fd5 (6 revisions)
2023-11-16 bungeman@google.com Add GIT_SYNC_DEPS_SHALLOW_CLONE to git-sync-deps

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-16 21:25:37 +00:00
Matan Lurey
56fc8315cc Re-land "Make flow/embedded_views.h compatible with .clang_tidy." (flutter/engine#48137) 
Reverts flutter/engine#48130.

Now that the `runIf` clauses are omitted, CI should be a reliable source
of truth.
 2023-11-16 13:05:13 -08:00
skia-flutter-autoroll
a189220384 Roll Skia from 297049bbfc0d to 4c099aaa259f (5 revisions) (flutter/engine#48138) 
https://skia.googlesource.com/skia.git/+log/297049bbfc0d..4c099aaa259f

2023-11-16 lovisolo@google.com Reland "Reland: [bazel] Housekeeper-PerCommit-CheckGeneratedFiles: Add "go generate", Gazelle and Buildifier steps."
2023-11-16 SCHMIDT Expose default SK_GAMMA_CONTRAST values in SkTypes
2023-11-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 14160bee80f4 to bc5a26ce9f2b
2023-11-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from ba1e7f5c1e82 to f23b91844a05
2023-11-16 kjlubick@google.com Fix up fuzzers implicit dependency on default SkFontMgr

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-16 20:27:17 +00:00
skia-flutter-autoroll
18fe89baba Roll Dart SDK from b512191e9612 to 906f23c1cb20 (1 revision) (flutter/engine#48136) 
https://dart.googlesource.com/sdk.git/+log/b512191e9612..906f23c1cb20

2023-11-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-143.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-16 20:11:06 +00:00
Matan Lurey
990ae10e5b Disable the runIfNot clauses in .ci.yaml, as they are unsafe. (flutter/engine#48132) 
See https://github.com/flutter/flutter/issues/138559.

I'll assign this as an infra bug after merging.

/cc @zanderso @dnfield for FYI.
 2023-11-16 11:05:02 -08:00
Victoria Ashworth
1cb5474a11 Fix race condition in Unobstructed Platform View Scenario tests (flutter/engine#48096) 
Fixes race situation where `_onPlatformMessage` is triggered before the first frame, essentially skipping the first frame.

Fixes https://github.com/flutter/flutter/issues/138193.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-16 19:02:57 +00:00
Jonah Williams
50edc5f397 [Impeller] store all path point data in single buffer. (flutter/engine#47896) 
Path objects are expensive to allocate, create, move, et cetera because of the large number of internal heap allocations performed. This change combines the linear, quad, and cubic buffers into a single point buffer that stores all points/control points inline.

The existing component buffer stores the index to the first point in the buffer, and the type field determines how many points are read.

Benchmarked in https://flutter-engine-perf.skia.org/e/?queries=test%3DBM_Polyline_cubic_polyline%26test%3DBM_Polyline_quad_polyline&selected=commit%3D38035%26name%3D%252Cconfig%253Ddefault%252Ccpu_scaling_enabled%253Dfalse%252Cexecutable%253D_b_s_w_ir_cache_builder_src_out_host_release_geometry_benchmarks%252Clibrary_build_type%253Drelease%252Cmhz_per_cpu%253D2200%252Cnum_cpus%253D8%252Csub_result%253DTotalPointCount%252Ctest%253DBM_Polyline_quad_polyline%252Cunit%253Dns%252C

https://github.com/flutter/flutter/issues/138004
 2023-11-16 18:54:12 +00:00
skia-flutter-autoroll
8325f708f0 Roll Skia from b9ead4140f84 to 297049bbfc0d (2 revisions) (flutter/engine#48133) 
https://skia.googlesource.com/skia.git/+log/b9ead4140f84..297049bbfc0d

2023-11-16 kjlubick@google.com Add option to skip emsdk sync
2023-11-16 jvanverth@google.com [graphite] Improvement to image sampling performance.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-16 18:36:26 +00:00
Chris Bracken
ee4fcf69da [macOS] Replace pasteboard mock with fake (flutter/engine#48110) 
Also replaces the use of OCMock with a fake for tests involving the use of NSPasteboard. This avoids unnecessary use of OCMock in the tests, which has been responsible for flakiness in some tests, in particular where the mock is used across threads. This test was not problematic, but the fake makes the tests more readable.

Issue: https://github.com/flutter/flutter/issues/104789
Issue: https://github.com/flutter/flutter/issues/127441
Issue: https://github.com/flutter/flutter/issues/124840

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-16 18:13:50 +00:00
Chinmay Garde
94bb885ead [Impeller] Fix issue where the lock was not re-acquired when the wait exits on CV. (flutter/engine#48104) 
Had not used std::adopt_lock before and didn't realize that the unique lock destructor unlocks the mutex even when the mutex is adopted (which I suppose makes sense when you think about it). But I had added the annotations assuming the lock will remain if adopted. Found after a painful round of debugging the "safe" condition variables.
 2023-11-16 17:54:05 +00:00
Jonah Williams
a4b4cae1a8 [Impeller] Create a drawable backed TextureMTL. (flutter/engine#48049) 
Allow creating a TextureMTL instance that is backend by a CAMetalLayer, which only acquires the drawable (and texture) lazily.

I split TextureMTL into two subclasses, one that has the standard wrapping behavior of a MTLTexture, and the other that holds a drawable. This is part of the foundational work for "removing drawable acquisition latency", as we need to delay aquisition of the drawable texture to a worker thread.

The drawable backed texture is only used in tests for now.

Part of https://github.com/flutter/flutter/issues/138490
 2023-11-16 17:50:18 +00:00
auto-submit[bot]
74d08febd7 Reverts "Make flow/embedded_views.h compatible with .clang_tidy." (flutter/engine#48130) 
Reverts flutter/engine#47994
Initiated by: jonahwilliams
This change reverts the following previous change:
Original Description:
Work towards https://github.com/flutter/flutter/issues/134969.

All changes were made automatically (i.e. with `--fix`).
 2023-11-16 17:18:18 +00:00
Chris Bracken
87e57d7e14 [macOS] Replace fixture subclasses with usings (flutter/engine#48111) 
In cases where we subclassed gtest fixtures purely to get better naming for test output (i.e. displaying/filtering on AccessibilityBridgeMacTest instead of AutoreleasePoolTest, replace these with `using` declarations, which is equally effective and avoids actually subclassing.

This applies no semantic changes to the code or tests.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-16 16:55:27 +00:00
Matan Lurey
b741431a73 Make flow/embedded_views.h compatible with .clang_tidy. (flutter/engine#47994) 
Work towards https://github.com/flutter/flutter/issues/134969.

All changes were made automatically (i.e. with `--fix`).
 2023-11-16 08:47:54 -08:00
Matan Lurey
933bd94016 Make flow/... compatible with .clang_tidy. (flutter/engine#47995) 
Work towards https://github.com/flutter/flutter/issues/134969.

All changes were made automatically (i.e. with `--fix`).
 2023-11-16 08:41:10 -08:00
Matan Lurey
5bb5a50b0a Make lib/ui/painting/... compatible with .clang_tidy. (flutter/engine#47999) 
Work towards https://github.com/flutter/flutter/issues/134969.

All changes were made automatically (i.e. with `--fix`).
 2023-11-16 08:40:42 -08:00
Matan Lurey
4638f4fc85 Re-land "Make lib/ui/{text|window}/... compatible with .ci.yaml" (flutter/engine#48097) 
Reverts https://github.com/flutter/engine/pull/48083.
 2023-11-16 08:40:19 -08:00
skia-flutter-autoroll
a7cb9573ca Roll Skia from bf1d6d84db73 to b9ead4140f84 (1 revision) (flutter/engine#48124) 
https://skia.googlesource.com/skia.git/+log/bf1d6d84db73..b9ead4140f84

2023-11-16 robertphillips@google.com [graphite] Allow creation of Protected Devices

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-16 16:37:06 +00:00
skia-flutter-autoroll
79e0a2f56a Roll Skia from 2fe70dd9cbf8 to bf1d6d84db73 (1 revision) (flutter/engine#48122) 
https://skia.googlesource.com/skia.git/+log/2fe70dd9cbf8..bf1d6d84db73

2023-11-16 lehoangquyen@chromium.org GraphiteDawn: cache uniform buffers' bind groups.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-16 15:39:59 +00:00
skia-flutter-autoroll
696b837f74 Roll Dart SDK from 5cccc24d127f to b512191e9612 (1 revision) (flutter/engine#48120) 
https://dart.googlesource.com/sdk.git/+log/5cccc24d127f..b512191e9612

2023-11-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-142.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-16 13:38:33 +00:00
skia-flutter-autoroll
86e7d7731d Roll Fuchsia Linux SDK from AuDKY8ob6GrGwDlmk... to M0zM3CJLIrd5lb0u0... (flutter/engine#48115) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-16 08:49:15 +00:00
skia-flutter-autoroll
55fb5658c1 Roll Skia from 2642516e7de7 to 2fe70dd9cbf8 (1 revision) (flutter/engine#48114) 
https://skia.googlesource.com/skia.git/+log/2642516e7de7..2fe70dd9cbf8

2023-11-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 13dd63c18adf to 8fa1b1b67aa7 (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-16 08:27:14 +00:00
skia-flutter-autoroll
041a1c3224 Roll Skia from add865f891c8 to 2642516e7de7 (1 revision) (flutter/engine#48112) 
https://skia.googlesource.com/skia.git/+log/add865f891c8..2642516e7de7

2023-11-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from a982e241b362 to c5eb810b941f (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-16 07:38:40 +00:00
skia-flutter-autoroll
185345e14d Roll Dart SDK from cc6acfd7d57c to 5cccc24d127f (1 revision) (flutter/engine#48109) 
https://dart.googlesource.com/sdk.git/+log/cc6acfd7d57c..5cccc24d127f

2023-11-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-141.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-16 06:04:24 +00:00
skia-flutter-autoroll
fa0cf0bc76 Roll Skia from 5d6bdbf69dea to add865f891c8 (1 revision) (flutter/engine#48108) 
https://skia.googlesource.com/skia.git/+log/5d6bdbf69dea..add865f891c8

2023-11-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 99672e2bf1ed to 85b15b0b132e (18 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-16 05:23:47 +00:00
skia-flutter-autoroll
eca85da3ce Roll Dart SDK from 65819963fb17 to cc6acfd7d57c (5 revisions) (flutter/engine#48100) 
https://dart.googlesource.com/sdk.git/+log/65819963fb17..cc6acfd7d57c

2023-11-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-140.0.dev
2023-11-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-139.0.dev
2023-11-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-138.0.dev
2023-11-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-137.0.dev
2023-11-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-136.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-16 02:16:32 +00:00
Matan Lurey
0371968293 Make fml/status_or.h compatible with .clang_tidy. (flutter/engine#48002) 
Work towards https://github.com/flutter/flutter/issues/134969.
 2023-11-15 18:08:56 -08:00