9250 Commits

Author SHA1 Message Date
Jason Simmons
3c089996dc Disconnect from platform views and virtual displays before detaching from the engine (flutter/engine#17379) 2020-04-02 18:16:05 -07:00
Kaushik Iska
ce0ec9042f [pipeline] Add trace event for lag between target and display times (flutter/engine#17384)
This change also adds TimeRecorder which records time at the start
of each frame to capture the latest vsync target display time and
wires it in to the rasterizer to add trace events when there is a lag.
2020-04-02 17:15:45 -07:00
Dan Field
f1a58638ad Fix bad texture view config (flutter/engine#17486) 2020-04-02 15:06:03 -07:00
stuartmorgan
7b222c8310 Remove JSON codec from C++ client wrapper (flutter/engine#17312)
The JSON codec is awkward to use in the wrapper (since the client has to build and link one of the JSON libraries to do so). Since it would be very cumbersome to wrap in a C API, and there's essentially no reason to use it instead of the standard codec, this removes it from the wrapper entirely.

Since some system channels (internal to the engine) still use it, it's moved into common/cpp instead of being eliminated entirely. Internally we always use RapidJSON though, so the jsoncpp implementation is removed. Also adds some unit test coverage, since there wasn't any.

Fixes #30669
2020-04-02 14:57:46 -07:00
Dan Field
904a84fee3 Roll to clang11, mark 4 (flutter/engine#17483)
* "Reland Clang 11, roll buildroot to 1bc40a5f916adb93d87e2a2230a0ec43db876c1c, take 4 (#17467)" (#17482)"

This reverts commit d7bbf2e70c8cb86823f1ec7a310d6ab0b9a610db.

* format code

* Roll buildroot to 3a27de1c5bb0f50be7d3efe3e00de4f6068c9f30
2020-04-02 13:04:49 -07:00
Chinmay Garde
165af3205c Always cache SkSL when using the Metal backend. (flutter/engine#17468)
There is no ability to compile shaders online and cache those binaries when
using the Metal backend. SkSL caching must always be used.
2020-04-02 13:00:29 -07:00
Jonah Williams
e6e8170ea8 fix typos in switch descriptions (flutter/engine#17475) 2020-04-02 11:21:04 -07:00
skia-flutter-autoroll
67ba02a348 Roll src/third_party/skia 8ce842d38d0b..8afde5f39508 (9 commits) (flutter/engine#17480) 2020-04-02 10:51:02 -07:00
Dan Field
a04ba4f15e Initialize locale from FlutterEngine (flutter/engine#17473)
* Initialize locale from FlutterEngine
2020-04-02 10:06:06 -07:00
Dan Field
d7bbf2e70c Revert "Reland Clang 11, roll buildroot to 1bc40a5f916adb93d87e2a2230a0ec43db876c1c, take 3 (#17467)" (flutter/engine#17482)
This reverts commit 31eab31f771363d9c4fc9799449859abe0e464f2.
2020-04-02 10:01:26 -07:00
skia-flutter-autoroll
fc4c1fc626 Roll src/third_party/skia 6c51bf61e283..8ce842d38d0b (1 commits) (flutter/engine#17477) 2020-04-02 06:56:03 -07:00
skia-flutter-autoroll
2ff59573d0 Roll src/third_party/skia 46aacc771012..6c51bf61e283 (3 commits) (flutter/engine#17472) 2020-04-02 00:01:04 -07:00
skia-flutter-autoroll
55efd61beb Roll fuchsia/sdk/core/linux-amd64 from zJlvo... to v61zg... (flutter/engine#17471) 2020-04-01 23:56:03 -07:00
skia-flutter-autoroll
ee3d1384dd Roll src/third_party/skia b14b14445884..46aacc771012 (5 commits) (flutter/engine#17466) 2020-04-01 21:26:03 -07:00
Dan Field
31eab31f77 Reland Clang 11, roll buildroot to 1bc40a5f916adb93d87e2a2230a0ec43db876c1c, take 3 (flutter/engine#17467)
* Reland Clang 11, Roll buildroot to 1bc40a5f916adb93d87e2a2230a0ec43db876c1c (#17457)" (#17464)

This reverts commit 6083cda709c194ec81d2092c70a0151a10f0c922.

* Skip more image tests, use newer dsymutil, add missing symbols
2020-04-01 20:55:27 -07:00
mikejurka
d133ffb5a8 [fuchsia] Add tests for TransformLayer. (flutter/engine#17439) 2020-04-01 20:01:52 -07:00
George Wright
9b4556331b Flush the session after updating the scene 2020-04-01 19:48:07 -07:00
George Wright
34be05b507 Manual roll fuchsia/sdk/core/linux-amd64 from nK6R0... to zJlvo... 2020-04-01 19:48:07 -07:00
skia-flutter-autoroll
d9ac997b8f Roll src/third_party/skia bfc09267bdb4..b14b14445884 (13 commits) (flutter/engine#17462) 2020-04-01 19:01:04 -07:00
Gary Qian
eff62e12bd Implement getExtractedText in InputConnectionAdaptor (flutter/engine#17426) 2020-04-01 18:51:04 -07:00
liyuqian
474e90ba76 Add build_and_test_linux_release presubmit test (flutter/engine#17073) 2020-04-01 18:46:04 -07:00
Dan Field
6083cda709 Revert "Reland Clang 11, Roll buildroot to 1bc40a5f916adb93d87e2a2230a0ec43db876c1c (#17457)" (flutter/engine#17464)
This reverts commit fe77c763691277d3194269f30d9a8c915e437852.
2020-04-01 17:50:57 -07:00
Dan Field
fe77c76369 Reland Clang 11, Roll buildroot to 1bc40a5f916adb93d87e2a2230a0ec43db876c1c (flutter/engine#17457)
* Reland "Roll Clang to v11, roll buildroot to fe13f79dce4ce9aab3209f11988d825dcf580b4a, allow newly exported symbols (#17440)" (#17451)"

This reverts commit d77d53688f77285966adeb2a24349ba490a7e6ce.

* skip golden that is different on macos

* buildroot to 1bc40a5f916adb93d87e2a2230a0ec43db876c1c
2020-04-01 16:32:13 -07:00
gaaclarke
f3c6f8902f Started clearing out the semantics information in Dart as well as deleting the AccessibilityBridge. (flutter/engine#17433) 2020-04-01 13:08:01 -07:00
skia-flutter-autoroll
5ea5e92f0a Roll src/third_party/skia e8d2080a34ed..bfc09267bdb4 (8 commits) (flutter/engine#17450) 2020-04-01 12:16:01 -07:00
Dan Field
d77d53688f Revert "Roll Clang to v11, roll buildroot to fe13f79dce4ce9aab3209f11988d825dcf580b4a, allow newly exported symbols (#17440)" (flutter/engine#17451)
This reverts commit 44327d852622d7ea8fafa4b232b91f74ea7aaf72.
2020-04-01 11:06:07 -07:00
stuartmorgan
18e2aed939 Remove me from auto-assign list (flutter/engine#17446) 2020-04-01 10:51:03 -07:00
Dan Field
44327d8526 Roll Clang to v11, roll buildroot to fe13f79dce4ce9aab3209f11988d825dcf580b4a, allow newly exported symbols (flutter/engine#17440)
* Buildroot to fe13f79dce4ce9aab3209f11988d825dcf580b4a

* whitelist more symbols
2020-04-01 10:49:24 -07:00
cjng96
fdfb501df7 Remove code which skips keyEvent from input control on web (flutter/engine#17242) 2020-04-01 09:32:18 -07:00
skia-flutter-autoroll
2dc19afab4 Roll src/third_party/skia 0f5e7581a004..e8d2080a34ed (2 commits) (flutter/engine#17447) 2020-04-01 09:21:03 -07:00
Brian Osman
6ed6d9bdc8 Finish removing deprecated SkCanvas virtuals (flutter/engine#17445)
API staging is complete - these defines have been removed.
2020-04-01 10:27:50 -04:00
skia-flutter-autoroll
90d00cc625 Roll src/third_party/skia 7a3358c80b6e..0f5e7581a004 (1 commits) (flutter/engine#17444) 2020-04-01 06:56:01 -07:00
Chinmay Garde
c338e362f1 Use Metal on iOS by default. (flutter/engine#17431)
Fixes https://github.com/flutter/flutter/issues/18208. All Metal for iOS related work items described in https://github.com/orgs/flutter/projects/5 have been completed.
2020-03-31 23:37:04 -07:00
Chinmay Garde
1eec7d5d8e If the application says there is a new texture but does not provide one, reuse the last texture. (flutter/engine#17437)
This matches the behavior of the OpenGL backend.
2020-03-31 22:01:32 -07:00
mikejurka
f434b2e6a8 [fuchsia] Fix bug when applying scale. (flutter/engine#17436)
We were always scaling z by 0, instead of 1. This
caused the z elevation of some layers to be 0,
which was incorrect.
2020-03-31 21:49:44 -07:00
skia-flutter-autoroll
76cf8e7f91 Roll src/third_party/skia 65d3ad953957..7a3358c80b6e (20 commits) (flutter/engine#17435) 2020-03-31 18:21:01 -07:00
mikejurka
9a7303b7ad [fuchsia] Re-enable shadows. (flutter/engine#17380)
Now that client apps use the same elevations on
Fuchsia and other platforms, shadows should look
identical.
2020-03-31 18:07:12 -07:00
Robert Ancell
eda8501719 Update FlDartProject to new path format (flutter/engine#17302)
Matches the structure used on Windows of assuming a directory format.
2020-03-31 15:25:44 -07:00
liyuqian
b4f8a7c881 GPU to raster rename, patch 2 (flutter/engine#17428) 2020-03-31 15:16:11 -07:00
Chinmay Garde
7bc00f2d09 Fix iOS builds on Xcode 11.4 for new enum values added in iOS 13.4. (flutter/engine#17429)
The following issues have been filed to track the handling of these enum values:

* Handle the UITouchTypeIndirectPointer enum value. https://github.com/flutter/flutter/issues/53696
* Handle the UITouchPhaseRegion enum values. https://github.com/flutter/flutter/issues/53695

No change in functionality. Only makes the iOS engine build on the latest
versions of Xcode and iOS SDK. The enum values cannot be used with the
API_AVAILABLE macro because the buildbots have not been updated yet.
2020-03-31 15:10:05 -07:00
Nathan Rogers
afb66ed5a6 [fuchsia] Remove "CreateTraceProvider" trace event (flutter/engine#17423)
Since the trace provider hasn't been created yet, it is not possible to
trace the creation of a trace provider using a TRACE_DURATION event (the
trace enabled and category check will always fail).  While this isn't
causing any urgent problems, remove it to set a good example for other
clients of tracing that might happen to reference this code.
2020-03-31 15:09:38 -07:00
liyuqian
6464f4eb97 Strengthen json string comparisons (flutter/engine#17425)
Make the test robust even if the json map reorders its keys.
2020-03-31 15:02:26 -07:00
liyuqian
b5318d05ff More rename from GPU thread to raster thread (flutter/engine#17408)
This PR touches variable names, class names, and file names so it's significantly more risky than its predecessor https://github.com/flutter/engine/pull/17329

Due to file name changes, this PR is expected to change the license files.

We haven't rename `shell/gpu` to `shell/raster` yet. It should be optional but I think it's better to have `raster_surface_software.cc` than `gpu_surface_software.cc`.
2020-03-31 14:05:28 -07:00
skia-flutter-autoroll
904b02bd39 Roll src/third_party/skia 732f84d3e279..65d3ad953957 (3 commits) (flutter/engine#17418) 2020-03-31 10:31:03 -07:00
liyuqian
2849649e8c Correct --dry-run hint (flutter/engine#17413) 2020-03-31 10:21:02 -07:00
Ferhat
1a3231ec1f Add regression test for treeshaking debugFillProperties (flutter/engine#17325)
* Add test to make sure we don't regress treeshaking of debugFillProperties
* update cirrus
2020-03-31 09:43:14 -07:00
skia-flutter-autoroll
0d22fd875e Roll src/third_party/skia e9bc857b39c2..732f84d3e279 (25 commits) (flutter/engine#17411) 2020-03-31 05:56:03 -07:00
Chinmay Garde
319400c37e Document flutter::SkiaConcurrentExecutor. (flutter/engine#17394) 2020-03-30 16:45:51 -07:00
Ferhat
de38b85deb [web] Fix HtmlImage state pollution due to image.clone optimization (flutter/engine#17370)
* fix drawImage style when destination width==source
* Add regression test
* dartfmt
* update golden lock
* Addressed review comment
* remove transform reset since _drawImage is called
2020-03-30 16:42:36 -07:00
gaaclarke
ff0ab7cc79 Roll src/third_party/dart 1402e8e1a42d.e21c4353006d (95 commits) (flutter/engine#17386)
git log 1402e8e1a42d..e21c4353006d665e7c4378413ad4d237f18437e0 --date=short --first-parent --format='%ad %ae %s'
2020-03-30 jsimmons@google.com [dart:io] Fuchsia version of SocketBase::AvailableDatagram
2020-03-30 jwren@google.com Fix the dart help test output by implementing printUsage() in the test command
2020-03-30 sstrickl@google.com [vm/aot] Drop some Function objects not needed at runtime.
2020-03-30 mit@google.com Roll pub to latest version
2020-03-30 scheglov@google.com Document differences in inheritance tests between CFE and analyzer.
2020-03-30 scheglov@google.com Revert "Fix the result type of binary expression with the left TypeParameter extends num type."
2020-03-30 johnniwinther@google.com [cfe] Handle member signatures from dill in class hierarchy builder
2020-03-30 eernst@google.com [cfe] Add missing .next in endImplicitCreationExpression
2020-03-30 jensj@google.com [CFE] Add api to get language version for uri
2020-03-30 johnniwinther@google.com [cfe] Don't include member signature in id testing by default.
2020-03-30 johnniwinther@google.com [kernel] Make verbose qualified names conditional in toStringInternal
2020-03-30 devoncarew@google.com [dartdev] test the dartdev analyze --fatal-warnings option
2020-03-30 brianwilkerson@google.com Enable omit_local_variable_types in analyzer_plugin
2020-03-30 brianwilkerson@google.com Enable omit_loval_variable_types in analysis_server_client
2020-03-30 brianwilkerson@google.com Enable omit_local_variable_types in analysis_server
2020-03-30 keertip@google.com Add guard code for exceptions from ResourceProvider when reading contents.
2020-03-29 scheglov@google.com Fix the result type of binary expression with the left TypeParameter extends num type.
2020-03-28 scheglov@google.com Fix for creating a setter when the target is in a part without a library.
2020-03-28 brianwilkerson@google.com Remove the need for a --corpus flag from completion_metrics
2020-03-28 brianwilkerson@google.com Remove the need for a --corpus flag from relevance_metrics
2020-03-28 brianwilkerson@google.com Remove an unused variable in AstBuilder
2020-03-28 brianwilkerson@google.com Sort non-generated files in analyis_server and add a test to ensure they stay that way
2020-03-28 scheglov@google.com Add LibraryElement.languageVersionMajor/Minor
2020-03-28 scheglov@google.com Report exceptions with the file content for getResult().
2020-03-28 scheglov@google.com Fix crash in index when the invoked element is multiply defined.
2020-03-28 eernst@google.com Add implementation of several parts of non-function type aliases
2020-03-28 johnniwinther@google.com [cfe] Groups standard tests in update_expectations.dart
2020-03-28 sra@google.com [dart2js] Specialize is- and as- tests for nullable types
2020-03-28 rmacnak@google.com [vm] Do not allocate when evaluating arguments to StorePointer.
2020-03-28 rmacnak@google.com [vm] Fix some data races with profiler samples.
2020-03-28 alexmarkov@google.com Revert "[analyzer] Remove deprecated language version API"
2020-03-27 nshahan@google.com [ddc] Cleanup cast in dart:_runtime lib
2020-03-27 brianwilkerson@google.com New relevance values for UriContributor
2020-03-27 brianwilkerson@google.com New relevance values for KeywordContributor
2020-03-27 brianwilkerson@google.com New relevance values for VariableNameContributor
2020-03-27 paulberry@google.com Migration: don't use union edges for field formal parameters
2020-03-27 rmacnak@google.com [vm] Fix memory leak in profiler when some samples are in native functions without a dynamic symbol.
2020-03-27 bkonyi@google.com [ package:dds ] Fixed smoke_test.dart which was unable to launch smoke.dart due to use of a relative path.
2020-03-27 zichangguo@google.com [dart:io] Fix parsing the response of the HTTP connect method
2020-03-27 mfairhurst@google.com [nnbd_migration] Add confirm dialog to "apply migration" button
2020-03-27 rmacnak@google.com [test] Update use of Null as a bottom type to Never.
2020-03-27 eernst@google.com Added new tests.
2020-03-27 alexmarkov@google.com [vm/nnbd/aot/tfa] Support NNBD strong mode in type flow analysis
2020-03-27 mfairhurst@google.com [analyzer] Remove deprecated language version API
2020-03-27 brianwilkerson@google.com Update relevance computations in LocalReferenceContributor
2020-03-27 brianwilkerson@google.com Update relevance values for LocalLibraryContributor and ImportedReferenceContributor
2020-03-27 sigurdm@google.com Bump pub version
2020-03-27 sigmund@google.com [dart2js] Update test-matrix to specify the libraries.json to dart2js batch runner
2020-03-27 jcollins@google.com Update dartdoc to 0.30.3.
2020-03-27 alexmarkov@google.com [vm/nnbd] Fix marking static fields as late
2020-03-27 scheglov@google.com Fix for completion in formal parameters of GenericFunctionType.
2020-03-27 mfairhurst@google.com [nnbd_migration] Add a "rerun from sources" button.
2020-03-27 mfairhurst@google.com Revert "[analyzer] Copy result of allSupertypes for now."
2020-03-27 scheglov@google.com Merge types during instance member inference.
2020-03-27 scheglov@google.com Catch linking exceptions and include the cycle file contents.
2020-03-27 johnniwinther@google.com [cfe] Handle throw in return type inference
2020-03-27 alexmarkov@google.com [vm/aot/tfa] Fix tracking of parameters in async_op closures
2020-03-27 zichangguo@google.com Reland "[dart:io] Fix hanging on zero-length datagram"
2020-03-27 athom@google.com [infra] Update checked-in SDKs to 2.8.0-dev.18.0
2020-03-27 johnniwinther@google.com [cfe] Add tool for updating all id-tests and expectation tests
2020-03-27 athom@google.com [homebrew] Add support for the beta channel formula
2020-03-27 brianwilkerson@google.com Sort files in analysis_server_client and analyzer_plugin and add tests to keep them that way
2020-03-27 askesc@google.com [benchmark] Benchmark for UTF-8 decoding with typical data.
2020-03-27 jensj@google.com [parser] Change recovery for constructor; report errors in bad constructors
2020-03-27 johnniwinther@google.com [cfe] Use legacy erasure before argument inference
2020-03-27 jensj@google.com [kernel] Polish toString implementation on AST nodes
2020-03-27 sra@google.com [dart2js] Print non-minified init object as multiline
2020-03-27 karlklose@google.com [infra] Handle test steps with no tested configuration
2020-03-27 zichangguo@google.com [dart:io] remove available at _NativeSocket::Read
2020-03-27 nbosch@google.com Remove a stale TODO comment
2020-03-27 rnystrom@google.com Add other breaking changes to CHANGELOG.
2020-03-27 liama@google.com [nnbd/test] Fix tests that are failing in strong mode
2020-03-26 rnystrom@google.com Fix Markdown link in CHANGELOG and remove duplicate entry.
2020-03-26 brianwilkerson@google.com Compute new relevance in LocalConstructorContributor
2020-03-26 kevmoo@google.com DEPS: remove references to pkg:package_resolver
2020-03-26 jcollins@google.com Add a way for analysis_server to open communication via a IsolateChannel.
2020-03-26 scheglov@google.com Use NNBD_TOP_MERGE to combine signatures of the inherited members.
2020-03-26 nshahan@google.com [ddc] Update types in JSArray operations
2020-03-26 srawlins@google.com Migrator: Add an auth token for the preview site
2020-03-26 dacoharkes@google.com [vm] Add Reachability Fence Instruction
2020-03-26 sra@google.com [benchmark] Make BigIntPrintParse be NNBD-agnostic
2020-03-26 rnystrom@google.com Bump the SDK constraint on dart_internal to permit Dart 2.8.0.
2020-03-26 kevmoo@google.com Update changelog with dart2js --package-root removal
2020-03-26 alexmarkov@google.com [vm/corelib] Specify types explicitly in convert_patch.dart
2020-03-26 scheglov@google.com Update checkForWrongTypeParameterVarianceInMethod(), fix NPE.
2020-03-26 mfairhurst@google.com [analyzer] Copy result of allSupertypes for now.
2020-03-26 scheglov@google.com Add  more data to debug crash in buildExportNamespace().
2020-03-26 scheglov@google.com Fix for crash when FieldFormalParameter in a local function has annotations.
2020-03-26 bkonyi@google.com [ VM / DartDev ] Disable DartDev for the 2.8 release
2020-03-26 kevmoo@google.com Remove unused package-root option and configuration from dart2js
2020-03-26 srujzs@google.com [dart:html] Add nullability to EventTarget conversion
2020-03-26 kevmoo@google.com DEPS: Bring in latest pub
2020-03-26 dacoharkes@google.com [vm/ffi] Mark Struct as entrypoint
2020-03-26 jensj@google.com [analyzer] Sort entries in error.dart and syntactic_errors.dart
2020-03-26 karlklose@google.com [infra] pkg/smith: custom test runner steps are test steps
2020-03-30 15:22:47 -07:00