DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

[fuchsia] Remove "CreateTraceProvider" trace event (flutter/engine#17423)

Browse Source 
Since the trace provider hasn't been created yet, it is not possible to
trace the creation of a trace provider using a TRACE_DURATION event (the
trace enabled and category check will always fail).  While this isn't
causing any urgent problems, remove it to set a good example for other
clients of tracing that might happen to reference this code.
This commit is contained in:
Nathan Rogers 2020-03-31 15:09:38 -07:00 committed by GitHub
parent 6464f4eb97
commit afb66ed5a6
2 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
engine/src/flutter/shell/platform/fuchsia/dart_runner/main.cc
View File

@ -36,7 +36,6 @@ int main(int argc, const char** argv) {
std::unique_ptr<trace::TraceProviderWithFdio> provider;
{
TRACE_DURATION("dart", "CreateTraceProvider");
bool already_started;
// Use CreateSynchronously to prevent loss of early events.
trace::TraceProviderWithFdio::CreateSynchronously(

1
engine/src/flutter/shell/platform/fuchsia/flutter/main.cc
View File

@ -17,7 +17,6 @@ int main(int argc, char const* argv[]) {
std::unique_ptr<trace::TraceProviderWithFdio> provider;
{
TRACE_DURATION("flutter", "CreateTraceProvider");
bool already_started;
// Use CreateSynchronously to prevent loss of early events.
trace::TraceProviderWithFdio::CreateSynchronously(