From afb66ed5a6fbd2d0fe78b37f98e7acf2ca3f454d Mon Sep 17 00:00:00 2001 From: Nathan Rogers Date: Tue, 31 Mar 2020 15:09:38 -0700 Subject: [PATCH] [fuchsia] Remove "CreateTraceProvider" trace event (flutter/engine#17423) Since the trace provider hasn't been created yet, it is not possible to trace the creation of a trace provider using a TRACE_DURATION event (the trace enabled and category check will always fail). While this isn't causing any urgent problems, remove it to set a good example for other clients of tracing that might happen to reference this code. --- engine/src/flutter/shell/platform/fuchsia/dart_runner/main.cc | 1 - engine/src/flutter/shell/platform/fuchsia/flutter/main.cc | 1 - 2 files changed, 2 deletions(-) diff --git a/engine/src/flutter/shell/platform/fuchsia/dart_runner/main.cc b/engine/src/flutter/shell/platform/fuchsia/dart_runner/main.cc index 357ac33324c..2dfe8d41810 100644 --- a/engine/src/flutter/shell/platform/fuchsia/dart_runner/main.cc +++ b/engine/src/flutter/shell/platform/fuchsia/dart_runner/main.cc @@ -36,7 +36,6 @@ int main(int argc, const char** argv) { std::unique_ptr provider; { - TRACE_DURATION("dart", "CreateTraceProvider"); bool already_started; // Use CreateSynchronously to prevent loss of early events. trace::TraceProviderWithFdio::CreateSynchronously( diff --git a/engine/src/flutter/shell/platform/fuchsia/flutter/main.cc b/engine/src/flutter/shell/platform/fuchsia/flutter/main.cc index e37a12d2756..8fa2dfe803a 100644 --- a/engine/src/flutter/shell/platform/fuchsia/flutter/main.cc +++ b/engine/src/flutter/shell/platform/fuchsia/flutter/main.cc @@ -17,7 +17,6 @@ int main(int argc, char const* argv[]) { std::unique_ptr provider; { - TRACE_DURATION("flutter", "CreateTraceProvider"); bool already_started; // Use CreateSynchronously to prevent loss of early events. trace::TraceProviderWithFdio::CreateSynchronously(