30164 Commits

Author SHA1 Message Date
skia-flutter-autoroll
2ffc866a39 Roll Fuchsia Linux SDK from ZwCUlo28olVzLlqTl... to hVAAd2NqYOjUF_I99... (flutter/engine#43850)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-20 14:01:08 +00:00
skia-flutter-autoroll
2d184793a0 Roll ANGLE from 5e38a31bd76a to a4c283be741f (1 revision) (flutter/engine#43849)
5e38a31bd7..a4c283be74

2023-07-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 7f74d379edd8 to e1c3b16d5aa5 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC bdero@google.com,flutter-engine@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-20 11:38:34 +00:00
skia-flutter-autoroll
d6679b38f4 Roll Skia from 65a83c4de7f2 to 401c85ab1e21 (1 revision) (flutter/engine#43848)
https://skia.googlesource.com/skia.git/+log/65a83c4de7f2..401c85ab1e21

2023-07-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f3c508b81760 to e1c3b16d5aa5 (11 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-20 09:45:05 +00:00
skia-flutter-autoroll
fafb7f302d Roll Skia from d09e9869f84c to 65a83c4de7f2 (2 revisions) (flutter/engine#43847)
https://skia.googlesource.com/skia.git/+log/d09e9869f84c..65a83c4de7f2

2023-07-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from b32d661389a6 to 5e38a31bd76a (5 revisions)
2023-07-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from a1951225a465 to b698c2aac01c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-20 08:03:41 +00:00
skia-flutter-autoroll
664b0f50f8 Roll Fuchsia Mac SDK from 7kGBjmX-zBXcg1svE... to SmAtKPfGzPllC9gfO... (flutter/engine#43845)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-20 07:23:20 +00:00
skia-flutter-autoroll
272e54908f Roll Skia from b238c09fe959 to d09e9869f84c (1 revision) (flutter/engine#43842)
https://skia.googlesource.com/skia.git/+log/b238c09fe959..d09e9869f84c

2023-07-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from c10b5129407a to a1951225a465 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-20 06:25:22 +00:00
skia-flutter-autoroll
d336742794 Roll Dart SDK from 368a205aa1d4 to 603aacd8400f (1 revision) (flutter/engine#43843)
https://dart.googlesource.com/sdk.git/+log/368a205aa1d4..603aacd8400f

2023-07-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-330.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-20 06:07:21 +00:00
John McCutchan
b3945f7706 Add a PlatformViewRenderTarget abstraction (flutter/engine#43813)
- Introduce PlatformViewRenderTarget interface.
- Refactor VirtualDisplayController and PlatformViewWrapper to extract
SurfaceTexturePlatformViewRenderTarget into a separate class.

In a future CL I will add an ImageReaderPlatformViewRenderTarget which
will enable Platform Views on Impeller/Vulkan.

Tracking issue: https://github.com/flutter/flutter/issues/130892
2023-07-19 20:26:21 -07:00
skia-flutter-autoroll
4cb94272fd Roll Dart SDK from 677bbf64d4d7 to 368a205aa1d4 (1 revision) (flutter/engine#43841)
https://dart.googlesource.com/sdk.git/+log/677bbf64d4d7..368a205aa1d4

2023-07-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-329.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-20 02:27:33 +00:00
skia-flutter-autoroll
79e8f191b8 Roll Fuchsia Linux SDK from -SNz0augjLKFVsUWn... to ZwCUlo28olVzLlqTl... (flutter/engine#43839)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-20 01:23:28 +00:00
skia-flutter-autoroll
4338c8482f Roll ANGLE from 4515b270772e to 5e38a31bd76a (1 revision) (flutter/engine#43836)
4515b27077..5e38a31bd7

2023-07-19 angle-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from 831910dbe1f3 to 7f74d379edd8 (38 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC bdero@google.com,flutter-engine@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 23:21:24 +00:00
skia-flutter-autoroll
6998929456 Roll Skia from 8413c82dea43 to b238c09fe959 (1 revision) (flutter/engine#43835)
https://skia.googlesource.com/skia.git/+log/8413c82dea43..b238c09fe959

2023-07-19 johnstiles@google.com Add a WGSL testbed file to dm tests.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 23:03:57 +00:00
skia-flutter-autoroll
f7b39000fd Roll Dart SDK from 936824d49aa7 to 677bbf64d4d7 (1 revision) (flutter/engine#43833)
https://dart.googlesource.com/sdk.git/+log/936824d49aa7..677bbf64d4d7

2023-07-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-328.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 22:29:14 +00:00
Jim Graham
6f48af53e9 Reland "Add non-rendering operation culling to DisplayListBuilder" (#41463) (flutter/engine#43831)
Fixes: https://github.com/flutter/flutter/issues/129862

This reverts commit 6237207218438748937fd4878c54884f83e66df2.

The framework test that was blocking the previous reland has been [fixed](https://github.com/flutter/flutter/pull/130751) to not rely on non-visible (cullable) operations.
2023-07-19 22:26:01 +00:00
skia-flutter-autoroll
c880af72b7 Roll Skia from bf75ae2f6eec to 8413c82dea43 (1 revision) (flutter/engine#43832)
https://skia.googlesource.com/skia.git/+log/bf75ae2f6eec..8413c82dea43

2023-07-19 johnstiles@google.com Fix overflow in matrix-multiply constant folding.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 22:13:10 +00:00
skia-flutter-autoroll
4334052623 Roll Skia from b1d6eab1f590 to bf75ae2f6eec (2 revisions) (flutter/engine#43829)
https://skia.googlesource.com/skia.git/+log/b1d6eab1f590..bf75ae2f6eec

2023-07-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 616ec95a04fe to f3c508b81760 (4 revisions)
2023-07-19 johnstiles@google.com Fix assertion in inliner when makeSampler2D is used.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 21:25:36 +00:00
skia-flutter-autoroll
45078d09c3 Roll ANGLE from 4dcaad2a894d to 4515b270772e (2 revisions) (flutter/engine#43830)
4dcaad2a89..4515b27077

2023-07-19 m.maiya@samsung.com Account for implementations that support large gl_PointSize values
2023-07-19 phanquangminh217@gmail.com Vulkan: Make UtilsVk::copyImage copy YCbCr images properly

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC bdero@google.com,flutter-engine@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 21:22:41 +00:00
Loïc Sharma
5509e3b51f Add the 'affects: desktop' label to labeler.yml (flutter/engine#43827)
The desktop team uses the [`affects: desktop`](https://github.com/flutter/engine/pulls?q=is%3Aopen+label%3A%22affects%3A+desktop%22+sort%3Aupdated-desc) label to [triage](https://github.com/flutter/flutter/wiki/Triage#desktop-platforms-team-team-desktop) pull requests.
2023-07-19 21:01:57 +00:00
skia-flutter-autoroll
34106734af Roll Skia from 30d458aea0b9 to b1d6eab1f590 (2 revisions) (flutter/engine#43826)
https://skia.googlesource.com/skia.git/+log/30d458aea0b9..b1d6eab1f590

2023-07-19 jmbetancourt@google.com [skottie] plumb vec2 support to SlotManager
2023-07-19 jmbetancourt@google.com [skottie] move color slot tracking to bind call

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 20:36:13 +00:00
skia-flutter-autoroll
21598967c0 Roll Skia from 650c980daa72 to 30d458aea0b9 (1 revision) (flutter/engine#43825)
https://skia.googlesource.com/skia.git/+log/650c980daa72..30d458aea0b9

2023-07-19 bungeman@google.com Roll HarfBuzz from 49c52fa9 to f94508ed (171 commits)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 19:17:26 +00:00
skia-flutter-autoroll
9f8a1e43a1 Roll Fuchsia Mac SDK from Iqf3gYJ8Vkq8k8l3O... to 7kGBjmX-zBXcg1svE... (flutter/engine#43823)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 18:46:31 +00:00
Jim Graham
8d73d38291 fix handling of clipped rendering inside a layer that applies a filter (flutter/engine#43787)
When a saveLayer is rendered with an ImageFilter that modifies the bounds of the rendered pixels, and some of the content of that saveLayer did not intersect the clip, but the filtered output of that content did intersect the clip, we might not accumulate the bounds of those rendering operations into the DisplayList bounds.

This bug was not encountered during practical testing, but showed up on some testing with the new NOP culling code.

For now, this bug only affects the accuracy of the reported bounds of the DisplayList, but that can affect raster caching and potentially the layer culling done in the LayerTree. It might also affect the accuracy of the RTree associated with the DisplayList, which would only show up in rare circumstances when the indicated operation was used in the presence of an embedded view.
2023-07-19 18:40:31 +00:00
skia-flutter-autoroll
017f0f9085 Roll Skia from 8d19d04472e1 to 650c980daa72 (6 revisions) (flutter/engine#43821)
https://skia.googlesource.com/skia.git/+log/8d19d04472e1..650c980daa72

2023-07-19 jvanverth@google.com [GL] Restrict setMaxLevel mipmap fix
2023-07-19 michaelludwig@google.com Consolidate SkImage::makeWithFilter implementations
2023-07-19 cmumford@google.com Revert "[infra] Add rule to build final debugger-app image"
2023-07-19 aeubanks@google.com Fix newly warned -Wconstant-logical-operand
2023-07-19 bungeman@google.com Roll FreeType from e4586d96 to 5769f13a (9 commits)
2023-07-19 brianosman@google.com Remove gltestthreading config

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 18:38:54 +00:00
skia-flutter-autoroll
1ce6162432 Roll Dart SDK from a013e7bf089e to 936824d49aa7 (1 revision) (flutter/engine#43820)
https://dart.googlesource.com/sdk.git/+log/a013e7bf089e..936824d49aa7

2023-07-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-327.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 18:37:24 +00:00
skia-flutter-autoroll
07e8e186cb Roll Skia from a352521a3a7c to 8d19d04472e1 (1 revision) (flutter/engine#43818)
https://skia.googlesource.com/skia.git/+log/a352521a3a7c..8d19d04472e1

2023-07-19 kjlubick@google.com Use mirror instead of github directory for libavif dep

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 17:37:32 +00:00
skia-flutter-autoroll
8eb6250802 Roll Skia from 4728980564b1 to a352521a3a7c (3 revisions) (flutter/engine#43816)
https://skia.googlesource.com/skia.git/+log/4728980564b1..a352521a3a7c

2023-07-19 nigeltao@google.com Roll third_party/wuffs to version 0.3.3
2023-07-19 johnstiles@google.com Enable inlining for runtime effects using SkRP.
2023-07-19 johnstiles@google.com Add instruction count to the top of SkRP dumps.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 16:57:53 +00:00
Brandon DeRosier
6bb9c99a11 [Impeller] Disable color attachment on clip pipelines for Metal & Vulkan. (flutter/engine#43781)
Remove the color attachment completely in Metal and Vulkan clips.

When the color write mask is set to all false, Metal is smart about not
executing the fragment shader at all, but some Vulkan and GL drivers may
not be. GL requires binding shader objects to draw, and so a cap check
is needed here.

In the future, we could add minimal no-op shaders to use with the GL
clip pipeline to shave off a few flops on drivers that aren't smart
about the color write mask.
2023-07-19 09:57:50 -07:00
skia-flutter-autoroll
b57e61a61f Roll Skia from 16475d7aa315 to 4728980564b1 (1 revision) (flutter/engine#43815)
https://skia.googlesource.com/skia.git/+log/16475d7aa315..4728980564b1

2023-07-19 cmumford@google.com [infra] Add rule to build final debugger-app image

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 15:52:01 +00:00
Jason Simmons
a4e0000a77 Apply the offset to the child bounds of an ImageFilterLayer with no filter (flutter/engine#43783)
Fixes https://github.com/flutter/flutter/issues/130318
2023-07-19 15:15:02 +00:00
skia-flutter-autoroll
885df86099 Roll Skia from 1f175b7a2155 to 16475d7aa315 (1 revision) (flutter/engine#43812)
https://skia.googlesource.com/skia.git/+log/1f175b7a2155..16475d7aa315

2023-07-19 cmumford@google.com [bazel] Add skia_app_container macro

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 15:09:03 +00:00
skia-flutter-autoroll
0013a53d42 Roll Skia from e9409b832799 to 1f175b7a2155 (1 revision) (flutter/engine#43811)
https://skia.googlesource.com/skia.git/+log/e9409b832799..1f175b7a2155

2023-07-19 robertphillips@google.com [graphite] Add initial precompilation fuzzer

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 14:32:04 +00:00
skia-flutter-autoroll
a2ab2e8980 Roll Fuchsia Linux SDK from ZABO4Om1vToxhI394... to -SNz0augjLKFVsUWn... (flutter/engine#43810)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 12:44:27 +00:00
Kevin Lubick
c4494c9718 Update legacy call to SkImage::makeSubset (flutter/engine#43786)
In https://skia-review.googlesource.com/c/skia/+/671679 Skia updated the
calls to SkImage::makeSubset() to always need a `GrDirectContext*`. This
updates Flutter's one call that needed it.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-07-19 08:26:05 -04:00
skia-flutter-autoroll
a579257e60 Roll ANGLE from 255dec886475 to 4dcaad2a894d (1 revision) (flutter/engine#43809)
255dec8864..4dcaad2a89

2023-07-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 151fa797ee3e to 4e401427f8dd (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC bdero@google.com,flutter-engine@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 11:37:47 +00:00
skia-flutter-autoroll
c7256139cb Roll Skia from c03050eb2b65 to e9409b832799 (1 revision) (flutter/engine#43808)
https://skia.googlesource.com/skia.git/+log/c03050eb2b65..e9409b832799

2023-07-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f0752efcbdb2 to 616ec95a04fe (10 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 11:04:54 +00:00
skia-flutter-autoroll
7bb0c3a44c Roll Dart SDK from 9f5e86b4c108 to a013e7bf089e (1 revision) (flutter/engine#43805)
https://dart.googlesource.com/sdk.git/+log/9f5e86b4c108..a013e7bf089e

2023-07-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-326.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 08:55:04 +00:00
skia-flutter-autoroll
8063414731 Roll ANGLE from b32d661389a6 to 255dec886475 (1 revision) (flutter/engine#43804)
b32d661389..255dec8864

2023-07-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 8806dade91f0 to e3bcada48f45 (580 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC bdero@google.com,flutter-engine@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 08:35:06 +00:00
Jason Simmons
a4d8601b57 Fix the rules for determining whether a blur image filter is valid (flutter/engine#43791)
See https://github.com/flutter/flutter/issues/130318
2023-07-19 07:14:06 +00:00
skia-flutter-autoroll
06181865d4 Roll Skia from 035b12a03918 to c03050eb2b65 (1 revision) (flutter/engine#43802)
https://skia.googlesource.com/skia.git/+log/035b12a03918..c03050eb2b65

2023-07-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from ec2948c5ed1e to b32d661389a6 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 07:06:06 +00:00
skia-flutter-autoroll
d1866abd24 Roll Skia from 9062ca6a691c to 035b12a03918 (3 revisions) (flutter/engine#43801)
https://skia.googlesource.com/skia.git/+log/9062ca6a691c..035b12a03918

2023-07-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from c10b5129407a to 55a98e279ec6
2023-07-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 0733bf3a7728 to c10b5129407a (7 revisions)
2023-07-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 151fa797ee3e to 4e401427f8dd (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 06:16:11 +00:00
skia-flutter-autoroll
28613fc7c4 Roll Fuchsia Mac SDK from SCshjyIlymHWD9W4D... to Iqf3gYJ8Vkq8k8l3O... (flutter/engine#43800)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 06:08:00 +00:00
skia-flutter-autoroll
9dd13cb324 Roll Skia from caf0d191bd07 to 9062ca6a691c (1 revision) (flutter/engine#43799)
https://skia.googlesource.com/skia.git/+log/caf0d191bd07..9062ca6a691c

2023-07-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 937670a0ed00 to beaf20f90f1b (19 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 05:22:22 +00:00
skia-flutter-autoroll
2a77fee2f6 Roll Dart SDK from c184cac2d22f to 9f5e86b4c108 (1 revision) (flutter/engine#43798)
https://dart.googlesource.com/sdk.git/+log/c184cac2d22f..9f5e86b4c108

2023-07-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-325.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 05:12:12 +00:00
skia-flutter-autoroll
5b21331b85 Roll Skia from d1d2b623799e to caf0d191bd07 (1 revision) (flutter/engine#43797)
https://skia.googlesource.com/skia.git/+log/d1d2b623799e..caf0d191bd07

2023-07-19 brianosman@google.com Ignore failing test on IntelIrisXe + Vulkan

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 03:25:03 +00:00
skia-flutter-autoroll
b89c4af229 Roll ANGLE from 6eea5ff4db82 to b32d661389a6 (1 revision) (flutter/engine#43796)
6eea5ff4db..b32d661389

2023-07-19 angle-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from aa35b58fce7d to 831910dbe1f3 (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC bdero@google.com,flutter-engine@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 02:25:02 +00:00
skia-flutter-autoroll
ce0e083536 Roll Skia from 280fb8391187 to d1d2b623799e (1 revision) (flutter/engine#43795)
https://skia.googlesource.com/skia.git/+log/280fb8391187..d1d2b623799e

2023-07-19 michaelludwig@google.com [skif] Implement image delegate for graphite

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 02:04:06 +00:00
skia-flutter-autoroll
d13c63c2ff Roll Dart SDK from ec95774043ec to c184cac2d22f (1 revision) (flutter/engine#43794)
https://dart.googlesource.com/sdk.git/+log/ec95774043ec..c184cac2d22f

2023-07-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-324.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-19 01:22:27 +00:00
Zachary Anderson
d84cf41f4f Increase engine v2 orchestrator timeouts (flutter/engine#43788)
This PR increases orchestrator timeouts to avoid the case where subjobs that are making progress after a long queue time may be needlessly cancelled if the orchestrator runs over a too-small timeout.
2023-07-18 23:44:11 +00:00
skia-flutter-autoroll
da93805e6c Roll Skia from dcc56df202cc to 280fb8391187 (1 revision) (flutter/engine#43793)
https://skia.googlesource.com/skia.git/+log/dcc56df202cc..280fb8391187

2023-07-18 lovisolo@google.com [bazel] //gm/BUILD.bazel and cc_test_with_flags: Fix broken targets.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-18 22:52:11 +00:00
Zachary Anderson
562a5764b0 Remove obsolete legacy engine builds from staging (flutter/engine#43790)
These builds have had engine v2 variants running for nearly a quarter or
more in most cases, and they are now not serving much of a purpose.
Additionally, during MTV peak hours, queue times and therefore overall
cycle times are getting too long, and we should be freeing up these
resources.
2023-07-18 15:22:11 -07:00