12885 Commits

Author SHA1 Message Date
Todd Volkert
0c9c293b56
Add Rect.fromCenter() constructor (#8716) 2019-04-25 14:40:29 -07:00
skia-flutter-autoroll
74abe2965b
Roll src/third_party/skia 8413ff13fefa..b14574924ab3 (4 commits) (#8745)
https://skia.googlesource.com/skia.git
/%2Blog/8413ff13fefa..b14574924ab3

git log 8413ff13fefa1e88cd3fc67ebaed87c9eb3419c7..b14574924ab332c1b6ce9afabdc03820540aab1e --date=short --no-merges --format=%ad %ae %s
2019-04-25 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-04-25 brianosman@google.com Turn off warnings as errors in SwiftShader
2019-04-25 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-04-25 csmartdalton@google.com Revert "ccpr: Set atlas proxy size to draw bounds rather than backing size"

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (mtklein@google.com), and stop
the roller if necessary.
2019-04-25 17:13:24 -04:00
Ben Konyi
95fd36cad3 Roll src/third_party/dart 1f1592edce..e70273c306 (78 commits)
e70273c306 Issue 36733. Completion in spread, if, and for elements.
d0b236c319 [dart/fuzzer] restrict stmt depth and length
ccf7eac86d [vm, jit] Make unoptimized instance calls compatible with megamorphic calls.
bba0be2797 Rework type parameters, use correct enclosing element / reference.
317a075d93 [vm] Fix DEGUG typo and a few other bugs it was hiding.
05d33b1240 Add WorkspacePackage support for InSummarySource sources
eeb7a92b21 Pass the authentication code when fetching timeline and CPU profile data
76c6b86915 Revert "[Infra] Let run_vm_tests --list output a test expectation marker"
9238e25305 Revert "[vm] Finish adding support for ECMAScript 2018 features."
000a3eb3f7 Add completion support for late and required
4da31564cb Fix the placement of late in two tests
7cb73d97d2 [Infra] Let run_vm_tests --list output a test expectation marker
a3c19d4ffc [vm/compiler] Move inlining/intrinsics pipeline passes to compiler_pass.h
5fc8029587 Remove StaticMemberUsage and cleanup codegen world builder
a0a51a7cde Resynthesize fields.
3fd6fa4ff7 [vm] Fix errors compiling with GCC.
225516466f [vm, interpreter] noSuchMethod dispatchers as a bytecode.
f3bd910e10 Only use MapFormatter for SDK maps (HashMap and LinkedHashMap)
f82000dfb1 pre-nnbd modifier as identifier tests
f3e86852de Fix the order of arguments when composing an error message (issue 36732)
f04cac8fbd Implement inheritsCovariant.
2cadc90ec5 Add summary support for isLate
a28d5e7a0f Rework reportTypeErrorForNode() to work even when FunctionType does not have an element.
f7c67ee927 [dart/vm] Use EvenSRegisterOf() instead of unclear cast
e7175ac2ed [vm, fuchsia] Consume specialized symbols for the Dart VM's profiler.
91e9962699 Don't report libraries that became parts as changed libraries.
ec09fab85a Create elements for @prefix in LInkedElementFactory.
2c77aae6b3 Support for LibraryElementImpl.hasExtUri
e6260f67b3 [dart/fuzzer] Remove hashCode from API table
c3e7859035 Store raw elements for parameters.
e429cba1ec [vm] Change FpuTMP to XMM15/XMM7 on X64/IA32.
9a03c94d36 Clean up ParseBase's use of AnalysisOptions.experimentStatus
0c5199d467 Wrapper script for running ABI tests
c5e57cc078 Plumb FeatureSet through resolver
296505e2e3 Sort declarations in pkg/analyzer/test/generated/parser_test.dart
ed984b6985 Sort declarations in pkg/analyzer/test/dart/ast/ast_test.dart
8516ad8256 Sort declarations in pkg/analyzer/lib/src/dart/sdk/sdk.dart
efd1ccb31a Modify the MOVE_FILE refactoring support to be passed a resolved unit like other refactorings.
43e26c2de9 Add highlight support for late and required
e42c5d12fe Cleanup tests by removing references to enabled experiments and by reducing duplication
663919e361 [vm] Free error if embedder failed to start service isolate
650cd2ed1d [gardening] Fix multitest comments on this file.
5ebb640a67 [vm] Finish adding support for ECMAScript 2018 features.
c4ab0d2014 Inline create methods in JsKernelToElementMap
446c6754d6 Fix runtime type error in Swarm
db8f0090a5 Separate mixins into @mixin, build GenericTypeAlias.
d6a09ff02f Prepare to publish analyzer version 0.36.2
07017d33a6 pkg/analyzer_plugin: support the latest pkg:analyzer
9af0574287 Remove unused import
2eb36e8879 [dart/vm] What's in a (register) name?
b5769936a9 Perform mixin inference during types building.
d06121ea89 [vm/compiler] Remove AbortBackgroundCompilation from guard instructions
4624419736 Support UI-as-code in deprecated parse functions.
ca9bbd39d5 [dartdevc] Remove ddc and ddk pre-compiled "legacy" sdk modules
e695bc3c6d Record type inference errors for fields and parameters.
174395a49e NNBD "late" modifier language_2 tests
7c18fc0c3d Revert "[gardening] Mark ffi/function_stress_test/1 test as slow."
2c4dc7a431 Support targetting flutter and flutter_runner in kernel_worker
2298712d62 [vm] fix position of DebugStepCheck when building break statement in flowgraph
c66a67c4a3 Rename isLazy to isLate to reflect change in keyword
ab7e9500c7 [vm, arm64] Fix some assertions.
b9be35b3fc Perform override and initializer inference at the same time when required.
34f0bed189 Use the correct syntax for null-aware spread in CHANGELOG.
04e1b0d976 [ VM ] Updated standalone VM to display message about --disable-service-auth-codes when --help --verbose is provided.
688f029c4f Rename workspace to refactoringWorkspace in move_file.dart to clarify the type of the object.
7388c3e3db [gardening] Mark ffi/function_stress_test/1 test as slow.
594a0ef7a7 Perform instantiateToBounds() even for not simply bounded types.
b4d17f2eee Add diagnostics related to default values
dbfcb97fa5 [dart/vm]: sometimes a smi is just a smi
cee1e41fe8 Plumb new FeatureSet class into Scanner.
293c0f42f7 NNBD "required" modifier language_2 tests
bb2a3ca6f6 Plumb FeatureSet into ConstantVerifier
81b028de78 cleanup some error codes
80d4b9a5db [vm/frontend_server] Expose protobuf aware tree shaker in frontend server
b7375d0360 Nit: convert singular tab into spaces in test_matrix.json.
a58aa6f705 Fix NoSuchMethodError in observatory when setting breakpoint via debugger console
86fe7ca75c Fix build when python=python3
475c918f0a [infra] Run analyzer unit tests only on analyzer builders
2019-04-25 16:54:19 -04:00
Kaushik Iska
7471ddea46
Limit the size of VirtualDisplay we create in android (#8704)
- This can cause phones to restart as documented in https://github.com/flutter/flutter/issues/28978
2019-04-25 13:44:45 -07:00
skia-flutter-autoroll
8edfaea973
Roll src/third_party/skia 10d172169f2d..8413ff13fefa (10 commits) (#8741)
https://skia.googlesource.com/skia.git
/%2Blog/10d172169f2d..8413ff13fefa

git log 10d172169f2d2184d407632276352b401e4111da..8413ff13fefa1e88cd3fc67ebaed87c9eb3419c7 --date=short --no-merges --format=%ad %ae %s
2019-04-24 mtklein@google.com SKIA_IMPLEMENTATION is only relevant in shared builds
2019-04-25 fmalita@chromium.org [skottie] Parented camera support
2019-04-25 brianosman@google.com Add SkSL editing to Viewer in Vulkan backend
2019-04-25 brianosman@google.com Blacklist GL processor tests on GalaxyS6, too
2019-04-25 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-04-25 fmalita@chromium.org [skottie] Fix camera z-rotation
2019-04-25 brianosman@google.com Normalize storage of shader strings in the cache
2019-04-24 halcanary@google.com Experimental: text editor
2019-04-25 brianosman@google.com Blacklist GL processor tests on low-end Android devices
2019-04-25 mtklein@google.com roll libpng to pre-1.6.38

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (mtklein@google.com), and stop
the roller if necessary.
2019-04-25 13:41:24 -04:00
Zachary Anderson
3a29e6a7a7
Plumb arguments from Settings to Dart main() (#8710) 2019-04-25 07:57:54 -07:00
skia-flutter-autoroll
e44c5d99c9
Roll src/third_party/skia 2444c0e9aa23..10d172169f2d (1 commits) (#8740)
https://skia.googlesource.com/skia.git
/%2Blog/2444c0e9aa23..10d172169f2d

git log 2444c0e9aa23e28e866b1cea700d3f9699ae013b..10d172169f2d2184d407632276352b401e4111da --date=short --no-merges --format=%ad %ae %s
2019-04-24 robertphillips@google.com Remove GrInternalSurfaceFlags::kNoPendingIO as it is no longer needed

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (mtklein@google.com), and stop
the roller if necessary.
2019-04-25 10:09:25 -04:00
Dan Field
1a8534cb93
Revert "Increase the memory usage estimate for EngineLayer (#8700)" (#8738)
This reverts commit 30fb4a697724061ffa8f44ed42d5fc9fff968566.
2019-04-25 06:55:31 -07:00
skia-flutter-autoroll
d2703b4eeb
Roll src/third_party/skia a1ab899e9e3f..2444c0e9aa23 (2 commits) (#8739)
https://skia.googlesource.com/skia.git
/%2Blog/a1ab899e9e3f..2444c0e9aa23

git log a1ab899e9e3f842825a342ee41863146e2ae86e4..2444c0e9aa23e28e866b1cea700d3f9699ae013b --date=short --no-merges --format=%ad %ae %s
2019-04-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 62e274e86c7e..1b0acbb5126e (7 commits)
2019-04-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 7d439e099c7a..ea73ef568188 (418 commits)

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (mtklein@google.com), and stop
the roller if necessary.
2019-04-25 03:49:25 -04:00
skia-flutter-autoroll
0f47ab6653
Roll src/third_party/skia 46d0f9aad1e6..a1ab899e9e3f (2 commits) (#8737)
https://skia.googlesource.com/skia.git
/%2Blog/46d0f9aad1e6..a1ab899e9e3f

git log 46d0f9aad1e68b90774315ad09abe55dd8fe2fd9..a1ab899e9e3f842825a342ee41863146e2ae86e4 --date=short --no-merges --format=%ad %ae %s
2019-04-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-04-24 fmalita@chromium.org [skottie] Fix 3d rotation order

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (mtklein@google.com), and stop
the roller if necessary.
2019-04-25 00:17:24 -04:00
skia-flutter-autoroll
26b30a4646
Roll src/third_party/skia 9adc82c73df0..46d0f9aad1e6 (41 commits) (#8736)
https://skia.googlesource.com/skia.git
/%2Blog/9adc82c73df0..46d0f9aad1e6

git log 9adc82c73df0ef25b708cae8aa48ef9c39ed4c67..46d0f9aad1e68b90774315ad09abe55dd8fe2fd9 --date=short --no-merges --format=%ad %ae %s
2019-04-24 csmartdalton@google.com ccpr: Set atlas proxy size to draw bounds rather than backing size
2019-04-18 bungeman@google.com Use linear metrics flag for linear metrics.
2019-04-24 mtklein@google.com cut SK_SAMPLES_FOR_X, simplify SK_?32_SHIFT
2019-04-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-04-24 mtklein@google.com flip static initializer default
2019-04-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-04-24 benjaminwagner@google.com [recipes] Fix Windows pathsep; add Windows tests
2019-04-24 mtklein@google.com AFAICT, only gm/etc1 uses third_party/etc1
2019-04-24 robertphillips@google.com Change flushing policy in GrContextPriv::writeSurfacePixels
2019-04-24 reed@google.com add gm/bench for runtime colorfilter
2019-04-24 mtklein@google.com update GL interface codegen
2019-04-24 ethannicholas@google.com minor interpreter cleanups
2019-04-24 mtklein@google.com I think we've made it past this intern demo.
2019-04-23 mtklein@google.com rewrite includes to not need so much -Ifoo
2019-04-24 halcanary@google.com SkTInternalLList: remove SkPtrWrapper, SkNoncopyable
2019-04-24 robertphillips@google.com Implement alternate method for determining recycle-ability of allocated GrSurfaces (take 2)
2019-04-24 mtklein@google.com move SK_ENABLE_DISCRETE_GPU to cover only tools
2019-04-24 bsalomon@google.com Use tasks for GrVkGpuTextureCommandBuffer.
2019-04-24 reed@google.com rm older api from colormatrix, change to normalized translate
2019-04-24 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset
2019-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 cff6f150eae1..62e274e86c7e (2 commits)
2019-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 707ed9974cb3..a161493942fa (9 commits)
2019-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 29e17ed23dea..7d439e099c7a (412 commits)
2019-04-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-04-23 reed@google.com (start to) explicitly use float for color values
2019-04-23 bsalomon@google.com Store tasks to execute before VK secondary command buffers generically.
2019-04-23 mtklein@google.com make -Werror or /WX optional, off by default
2019-04-23 mtklein@google.com fix sk_colorspace include guard
2019-04-23 reed@google.com remove dead function MakeSingleChannelOutput
2019-04-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-04-23 mtklein@google.com sort, dedup skia_public_includes
2019-04-23 mtklein@google.com inject SkUserConfig.h with -DSK_USER_CONFIG_HEADER
2019-04-23 mtklein@google.com another stray <include> -> ""
2019-04-23 ethannicholas@google.com added support for interpreting generic SkSL functions
2019-04-23 mtklein@google.com are these include paths no longer needed?
2019-04-23 herb@google.com Only call findImage when needed
2019-04-23 mtklein@google.com switch some idiosyncratic <includes> to ""
2019-04-23 robertphillips@google.com Revert "Implement alternate method for determining recycle-ability of allocated GrSurfaces"
2019-04-23 reed@google.com change colormatrixfilter to be 0...1 for translate
2019-04-22 jvanverth@google.com Add GrMtlCommandBuffer
2019-04-23 halcanary@google.com Make default SkUserConfig a noop

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (mtklein@google.com), and stop
the roller if necessary.
2019-04-24 20:51:24 -04:00
Chris Bracken
fdd8fdbf40
Fix reflective ctor invocation in FlutterFragment (#8735)
Class.newInstance() propagates any exception thrown by the nullary
constructor, including a checked exception. This effectively bypasses
the compile-time exception checking that would otherwise be performed by
the compiler. The Constructor.newInstance method avoids this problem by
wrapping any exception thrown by the constructor in a (checked)
InvocationTargetException.
2019-04-24 17:50:19 -07:00
David Worsham
a56aa95e80
[scenic] Purge references to Mozart (#8712)
We also rename all MZ-* bugs to SCN-*.

SCN-580 #comment
2019-04-24 12:26:25 -07:00
Brian Osman
e4c439d370
Fix include paths in libtxt to prepare for upcoming Skia build change (#8723)
* Fix include paths in libtxt to prepare for upcoming Skia build change

Red test results are due to a different change. This PR fixes compile issues on the Skia side, and ensures that the next Skia -> Flutter roll can land properly.
2019-04-24 13:50:21 -04:00
liyuqian
7c8ec376ff
Document that OpacityLayer's children are nonempty (#8707)
See https://github.com/flutter/flutter/issues/31517
2019-04-23 15:02:57 -07:00
Jason Simmons
30fb4a6977
Increase the memory usage estimate for EngineLayer (#8700)
EngineLayers can hold references to Skia objects and may consume significant
resources.  This change will result in more aggressive cleanup of EngineLayers
by the Dart GC.

See https://github.com/flutter/flutter/issues/31303
2019-04-23 13:25:08 -07:00
Dan Field
3e47b4bb39
Reland const Rect/RRect (#8695) 2019-04-23 11:21:03 -07:00
Brian Osman
098ada5398
Convert animated unpremul images to premul during decode (#8698)
Skia allows drawing unpremul images, but filtering them can look bad.
Internally Skia performs this transformation when creating SkImages from
encoded data (so this already happens for MakeCrossContextFromEncoded),
and for consistency/quality it should be done here, too.

Fixes #28785
2019-04-23 13:47:23 -04:00
skia-flutter-autoroll
c63d1cf9c9
Roll src/third_party/skia 7ecad8791ff1..9adc82c73df0 (4 commits) (#8699)
https://skia.googlesource.com/skia.git/%2Blog/7ecad8791ff1..9adc82c73df0

git log 7ecad8791ff10646d05b74393f1e026e3f6aad7c..9adc82c73df0ef25b708cae8aa48ef9c39ed4c67 --date=short --no-merges --format=%ad %ae %s
2019-04-23 reed@google.com Fixes for saveBehind/drawBehind
2019-04-23 robertphillips@google.com Implement alternate method for determining recycle-ability of allocated GrSurfaces
2019-04-23 mtklein@google.com rename gamma stage gamma_
2019-04-23 robertphillips@google.com Remove the option of disabling explicit resource allocation

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (mtklein@google.com), and stop
the roller if necessary.
2019-04-23 11:37:26 -04:00
skia-flutter-autoroll
62655b36e2
Roll src/third_party/skia f153e221140a..7ecad8791ff1 (1 commits) (#8697)
https://skia.googlesource.com/skia.git/%2Blog/f153e221140a..7ecad8791ff1

git log f153e221140adb32b91cbbc45e1f05d08f4fee0c..7ecad8791ff10646d05b74393f1e026e3f6aad7c --date=short --no-merges --format=%ad %ae %s
2019-04-23 mtklein@google.com add third_party/skcms to includes

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (mtklein@google.com), and stop
the roller if necessary.
2019-04-23 08:04:24 -04:00
skia-flutter-autoroll
45a9d36c46
Roll src/third_party/skia 977b16d9c978..f153e221140a (3 commits) (#8696)
https://skia.googlesource.com/skia.git/%2Blog/977b16d9c978..f153e221140a

git log 977b16d9c978f85007613cd0ed05eef6ad0e169e..f153e221140adb32b91cbbc45e1f05d08f4fee0c --date=short --no-merges --format=%ad %ae %s
2019-04-23 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset
2019-04-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 c467f7b54188..cff6f150eae1 (1 commits)
2019-04-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 3ed0f75776bb..29e17ed23dea (265 commits)

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (mtklein@google.com), and stop
the roller if necessary.
2019-04-23 04:32:24 -04:00
skia-flutter-autoroll
e27c867c30
Roll src/third_party/skia 731ba99a8581..977b16d9c978 (5 commits) (#8694)
https://skia.googlesource.com/skia.git/%2Blog/731ba99a8581..977b16d9c978

git log 731ba99a8581cb81978e8217d210309880558b09..977b16d9c978f85007613cd0ed05eef6ad0e169e --date=short --no-merges --format=%ad %ae %s
2019-04-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader bcc71a322953..707ed9974cb3 (3 commits)
2019-04-22 brianosman@google.com Add skcms directory to public includes
2019-04-22 egdaniel@google.com Add wait function on GrContext to wait on semaphores.
2019-04-22 jvanverth@google.com More buffer changes for Metal.
2019-04-21 reed@google.com hide internals of SkColorMatrix (so we can migrate to col-major)

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (mtklein@google.com), and stop
the roller if necessary.
2019-04-23 01:05:24 -04:00
Ben Konyi
e1680c1e43 Roll src/third_party/dart cf4444b803..1f1592edce (49 commits)
1f1592edce Add manifest checks for touchscreen feature
630058286f [build] Fix deps for dart_io.
5ee20c99ac [vm/aot/tfa] Workaround for crash in getStaticType
2c304d997f [dartdevc] fix #36372, make JS Array constructor property usable from JS
ef9c25c08b Support codeOffset/Length for CompilationUnit and other nodes.
80bed430c8 Extract AnalysisDriver tests that work with summary1 into a separate test class.
39662f8108 Set ElementAnnotation for directives.
c7279d347b Always lazy create TypeParameterTypeImpl.
27b64953d5 Fixes for applying resolution for fields metadata.
385406ac92 Give LinkedElementFactory its AnalysisSession, fixes for nameOffset.
8b6d04b2ee sort tests
c89e71cd40 The default return type for []= is void.
971f4845d7 [build] Remove last platform -> vm and bin -> vm dependencies. Fix some ODR violations.
3aef424c9c Always add imported / exported files, even if they are parts.
e7a54a9759 Support for TokenType.GT_GT_GT
ec79fc2ff4 update AstBuilder to process "late" modifier
390ba6925d Allow nnbd to be enabled in tests
d1b675055c Read all GenericFunctionType(s) and TypeParameter(s) is lazy AST before reading eager AST.
17db9f986a Simplify type tests in nullable_type_ambiguous_test.dart
dfa56c7031 [vm, interpreter] Invoke field as a bytecode.
2d6313c9e4 Prepare to publish analyzer version 0.36.1
4a33d33297 Store FeatureSet in CompilationUnit.
08832508ec Forward "late" modifier to parser listeners
449cdecda2 [vm/interpreter] Fix bytecode instruction formats in interpreter
6d9d95d938 Add GenericFunctionTypeImpl.declaredElement
fd48001ace Put NNBD modifiers behind a flag
a9b1d9e33b Splice resolved API nodes and unresolved function bodies.
38eed58f61 Fix hints in nullability migration code
d50232a3f5 Plumb new FeatureSet class into AstBuilder.
780f1b6c3e Remove unused imports
c3f822eae6 Attempt to fix failures on the windows bot
47a8ff60e1 Convert more analyzer unit tests
76f177a492 Use a non-null index for all features, even expired ones.
f5224b53e4 [dart_internal] Bump SDK constraint upper-bound to <2.4.0
3d1ca4ae39 Revert "[vm, interpreter] Invoke field as a bytecode."
c85631330d [vm, interpreter] Invoke field as a bytecode.
680744d169 Fix version number strings to always include a patch number.
cb4db33010 [vm/debugger] fix order of type arguments in debugger
1ecedb2341 Fix JsLinkedHashMap memory leak
af0fa108da Add support for required named parameters
a2e06eafff allow built-in keywords as identifier in for-in loop
63658b113c Proposed new API for tracking feature opt in/out
8924c18003 [vm/tests] Revert changes in pkg/vm unit tests after constant-update-2018 was disabled
aaa829695f Fix typo in CHANGELOG.md
78340fdf82 [vm] Support ListInterfaces for android
9e87c16677 Record TopLevelInferenceErrorKind.dependencyCycle in summary2.
3ae2ef7763 parse "late" modifier
b352b5ffb7 [vm, jit] The hottest Smi ops are + < == not + - ==.
3f477a6218 Consolidated CHANGELOG entry for 2.3.0.
2019-04-22 21:54:21 -07:00
Dan Field
0523870e0b
Add tests from framework (#8692) 2019-04-22 16:39:00 -07:00
Jason Simmons
ed1f3fd99f
Change Vertices.indices to use a Uint16 list to more accurately reflect Skia's API (#8657)
Also throw if SkVertices::Builder reports an invalid configuration.

Fixes https://github.com/flutter/flutter/issues/31270
2019-04-22 16:13:22 -07:00
Dan Field
4f2fd84cbc
Revert Rect/RRect 64 bit (#8690)
* Revert "fix toString (#8688)"

This reverts commit 9fa7336784b56ef70fd3580ac54d2939d1faa5a0.

* Revert "Make Rect and RRect use 64 bit doubles, and make them const-able (#8565)"

This reverts commit c12315273f6344175dae748ec1f23e15b4e7d59e.
2019-04-22 15:45:59 -07:00
Chinmay Garde
6dc5dcad32
Revert "Remove unused Settings::ToString. (#8642)" (#8689)
This reverts commit 4ead9c8f99d417c13bc8c51e6e90c66ec52045b6.

Reland tracked in https://github.com/flutter/flutter/issues/31433.
2019-04-22 14:31:33 -07:00
Dan Field
9fa7336784
fix toString (#8688) 2019-04-22 14:12:31 -07:00
Dan Field
c12315273f
Make Rect and RRect use 64 bit doubles, and make them const-able (#8565)
* Make Rect and RRect 64bit and const-able
2019-04-22 12:58:48 -07:00
skia-flutter-autoroll
934772dd87
Roll src/third_party/skia a76fad2d494a..731ba99a8581 (20 commits) (#8686)
https://skia.googlesource.com/skia.git/%2Blog/a76fad2d494a..731ba99a8581

git log a76fad2d494af8bde8c3fb34a2de2b359beebab1..731ba99a8581cb81978e8217d210309880558b09 --date=short --no-merges --format=%ad %ae %s
2019-04-22 mtklein@google.com deshard NP and N7 CPU test bots
2019-04-22 mtklein@google.com Revert &#34;simplify and centralize SK_API&#34;
2019-04-22 robertphillips@google.com Add explicit GrSurfaceProxy flag to skip explicit resource allocation (take 2)
2019-04-22 mtklein@google.com remove duplicate SkBase64.h
2019-04-22 mtklein@google.com rm src/compute
2019-04-22 borenet@google.com [docs] Update documentation for branching process
2019-04-11 mtklein@google.com simplify and centralize SK_API
2019-04-22 egdaniel@google.com Fully add back old GrContext flush api.
2019-04-15 mtklein@google.com add constexpr constructor to SkMatrix
2019-04-22 egdaniel@google.com Update comment on vulkan allocator.
2019-04-22 egdaniel@google.com Add back deprecated GrCotnext flush API till clients get fixed.
2019-04-19 brianosman@google.com Add SkSL viewing/editing to viewer
2019-04-22 mtklein@google.com Revert &#34;Add explicit GrSurfaceProxy flag to skip explicit resource allocation&#34;
2019-04-22 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset
2019-04-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 145ec7fa7c81..c467f7b54188 (4 commits)
2019-04-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader a16238df3f28..bcc71a322953 (7 commits)
2019-04-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src a55917cb9824..3ed0f75776bb (344 commits)
2019-04-21 reed@google.com use portable typeface for new gm
2019-04-21 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version
2019-04-21 rmistry@google.com Skip __init__.py in webpages_playback.py

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (mtklein@google.com), and stop
the roller if necessary.
2019-04-22 15:27:24 -04:00
Gary Qian
ea28bfa13e
Custom RTL handling for ghost runs, NotoNaskhArabic test font (#8683)
Relands #8638
2019-04-22 11:09:43 -07:00
liyuqian
1c9457cedc
Revert "Only allow mappings for ICU initialization. (#8656)" (#8682)
This reverts commit bd8c5b135e4d41842d0d5d42ff4943a18b8f4f0c.

Reverts flutter/engine#8656

Reason:  https://github.com/flutter/engine/pull/8656 seems to break the framework windows tests and the engine roll (see https://cirrus-ci.com/task/4704667236827136 and https://github.com/flutter/flutter/pull/31330). The failure has been consistent for 7 consecutive engine-to-framework auto-rolls.

TBR: @chinmaygarde
2019-04-22 10:28:54 -07:00
liyuqian
b4ed3039fa
Revert "RTL handling for ghost runs, NotoNaskhArabic test font (#8638)" (#8681)
This reverts commit 6e79dcd0cfd9df08b4240a5aa158659c34e4154f.

Reverts flutter/engine#8638

Reason: flutter/engine#8638 breaks the post-submit Cirrus tests. See https://cirrus-ci.com/build/5143341531398144 and subsequent post-submit failures. Specifically, ParagraphTest.RightAlignParagraph is failing.

TBR: @GaryQian
2019-04-22 10:18:32 -07:00
Stanislav Baranov
8b5f77630f
Remove support for downloading dynamic patches. (#8663) 2019-04-22 09:05:06 -07:00
liyuqian
1bcb96bf3d
Add framework test in engine presubmit checks (#8664)
With this, no Skia or Dart roll (or any other engine commit) would accidentally break the framework.

For commits that require manual engine-to-framework rolls, the `build_and_test_host` test would fail. In such cases, the author should explicitly mention **"merge on red as the failure is expected; the engine will be manually rolled into the framework"**.
2019-04-21 11:04:37 -07:00
Gary Qian
6e79dcd0cf
RTL handling for ghost runs, NotoNaskhArabic test font (#8638) 2019-04-21 00:30:53 -07:00
skia-flutter-autoroll
c37d459819
Roll src/third_party/skia 1c0b05afdef8..a76fad2d494a (4 commits) (#8665)
https://skia.googlesource.com/skia.git/%2Blog/1c0b05afdef8..a76fad2d494a

git log 1c0b05afdef8c0366926d3a5cdbe828ff122cfe2..a76fad2d494af8bde8c3fb34a2de2b359beebab1 --date=short --no-merges --format=%ad %ae %s
2019-04-21 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset
2019-04-20 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset
2019-04-18 jvanverth@google.com Add Metal support for dynamic buffers.
2019-04-19 reed@google.com Add secret draw-behind method

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (mtklein@google.com), and stop
the roller if necessary.
2019-04-21 02:15:49 -04:00
Chinmay Garde
2e4f0a4a72
Put the testing lib in the flutter namespace. (#8661) 2019-04-20 20:42:46 -07:00
Chinmay Garde
1239df96aa
Allow native bindings in secondary isolates. (#8658)
The callbacks can be wired in via the Settings object. Both runtime and shell unit-tests have been patched to test this.
2019-04-19 17:36:36 -07:00
Matthew Dempsky
b0cbce4175 Replace ThreadLocal with ThreadLocalUniquePtr<T> (#8659)
Fixes https://github.com/flutter/flutter/issues/31292.
2019-04-19 17:33:46 -07:00
Chinmay Garde
bd8c5b135e
Only allow mappings for ICU initialization. (#8656)
If the mapping callback is not set or it the callback returns invalid data, ICU initialization will be embedder responsibility.

This affects all embedders and the following have been audited:
* Android: Via a symbol mapping.
* iOS: Via a file mapping.
* Embedder: Via a file mapping.
* Fuchsia: Via a VMO mapping
* Test shells and Flutter tester: Via file mapping with ICU data needing to be next to the executable.
2019-04-19 15:01:40 -07:00
skia-flutter-autoroll
206cab6e70
Roll src/third_party/skia cc5d3e09e394..1c0b05afdef8 (14 commits) (#8654)
https://skia.googlesource.com/skia.git/%2Blog/cc5d3e09e394..1c0b05afdef8

git log cc5d3e09e39410841ba6e8866680257a92ee5205..1c0b05afdef8c0366926d3a5cdbe828ff122cfe2 --date=short --no-merges --format=%ad %ae %s
2019-04-19 bsalomon@google.com SkClipStack::isRRect succeeds if stack is  an intersection of rects.
2019-04-17 csmartdalton@google.com ccpr: Calculate edge coverage in the coverage processor
2019-04-19 ethannicholas@google.com Fixed internal skslc error with negated literal vectors
2019-04-19 egdaniel@google.com Adjust vulkan memory allocation block size knobs to better match the type of draws we do.
2019-04-17 ethannicholas@google.com reworked SPIR-V binary operations and added support for VectorTimesScalar
2019-04-19 robertphillips@google.com Add explicit GrSurfaceProxy flag to skip explicit resource allocation
2019-04-19 halcanary@google.com SkQP: new docker test code
2019-04-19 ethannicholas@google.com fixed Metal code generation for recursive functions
2019-04-19 michaelludwig@google.com Don&#39;t batch across domain modes in GrTextureOp
2019-04-19 brianosman@google.com Convexity checker: Wait for significant x-product when walking edges
2019-04-19 michaelludwig@google.com Update compositing benchmark to use image-set API
2019-04-18 csmartdalton@google.com ccpr: Indicate path fill type by winding direction of cover triangles
2019-04-19 ethannicholas@google.com added error detection for writing to a constant swizzle mask
2019-04-19 kjlubick@google.com [spec] Initial commit for web spec

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (herb@google.com), and stop
the roller if necessary.
2019-04-19 16:43:24 -04:00
Chinmay Garde
1fe3279149
Cleanup references to FLX archives from the engine. (#8653) 2019-04-19 12:49:07 -07:00
Chinmay Garde
6257dfeb53
Add factory methods to FileMapping that make it easy to create common mappings. (#8652)
The GetMapping calls removed in this patch had the same code and had to be repeated across different test harnesses as well as in dart_snapshot.cc. Just make this a factory method so the code is less verbose.
2019-04-19 12:48:53 -07:00
Vyacheslav Egorov
5fed725202
Roll buildroot to 380d0ed5c3399d5a2aaac4a66d98e3a3fda77c31 (#8649)
380d0ed Build host Dart binary with -march=core2 on Mac OS X. (#235)
2019-04-19 19:48:51 +02:00
skia-flutter-autoroll
eaa0e9c706
Roll src/third_party/skia e5763787f920..cc5d3e09e394 (3 commits) (#8651)
https://skia.googlesource.com/skia.git/%2Blog/e5763787f920..cc5d3e09e394

git log e5763787f920c0c3a30527a596a6c207eb1b220b..cc5d3e09e39410841ba6e8866680257a92ee5205 --date=short --no-merges --format=%ad %ae %s
2019-04-19 ethannicholas@google.com Revert &#34;Revert &#34;added more SPIR-V RelaxedPrecision decorations&#34;&#34;
2019-04-19 reed@google.com use char-to-glyph cache in freetype typeface
2019-04-19 brianosman@google.com Remove SK_TREAT_COLINEAR_DIAGONAL_POINTS_AS_CONCAVE

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (herb@google.com), and stop
the roller if necessary.
2019-04-19 13:15:04 -04:00
Chinmay Garde
7e37080ec0
Allow specifying the Mac SDK path as an environment variable to //flutter/tools/gn (#8643)
As long as the Mac SDK is i386 ready, engine developers should be able to use the latest version of Xcode to build all artifacts. This issue goes away when gen_snapshot migrates to x64.
2019-04-19 10:01:44 -07:00
skia-flutter-autoroll
30c23e6042
Roll src/third_party/skia e8a33ec6d084..e5763787f920 (1 commits) (#8650)
https://skia.googlesource.com/skia.git/%2Blog/e8a33ec6d084..e5763787f920

git log e8a33ec6d084fef3200eb8732b453734f4b391ca..e5763787f920c0c3a30527a596a6c207eb1b220b --date=short --no-merges --format=%ad %ae %s
2019-04-17 robertphillips@google.com Allow GrShadowRRectOp::Make to fail

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (herb@google.com), and stop
the roller if necessary.
2019-04-19 09:45:51 -04:00
skia-flutter-autoroll
8f0af31ecb
Roll src/third_party/skia 8cdae55bf1ac..e8a33ec6d084 (3 commits) (#8648)
https://skia.googlesource.com/skia.git/%2Blog/8cdae55bf1ac..e8a33ec6d084

git log 8cdae55bf1ac0270b8f7c92f131ec9a18957e84d..e8a33ec6d084fef3200eb8732b453734f4b391ca --date=short --no-merges --format=%ad %ae %s
2019-04-19 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset
2019-04-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 82bcffa78747..145ec7fa7c81 (10 commits)
2019-04-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader abaecd5f2ba7..a16238df3f28 (12 commits)

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (herb@google.com), and stop
the roller if necessary.
2019-04-19 04:28:24 -04:00
skia-flutter-autoroll
25c33dc9d5
Roll src/third_party/skia 9b67802a4cd0..8cdae55bf1ac (1 commits) (#8647)
https://skia.googlesource.com/skia.git/%2Blog/9b67802a4cd0..8cdae55bf1ac

git log 9b67802a4cd01fbbe5fcbe9f4117ff68e7b8e751..8cdae55bf1ac0270b8f7c92f131ec9a18957e84d --date=short --no-merges --format=%ad %ae %s
2019-04-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src f968f64cdf27..a55917cb9824 (433 commits)

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (herb@google.com), and stop
the roller if necessary.
2019-04-19 00:58:24 -04:00