DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
34,430 Commits 882 Branches 1,069 Tags
Commit Graph

34430 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jackson Gardner
0424f1f86e Reland "[skwasm] Clip pictures if they go beyond the bounds of the window." (flutter/engine#51077) 
This fixes https://github.com/flutter/flutter/issues/143800, where we are attempting to capture an image that is way too large. We only need to render the part of the image that will be visible in the window.

This includes some additional fixes for regressions in the original fix.
 2024-02-29 21:06:02 +00:00
Matej Knopp
0d3941630d Revert "[macOS] Use CVDisplayLink to drive repaint (#49159)" (flutter/engine#51095) 
The original PR assumed that `fml::TimePoint` has same base as
`CACurrentMediaTime()`. However due to recent change in Dart SDK that's
no longer true. Dart SDK
[replaced](https://dart-review.googlesource.com/c/sdk/+/348044?tab=comments)
call to `mach_absolute_time` with
`clock_gettime_nsec_np(CLOCK_MONOTONIC_RAW)`, while
`CACurrentMediaTime()` corresponds to `CLOCK_UPTIME_RAW`.

This needs to be fixed either in Dart SDK
https://github.com/dart-lang/sdk/issues/55071 or the original PR needs
to be relanded with appropriate conversions.

This reverts commit 8ff01af723be83ab019b0ddf7d64d8586d280186.

*Replace this paragraph with a description of what this PR is changing
or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one
issue.*

*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-02-29 12:39:33 -08:00
Kevin Moore
7ba403293e [web] Drop noisy prints from bootstrapping logic (flutter/engine#51097) 
Fixes https://github.com/flutter/flutter/issues/143976
 2024-02-29 20:00:22 +00:00
Jackson Gardner
3615c28ff8 Fix a few issues rendering text with Skwasm. (flutter/engine#51074) 
This fixes https://github.com/flutter/flutter/issues/141001
This also fixes https://github.com/flutter/flutter/issues/143743

* We need to always call `setStrutEnabled(true)` on `StrutStyle`.
* `getLineMetricsAt` had reversed ternary logic.
* We also need to apply the rounding hack in Skwasm.
* Ported unit tests from CanvasKit over to UI to cover Skwasm ~and HTML~
* ~The HTML renderer should return 0 line metrics for an empty paragraph.~
 2024-02-29 19:42:09 +00:00
Jonah Williams
9d7d2d5142 [Impeller] test removal of submit batching. (flutter/engine#51094) 
I have a feeling this is related to https://github.com/flutter/flutter/issues/144371 

Locally on the Pixel 4 (which is a similarish GPU, the batch submission is actually regressing performance).
 2024-02-29 18:11:55 +00:00
Zachary Anderson
efda66bcff Use RBE for mac_clang_tidy (flutter/engine#51083) 2024-02-29 17:27:17 +00:00
Dan Field
2e9e6107eb Reapply "Bump everything to Android 21" (#51056) (flutter/engine#51070) 
This reverts commit 98485b3f82fec45a6a0ac932c3c20285a9a14e02.

Reverted in https://github.com/flutter/engine/pull/51056 because it
caused failures in the framework. No changes, but framework test has
been updated to use an actual robolectric implementation to avoid those
failures.

This should not land until
https://github.com/flutter/flutter/pull/144348 has landed in the
framework.

@gaaclarke @johnmccutchan fyi
 2024-02-29 09:00:01 -08:00
Loïc Sharma
461cf83c58 [Windows] Add view ID runner APIs (flutter/engine#51020) 
Allow Flutter Windows apps and plugins to get the view's ID.

Design doc: https://flutter.dev/go/desktop-multi-view-runner-apis

Part of https://github.com/flutter/flutter/issues/143767
Part of https://github.com/flutter/flutter/issues/142845

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-29 16:22:39 +00:00
skia-flutter-autoroll
c42482040d Roll Skia from 05a8d57f0e61 to 139461270500 (1 revision) (flutter/engine#51091) 
https://skia.googlesource.com/skia.git/+log/05a8d57f0e61..139461270500

2024-02-29 kjlubick@google.com Compile Slug::NextUnique on CPU builds also

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-29 15:23:10 +00:00
skia-flutter-autoroll
84adbd5296 Roll Skia from ffbe23b3b3b9 to 05a8d57f0e61 (1 revision) (flutter/engine#51090) 
https://skia.googlesource.com/skia.git/+log/ffbe23b3b3b9..05a8d57f0e61

2024-02-29 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from ffd0c1c14e46 to 12f9cddb3ff7 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-29 14:18:40 +00:00
skia-flutter-autoroll
94ba9367c4 Roll Skia from 0d00c9f3852a to ffbe23b3b3b9 (2 revisions) (flutter/engine#51089) 
https://skia.googlesource.com/skia.git/+log/0d00c9f3852a..ffbe23b3b3b9

2024-02-29 jgaillard@google.com Use UserConfig to load platform in SkImageGeneratorCG.h
2024-02-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 434a5b01707d to 4d362242673e (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-29 12:49:36 +00:00
skia-flutter-autoroll
cc0e2ddc42 Roll Skia from ef2511b0a6f2 to 0d00c9f3852a (2 revisions) (flutter/engine#51086) 
https://skia.googlesource.com/skia.git/+log/ef2511b0a6f2..0d00c9f3852a

2024-02-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 983e5c4c3486 to 8be5f1367447
2024-02-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 1ce4523589b0 to 983e5c4c3486 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-29 09:02:04 +00:00
Matan Lurey
b2b8311980 The adb logcat filtering will continue until morale improves. (flutter/engine#51069) 
Closes https://github.com/flutter/flutter/issues/144346.
 2024-02-28 19:10:17 -08:00
skia-flutter-autoroll
f1eec9b65f Roll Skia from f0a60bfe98e0 to ef2511b0a6f2 (2 revisions) (flutter/engine#51075) 
https://skia.googlesource.com/skia.git/+log/f0a60bfe98e0..ef2511b0a6f2

2024-02-28 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll ANGLE from a627dd89762e to 434a5b01707d (5 revisions)
2024-02-28 brianosman@google.com Remove outdated assert (that no longer holds)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-29 03:09:08 +00:00
Robert Ancell
da5550db7f Update Linux embedder to latest semantics API (flutter/engine#51030) 
Change to the latest semantics API and remove an unused class.
 2024-02-29 15:18:19 +13:00
Jonah Williams
65f3a2348b [Impeller] switch fallback default from ImpellerVulkan to SkiaOpenGLES (flutter/engine#51071) 
Unblocks shipping Impeller on Android before GLES is ready.
 2024-02-29 01:47:19 +00:00
skia-flutter-autoroll
f026d97f42 Roll Skia from 27171d6a9205 to f0a60bfe98e0 (4 revisions) (flutter/engine#51068) 
https://skia.googlesource.com/skia.git/+log/27171d6a9205..f0a60bfe98e0

2024-02-28 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from 83c3be5d8216 to ffd0c1c14e46 (2 revisions)
2024-02-28 herb@google.com Reland "Cleanup linkage in SkSwizzler_opts.h"
2024-02-28 johnstiles@google.com Update Perlin noise GM slide.
2024-02-28 herb@google.com Only define _opts functions when needed

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-28 23:44:50 +00:00
Casey Hillers
66a29b492b Prefix flutter in flutter_vma.h import (flutter/engine#51065) 
Breaks the Google build (b/327309677)
 2024-02-28 22:26:55 +00:00
Jonah Williams
2305461a66 [Impeller] Cache entire render target and not just allocations. (flutter/engine#50990) 
This may be required to fix https://github.com/flutter/flutter/issues/144116 , and in general the safety of the render pass caches.

Because the RenderPass / Framebuffer objects refer to specific attachments, the caches are placed on the resolve texture, which is "real". The stencil/depth and or MSAA textures may be different but that didn't seem to matter on many Android devices. It doesn't seem like its actually valid though, whether or not there is a validation error to catch it.

I can confirm this fixes https://github.com/flutter/flutter/issues/144116  locally.

This change moves the cache one level up to cover the properties of the RenderTarget we care about, and ensures that we always use the same attachment combinations.

Fixes https://github.com/flutter/flutter/issues/141750
Maybe https://github.com/flutter/flutter/issues/144255 ?
 2024-02-28 22:23:05 +00:00
Matan Lurey
bc4d5caa20 Test the SurfaceTextureSurfaceProducer-branch in the Android scenario_app (flutter/engine#51061) 
This PR does the following:
- Relands https://github.com/flutter/engine/pull/50993.
- Fixes a bug in `SurfaceTextureSurfaceProducer` where it would crash on
release (now tested, yay!)

Closes https://github.com/flutter/flutter/issues/143539.
Closes https://github.com/flutter/flutter/issues/143483.

/cc @gaaclarke @chinmaygarde, this PR should (after landed) test/verify
https://github.com/flutter/engine/pull/50730.
 2024-02-28 14:17:21 -08:00
Jackson Gardner
c98ee51b1e Revert "[skwasm] Clip pictures if they go beyond the bounds of the window. (#50887)" (flutter/engine#51067) 
This reverts commit 3af9b7b3baa33896103d286d3e4593f95b87b7a7.

The change is causing skwasm benchmarks to flake. See https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.prod/Linux%20web_benchmarks_skwasm
 2024-02-28 21:20:00 +00:00
skia-flutter-autoroll
b2f8f71a8b Roll Fuchsia Linux SDK from T1xAi_ww_mWEiDkVN... to ujOkbeYbrC8loPbfR... (flutter/engine#51066) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-28 21:12:11 +00:00
Chris Bracken
99f8815ee4 Roll abseil-cpp to 1db3bdd4eb208bef55c77f22aa94991e52225230 (flutter/engine#51062) 
Our abseil dependency is a clone of Chromium's, located at:
https://chromium.googlesource.com/chromium/src/third_party/

which is a downstream copy of the source of truth, located at:
https://github.com/abseil/abseil-cpp

This rolls to Chromium commit 185f27671ca28c0f25d9d7a15b6e621f69972706,
then reapplies jsimmons@google.com's commits, in chronological order:
* 9ec8f453a42aad2f11a1760fe4ce6014a124edc2
* f92f9effc89af7692436c3b9fbb3a67f2239d893
* 61833f2c057a2b1993d871e8c51156aed1dd4354

Preparation for: https://github.com/flutter/flutter/issues/144201
Part of: https://github.com/flutter/flutter/issues/67373

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [X] This patch complies with USDA policy on the use of bovine growth
hormone.
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I signed the [CLA].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-02-28 13:00:30 -08:00
skia-flutter-autoroll
631edadb1c Roll Dart SDK from 7896a944fe67 to fdf4a62bd07b (1 revision) (flutter/engine#51064) 
https://dart.googlesource.com/sdk.git/+log/7896a944fe67..fdf4a62bd07b

2024-02-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-187.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-28 20:58:06 +00:00
Jason Simmons
f6f7230917 [Impeller] Mark subpass framebuffer fetch tests as unsupported on GLES (flutter/engine#50982) 
Currently the GLES backend may claim the framebuffer fetch capability but its implementation does not support the multisample subpass input used in this test.  Do not run this on GLES until there is clarification of the level of framebuffer fetch support intended for the GLES backend.
 2024-02-28 20:54:06 +00:00
skia-flutter-autoroll
037e853355 Roll Skia from 93f245da0097 to 27171d6a9205 (1 revision) (flutter/engine#51063) 
https://skia.googlesource.com/skia.git/+log/93f245da0097..27171d6a9205

2024-02-28 johnstiles@google.com Fix baseFrequencyY calculation again.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-28 20:37:05 +00:00
Jonah Williams
8acca62755 [Impeller] fix render pass depth descriptor. (flutter/engine#51031) 
Depth+stencil should be treated as the same attachment. Adding more than one d/s attachment in the render pass descriptor seems to be confusing swiftshader.

@bdero 

This fixes things for me locally, lets let CI take a spin
 2024-02-28 20:33:51 +00:00
Jim Graham
98c96670b4 Make Skia object ostream operators work with unit tests (flutter/engine#51041) 
Unit tests currently output basic hex dumps of skia objects even though we have ostream operators for many of the common ones. It looks like the operators were created in the wrong namespace (flutter/testing rather than the std namespace). Changing the namespace for the associated `assertions_skia` source files makes them compatible with unit tests that deal with these objects provided that the test files include that header and gn dependency, as verified with the `display_list_unittests` here.
 2024-02-28 20:32:07 +00:00
Zachary Anderson
20a707ca00 Revert to goma on mac_clang_tidy builder (flutter/engine#51060) 
Reverting for build time regression: https://github.com/flutter/engine/pull/51057#issuecomment-1969647657
 2024-02-28 19:41:10 +00:00
Dan Field
98485b3f82 Revert "Bump everything to Android 21" (flutter/engine#51056) 
Reverts flutter/engine#51032

Probably causing some of the failures in https://github.com/flutter/flutter/pull/144326

@johnmccutchan fyi
 2024-02-28 19:15:04 +00:00
skia-flutter-autoroll
21a5b7d261 Roll Skia from 0c294ee206e8 to 93f245da0097 (2 revisions) (flutter/engine#51055) 
https://skia.googlesource.com/skia.git/+log/0c294ee206e8..93f245da0097

2024-02-28 scroggo@google.com Use a VMA block size of only 64k
2024-02-28 senorblanco@chromium.org Fix wireframe mode in GrTriangulator.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-28 19:07:24 +00:00
Jonah Williams
919af4322a [Android] update fallback and rendering state to combine impeller + android backend. (flutter/engine#51008) 
1. Makes it possible to implement Impeller Vulkan -> Skia fallback.
2. Fixes https://github.com/flutter/flutter/issues/143871
3. Fixes https://github.com/flutter/flutter/issues/143873
4. Work towards https://github.com/flutter/flutter/issues/137798

Combines AndroidRenderingAPI + enable_impeller into a 4 values enum that describes all combinations of rendering behavior: ImpellerVulkan, ImpellerOpenGLES, SkiaOpenGLES, Software. 

Updates the fallback behavior to happen in flutter_main. This allows us to change the value of Settings.enable_impeller to support an Impeller -> Skia fallback.
 2024-02-28 18:47:04 +00:00
Brandon DeRosier
3acbd059fd [Impeller] Fix GL depth state. (flutter/engine#51040) 
This patch fixes problems with GL depth (in service of
https://github.com/flutter/engine/pull/50856):
* The depth + stencil masks weren't being set prior to clearing.
* When the driver identifies as desktop GL rather than ES, use
`glClearDepth` and `glDepthRange` rather than `glClearDepthf` and
`glDepthRangef`.
 2024-02-28 10:41:35 -08:00
Chris Bracken
ad71df4c01 Roll buildroot to 7b537de78ac2239982ace130d1845374e5dcf113 (flutter/engine#51053) 
Wraps `$python_path` usages in quotes to support python installations in
directories with spaces.

Fixes: https://github.com/flutter/flutter/issues/143740

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] Machine wash cold.
- [X] Do not iron.
- [X] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I signed the [CLA].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-02-28 10:33:00 -08:00
skia-flutter-autoroll
55aa1a9d75 Roll Skia from d935943bedcd to 0c294ee206e8 (3 revisions) (flutter/engine#51051) 
https://skia.googlesource.com/skia.git/+log/d935943bedcd..0c294ee206e8

2024-02-28 johnstiles@google.com Fix base frequency of stitched Perlin noise.
2024-02-28 nscobie@google.com Re-enable tracing when building for Android framework
2024-02-28 nscobie@google.com [graphite] Add missing failure callback in QueueManager::addRecording

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-28 17:54:15 +00:00
Zachary Anderson
65ada342b1 When run_tests.py is in --quiet mode, write verbose logs to a file (flutter/engine#51029) 
This PR causes `run_test.py` to write `info` and higher logs to
`out/run_tests.log` even when `--quiet` is passed. If `--logs-dir` is
also passed, the logs file is copied to that location after all tests
are run.

These flags are added to one invocation on CI to check the correct
behavior.
 2024-02-28 09:47:40 -08:00
skia-flutter-autoroll
264546190d Roll Skia from fe34002ee826 to d935943bedcd (1 revision) (flutter/engine#51049) 
https://skia.googlesource.com/skia.git/+log/fe34002ee826..d935943bedcd

2024-02-28 jvanverth@google.com [graphite] Minor DrawAtlas cleanup.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-28 16:46:31 +00:00
Dan Field
6efee79357 Bump everything to Android 21 (flutter/engine#51032) 
Followed the linter, got rid of a bunch of version check/guards we don't need anymore.
 2024-02-28 15:56:40 +00:00
Jia Hao
b9ebc96690 Add flutter prefix to import (flutter/engine#51042) 
Internally, the source transformations need the flutter prefix here to
replace the import with an absolute path for the depot.

b/327318241
 2024-02-28 07:55:06 -08:00
skia-flutter-autoroll
16575d1075 Roll Skia from d591703635b0 to fe34002ee826 (1 revision) (flutter/engine#51048) 
https://skia.googlesource.com/skia.git/+log/d591703635b0..fe34002ee826

2024-02-28 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 11b95ad3e8f7 to aa0be6f5777f (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-28 15:38:29 +00:00
Victoria Ashworth
223dbba0c6 Process FlutterMacOS.framework before creating xcframework (flutter/engine#51023) 
Process (including stripping) FlutterMacOS.framework before creating it as an xcframework.

Should fix https://github.com/flutter/flutter/issues/144251.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-28 15:24:17 +00:00
skia-flutter-autoroll
cbb128e715 Roll Skia from a55a65d65378 to d591703635b0 (1 revision) (flutter/engine#51046) 
https://skia.googlesource.com/skia.git/+log/a55a65d65378..d591703635b0

2024-02-28 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from 64550d191409 to 83c3be5d8216 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-28 14:41:25 +00:00
skia-flutter-autoroll
ce935f39c2 Roll Skia from cce35b54379c to a55a65d65378 (3 revisions) (flutter/engine#51045) 
https://skia.googlesource.com/skia.git/+log/cce35b54379c..a55a65d65378

2024-02-28 robertphillips@google.com Revert "Cleanup linkage in SkSwizzler_opts.h"
2024-02-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 2fb425d2847f to a627dd89762e (4 revisions)
2024-02-28 herb@google.com Cleanup linkage in SkSwizzler_opts.h

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-28 13:33:22 +00:00
skia-flutter-autoroll
a262ad8406 Roll Dart SDK from 44af84628b90 to 7896a944fe67 (1 revision) (flutter/engine#51043) 
https://dart.googlesource.com/sdk.git/+log/44af84628b90..7896a944fe67

2024-02-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-186.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-28 09:51:23 +00:00
skia-flutter-autoroll
e83fcebea5 Roll Skia from a673ab63fccc to cce35b54379c (3 revisions) (flutter/engine#51036) 
https://skia.googlesource.com/skia.git/+log/a673ab63fccc..cce35b54379c

2024-02-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 1ce4523589b0 to 22671d61de6c
2024-02-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 34f900647879 to 1ce4523589b0 (7 revisions)
2024-02-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 7b482f48e635 to 11b95ad3e8f7 (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-28 06:24:31 +00:00
skia-flutter-autoroll
b70cbd046c Roll Dart SDK from 1e6b559fae88 to 44af84628b90 (1 revision) (flutter/engine#51035) 
https://dart.googlesource.com/sdk.git/+log/1e6b559fae88..44af84628b90

2024-02-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-185.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-28 05:24:23 +00:00
skia-flutter-autoroll
cb2674a600 Roll Skia from 84c60d70fbbd to a673ab63fccc (1 revision) (flutter/engine#51034) 
https://skia.googlesource.com/skia.git/+log/84c60d70fbbd..a673ab63fccc

2024-02-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 32b3df0d7dd6 to 64550d191409 (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-28 04:53:04 +00:00
Sam Rawlins
c86194e544 Null-assert the value given to a Completer expecting a non-null value (flutter/engine#49053) 
The code with out the null assertion is legal as per the type signature,
but will throw a runtime exception if the nullable value is null. To
make this exception more explicit, the value must be null-checked before
completing the completer with the value.

The analyzer will soon enforce such checks. See dart-lang/sdk#53253.

This PR is behaviorally a no-op.

Fixes https://github.com/flutter/flutter/issues/136775


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-02-27 17:27:24 -08:00
skia-flutter-autoroll
67cc2ec0a3 Roll Dart SDK from a0e3c16eea3e to 1e6b559fae88 (1 revision) (flutter/engine#51025) 
https://dart.googlesource.com/sdk.git/+log/a0e3c16eea3e..1e6b559fae88

2024-02-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-184.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-28 01:09:35 +00:00
Loïc Sharma
9da5ed5312 [Windows] Reduce log level of unsupported accessibility event message (flutter/engine#51024) 
https://github.com/flutter/engine/pull/50975 made the Windows embedder a bit more defensive on accessibility event messages and introduced an error if it received an event it does not support. This change reduces that error to a warning as it can be triggered by hovering over the counter app's `+` button.

Fixes https://github.com/flutter/flutter/issues/144274

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-28 00:45:30 +00:00