2.9 KiB
🚀 Pull Request
📝 Description
🛠️ Changes Implemented
🧪 Testing Strategy
📸 Visual Changes (if applicable)
⚠️ Required Pre-Submission Checklist
Please Read - This Checklist is Mandatory
Important Notice: We've experienced several production bugs recently due to incomplete pre-submission checks. To maintain code quality and prevent issues from reaching production, we're enforcing stricter adherence to this checklist.
All checkboxes below must be completed before requesting review. PRs that haven't completed these requirements will be sent back for completion.
Mandatory Requirements (please check ALL boxes):
- Code adheres to project style guidelines and conventions
- Branch synchronized with latest
developbranch (please resolve any merge conflicts) - 🚨 CRITICAL: Automated unit tests added/updated to cover changes (MANDATORY for ALL Spring Boot backend and Angular frontend changes - this is non-negotiable)
- 🚨 CRITICAL: All tests pass locally (run
./gradlew testfor Spring Boot backend, andng testfor Angular frontend - NO EXCEPTIONS) - 🚨 CRITICAL: Manual testing completed in local development environment (verify your changes work AND no existing functionality is broken - test related features thoroughly)
- Flyway migration versioning follows correct sequence (if database schema was modified)
- Documentation PR submitted to booklore-docs (required for features or enhancements that introduce user-facing or visual changes)
Why This Matters:
Recent production incidents have been traced back to:
- Incomplete testing coverage (especially backend)
- Merge conflicts not resolved before merge
- Missing documentation for new features
Backend changes without tests will not be accepted. By completing this checklist thoroughly, you're helping maintain the quality and stability of Booklore for all users.
Note to Reviewers: Please verify the checklist is complete before beginning your review. If items are unchecked, kindly ask the contributor to complete them first.