59381 Commits

Author SHA1 Message Date
Johannes Rieken
fbb4fbcd4b fix issue with accessibility provider, #88554 2020-01-13 21:17:36 +01:00
Martin Aeschlimann
a5f90a5685 polish html sem highlighting 2020-01-13 21:07:00 +01:00
Connor Peet
5e1dbb1096
fix(debug): don't insert task boundaries between events (#88459)
* fix(debug): don't insert task boundaries between events

See discussion in https://github.com/microsoft/vscode-js-debug/issues/206.

This PR adjusts logic such that we only assert task boundaries around
requests and responses, rather than around every single event. I believe
this will solve the primary case where misordering can happen, as given
in the existing unit test and described more verbosely in the doc
comment in this PR.

A more conservative approach would be to only omit the boundary between
events of the same type. That would be safer, but I browsing through
the code I didn't see any cases where it looked like we could get
tripped up by bucketing here (e.g. cases where we resolve a deferred
promise in an event handler).

Seems to fix the performance issue for me.

* fixup! add unit tests for ordering
2020-01-13 11:47:25 -08:00
Jackson Kearl
8d1456e210 Fix search editor URI malform error 2020-01-13 10:58:53 -08:00
Kai Maetzel
06167cfb3e
Merge pull request #88397 from microsoft:kieferrm/issueflow
Configuration for the probot handling feature-requests
2020-01-13 10:46:58 -08:00
SteVen Batten
4e7b4bc326 missed rename for viewsservice 2020-01-13 10:40:38 -08:00
SteVen Batten
91283c1351
Enhance views service (#87505)
Add view-moving functionality to viewsservice which has been renamed to viewdescriptorservice. also includes outline view moving
2020-01-13 10:15:40 -08:00
Daniel Imms
8631d96cc0
Merge pull request #88237 from solomatov/terminal-code-cleanup
Reduce duplication and make code less opaque
2020-01-13 09:16:43 -08:00
Daniel Imms
7da3ea70a5 has -> had 2020-01-13 09:15:36 -08:00
Daniel Imms
a3cce1489e
Merge branch 'master' into terminal-code-cleanup 2020-01-13 09:14:14 -08:00
Isidor Nikolic
3d26e9ee61
Merge pull request #88502 from jeanp413/fix-88242
Fixes cannot create new debug watch expressions while filtering is active
2020-01-13 18:00:27 +01:00
Martin Aeschlimann
ae8fee7ba8 finish test 2020-01-13 17:51:11 +01:00
Martin Aeschlimann
517e4391c2 readonly semantic highlighting 2020-01-13 17:51:11 +01:00
Johannes Rieken
0fde639a9e message polish for #88552 2020-01-13 17:35:53 +01:00
Johannes Rieken
9bd40be50e fix #88560 2020-01-13 17:18:30 +01:00
Johannes Rieken
08c04a487d add accessibility provider for refactor preview, #88554 2020-01-13 17:18:30 +01:00
Benjamin Pasero
2a3dc1edac fix tests 2020-01-13 16:59:08 +01:00
Daniel Imms
a62805844e Expose IExtHostTerminalService.getDefaultShellArgs internally
Fixes #88280
2020-01-13 07:45:08 -08:00
Benjamin Pasero
76c72ffc94 telemetry - restore back load/save reason for files 2020-01-13 16:01:30 +01:00
Joao Moreno
11045f78f7
Merge branch 'pr/86778' 2020-01-13 15:54:21 +01:00
Joao Moreno
420fa18924
💄 2020-01-13 15:54:10 +01:00
Benjamin Pasero
ad41028d8f debt - drop untyped events in favor of typed (text files) 2020-01-13 15:49:21 +01:00
Sandeep Somavarapu
06a9d488fb fix compilation 2020-01-13 15:46:19 +01:00
João Moreno
99d2801fa5
Merge branch 'master' into fix-gitfs-stat 2020-01-13 15:31:00 +01:00
Sandeep Somavarapu
ebfcd2a3a8 directly add override identifier property schema 2020-01-13 15:21:40 +01:00
Sandeep Somavarapu
a4ec354926
use set instead of array (#88538)
use set instead of array
2020-01-13 15:15:40 +01:00
Sandeep Somavarapu
20437e98f6
Merge branch 'master' into ben/overrideproperty 2020-01-13 15:15:31 +01:00
Alexandru Dima
519ceb6283
Respect editor.wrappingAlgorithm 2020-01-13 15:00:22 +01:00
Alexandru Dima
53125e31f0
Pass in entire fontInfo when computing line breaks 2020-01-13 15:00:22 +01:00
Alexandru Dima
314d0e12a9
Introduce editor.wrappingAlgorithm 2020-01-13 15:00:21 +01:00
Alexandru Dima
c6dec6ef12
Add support for WrappingIndent.Same in DOMLineBreaksComputer 2020-01-13 15:00:21 +01:00
Alexandru Dima
02d39920cd
Better handling of multiple spaces when using the DOM for line breaks 2020-01-13 15:00:20 +01:00
Benjamin Pasero
238617a847 debt - drop TextFileModelChangeEvent 2020-01-13 13:02:50 +01:00
Sandeep Somavarapu
9918d87cb6 Fix #88402 2020-01-13 13:01:11 +01:00
Benjamin Pasero
224f983016 text files - drop debounced bulk events 2020-01-13 12:50:18 +01:00
Pine Wu
4c9c6780c7 Fix #88541 2020-01-13 12:48:37 +01:00
Johannes Rieken
e69cc0760c update telemetry message with index of changed field #87187 2020-01-13 12:26:42 +01:00
Benjamin Pasero
0dfc47f4ef use set instead of array 2020-01-13 12:19:08 +01:00
Johannes Rieken
9c4aa6d903 💄 2020-01-13 12:06:28 +01:00
Benjamin Pasero
bc0f81bd05 debt - cleanup file model a bit 2020-01-13 11:42:13 +01:00
Benjamin Pasero
dd54a1439d debt - move text file model telemetry into telemetry contribution 2020-01-13 11:23:03 +01:00
Alexandru Dima
73b24574df
Fix mightProducePrintableCharacter numeric keypad support (#77911)
Fix mightProducePrintableCharacter numeric keypad support
2020-01-13 11:01:15 +01:00
Alexandru Dima
94742854c2
Minor tweaks 2020-01-13 10:59:18 +01:00
Johannes Rieken
f36e0c13c6 fix #88310 2020-01-13 10:43:20 +01:00
Johannes Rieken
0b134f8c13
Merge pull request #88185 from jeanp413/peek-widget-focus-setting
Add setting to control whether to focus the inline editor in peek widget by default
2020-01-13 10:20:24 +01:00
Benjamin Pasero
5e758c10c9 fix compile errors 2020-01-13 10:17:41 +01:00
Johannes Rieken
561f5215d7 for rename-file, show the new name more prominent, #77728 2020-01-13 10:17:06 +01:00
Benjamin Pasero
b84d08be70 options - make sure text editor options are proper 2020-01-13 10:04:48 +01:00
Alexandru Dima
652ea313e7
Merge branch 'master' into fix-71134 2020-01-13 09:32:59 +01:00
Johannes Rieken
17d6b13a35
Merge pull request #88428 from microsoft/joh/bulkEditPreview
Preview workspace edits
2020-01-13 09:24:39 +01:00