Matt Bierner
cf38af84ff
Revert "Fix #106303 "
...
This reverts commit 8e5eed12991c8af7a599b3f68fb9ca723b953316.
this is causing a layer check issue
2020-09-09 21:37:16 -07:00
Matt Bierner
3f8f022200
Use destructuring to make code more clear
2020-09-09 21:26:51 -07:00
Rob Lourens
8e5eed1299
Fix #106303
2020-09-09 21:44:43 -05:00
rebornix
03960a5aa1
re #105735 . no more udpateMetadata api.
2020-09-09 16:45:00 -07:00
rebornix
73a3c9ded3
re #105735 .
2020-09-09 16:45:00 -07:00
Connor Peet
7e62739639
debug: bump js-debug-companion
2020-09-09 16:41:48 -07:00
Rachel Macfarlane
cceaf14323
#106358
2020-09-09 15:37:31 -07:00
Matt Bierner
80b1a775d6
Enable webview commands for webview views
...
Fixes #105670
Previously our webview commands assumed that webviews were always going to be in an editor. This is no longer true with webview views.
To fix this, I've added an `activeWebview` to the `IWebviewService`. This tracks the currently focused webview.
2020-09-09 14:44:46 -07:00
Matt Bierner
6cf52e3828
Mark property readonly
2020-09-09 14:44:46 -07:00
rebornix
889fe1787b
💄
2020-09-09 14:40:44 -07:00
rebornix
69f26324d4
initialize notebook text model data only through ctor.
2020-09-09 14:40:44 -07:00
Miguel Solorio
a037570775
Update Codicons: add 'graph-left'
...
dd1edb245d
2020-09-09 13:54:51 -07:00
Daniel Imms
6821292b4b
Fix ts 4.1 issues in terminal api tests
2020-09-09 12:43:25 -07:00
Daniel Imms
d55efd8041
Fix terminal ts 4.1 compile issues
...
Part of #106358
2020-09-09 12:43:22 -07:00
Jackson Kearl
ebff341de3
Add subscribers action
2020-09-09 12:22:34 -07:00
SteVen Batten
424a2bf17b
refs #106285
2020-09-09 12:07:26 -07:00
rebornix
ee5ee9e8aa
chore, simply notebook text model event emitter
2020-09-09 12:04:21 -07:00
rebornix
8bc3145bc5
move dirty state to NotebookEditorModel.
2020-09-09 12:04:21 -07:00
rebornix
4e70e4a699
fix #105916 . expand metadata section if modified.
2020-09-09 12:04:20 -07:00
rebornix
e491efbaab
replace changeCellLanguage to applyEdit
2020-09-09 12:04:20 -07:00
rebornix
eb7f042acf
remove selections from nb text model.
2020-09-09 12:04:20 -07:00
rebornix
deaf9f2689
💂 polish nb tests.
2020-09-09 12:04:20 -07:00
rebornix
eb05b79e9b
do not need isUntitled.
2020-09-09 12:04:20 -07:00
Johannes Rieken
9753398da5
debt - invoke resolve notebook when opening a notebook in an editor, not when loading a notebook from source
2020-09-09 20:34:54 +02:00
Johannes Rieken
e40d854df6
debt - IMainNotebookController#removeNotebookDocument
2020-09-09 20:01:35 +02:00
Matt Bierner
5cdf679c44
Add explicit undefined parameters / types
...
These errors come from the new stricter types for Promises in TS 4.1
2020-09-09 10:57:05 -07:00
Miguel Solorio
fecec73e53
Update Codicons
...
- Update 'pinned'
- Add 'export'
- Compress 'merge'
5bcb1a0454
2020-09-09 09:29:42 -07:00
Johannes Rieken
f3532c9061
chore - use workingCopyService.isDirty instead notebook.isDirty
2020-09-09 18:24:47 +02:00
Matt Bierner
7e0c1aa76e
Don't use async on abstract functions
2020-09-09 09:21:56 -07:00
Matt Bierner
c348165cc0
Adding more explicit typings for promises
...
This gets us ready for TS 4.1
2020-09-09 09:21:56 -07:00
Matt Bierner
2a954244f0
Only allow configurePlugin against main TS Server
...
Fixes #106346
Looks like the TS Server doesn't support this in partial mode at the moment
2020-09-09 09:21:56 -07:00
Benjamin Pasero
c1e9502223
Save prompt is shown while saving from settings split json editor ( fix #106330 )
2020-09-09 16:51:36 +02:00
João Moreno
f41efe546c
Merge branch 'master' into pr/85074
2020-09-09 16:35:26 +02:00
João Moreno
d9d314e8c6
Update extensions/git/src/commands.ts
2020-09-09 16:30:24 +02:00
João Moreno
bec65e80de
Update extensions/git/src/commands.ts
2020-09-09 16:30:18 +02:00
João Moreno
9ff783bdd6
Update extensions/git/src/commands.ts
2020-09-09 16:29:53 +02:00
Daniel Imms
0fbda8ef06
Merge pull request #104090 from Abhijith-S-D/bugfix/101155
...
Always trim trailing colon from word link provider links
2020-09-09 06:29:46 -07:00
Daniel Imms
66e99a777c
Move comment into helper function
2020-09-09 06:28:49 -07:00
Daniel Imms
41586fc0ea
Merge pull request #105108 from DavidGoldman/master
...
Terminal: Support linking local file paths containing '+'
2020-09-09 06:24:08 -07:00
Daniel Imms
2565f7e28f
Merge branch 'master' into master
2020-09-09 06:20:11 -07:00
Daniel Imms
49be31b86b
Merge pull request #104734 from brajkowski/issue-104612
...
Run Selected Text action should use the active code editor
2020-09-09 06:19:27 -07:00
Daniel Imms
5fabfbf6c0
Check length again
...
I prefer chatAt over slice as it's more obvious what's happening
2020-09-09 06:14:38 -07:00
Daniel Imms
67def0324c
Avoid slice when checking colon
2020-09-09 06:12:41 -07:00
Daniel Imms
3456e084e2
Consolidate colon trim logic
2020-09-09 06:12:01 -07:00
Daniel Imms
17a2ff467d
Use instantiation service to create TerminalLinks
2020-09-09 06:08:55 -07:00
Daniel Imms
d3b95c5793
Fix compile after merge
2020-09-09 06:07:03 -07:00
Daniel Imms
92a97ecdaf
Merge remote-tracking branch 'origin/master' into pr/Abhijith-S-D/104090
2020-09-09 06:04:46 -07:00
Daniel Imms
65b4134965
Merge pull request #95637 from luqmana/workspace-mimetype
...
Register mimetype for *.code-workspace
2020-09-09 05:55:27 -07:00
Daniel Imms
f4833ee480
Merge pull request #106072 from IllusionMH/terminal-numeric-font-weight-101467
...
Add numeric values support for terminal.integrated.fontWeight
2020-09-09 05:48:01 -07:00
Daniel Imms
6f82a3904b
Merge branch 'master' into terminal-numeric-font-weight-101467
2020-09-09 05:42:40 -07:00
