100779 Commits

Author SHA1 Message Date
Alex Dima
5b7dc41f02
Add types to editor core commands arguments 2022-09-20 18:44:00 +02:00
Alex Dima
77fc18104b
Add IMouseTargetOutsideEditor.outsideDistance 2022-09-19 09:00:10 +02:00
Alex Dima
25018bedbc
Add IMouseTargetOutsideEditor.outsidePosition 2022-09-19 08:56:42 +02:00
Matt Bierner
3f92eb60d8
Better handle markup rendering errors in noetebooks (#161153)
Better handle markup rendering errors

Show an error to users if rendering of markup items fail. Previously when a renderer fails to load or render, we would not show any user facing errors (and would sometimes prevent the entire notebook from loading)
2022-09-19 07:49:02 +02:00
Sandeep Somavarapu
2ae5bc6980
support syncing profiles (#161208)
- sync profiles while turning on
- simplify turn on experience
- improve handling conflicts
2022-09-19 07:17:20 +02:00
Matt Bierner
d03f015931
Clean up structure of markdown extension (#161148)
- Move things related to the client under `client`
- Remove extra abstractions that are no longer used
- Add MdLanguageClient type
2022-09-19 07:16:45 +02:00
Matt Bierner
f4bf1f30a2
Skip ul and ol when highlighting selected markdown element (#161139)
Fixes #155552

For lists, the outer ul/ol always has the same source line as the first element in the list. We should prefer using the first element in the list when highlighting the active line

This also fixes a bug where scroll sync would stop working if you added lines to the doc. This was caused by `lineCount` getting out of sync as the document is being updated. I've removed this state and made the reveal logic more robust instead
2022-09-19 07:16:06 +02:00
Alexandru Dima
bd782eb059
Adopt latest loader (#161129) 2022-09-16 21:13:20 -07:00
Peng Lyu
b753d3303f
Avoid tweaking command arguments when they are already provided by extensions (#161154) 2022-09-16 20:54:53 -04:00
Matt Bierner
a10bdfb49b
Allow underscores in rendered md headers (#161149)
Follow up from https://github.com/microsoft/vscode-markdown-languageservice/pull/49
2022-09-16 20:52:50 -04:00
Matt Bierner
4c9c3f628d
Pick up latest markdown language service (#161142) 2022-09-16 20:52:16 -04:00
Benjamin Simmonds
42e854463c
checkbox api event naming change (#161131) 2022-09-16 14:53:07 -07:00
Peng Lyu
6e8bc02be4
Cell attachment cleanup tool improvement in diff editor (#161132)
* Move attachment out of custom metadata, prep for attachment clean up in diff editor

* recover attachments from dirty notebook document

* Allow metadata to be restored when content changed/reverted in nb diff editor
2022-09-16 14:12:53 -07:00
Matt Bierner
2d7655cb16
Add Refactor.move and Refactor.inline to code action widget (#161134)
Fixes #158515

Also aligns the icon to be more consistent with how they are used:

- Surround with snippets use snippet icon
- All refactorings use the wrench icon
- Remove custom color which was added to some refactorings but not others
2022-09-16 13:51:00 -07:00
Matt Bierner
6c3e1f0ff1
Pick up latest notebook renderer API typings (#161135) 2022-09-16 13:09:20 -07:00
Matt Bierner
687712b871
Pick up latest TS nightly for building VS Code (#161127) 2022-09-16 10:37:58 -07:00
Matt Bierner
7c3ea7ac06
Pick up TS 4.8.3 (#161126)
Picks up latest TS stable build
2022-09-16 10:22:13 -07:00
Matt Bierner
b12b061b7e
Throw when invalid parameter hint label is passed in (#161125)
Fixes #161055

I'm fairly sure that our code is correct if everything has the expected types. However extensions may be passing us invalid data so that the types are runtime don't match what we expect
2022-09-16 10:16:40 -07:00
Rob Lourens
f05eb4af4f
Clean up duplicate menu registration in cell run toolbar (#161124) 2022-09-16 10:07:22 -07:00
Sandeep Somavarapu
c126d947f6
Introduce Conflicts view (#161116)
* Introduice Conflicts view
- supports showing conflicts across profiles

* fix tests
2022-09-16 19:04:13 +02:00
Aaron Munger
236e476f01
Merge pull request #158421 from amunger/undoIWCellDelete
enabled core cell delete for IW and undo operations
2022-09-16 09:35:44 -07:00
Benjamin Pasero
84c46b71a5
Revert "Use esbuild to bundle some CommonJS main files (#160957)" (#161118)
This reverts commit 2179e52fb9a29ff8b666d3e09182d947b9c199e6.
2022-09-16 09:31:44 -07:00
Johannes Rieken
107f6cade5
Merge pull request #161098 from microsoft/joh/notebook-toolbar
joh/notebook toolbar
2022-09-16 18:22:35 +02:00
Robo
158949651c
chore: update distro (#161117) 2022-09-16 09:01:42 -07:00
Alexandru Dima
fe71b38f5d
Update service registration (#161115)
Update service registration (for #159178)
2022-09-16 08:53:20 -07:00
Martin Aeschlimann
94402ce979
Set IWorkbenchThemeService as Eager. For #159178 (#161113) 2022-09-16 08:03:04 -07:00
Martin Aeschlimann
724a088c68
update vscode-uri, fix links in untited (fixes #147788) (#161108) 2022-09-16 07:57:10 -07:00
Johannes Rieken
c65b01d010
show a disabled placeholder action when right clicking a none MenuItemAction, e.g the ... button (#161101) 2022-09-16 16:05:32 +02:00
Benjamin Pasero
42cbf7dde0
build - debug playwright install (#161099) 2022-09-16 06:52:48 -07:00
Benjamin Pasero
9d90f376eb
dev - fix user data path running out of sources (#161097) 2022-09-16 06:38:26 -07:00
Tyler James Leonhardt
869733274b
Have createAsset not short circuit (#161030) 2022-09-16 06:34:58 -07:00
Johannes
7c5634e0aa
tweak hiddenItemStrategy for run toolbar 2022-09-16 15:27:34 +02:00
Johannes
17079b458d
tweak delete cell toolbar 2022-09-16 15:23:44 +02:00
Johannes
f14be8257b
show a disabled placeholder action when right clicking a none MenuItemAction, e.g the ... button 2022-09-16 15:18:26 +02:00
Johannes
a936d06bde
Revert "use WorkbenchToolBar in notebook editor toolbar"
This reverts commit fa89b71d8a479ba7121377b972e28eb1ad5d59fb.
2022-09-16 15:13:33 +02:00
Johannes
0d067d86df
use WorkbenchToolBar in notebook diff land 2022-09-16 15:02:43 +02:00
Daniel Imms
bed45532b5
Merge pull request #161012 from microsoft/tyriar/xterm5_update
xterm@5
2022-09-16 06:02:37 -07:00
Johannes
fa89b71d8a
use WorkbenchToolBar in notebook editor toolbar 2022-09-16 15:02:15 +02:00
Ladislau Szomoru
0cd555dc1f
Enable git.fetchBeforeCheckout (#161092) 2022-09-16 05:58:00 -07:00
Johannes
76d65d3772
use WorkbenchToolBar in codeCellRunToolbar 2022-09-16 14:34:24 +02:00
Benjamin Pasero
a6a46240eb
web - align our html main files (#161091) 2022-09-16 05:26:25 -07:00
Johannes
517448a4a7
use MenuWorkbenchToolBar in BetweenCellToolBar
@roblourens this removes listening and rebuilding the menu when `insertToolbarAlignment` changes. This might be wrong but I couldn't get see how that event relates to the number of menu items (which are context key driven)

use `WorkbenchToolBar` in CellTitleToolbarPart, doesn't use `MenuWorkbenchToolBar` because of `updateAction` things
2022-09-16 14:25:44 +02:00
Benjamin Pasero
2179e52fb9
Use esbuild to bundle some CommonJS main files (#160957)
* ensure node.js `require` is captured

* optimize `main.js` and `cli.js`

* cleanup

* leave out bundled files

* drop package.json from userdata paths

* fix web task

* fix editor distro

* inline version into `product.json`

* also bundle server

* t

* actually do server too

* Keep bundling nls in editor worker

Co-authored-by: Alex Dima <alexdima@microsoft.com>
2022-09-16 05:24:23 -07:00
Johannes
67c63fed99
use WorkbenchToolBar in cellOutput but not MenuWorkbenchToolBar because some custom action things are going on 2022-09-16 14:15:12 +02:00
Johannes
51fb316ed7
Use MenuWorkbenchToolBar in interactive editor 2022-09-16 14:14:30 +02:00
Benjamin Simmonds
694ecf5fd0
Small changes extensions updates view (#161077)
* Small Updates extension view improvements

* Use already existing hasOutdatedContextKey
2022-09-16 04:59:59 -07:00
Johannes Rieken
25ab33edc2
align details for input 1 and 2 to the left (#161082)
fixes https://github.com/microsoft/vscode/issues/160358
2022-09-16 12:56:00 +02:00
Sandeep Somavarapu
9cb0aa8e6c
implement syncing profile and its data (#161078) 2022-09-16 12:55:39 +02:00
Robo
22cbb8e958
chore: update electron@19.0.17 (#161027)
* chore: update electron@19.0.17

* chore: update API typings

* fix: compilation errors

* build: add libcups dependency
2022-09-16 12:41:52 +02:00
Johannes Rieken
816b3e26df
preserve focus when self-replacing 3wm editor (#161076)
fixes https://github.com/microsoft/vscode/issues/160772
2022-09-16 03:01:46 -07:00