mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
d04705c92f
fixes https://github.com/flutter/flutter/issues/176417 This fixes the linked issue in so far as it is possible today. This opts for the runtime lookup of bindings since it avoids all sort of messy issues when dealing with codegen. This doesn't stop us from doing codegen in the future. This also adds tests for hot reload cases that would fail in the past, like inserting new uniforms. ## Limitations 1) It doesn't handle component names like ".r" or ".x". This is possible if we want. 1) It doesn't handle nested structs. This isn't possible with the current shader metadata and may be a limitation with glsl? ## Features 1) Slots can be cached to amortize the cost of looking up the bindings 1) Works with hot reload (tested inserting a uniform before one accessed by name) ## Followup work I plan on filing the following issues: 1) Map postfixes like ".r" ".z" to offsets so a uniform can be "foo.z" 1) Support nested structs so a uniform name can be "foo.bar" 1) Support codegen for uniforms to get compile-time uniform name support ## Example ```dart ShaderBuilder( assetKey: 'shaders/grayscale.frag', (context, shader, _) { Color color = Colors.red; shader.getUniformFloat('uColor', 0).set(color.r); shader.getUniformFloat('uColor', 1).set(color.g); shader.getUniformFloat('uColor', 2).set(color.b); return BackdropFilter( filter: ImageFilter.shader(shader), child: Container( color: Colors.transparent, ), ); }, ), ``` ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md