DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
flutter_flutter/packages/flutter/lib/src/material
History
Greg Spencer 8ec4c59e55
Fix DropdownMenu throwing TextEditingController disposed error on select (#139385) 
## Description

When a DropdownMenu exists within another menu and a MenuItem is selected, the `TextEditingController` of the DropdownMenu is used after it has been disposed.

This PR manages the local `TextController` instance better, making sure that the one used when building is the current one, and handling the case where the `controller` is set on the widget after initial creation.

Also, places where we were setting the text and selection separately were converted to use `TextEditingValue` and set the value atomically.

## Related Issues
 - Fixes https://github.com/flutter/flutter/issues/139266

## Tests
 - Added tests (Created by @josh-burton  in https://github.com/flutter/flutter/pull/139268 - Thanks Josh!)
2023-12-05 01:39:29 +00:00
..
animated_icons
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
shaders
[framework] reduce ink sparkle uniform count. (#133897)
2023-09-13 19:29:06 +00:00
about.dart
…
action_buttons.dart
…
action_chip.dart
Fix chip widgets don't the apply provided iconTheme (#135751)
2023-10-12 14:17:56 +00:00
action_icons_theme.dart
…
adaptive_text_selection_toolbar.dart
…
animated_icons.dart
…
app_bar_theme.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
app_bar.dart
implemented leadingWidth and automaticallyImplyLeading options (#136165)
2023-11-29 08:29:06 +00:00
app.dart
Convert some usage of RawKeyEvent, et al to KeyEvent (#139329)
2023-12-04 21:49:48 +00:00
arc.dart
…
autocomplete.dart
Add timeline events for post frame callbacks (#136435)
2023-10-22 20:46:21 +00:00
back_button.dart
…
badge_theme.dart
…
badge.dart
…
banner_theme.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
banner.dart
Reland "Update framework_test.dart to remove ButtonBar usage and remove references from other clases (#137550) (#137753)
2023-11-14 17:55:05 +00:00
bottom_app_bar_theme.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
bottom_app_bar.dart
…
bottom_navigation_bar_theme.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
bottom_navigation_bar.dart
Reland update bottom navigation bar test for m3 (#137998)
2023-11-20 22:18:38 +00:00
bottom_sheet_theme.dart
…
bottom_sheet.dart
Remove unused generic type from BottomSheet (#137791)
2023-11-03 22:25:37 +00:00
button_bar_theme.dart
Fix. typos (#137325)
2023-10-27 01:09:03 +00:00
button_bar.dart
…
button_style_button.dart
Update ButtonStyleButton.scaledPadding documentation. Migrate callers in flutter/flutter (#139014)
2023-11-29 07:05:42 +00:00
button_style.dart
…
button_theme.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
button.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
calendar_date_picker.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
card_theme.dart
Improve documentation of CardTheme.shape (#139096)
2023-11-29 09:54:59 +00:00
card.dart
Improve documentation of CardTheme.shape (#139096)
2023-11-29 09:54:59 +00:00
checkbox_list_tile.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
checkbox_theme.dart
…
checkbox.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
chip_theme.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
chip.dart
Fix chips onDeleted callback don't show the delete button when disabled (#137685)
2023-11-29 23:57:05 +00:00
choice_chip.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
circle_avatar.dart
…
color_scheme.dart
Docs typo: comprised -> composed (#137896)
2023-11-10 15:00:35 -08:00
colors.dart
…
constants.dart
…
curves.dart
…
data_table_source.dart
…
data_table_theme.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
data_table.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
date_picker_theme.dart
Fix. typos (#137465)
2023-10-31 17:36:10 +00:00
date_picker.dart
Fix memory leaks in DateRangePickerDialog. (#136034)
2023-10-06 11:26:06 +00:00
date.dart
…
debug.dart
…
desktop_text_selection_toolbar_button.dart
…
desktop_text_selection_toolbar.dart
…
desktop_text_selection.dart
…
dialog_theme.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
dialog.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
divider_theme.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
divider.dart
…
drawer_header.dart
…
drawer_theme.dart
…
drawer.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
dropdown_menu_theme.dart
…
dropdown_menu.dart
Fix DropdownMenu throwing TextEditingController disposed error on select (#139385)
2023-12-05 01:39:29 +00:00
dropdown.dart
Fix. typos (#137465)
2023-10-31 17:36:10 +00:00
elevated_button_theme.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
elevated_button.dart
Update ButtonStyleButton.scaledPadding documentation. Migrate callers in flutter/flutter (#139014)
2023-11-29 07:05:42 +00:00
elevation_overlay.dart
…
expand_icon.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
expansion_panel.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
expansion_tile_theme.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
expansion_tile.dart
Added Features requested in #137530 (#137532)
2023-11-20 23:50:49 +00:00
feedback.dart
…
filled_button_theme.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
filled_button.dart
Update ButtonStyleButton.scaledPadding documentation. Migrate callers in flutter/flutter (#139014)
2023-11-29 07:05:42 +00:00
filter_chip.dart
Add delete button support to FilterChip (#136645)
2023-10-23 16:19:25 +00:00
flexible_space_bar.dart
Fix FlexibleSpaceBar does compositing with near zero opacity. (#136255)
2023-10-11 07:19:30 +00:00
floating_action_button_location.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
floating_action_button_theme.dart
…
floating_action_button.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
flutter_logo.dart
…
grid_tile_bar.dart
…
grid_tile.dart
…
icon_button_theme.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
icon_button.dart
Update IconButton.iconSize documentation (#137741)
2023-11-02 17:24:08 +00:00
icons.dart
Bump DartDoc to 8.0.0 (#139088)
2023-11-27 15:33:07 -08:00
ink_decoration.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
ink_highlight.dart
Enable private field promotion for framework (#134473)
2023-09-18 20:51:09 +00:00
ink_ripple.dart
Enable private field promotion for framework (#134473)
2023-09-18 20:51:09 +00:00
ink_sparkle.dart
Fix turbulence seed for all tests with ink sparkles (#138757)
2023-11-28 17:59:19 +00:00
ink_splash.dart
…
ink_well.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
input_border.dart
Make UnderlineInputBorder consistent (#124153)
2023-11-15 23:06:57 +00:00
input_chip.dart
Fix chip widgets don't the apply provided iconTheme (#135751)
2023-10-12 14:17:56 +00:00
input_date_picker_form_field.dart
Add InputDatePickerFormField.focusNode prop (#136673)
2023-10-23 17:15:08 +00:00
input_decorator.dart
Fix intrinsic width of input decorator (#138074)
2023-11-28 05:20:07 +00:00
list_tile_theme.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
list_tile.dart
Added Features requested in #137530 (#137532)
2023-11-20 23:50:49 +00:00
magnifier.dart
…
material_button.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
material_localizations.dart
[l10n] Update Material shareButtonLabel (#138899)
2023-12-01 23:32:57 +00:00
material_state_mixin.dart
…
material_state.dart
Updated MaterialStatesController class api doc (#134592)
2023-09-13 10:33:08 -07:00
material.dart
InkFeature should dispatch creation and disposal events. (#137793)
2023-11-03 12:34:16 -07:00
menu_anchor.dart
Add timeline events for post frame callbacks (#136435)
2023-10-22 20:46:21 +00:00
menu_bar_theme.dart
…
menu_button_theme.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
menu_style.dart
…
menu_theme.dart
…
mergeable_material.dart
AnimationController should dispatch creation in constructor. (#134839)
2023-10-26 16:23:33 -07:00
motion.dart
…
navigation_bar_theme.dart
Add ability to customize NavigationBar indicator overlay and fix indicator shape for the overlay (#138901)
2023-11-27 21:02:35 +00:00
navigation_bar.dart
Add ability to customize NavigationBar indicator overlay and fix indicator shape for the overlay (#138901)
2023-11-27 21:02:35 +00:00
navigation_drawer_theme.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
navigation_drawer.dart
Added option to disable [NavigationDrawerDestination]s (#132349)
2023-09-22 08:03:02 +00:00
navigation_rail_theme.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
navigation_rail.dart
Fix NavigationRail's indicator inkwell doesn't support transparent color. (#136359)
2023-10-16 08:48:13 +00:00
no_splash.dart
Fix NoSplash not being disposed (#138542)
2023-11-17 18:50:33 +00:00
outlined_button_theme.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
outlined_button.dart
Update ButtonStyleButton.scaledPadding documentation. Migrate callers in flutter/flutter (#139014)
2023-11-29 07:05:42 +00:00
page_transitions_theme.dart
[framework] restore old zoom page transition for benchmarking. (#133346)
2023-10-10 22:27:07 +00:00
page.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
paginated_data_table.dart
Fixed : Empty Rows shown at last page in Paginated data table (#132646)
2023-10-18 15:44:31 +00:00
popup_menu_theme.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
popup_menu.dart
Fix header formatting typo in PopupMenuButton docs (#139084)
2023-11-28 18:01:07 +00:00
progress_indicator_theme.dart
…
progress_indicator.dart
🚀 Add more fields to RefreshProgressIndicator (#135207)
2023-09-28 18:21:58 +00:00
radio_list_tile.dart
…
radio_theme.dart
…
radio.dart
…
range_slider.dart
GestureRecognizer should dispatch creation and disposal events. (#138223)
2023-11-10 13:14:14 -08:00
refresh_indicator.dart
🐛 Setup color tween for RefreshIndicator in a better way (#134492)
2023-09-14 18:29:18 +00:00
reorderable_list.dart
[New feature] Allowing the ListView slivers to have different extents while still having scrolling performance (#131393)
2023-09-12 02:16:48 +00:00
scaffold.dart
Remove unused generic type from BottomSheet (#137791)
2023-11-03 22:25:37 +00:00
scrollbar_theme.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
scrollbar.dart
…
search_anchor.dart
Added keyboardType & textInputAction props to SearchBar, SearchAnchor & SearchAnchor.bar (#138553)
2023-11-28 18:38:55 +00:00
search_bar_theme.dart
…
search_view_theme.dart
Fix SearchAnchor's search view isn't updated when the theme changes & widgets inside the search view do not inherit local themes (#132749)
2023-09-27 17:02:17 +00:00
search.dart
implemented leadingWidth and automaticallyImplyLeading options (#136165)
2023-11-29 08:29:06 +00:00
segmented_button_theme.dart
…
segmented_button.dart
Do not hold on to stale canvas reference in _RenderSegmentedButton (#136658)
2023-10-16 21:03:59 +00:00
selectable_text.dart
Fix memory leak in _SelectableTextState (#135049)
2023-09-20 16:43:44 -07:00
selection_area.dart
…
shadows.dart
…
slider_theme.dart
[Feat] Stroke color for Slider value indicator (#135986)
2023-10-18 16:03:08 +00:00
slider.dart
Optimize the display of the Overlay on the Slider (#139021)
2023-12-04 21:30:07 +00:00
snack_bar_theme.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
snack_bar.dart
TextPainter should dispatch creation and disposal events. (#137416)
2023-10-27 21:29:02 -07:00
spell_check_suggestions_toolbar_layout_delegate.dart
…
spell_check_suggestions_toolbar.dart
Add timeline events for post frame callbacks (#136435)
2023-10-22 20:46:21 +00:00
stepper.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
switch_list_tile.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
switch_theme.dart
…
switch.dart
Adaptive Switch (#130425)
2023-11-07 10:26:23 -08:00
tab_bar_theme.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
tab_controller.dart
_DefaultTabControllerState should dispose all created TabContoller instances. (#136608)
2023-10-19 10:38:19 -07:00
tab_indicator.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
tabs.dart
Fix M3 Tabs Specs links (#138808)
2023-11-21 21:46:07 +00:00
text_button_theme.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
text_button.dart
Update ButtonStyleButton.scaledPadding documentation. Migrate callers in flutter/flutter (#139014)
2023-11-29 07:05:42 +00:00
text_field.dart
TextField and TextFormField can use a MaterialStatesController (#133977)
2023-11-29 08:25:20 +00:00
text_form_field.dart
TextField and TextFormField can use a MaterialStatesController (#133977)
2023-11-29 08:25:20 +00:00
text_selection_theme.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
text_selection_toolbar_text_button.dart
…
text_selection_toolbar.dart
…
text_selection.dart
…
text_theme.dart
…
theme_data.dart
Adaptive Switch (#130425)
2023-11-07 10:26:23 -08:00
theme.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
time_picker_theme.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
time_picker.dart
TimePickerDialog should dispose created ChangeNotifiers. (#136261)
2023-10-10 11:05:26 -07:00
time.dart
…
toggle_buttons_theme.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
toggle_buttons.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
toggleable.dart
Enable strict-inference (#135043)
2023-09-20 19:59:08 +00:00
tooltip_theme.dart
Tooltip docs: Recommend setting preferBelow to false in theme (#135879)
2023-11-03 20:18:36 +00:00
tooltip_visibility.dart
Remove 'must be non-null' and 'must not be null' comments from material. (#134991)
2023-09-20 04:20:49 +00:00
tooltip.dart
Make it possible to disable tapping to dismiss a tooltip. (#137375)
2023-11-09 20:10:04 +00:00
typography.dart
Refactor to use Apple system fonts (#137275)
2023-11-29 21:03:32 +00:00
user_accounts_drawer_header.dart
…