Fix memory leak in _SelectableTextState (#135049)

2026-02-20 02:29:02 +08:00 · 2023-09-21 01:43:44 +02:00 · 2023-09-21 01:43:44 +02:00 · 04854e8aff
commit 04854e8aff
parent 1bfd6a1f3c
2 changed files with 137 additions and 124 deletions
--- a/packages/flutter/lib/src/material/selectable_text.dart
+++ b/packages/flutter/lib/src/material/selectable_text.dart
@ -536,6 +536,7 @@ class _SelectableTextState extends State<SelectableText> implements TextSelectio
    super.didUpdateWidget(oldWidget);
    if (widget.data != oldWidget.data || widget.textSpan != oldWidget.textSpan) {
      _controller.removeListener(_onControllerChanged);
+      _controller.dispose();
      _controller = _TextSpanEditingController(
          textSpan: widget.textSpan ?? TextSpan(text: widget.data),
      );
--- a/packages/flutter/test/widgets/selectable_text_test.dart
+++ b/packages/flutter/test/widgets/selectable_text_test.dart