0661e17e90
<!-- start_original_pr_link --> Reverts: flutter/flutter#177468 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: reidbaker <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: did not break tree see https://github.com/flutter/flutter/pull/177472 <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: auto-submit[bot] <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {fluttergithubbot} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: <!-- start_original_pr_link --> Reverts: flutter/flutter#177333 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: reidbaker <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: Possibly broke the tree see https://github.com/flutter/flutter/issues/177465 <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: reidbaker <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {justinmc} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: Updated the pull request template to include a changelog description section and improved clarity on impact description. This came up after multiple release engineering rotations where I needed to ask full time maintinainters to rewrite their changelogs entries. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. <!-- end_revert_body --> <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
1.7 KiB
This pull request is created by automatic cherry pick workflow Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
What is the link to the issue this cherry-pick is addressing?
https://github.com/flutter/flutter/issues/< Replace with issue link here >
Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping of production apps (the app crashes on launch). This information is for domain experts and release engineers to understand the consequences of saying yes or no to the cherry pick.
< Replace with impact description here >
Changelog Description:
Explain this cherry pick:
- In one line that is accessible to most Flutter developers.
- That describes the state prior to the fix.
- That includes which platforms are impacted. See best practices for examples.
< Replace with changelog description here > [flutter/<ISSUE_NUMBER>] When [on <PLAFORMS(S)>],
Workaround:
Is there a workaround for this issue?
< Replace with workaround here >
Risk:
What is the risk level of this cherry-pick?
- Low
- Medium
- High
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
- Yes
- No
Validation Steps:
What are the steps to validate that this fix works?
< Replace with validation steps here >