13662 Commits

Author SHA1 Message Date
Tong Mu
fbefd6b816
Simplify logic of TapGestureRecognizer (#30227)
Refactors the logic of TapGestureRecognizer, making the calling dependency unidirectional between resolve(accept) and checkUp.
v1.4.8
2019-04-01 10:58:30 -07:00
Hans Muller
14aa57b18d
Fix OutlineInputBorder crash (#30123) 2019-04-01 09:28:18 -07:00
engine-flutter-autoroll
d639883c5b
Roll engine f3ec767458f1..a850016454f6 (4 commits) (#30312)
f3ec767458...a850016454

git log f3ec767458f12bb3099248fdc57d6c0d1051f042..a850016454f6d33da64d03dbd1ea71fd0fac299f --no-merges --oneline
a85001645 Roll src/third_party/skia bb482ab871a2..73cc4e8d5fcf (1 commits) (flutter/engine#8395)
aba61e8fb Roll src/third_party/skia 5ee611b26f23..bb482ab871a2 (4 commits) (flutter/engine#8394)
82071e916 Don't access a11y APIs with reflection starting Android P. (flutter/engine#8393)
d9f16111a Roll src/third_party/skia acb4829c1be4..5ee611b26f23 (1 commits) (flutter/engine#8392)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (bmparr@google.com), and stop
the roller if necessary.
2019-04-01 11:36:41 -04:00
Zachary Anderson
61b5caff9a
[fuchsia_tester] Plumb through the location of icudtl (#30218) 2019-04-01 07:48:50 -07:00
engine-flutter-autoroll
976223533d
f3ec76745 Roll src/third_party/skia 83edfbe736fd..acb4829c1be4 (1 commits) (flutter/engine#8391) (#30266)
be6313d875...f3ec767458

git log be6313d87545874a6108edb2a311f30d9a027472..f3ec767458f12bb3099248fdc57d6c0d1051f042 --no-merges --oneline
f3ec76745 Roll src/third_party/skia 83edfbe736fd..acb4829c1be4 (1 commits) (flutter/engine#8391)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (bmparr@google.com), and stop
the roller if necessary.
2019-03-31 07:38:41 -04:00
engine-flutter-autoroll
2a6fc04984
be6313d87 Roll src/third_party/skia 2fdbeae32785..83edfbe736fd (1 commits) (flutter/engine#8390) (#30263)
ae024d7555...be6313d875

git log ae024d755518019f3618931fbc47d3f27e84fad5..be6313d87545874a6108edb2a311f30d9a027472 --no-merges --oneline
be6313d87 Roll src/third_party/skia 2fdbeae32785..83edfbe736fd (1 commits) (flutter/engine#8390)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (bmparr@google.com), and stop
the roller if necessary.
2019-03-31 04:29:41 -04:00
engine-flutter-autoroll
3c9a81c396
ae024d755 Roll src/third_party/skia a6dd1ebd42cf..2fdbeae32785 (1 commits) (flutter/engine#8389) (#30257)
28f8453629...ae024d7555

git log 28f8453629f951d41437aa16bb09957643f1e850..ae024d755518019f3618931fbc47d3f27e84fad5 --no-merges --oneline
ae024d755 Roll src/third_party/skia a6dd1ebd42cf..2fdbeae32785 (1 commits) (flutter/engine#8389)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (bmparr@google.com), and stop
the roller if necessary.
2019-03-30 20:28:40 -04:00
engine-flutter-autoroll
f3acb5d808
Roll engine 8dabd60a30d0..28f8453629f9 (3 commits) (#30255)
8dabd60a30...28f8453629

git log 8dabd60a30d048bf90b4bc0b29914ea00bda182c..28f8453629f951d41437aa16bb09957643f1e850 --no-merges --oneline
28f845362 Roll src/third_party/skia c9822a1818ba..a6dd1ebd42cf (1 commits) (flutter/engine#8388)
2e1f491ba Roll src/third_party/skia 265fd3de3527..c9822a1818ba (1 commits) (flutter/engine#8386)
b466aba58 Roll src/third_party/skia 59b733715141..265fd3de3527 (1 commits) (flutter/engine#8384)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (bmparr@google.com), and stop
the roller if necessary.
2019-03-30 16:45:41 -04:00
Shi-Hao Hong
4d958ea5b7
Added helpful Material assert message (#30219)
Clarified an assert for when a Material widget's backgroundColor is null when its type isn't MaterialType.transparency
2019-03-30 12:58:58 -07:00
engine-flutter-autoroll
f5b0a081e6
Roll engine b75472c106d0..8dabd60a30d0 (2 commits) (#30236)
b75472c106...8dabd60a30

git log b75472c106d0cd0aab45de6bc16e0d6aa6d418cf..8dabd60a30d048bf90b4bc0b29914ea00bda182c --no-merges --oneline
8dabd60a3 Remove unused DartVM::IsKernelMapping (flutter/engine#8381)
63b9d257c Roll src/third_party/dart f29e100f42..1e82544b07 (41 commits)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (bmparr@google.com), and stop
the roller if necessary.
2019-03-30 09:35:40 -04:00
engine-flutter-autoroll
daeaffc188
Roll engine ca7623eb39d7..b75472c106d0 (5 commits) (#30231)
ca7623eb39...b75472c106

git log ca7623eb39d74a8cbdd095fcc7db398267b6928f..b75472c106d0cd0aab45de6bc16e0d6aa6d418cf --no-merges --oneline
b75472c10 Add missing import to functional for Windows. (flutter/engine#8382)
9d7167516 Ensure OpacityLayer to have a single child (flutter/engine#8362)
131cc625a Allow native entrypoint registration for runtime unittests. (flutter/engine#8379)
5e124ffc1 Fix typos (flutter/engine#8339)
972afdc92 Allow running runtime_unittests in AOT mode. (flutter/engine#8375)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (bmparr@google.com), and stop
the roller if necessary.
2019-03-30 01:37:41 -04:00
Jonah Williams
c10e7ba6e9
Revert "Ensure that flutter run/drive/test/update_packages only downloads required artifacts (#30075)" (#30232) 2019-03-29 20:41:07 -07:00
Jonah Williams
89807e68d0
Ensure that flutter run/drive/test/update_packages only downloads required artifacts (#30075) 2019-03-29 20:33:37 -07:00
engine-flutter-autoroll
0e0a4eee57
Roll engine 86f4b741b863..ca7623eb39d7 (5 commits) (#30229)
86f4b741b8...ca7623eb39

git log 86f4b741b863aef5586f03f4d250f1d789fde2be..ca7623eb39d74a8cbdd095fcc7db398267b6928f --no-merges --oneline
ca7623eb3 Handle null values in TextInputConfiguration.actionLabel JSON (flutter/engine#8377)
d0239bd83 Roll src/third_party/skia 73c6c9d26870..59b733715141 (3 commits) (flutter/engine#8378)
71d59cde9 Check for hover motion events in AndroidTouchProcessor (flutter/engine#8376)
fdcbb40fe [flutter_tester] Accept --icu-data-file-path (flutter/engine#8374)
e633b26c5 Introduce unit tests and refactor web dart:ui into "package" (flutter/engine#8346)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (bmparr@google.com), and stop
the roller if necessary.
2019-03-29 22:41:41 -04:00
Jonah Williams
953a947130
add coverage benchmark (#30222) 2019-03-29 17:00:19 -07:00
engine-flutter-autoroll
225843056c
Roll engine a1a2129bc469..86f4b741b863 (5 commits) (#30223)
a1a2129bc4...86f4b741b8

git log a1a2129bc4696e66510be984fd7908eae51eb98f..86f4b741b863aef5586f03f4d250f1d789fde2be --no-merges --oneline
86f4b741b Move libdart selection into its own target in //flutter/runtime. (flutter/engine#8373)
f39cf3774 Add a GN format presubmit. (flutter/engine#8371)
d6e2d8527 Roll src/third_party/skia 7eeb74fdfd84..73c6c9d26870 (8 commits) (flutter/engine#8372)
8412c199a Enable Linux shell build (flutter/engine#8233)
133901199 libtxt: track the start and end x positions of glyph blobs for more accurate rendering of text decorations (flutter/engine#8368)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (bmparr@google.com), and stop
the roller if necessary.
2019-03-29 19:49:40 -04:00
Jonah Williams
b8bcfaa56f
make sure flutter test asks for cache upgrades (#30216) 2019-03-29 15:58:16 -07:00
xster
f2d671c15c
Cupertino localization step 3: in-place move some material tools around to make room for cupertino (#29644) 2019-03-29 15:57:09 -07:00
xster
d166a8d81e
Make sure everything in the Cupertino page transition can be linear when back swiping (#28629) 2019-03-29 15:56:18 -07:00
dacaiguoguo
1c0f82541c Set custom flutter_assets by add FLTAssetsPath to AppFrameworkInfo.plist (#29499)
* Get FLTAssetsPath from AppFrameworkInfo.plist
2019-03-29 15:45:18 -07:00
Jonah Williams
8220f8f4e3
add missing test case and handle wildcard removal (#30205) 2019-03-29 14:26:56 -07:00
engine-flutter-autoroll
6b2e939480
Roll engine 82765aa77db9..a1a2129bc469 (13 commits) (#30209)
82765aa77d...a1a2129bc4

git log 82765aa77db9621dfbc50801ee2709aa0a00e04d..a1a2129bc4696e66510be984fd7908eae51eb98f --no-merges --oneline
a1a2129bc GN Format all files in the engine. (flutter/engine#8369)
82c910414 Remove old Fuchsia external mem,sem extensions
6d1a6a4f4 Allow per-platform customization of the default Skia font manager (flutter/engine#8358)
3de50b8d2 Roll src/third_party/skia 84a53268af92..7eeb74fdfd84 (3 commits) (flutter/engine#8367)
65837ab32 Roll src/third_party/skia a2cec203eea8..84a53268af92 (1 commits) (flutter/engine#8366)
ada0a8e2b Roll src/third_party/skia 57b7a792bb6f..a2cec203eea8 (1 commits) (flutter/engine#8365)
9729f1ae3 Roll src/third_party/skia bf4229cc10a1..57b7a792bb6f (5 commits) (flutter/engine#8364)
23e0c3758 Roll src/third_party/skia 01fe26360660..bf4229cc10a1 (6 commits) (flutter/engine#8363)
fd0b44045 Roll src/third_party/skia cc8c7bee7925..01fe26360660 (10 commits) (flutter/engine#8361)
96c975163 Rename threshold to access_threshold (flutter/engine#8354)
09a67fe60 update buildroot dep for e2ca4571fa (flutter/engine#8359)
602b61213 Reduce z-fighting on Scenic (flutter/engine#8318)
b53e436f9 Roll src/third_party/dart a977273262..f29e100f42 (8 commits)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (bmparr@google.com), and stop
the roller if necessary.
2019-03-29 17:25:41 -04:00
Darren Austin
3892a0d96c
Made the showMenu() position parameter required (#30206)
Made the showMenu() position parameter required as it doesn't make sense to show a menu without indicating where it should be shown. Also added a test to verify this.
2019-03-29 14:15:03 -07:00
Michael Goderbauer
a3cbe25353
Part 1: Improve Overlay API (#28747) 2019-03-29 14:09:30 -07:00
Jonah Williams
d4f8a7f267
disable jit snapshot until we know what is going on here (#30204) 2019-03-29 13:10:36 -07:00
Dan Field
d6ddf82fe4
roll engine to 82765aa77db9621dfbc50801ee2709aa0a00e04d (#30198) 2019-03-29 12:41:58 -07:00
Shi-Hao Hong
0e2eeb5a48
Set Max Height for ListTile trailing and leading widgets (#29771) 2019-03-29 12:22:31 -07:00
liyuqian
ffbb335e35
Error message for setting shaderWarmUp too late (#30145)
Developers may get confused by setting PaintingBinding.shaderWarmUp in
the wrong place. The added assert and error message help avoid that.
2019-03-29 10:49:07 -07:00
Jonah Williams
1bfa2f2311
Intercept errors thrown by synchronous Completers in image resolution. (#30139) v1.4.7 2019-03-29 10:05:18 -07:00
Shi-Hao Hong
cbe4c9e1d7
Add link to hero animation page (#30059) 2019-03-28 18:14:55 -07:00
Darren Austin
19901f674b
Fix a misuse of matchesGoldenFile() in the physical_model_test. (#30141)
Fixed a misuse of matchesGoldenFile() in the physical_model_test so that it correctly reports a failed test on Linux (and skips the other platforms).
2019-03-28 18:08:29 -07:00
Ian Hickson
1123b71454 Update PULL_REQUEST_TEMPLATE.md (#29621)
This tries to make it more obvious when someone checks the "tests" box without actually having added tests.
2019-03-28 17:44:58 -07:00
Jonah Williams
876b45f64e
skip .dart_tool folders when running update-packages (#30082) 2019-03-28 12:15:59 -07:00
Jonah Williams
a813dc559a
Add more test coverage to image handling (#30078) 2019-03-28 10:37:49 -07:00
Christopher Fujino
ec93c87c89
Move spinner _defaultSlowWarning message to a new line (#30071)
* write newline before adding slow restart message to spinner
* update existing test
v1.4.6
2019-03-28 10:08:44 -07:00
Francisco Magdaleno
b70d260b3c
Adds the keyboard mapping for Linux (#29993) 2019-03-28 10:04:23 -07:00
engine-flutter-autoroll
a1712dcfbe
Roll engine 37947f961a62..c4d14a00716f (11 commits) (#30094)
37947f961a...c4d14a0071

git log 37947f961a6242d2efc05a55a4319b120764a403..c4d14a00716fa616b69d51bab957aee483bdc9c2 --no-merges --oneline
c4d14a007 Roll src/third_party/skia e4c67058ddb1..01a065884b7d (1 commits) (flutter/engine#8344)
5983b7adf Roll src/third_party/dart ffee99d79b..cf32584870 (6 commits)
84c62b4c7 Build Windows shell (flutter/engine#8331)
6415277d0 Roll src/third_party/skia 8d2c19554e4a..e4c67058ddb1 (1 commits) (flutter/engine#8341)
a0110107e Roll src/third_party/dart 991c9da720..ffee99d79b (7 commits)
2098398e1 Cleanups to run_tests.sh script (flutter/engine#8337)
5c99138fa Build GLFW from source for Linux shell (flutter/engine#8327)
68002458f Fix Windows build. (flutter/engine#8336)
6d8b83677 Remove use of epoxy from Linux shell (flutter/engine#8334)
4efc32163 Add super call in FLEView reshape (flutter/engine#8335)
cb8eb801a Allow embedders to specify their own task runner interfaces. (flutter/engine#8273)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (bmparr@google.com), and stop
the roller if necessary.
2019-03-28 11:55:43 -04:00
Jonah Williams
557c94ff77
Move binarySearch implementation in animated_list to foundation/collection.dart. (#29860) 2019-03-28 01:00:29 -07:00
engine-flutter-autoroll
16b7fd6a63
Roll engine 76200562779e..37947f961a62 (2 commits) (#30074)
7620056277...37947f961a

git log 76200562779e49d34e62056b66800ac870197092..37947f961a6242d2efc05a55a4319b120764a403 --no-merges --oneline
37947f961 Allow delegation of a11y events from nodes that were not yet traversed (flutter/engine#8333)
deeb7a747 Roll src/third_party/skia 99ccc0ca87e6..8d2c19554e4a (11 commits) (flutter/engine#8332)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (bmparr@google.com), and stop
the roller if necessary.
2019-03-28 03:58:41 -04:00
Shi-Hao Hong
de6995cfa8
Added Hero zero-frame animation documentation (#30048) 2019-03-27 18:17:12 -07:00
Nizarius
ea343ccc3f CupertinoTextField: added ability to change placeholder color (#28001) 2019-03-27 17:25:29 -07:00
Jonah Williams
3c93b65a9b
Update to latest matcher (#30019) 2019-03-27 17:21:10 -07:00
engine-flutter-autoroll
b889b400a0
Roll engine 3a3f707d5a9b..76200562779e (2 commits) (#30070)
3a3f707d5a...7620056277

git log 3a3f707d5a9b17388b60ff10b9f65b0c6a3c4134..76200562779e49d34e62056b66800ac870197092 --no-merges --oneline
762005627 Android Embedding PR22: Polish - FlutterActivity Intent factories, FlutterFragment control of render modes, FlutterSurfaceView transparent until rendering is ready. (flutter/engine#8317)
6bd697dd4 Fix "PointerEvent" flow end event (flutter/engine#8319)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (bmparr@google.com), and stop
the roller if necessary.
2019-03-27 20:13:41 -04:00
Jonah Williams
99866f4a3d
Make timeout durations configurable (#30053) v1.4.5 2019-03-27 16:21:16 -07:00
xster
4b365fb92a
Cupertino localization step 1.5: fix a resource mismatch in cupertino_en.arb (#29821) 2019-03-27 15:41:44 -07:00
engine-flutter-autoroll
1aabb0acec
Roll engine 0d83a2ecd1bb..3a3f707d5a9b (25 commits) (#30063)
0d83a2ecd1...3a3f707d5a

git log 0d83a2ecd1bb78f8e1f0ed9719ff3751cdfdd064..3a3f707d5a9b17388b60ff10b9f65b0c6a3c4134 --no-merges --oneline
3a3f707d5 Reland "Allow specification of std::functions as native entrypoints from Dart code." (flutter/engine#8329)
d4275d9ee Roll src/third_party/skia 576eb87a2d2d..99ccc0ca87e6 (5 commits) (flutter/engine#8328)
3a415c4f1 Map glfw into third_party, and roll buildroot (flutter/engine#8308)
ce9ea5869 [fuchsia] Disable FML_TRACE_COUNTER events to unblock roll (flutter/engine#8325)
48496588c Roll src/third_party/dart 8a92d2a8d9..991c9da720 (2 commits)
20c241ac3 Roll src/third_party/skia c476e5da4fef..576eb87a2d2d (7 commits) (flutter/engine#8324)
cadcf1c58 Roll src/third_party/dart f3fd1943fc..8a92d2a8d9 (16 commits)
66141eb8e Roll src/third_party/skia d1c271bd39f0..c476e5da4fef (2 commits) (flutter/engine#8322)
e5b31cdd9 Roll src/third_party/skia cec20280b3fb..d1c271bd39f0 (3 commits) (flutter/engine#8321)
1daff5ce1 Roll src/third_party/skia bf341ae88c83..cec20280b3fb (3 commits) (flutter/engine#8320)
87db585ad Roll src/third_party/skia 45d5f702133e..bf341ae88c83 (2 commits) (flutter/engine#8316)
fd7d7fa5a Add a11y support for embedded iOS platform view (flutter/engine#8156)
f64ee01e1 Roll src/third_party/skia d2ca31218bc4..45d5f702133e (11 commits) (flutter/engine#8315)
f521df383 Fixed service isolate not being initialized correctly due to bad name (flutter/engine#8251)
80b825ce8 Roll src/third_party/dart 093c2909fe..f3fd1943fc (13 commits) (flutter/engine#8310)
7e77d5c48 Revert "Allow specification of std::functions as native entrypoints from Dart code. (#8309)" (flutter/engine#8312)
400a86a62 Allow specification of std::functions as native entrypoints from Dart code. (flutter/engine#8309)
51f23fedf [vulkan] Add FUCHSIA external sem/mem extensions
78de8dcb4 Enable lambda like native callbacks in tests and add support for custom entrypoints. (flutter/engine#8299)
2812c7db4 Roll src/third_party/skia 62fd6c411622..d2ca31218bc4 (9 commits) (flutter/engine#8307)
95f9134e9 Roll src/third_party/skia d90004516a63..62fd6c411622 (4 commits) (flutter/engine#8306)
358273bd2 Roll src/third_party/skia 33211b2c7a02..d90004516a63 (1 commits) (flutter/engine#8305)
2804057bf Roll src/third_party/skia 80dd599e91d0..33211b2c7a02 (1 commits) (flutter/engine#8303)
a673bbf6f Roll src/third_party/skia c5ee499f2c59..80dd599e91d0 (5 commits) (flutter/engine#8301)
d88037dc0 Roll src/third_party/dart fa74184b7a..093c2909fe (71 commits)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (bmparr@google.com), and stop
the roller if necessary.
2019-03-27 18:38:41 -04:00
Jonah Williams
0a2175f133
Pass FLUTTER_TOOL_ARGS to snapshot command. (#29938) 2019-03-27 15:24:08 -07:00
Kate Lovett
76b9962fdd
Embedding new diagrams for API Docs (#29697)
* Embedding new diarams for API docs: Container, ListView, Align.

* Moving the diagrams to be enclosed within the snippet windows.

* Fixed wording for the alt image text.
2019-03-27 14:52:18 -07:00
Jonah Williams
50f1e1822a
ensure packages file is updated when using build_runner (#29885) 2019-03-27 14:40:52 -07:00
Chris Yang
3b3f6c7a04
Include platformViewId in semantics tree for iOS (#29304)
Include the platformViewId of PlatformViews in the semantics tree. The accessibility bridge in the engine can use this id to steal the semantics nodes from the actual platform view and stick them into Flutter's semantics tree.

It is the iOS PlatformView counter part of https://github.com/flutter/flutter/pull/28953. It reverts the change in 5b5d6e89ec and 03fd797eb8.

https://github.com/flutter/flutter/issues/29302
v1.4.4
2019-03-27 13:56:23 -07:00