LongCatIsLooong
37f9c54116
Use RenderSliverPadding to inset SliverFillViewport ( #45432 )
2019-11-27 11:33:38 -08:00
Kate Lovett
1374a41313
Provide debug output for Gold uploads on post-submit ( #45704 )
2019-11-27 11:29:53 -08:00
Zachary Anderson
e4b809b7c8
[flutter_tool] Crash less when git fails during 'version' ( #45628 )
2019-11-27 10:18:43 -08:00
Takeshi Tsukamoto
876303b3f9
Fix comment ( #45325 )
2019-11-27 10:01:57 -08:00
engine-flutter-autoroll
84a1de5c74
fad1b23c4 Roll fuchsia/sdk/core/linux-amd64 from xyyOR... to mSEnz... (flutter/engine#14043) ( #45689 )
...
git@github.com:flutter/engine.git/compare/18d74fe45b9c...fad1b23c42b9
git log 18d74fe45b9c..fad1b23c42b9 --first-parent --oneline
2019-11-27 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from xyyOR... to mSEnz... (#14043 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-27 07:40:51 -05:00
Danny Tuppeny
4741e9c3fe
Retry Xcode builds if they fail due to concurrent builds running ( #45608 )
...
* Retry Xcode builds if they fail due to concurrent builds running
Fixes #40576 .
* Add tests for concurrent iOS launches
* Increase number of retries to account for the initial build being slow
2019-11-27 09:44:05 +00:00
engine-flutter-autoroll
3e3b49e132
18d74fe45 Show test output when engine unit test fails. (flutter/engine#14026) ( #45675 )
...
git@github.com:flutter/engine.git/compare/e3e5f8dabc2e...18d74fe45b9c
git log e3e5f8dabc2e..18d74fe45b9c --first-parent --oneline
2019-11-27 flar@google.com Show test output when engine unit test fails. (#14026 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-27 02:59:51 -05:00
engine-flutter-autoroll
1b835a722b
e3e5f8dab Adding support for enabling semantics on desktop (flutter/engine#14003) ( #45667 )
...
git@github.com:flutter/engine.git/compare/2c0eee43923f...e3e5f8dabc2e
git log 2c0eee43923f..e3e5f8dabc2e --first-parent --oneline
2019-11-27 50856934+nturgut@users.noreply.github.com Adding support for enabling semantics on desktop (#14003 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-26 23:48:51 -05:00
engine-flutter-autoroll
3d4ceaf460
Roll engine 5250d6315e7a..2c0eee43923f (2 commits) ( #45663 )
...
git@github.com:flutter/engine.git/compare/5250d6315e7a...2c0eee43923f
git log 5250d6315e7a..2c0eee43923f --first-parent --oneline
2019-11-26 garyq@google.com Always set mEditable values when different in TextPlugin (#13951 )
2019-11-26 dnfield@google.com Avoid retaining self in block (#14022 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-26 22:40:51 -05:00
Kaushik Iska
d1805aa22a
update-packages after dwds updates ( #45633 )
2019-11-26 18:34:06 -08:00
engine-flutter-autoroll
20025e2579
Roll engine 27fa60793bcb..5250d6315e7a (4 commits) ( #45659 )
...
git@github.com:flutter/engine.git/compare/27fa60793bcb...5250d6315e7a
git log 27fa60793bcb..5250d6315e7a --first-parent --oneline
2019-11-26 skia-flutter-autoroll@skia.org Roll src/third_party/skia 54036c9b8e4b..40a7dfc268b6 (1 commits) (#14016 )
2019-11-26 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from Bxgic... to aVdHP... (#14017 )
2019-11-26 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from kzFUw... to xyyOR... (#14021 )
2019-11-26 chinmaygarde@gmail.com Add a separate target for Dart coverter on FML types. (#14011 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-26 21:33:51 -05:00
Greg Spencer
245d1b51ce
Add macOS to TargetPlatform ( #43457 )
...
This PR adds TargetPlatform.macOS to the TargetPlatform enum. This allows us to begin implementation of some adaptive UI based on which target platform is desired.
I haven't updated the tests here, that will come in a follow-up PR.
2019-11-26 18:32:34 -08:00
engine-flutter-autoroll
e60c0f6852
27fa60793 Added docstring for FlutterOverlayView. (flutter/engine#14019) ( #45642 )
...
git@github.com:flutter/engine.git/compare/e136d637a873...27fa60793bcb
git log e136d637a873..27fa60793bcb --first-parent --oneline
2019-11-26 30870216+gaaclarke@users.noreply.github.com Added docstring for FlutterOverlayView. (#14019 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-26 19:05:51 -05:00
Jonah Williams
831163f0d0
Register memory info command on vmservice for Android devices ( #45568 )
2019-11-26 14:49:56 -08:00
Dan Field
2d3d220988
Implicit scrolling for pageview ( #45598 )
2019-11-26 14:12:34 -08:00
Jenn Magder
7d8f82051b
Suggest GitHub template when flutter tool crashes ( #45360 )
...
* On flutter tool crash suggest GitHub template
* Shorten GitHub URLs
* Whitespace
* Wording tweak from @InMatrix
* Review edits
2019-11-26 14:06:31 -08:00
Albertus Angga Raharja
e1512b4dd7
Add additional properties callback in Inspector Serialization Delegate ( #45531 )
...
* Add additional properties callback in Inspector Serialization Delegate
* Rename _SerializationDelegate to InspectorSerializationDelegate and add test
* Fix indentation
* Remove trailing whitespace
* Handle case when addAdditionalPropertiesCallback returns null
* Improve docs and minor renames
* Improve docs
* Improve documentation
2019-11-26 13:57:41 -08:00
Greg Spencer
0190e40457
Keyboard scrolling of Scrollable ( #45019 )
...
This adds the ability to scroll and page up/down in a Scrollable using the keyboard. Currently, the macOS bindings use Platform.isMacOS as a check, but we'll switch that to be defaultTargetPlatform == TargetPlatform.macOS once that exists.
2019-11-26 09:56:25 -08:00
Danny Tuppeny
459c7fb884
Resume isolate before terminating tests to prevent flutter_tester leaks in integration tests ( #45248 )
...
* Resume isolate before terminating tests to prevent flutter_tester leak
* Fix lint
* Catch exceptions from resume() as well as timeout()
* Formatting fixes
* Don't try to resume if there's no vm service
* Fix handling of timeouts to not leak futures
2019-11-26 17:04:51 +00:00
Christopher Fujino
dc68d5700b
Fix flutter run cache ( #45267 )
2019-11-26 09:02:34 -08:00
Emmanuel Garcia
943f98d3c3
Add integration test for transitive plugin dependencies ( #45579 )
2019-11-26 08:58:43 -08:00
engine-flutter-autoroll
b2a36ffcd2
Roll engine 96cba6c92a8a..e136d637a873 (2 commits) ( #45616 )
...
git@github.com:flutter/engine.git/compare/96cba6c92a8a...e136d637a873
git log 96cba6c92a8a..e136d637a873 --first-parent --oneline
2019-11-26 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from 1nxSz... to Bxgic... (#14014 )
2019-11-26 skia-flutter-autoroll@skia.org Roll src/third_party/skia 4f90f9d83183..54036c9b8e4b (4 commits) (#14013 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-26 11:45:51 -05:00
Kate Lovett
8a48a27847
Performance Improvement for SliverFillRemaining ( #44471 )
2019-11-26 08:04:22 -08:00
Kate Lovett
cd94cd886a
SliverOffstage Fix ( #45580 )
2019-11-26 08:01:03 -08:00
Alexandre Ardhuin
a2c3f6c567
implicit-casts:false in flutter/lib/src/animation ( #45501 )
2019-11-26 16:53:14 +01:00
Alexandre Ardhuin
4055e19680
implicit-casts:false in flutter/lib/src/foundation ( #45503 )
2019-11-26 16:52:37 +01:00
engine-flutter-autoroll
9e72a80ab4
Roll engine 05f8c8b24b92..96cba6c92a8a (5 commits) ( #45597 )
...
git@github.com:flutter/engine.git/compare/05f8c8b24b92...96cba6c92a8a
git log 05f8c8b24b92..96cba6c92a8a --first-parent --oneline
2019-11-26 skia-flutter-autoroll@skia.org Roll src/third_party/skia 8fa469d3bcd6..4f90f9d83183 (4 commits) (#14012 )
2019-11-26 hterkelsen@users.noreply.github.com Refactor CanvasKit backend in preparation for platform views (#13935 )
2019-11-26 iska.kaushik@gmail.com [vulkan] Bundle vulkan validation layer so files (#13930 )
2019-11-25 chinmaygarde@google.com Don't crash but warn when the scene builder specifies no layers. (#14008 )
2019-11-25 franciscojma@google.com Remove device independent mask (#14010 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-26 10:50:51 -05:00
engine-flutter-autoroll
92b0ceaaa6
Roll engine 298e053bdc04..05f8c8b24b92 (5 commits) ( #45586 )
...
git@github.com:flutter/engine.git/compare/298e053bdc04...05f8c8b24b92
git log 298e053bdc04..05f8c8b24b92 --first-parent --oneline
2019-11-25 skia-flutter-autoroll@skia.org Roll src/third_party/skia 50299de39976..8fa469d3bcd6 (21 commits) (#14009 )
2019-11-25 jason-simmons@users.noreply.github.com Convert images to raster on the GPU thread for Image.toByteData (#13647 )
2019-11-25 dworsham@google.com Fix most fml tests on Fuchsia (#14007 )
2019-11-25 bkonyi@google.com Roll src/third_party/dart d5fa596d74..134e0e28cd (9 commits) (#14006 )
2019-11-25 amirh@users.noreply.github.com revert accidental change to MultipePlatformViewsTest (#13481 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-26 01:19:51 -05:00
Alexandre Ardhuin
f6dc4db2e0
implicit-casts:false in flutter/lib/src/gestures ( #45504 )
...
* implicit-casts:false in flutter/lib/src/gestures
* address review comments
2019-11-26 07:03:34 +01:00
Dan Field
e766ae740e
Automatically caching viewport ( #45327 )
2019-11-25 21:05:46 -08:00
Jonah Williams
84ce3f6097
Serve web source maps in release runner ( #45318 )
2019-11-25 17:09:36 -08:00
Greg Spencer
46632f9edc
Handle bare modifier flags on macOS ( #45438 )
...
This fixes an unreported bug in the macOS key handling where for some remote access situations, the modifier mask is set to the "any modifier" mask without any side specified (e.g. modifierShift bit is specified and not modifierLeftShift bit).
2019-11-25 17:06:16 -08:00
engine-flutter-autoroll
29650850e5
Roll engine c89ac6347b7e..298e053bdc04 (3 commits) ( #45572 )
...
git@github.com:flutter/engine.git/compare/c89ac6347b7e...298e053bdc04
git log c89ac6347b7e..298e053bdc04 --first-parent --oneline
2019-11-25 jonahwilliams@google.com Add support for FontLoader API for the web (#13999 )
2019-11-25 brianosman@google.com Use new SkPathDirection enum, previous one is deprecated (#14005 )
2019-11-25 skia-flutter-autoroll@skia.org Roll src/third_party/skia c3ff97a98b74..50299de39976 (1 commits) (#13998 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-25 19:25:51 -05:00
engine-flutter-autoroll
7726910a5b
c89ac6347 Roll fuchsia/sdk/core/linux-amd64 from _7JyV... to hK-BD... (flutter/engine#13997) ( #45565 )
...
git@github.com:flutter/engine.git/compare/b0d2caceab25...c89ac6347b7e
git log b0d2caceab25..c89ac6347b7e --first-parent --oneline
2019-11-25 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from _7JyV... to hK-BD... (#13997 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-25 16:47:51 -05:00
Jenn Magder
8eb6a925f9
Always compile with isysroot on iOS to point to SDK root ( #45436 ) ( #45560 )
2019-11-25 12:49:18 -08:00
Kate Lovett
d0ea9ed244
SliverOffstage ( #45128 )
2019-11-25 12:49:10 -08:00
Kate Lovett
1160c8fd29
Re-Staged: Fixing ContinuousRectangleBorder bottom radius ( #45304 )
2019-11-25 12:43:58 -08:00
engine-flutter-autoroll
c64d91a03f
Roll engine b6b54fd60631..b0d2caceab25 (2 commits) ( #45564 )
...
git@github.com:flutter/engine.git/compare/b6b54fd60631...b0d2caceab25
git log b6b54fd60631..b0d2caceab25 --first-parent --oneline
2019-11-25 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from Q9HKI... to 1nxSz... (#13995 )
2019-11-25 30870216+gaaclarke@users.noreply.github.com Removed auto roll commits from auto_assign. (#13992 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-25 15:41:51 -05:00
Jonah Williams
cf37c2cd07
Add assert for negative child count in ListView.builder ( #45506 )
2019-11-25 12:04:30 -08:00
Jonah Williams
1888fa3526
Allow flutter run to run release/profile x64 ( #45511 )
2019-11-25 12:04:17 -08:00
Alexandre Ardhuin
e6935efdf6
remove avoid_as lint for the upcoming implicit-casts: false ( #45527 )
2019-11-25 21:03:29 +01:00
Emmanuel Garcia
81724bd60f
Fallback to protocol discovery if mdns returns null ( #45439 )
2019-11-25 11:51:54 -08:00
Michael Klimushyn
901eb0fc81
Add a note to generated plugins files ( #45557 )
...
There has been some confusion about whether or not
.flutter-plugins-dependencies should be tracked in version control or
not. Added a comment to both it and .flutter-plugins explaining that
it's generated and shouldn't be.
.flutter-plugins-dependencies is parsed through JSON, and the JSON spec
doesn't support comments. So unfortunately the note is living in an
arbitrary "_info" key instead of an obvious top level comment.
2019-11-25 11:47:20 -08:00
Jenn Magder
4cc10a1fb8
Revert "Always compile with isysroot on iOS to point to SDK root ( #45436 )" ( #45555 )
...
Analyzer warning.
2019-11-25 10:46:42 -08:00
Jenn Magder
6b11f18bc0
Always compile with isysroot on iOS to point to SDK root ( #45436 )
2019-11-25 10:27:22 -08:00
Todd Volkert
bae92c32e5
Disable tests that fail on non-master branches from running on those branches ( #45455 )
...
https://github.com/flutter/flutter/issues/45453
2019-11-24 22:29:28 -08:00
Alexandre Ardhuin
980f14e0c5
implicit-casts:false on flutter_tools ( #45153 )
...
* implicit-casts:false on flutter_tools
* use castStringKeyedMap
* address review comments
* address review comments
* fix issues after rebase
2019-11-24 06:54:43 +01:00
engine-flutter-autoroll
033b897be5
b6b54fd60 PR ( #45456 )
...
git@github.com:flutter/engine.git/compare/591144dfef59...b6b54fd60631
git log 591144dfef59..b6b54fd60631 --no-merges --oneline
2019-11-23 chinmaygarde@google.com PR
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-23 04:05:54 -05:00
engine-flutter-autoroll
f87cbe05b9
591144dfe Roll src/third_party/dart 603fd7881f..16cbabec3a (1 commits) (flutter/engine#13994) ( #45452 )
...
git@github.com:flutter/engine.git/compare/d1cac77d5a4e...591144dfef59
git log d1cac77d5a4e..591144dfef59 --no-merges --oneline
2019-11-23 bkonyi@google.com Roll src/third_party/dart 603fd7881f..16cbabec3a (1 commits) (#13994 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-23 03:09:54 -05:00
engine-flutter-autoroll
f40dbf8ca0
d1cac77d5 Roll src/third_party/skia 47af12aa8331..c3ff97a98b74 (3 commits) (flutter/engine#13993) ( #45450 )
...
git@github.com:flutter/engine.git/compare/a6e890666d22...d1cac77d5a4e
git log a6e890666d22..d1cac77d5a4e --no-merges --oneline
2019-11-23 skia-flutter-autoroll@skia.org Roll src/third_party/skia 47af12aa8331..c3ff97a98b74 (3 commits) (#13993 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-23 01:02:54 -05:00
