5219 Commits

Author SHA1 Message Date
Michael Goderbauer
dda7382e49
Fix the the (#21732) 2018-09-14 12:42:20 +02:00
Mehmet Fidanboylu
2895d71b79
Make Flutter repo Dart SDK 2.1-dev3.1 compatible (#21853)
This is a blocker for Google roll since we are not at dev4.0:
- Future is not yet part of dart:core.
- Future.sync().then<dynamic>... causes failure without the new keyword.
2018-09-13 18:50:21 -07:00
liyuqian
069cddaa67
Missing default hardEdge clip for ClipRectLayer (#21826)
In my local tests, this should finally fix https://github.com/flutter/flutter/issues/21617
2018-09-13 11:42:49 -07:00
Jonah Williams
9bf8502fef
Add debug check for localization parent (#20787) 2018-09-13 10:47:31 -07:00
Hans Muller
d107ff9d48
Make TabBar's tab label padding configurable (#21758) 2018-09-13 08:59:00 -07:00
Gary Qian
28ba95abb1
Default clipBehavior of ClipRect to hardEdge. (#21703)
Previously, the engine did not properly pass the AA flag on ClipRect.clipBehavior. flutter/engine#6199 fixes this and enables AA. However, default AA on clipRects has caused severe regressions in benchmark performance.

To maintain expected performance, we should now default the clipBehavior to hardEdge to disable default AA. This is consistent with any flutter projects that did not previously explicitly set the clipBehavior and should not change app appearance.
2018-09-13 00:32:12 -07:00
Jonah Williams
23499f4004
Fix typo in MediaQuery.fromWindow and add invertColors flag to images for smart invert. (#21457) 2018-09-12 14:50:49 -07:00
Jonah Williams
5ea987db1d
Adjust floating label height when font size is larrrrgeee (#21248) 2018-09-12 14:17:43 -07:00
Jonah Williams
dd1c22e389
fix_some_padding (#20967) 2018-09-12 14:07:02 -07:00
Jacob Richman
29fae06f48
Temporarily remove screenshot service extension that is causing code size issues (#21749)
* Revert "Avoid ever creating the WidgetInspectorService outside of debug mode. (#21648)"

This reverts commit eeebd8332a5f4f5c79a9c77877781d7f1132d57b.

* Remove inspector screenshot service extension.
2018-09-12 13:30:16 -07:00
Ben Hagen
07dd80712e Call setState() (#21642) 2018-09-12 14:31:50 +02:00
Alexandre Ardhuin
d927c93310
Unnecessary new (#20138)
* enable lint unnecessary_new

* fix tests

* fix tests

* fix tests
2018-09-12 08:29:29 +02:00
Alexandre Ardhuin
387948a239
remove an avoid_void_async lint (#21672) 2018-09-11 08:51:42 +02:00
Alexandre Ardhuin
774ca2f197
enable lint avoid_void_async (#21652) 2018-09-11 07:14:04 +02:00
Dan Field
98ad574d9b
Fix keepalive for large jumps on tabs and lists. (#21350)
* Ensure that the _childElements map is properly traversed as a sparse list and not inflated with garbage collected children.

* Add tests to ensure Lists/Tabs with KeepAlive children can make large jumps, don't lose children (including after rebuild).
2018-09-10 21:01:10 -04:00
Jacob Richman
eeebd8332a
Avoid ever creating the WidgetInspectorService outside of debug mode. (#21648) 2018-09-10 15:20:22 -07:00
jslavitz
9dce4b8259
Shortcuts (#21558)
* added shortcuts and delete functionality

* added first test

*  afew chnages

* a few changes

* hope this works

* small change

* small changes

* fixed nits

* final changes:

* fixed initializing formals

* update comment

* minor change:

* added line

* final changes

* random change

* changed function to void

* one more

* removed line

* dis betta work

* final change

* actual final chnge
2018-09-10 13:47:04 -07:00
Michael Klimushyn
8ebd352511
Add semantic routing to CupertinoAlertDialog (#21583)
Fixes #21250
2018-09-10 13:15:55 -07:00
Gary Qian
d3e36807fe
Update goldens, and new Golden test for ClipRect (#21575) 2018-09-10 10:46:52 -07:00
Will Larche
c8ecae6935
[Material] Corrects default inactive switch track color (#21405)
* [Material] Corrects default switch color.

* [Switch] Making black32 a local const.

* [Switch] Tests for default colors.

* [Switch] Correcting number for being over 255.
2018-09-10 12:00:16 -04:00
Hans Muller
ed698b8165
Remove inheritFromElement assert, it can fail during deactivation (#21570) 2018-09-07 16:46:44 -07:00
Jonah Williams
3821c35d04
Ensure that textDirection is always passed to ShapeBorder.getOuterPath (#21532) 2018-09-07 14:38:14 -07:00
Michael Klimushyn
9a290c174a
Expand DropdownButton width based on isExpanded flag (#21515)
* Fix Dropdown where icon not set to end of button

* Expand DropdownButton based on isExpanded flag

* Add dropdown golden tests

Fixes #13135, #16606
2018-09-07 14:01:21 -07:00
Jonah Williams
11943ce7e7
Revert "Shortcuts (#21083)" (#21556)
This reverts commit 6e7f3e6f5a11341edd5c2519cbe1c7bc178cb8e9.
2018-09-07 10:36:52 -07:00
jslavitz
6e7f3e6f5a
Shortcuts (#21083)
* added shortcuts and delete functionality

* added first test

*  afew chnages

* a few changes

* hope this works

* small change

* small changes

* fixed nits

* final changes:

* fixed initializing formals

* update comment

* minor change:

* added line

* final changes
2018-09-07 10:28:35 -07:00
Jacob Richman
a2acc6a3e5
Revert "Revert "Enable taking screenshots of arbitrary RenderObjects from a running a… (#20637)" (#21395)" (#21448)
This reverts commit 5b5a5b82286923f52225320f5e9fc9f558838c05.
2018-09-07 10:02:05 -07:00
Ben Konyi
de9f775fc0
Fixed missing implementations of toString() in two tests (#21509) 2018-09-07 09:48:33 -07:00
Jonah Williams
908de76c17
Remove value listener from semantics bindings (#21296) 2018-09-07 09:24:08 -07:00
Alexandre Ardhuin
976cffa24d
lint unnecessary_new on samples (#21539)
* lint unnecessary_new on samples

* fix tests
2018-09-07 11:00:05 +02:00
Alexandre Ardhuin
3c58195350
lint unnecessary_const on samples (#21155) 2018-09-07 09:13:13 +02:00
creativecreatorormaybenot
c599f99584 Added music_note icon (#21459)
* Added music_note icon
2018-09-07 00:09:14 -07:00
CaiJingLong
c5d16612a5 Fix ThemeData's cursorColor doesn't work. (#21142) 2018-09-06 21:13:11 -07:00
Mehmet Fidanboylu
0235ec59d1
Revert "InheritedModel - an InheritedWidget for data models (#19739)" (#21523)
This reverts commit 343b57036a94ee9b0131d4d957372a147f8d838d.

Reverting because the assert introduced in framework.dart(inheritFromElement) is breaking certain Mulligan pages. @hixie suspects it might be due to global keys.
2018-09-06 20:23:13 -07:00
Jonah Williams
b53ac0ddce
change expand icon to use default icon colors (#21328) 2018-09-06 12:59:01 -07:00
sir-boformer
a4838a2adc Scale high-pixel-ratio images with BoxFit.none/BoxFit.scaleDown correctly (#20791)
* Scale high-pixel-ratio images with BoxFit.none/BoxFit.scaleDown correctly

* add test cases for image scale

* make analyzer happy

* Make sure that test images always have a scale to make all tests pass

* add a new author

* use new keyword in tests
2018-09-06 12:29:05 -07:00
Hans Muller
7a950eb3a7
Update InheritedModel doc (#21501) 2018-09-06 12:28:51 -07:00
Amir Hardon
9506d1e15b
Add an EagerGestureRecognizer. (#21407)
This recognizer can be passed in AndroidView's gesureRecognizers when we
want all touch events in the view bounds to be immediately dispatched
to the Android view.
2018-09-06 11:18:55 -07:00
jslavitz
7c477b9311
monodrag fix (#21138)
* monodrag fix

* added a test

* added test and changes

* fixed import

* removed comments
2018-09-06 11:04:43 -07:00
Jason Simmons
992f266208
Update animateToItem for new behavior of Future<void> in Dart 2 (#21446) 2018-09-06 11:03:03 -07:00
liyuqian
6c4b38b707
Enable fading animation during page transitions. (#21394)
The average frame time of page transitions on Moto G4 is now very
close to 16ms (the last 10 measurements on our dashboard are
between 15.5ms to 16.7ms and half of them are below 16ms).

It is now much faster than when we disabled it (which was at about
35ms). So I think that we should be able to enable it by default.
I'll leave the flag there until we implement the retained rendering
to bring the frame time comfortably below 16ms.

See https://github.com/flutter/flutter/issues/13736
2018-09-06 09:26:52 -07:00
Amir Hardon
3e7f8b8bb5
Add a clipBehavior parameter to BottomAppBar. (#21461)
Setting the default clip behavior made bottom app bar to no longer clip
its children.
With this parameter users could opt-in to clipping.
2018-09-06 08:48:12 -07:00
Amir Hardon
bae44b29df
Add a note about the Android API level requirement for AndroidView. (#21386) 2018-09-05 11:33:19 -07:00
Ian Hickson
88c94f57c7
Remove unnecessary consts (#21410) 2018-09-04 17:05:30 -07:00
Marcin Szałek
1658fd9412 Added size to stepper icons (#19313)
* Added size to stepper icons

* Added Stepper icons size test
2018-09-04 16:51:39 -07:00
Will Larche
2ef7cd649c
[Icons] Updating default icon theme values. (#20840)
Closes #3188
2018-09-04 19:26:52 -04:00
Jonah Williams
3cd6f40a34
wire bold text flag to text widget (#21325) 2018-09-04 13:49:20 -07:00
Jonah Williams
5b5a5b8228
Revert "Enable taking screenshots of arbitrary RenderObjects from a running a… (#20637)" (#21395)
This reverts commit 3306fc10421cfbad8f772d23c02aca27c7ca1d76.
2018-09-04 12:40:40 -07:00
Jacob Richman
3306fc1042
Enable taking screenshots of arbitrary RenderObjects from a running a… (#20637)
Enable taking screenshots of arbitrary RenderObjects from a running application from within the inspector.

Key functionality is in the added _ScreenshotPaintingContext class.
2018-09-04 10:50:04 -07:00
Hans Muller
343b57036a
InheritedModel - an InheritedWidget for data models (#19739)
Added InheritedModel:  An InheritedWidget that's intended to be used as the base class for models whose dependents may only depend on one part or "aspect" of the overall model.
2018-09-04 09:31:52 -07:00
Viet Do
26b2909077
Cupertino Countdown Timer Picker doc fix (#21299) 2018-09-02 11:29:10 -07:00