DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add a clipBehavior parameter to BottomAppBar. (#21461)

Browse Source 
Setting the default clip behavior made bottom app bar to no longer clip
its children.
With this parameter users could opt-in to clipping.
This commit is contained in:
Amir Hardon 2018-09-06 08:48:12 -07:00 committed by GitHub
parent 7fc9165e4e
commit 3e7f8b8bb5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 42 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/flutter/lib/src/material/bottom_app_bar.dart
View File

@ -41,16 +41,18 @@ import 'theme.dart';
class BottomAppBar extends StatefulWidget {
/// Creates a bottom application bar.
///
/// The [color] and [elevation] arguments must not be null.
/// The [color], [elevation], and [clipBehavior] arguments must not be null.
const BottomAppBar({
Key key,
this.color,
this.elevation = 8.0,
this.shape,
this.clipBehavior = Clip.none,
this.notchMargin = 4.0,
this.child,
}) : assert(elevation != null),
assert(elevation >= 0.0),
assert(clipBehavior != null),
super(key: key);
/// The widget below this widget in the tree.
@ -77,6 +79,9 @@ class BottomAppBar extends StatefulWidget {
/// If null the bottom app bar will be rectangular with no notch.
final NotchedShape shape;
/// {@macro flutter.widgets.Clip}
final Clip clipBehavior;
/// The margin between the [FloatingActionButton] and the [BottomAppBar]'s
/// notch.
///
@ -109,6 +114,7 @@ class _BottomAppBarState extends State<BottomAppBar> {
clipper: clipper,
elevation: widget.elevation,
color: widget.color ?? Theme.of(context).bottomAppBarColor,
clipBehavior: widget.clipBehavior,
child: new Material(
type: MaterialType.transparency,
child: widget.child == null

35
packages/flutter/test/material/bottom_app_bar_test.dart
View File

@ -284,6 +284,41 @@ void main() {
const Offset(50.0, 550.0),
);
});
testWidgets('clipBehavior is propagated', (WidgetTester tester) async {
await tester.pumpWidget(
new MaterialApp(
home: const Scaffold(
bottomNavigationBar:
BottomAppBar(
child: SizedBox(height: 100.0),
shape: RectangularNotch(),
notchMargin: 0.0,
),
),
),
);
PhysicalShape physicalShape = tester.widget(find.byType(PhysicalShape));
expect(physicalShape.clipBehavior, Clip.none);
await tester.pumpWidget(
new MaterialApp(
home: const Scaffold(
bottomNavigationBar:
BottomAppBar(
child: SizedBox(height: 100.0),
shape: RectangularNotch(),
notchMargin: 0.0,
clipBehavior: Clip.antiAliasWithSaveLayer,
),
),
),
);
physicalShape = tester.widget(find.byType(PhysicalShape));
expect(physicalShape.clipBehavior, Clip.antiAliasWithSaveLayer);
});
}
// The bottom app bar clip path computation is only available at paint time.