From 3e7f8b8bb5e8d406de49e1cdf7148af695660d4e Mon Sep 17 00:00:00 2001
From: Amir Hardon <amirh@users.noreply.github.com>
Date: Thu, 6 Sep 2018 08:48:12 -0700
Subject: [PATCH] Add a clipBehavior parameter to BottomAppBar. (#21461)

Setting the default clip behavior made bottom app bar to no longer clip
its children.
With this parameter users could opt-in to clipping.
---
 .../lib/src/material/bottom_app_bar.dart      |  8 ++++-
 .../test/material/bottom_app_bar_test.dart    | 35 +++++++++++++++++++
 2 files changed, 42 insertions(+), 1 deletion(-)

diff --git a/packages/flutter/lib/src/material/bottom_app_bar.dart b/packages/flutter/lib/src/material/bottom_app_bar.dart
index 0fe93a20881..f84f8afecf5 100644
--- a/packages/flutter/lib/src/material/bottom_app_bar.dart
+++ b/packages/flutter/lib/src/material/bottom_app_bar.dart
@@ -41,16 +41,18 @@ import 'theme.dart';
 class BottomAppBar extends StatefulWidget {
   /// Creates a bottom application bar.
   ///
-  /// The [color] and [elevation] arguments must not be null.
+  /// The [color], [elevation], and [clipBehavior] arguments must not be null.
   const BottomAppBar({
     Key key,
     this.color,
     this.elevation = 8.0,
     this.shape,
+    this.clipBehavior = Clip.none,
     this.notchMargin = 4.0,
     this.child,
   }) : assert(elevation != null),
        assert(elevation >= 0.0),
+       assert(clipBehavior != null),
        super(key: key);
 
   /// The widget below this widget in the tree.
@@ -77,6 +79,9 @@ class BottomAppBar extends StatefulWidget {
   /// If null the bottom app bar will be rectangular with no notch.
   final NotchedShape shape;
 
+  /// {@macro flutter.widgets.Clip}
+  final Clip clipBehavior;
+
   /// The margin between the [FloatingActionButton] and the [BottomAppBar]'s
   /// notch.
   ///
@@ -109,6 +114,7 @@ class _BottomAppBarState extends State<BottomAppBar> {
       clipper: clipper,
       elevation: widget.elevation,
       color: widget.color ?? Theme.of(context).bottomAppBarColor,
+      clipBehavior: widget.clipBehavior,
       child: new Material(
         type: MaterialType.transparency,
         child: widget.child == null
diff --git a/packages/flutter/test/material/bottom_app_bar_test.dart b/packages/flutter/test/material/bottom_app_bar_test.dart
index 36fa83f78bf..5c0d1de8adc 100644
--- a/packages/flutter/test/material/bottom_app_bar_test.dart
+++ b/packages/flutter/test/material/bottom_app_bar_test.dart
@@ -284,6 +284,41 @@ void main() {
       const Offset(50.0, 550.0),
     );
   });
+
+  testWidgets('clipBehavior is propagated', (WidgetTester tester) async {
+    await tester.pumpWidget(
+      new MaterialApp(
+        home: const Scaffold(
+          bottomNavigationBar:
+              BottomAppBar(
+                child: SizedBox(height: 100.0),
+                shape: RectangularNotch(),
+                notchMargin: 0.0,
+              ),
+        ),
+      ),
+    );
+
+    PhysicalShape physicalShape = tester.widget(find.byType(PhysicalShape));
+    expect(physicalShape.clipBehavior, Clip.none);
+
+    await tester.pumpWidget(
+      new MaterialApp(
+        home: const Scaffold(
+          bottomNavigationBar:
+          BottomAppBar(
+            child: SizedBox(height: 100.0),
+            shape: RectangularNotch(),
+            notchMargin: 0.0,
+            clipBehavior: Clip.antiAliasWithSaveLayer,
+          ),
+        ),
+      ),
+    );
+
+    physicalShape = tester.widget(find.byType(PhysicalShape));
+    expect(physicalShape.clipBehavior, Clip.antiAliasWithSaveLayer);
+  });
 }
 
 // The bottom app bar clip path computation is only available at paint time.