5196 Commits

Author SHA1 Message Date
Jonah Williams
11943ce7e7
Revert "Shortcuts (#21083)" (#21556)
This reverts commit 6e7f3e6f5a11341edd5c2519cbe1c7bc178cb8e9.
2018-09-07 10:36:52 -07:00
jslavitz
6e7f3e6f5a
Shortcuts (#21083)
* added shortcuts and delete functionality

* added first test

*  afew chnages

* a few changes

* hope this works

* small change

* small changes

* fixed nits

* final changes:

* fixed initializing formals

* update comment

* minor change:

* added line

* final changes
2018-09-07 10:28:35 -07:00
Jacob Richman
a2acc6a3e5
Revert "Revert "Enable taking screenshots of arbitrary RenderObjects from a running a… (#20637)" (#21395)" (#21448)
This reverts commit 5b5a5b82286923f52225320f5e9fc9f558838c05.
2018-09-07 10:02:05 -07:00
Ben Konyi
de9f775fc0
Fixed missing implementations of toString() in two tests (#21509) 2018-09-07 09:48:33 -07:00
Jonah Williams
908de76c17
Remove value listener from semantics bindings (#21296) 2018-09-07 09:24:08 -07:00
Alexandre Ardhuin
976cffa24d
lint unnecessary_new on samples (#21539)
* lint unnecessary_new on samples

* fix tests
2018-09-07 11:00:05 +02:00
Alexandre Ardhuin
3c58195350
lint unnecessary_const on samples (#21155) 2018-09-07 09:13:13 +02:00
creativecreatorormaybenot
c599f99584 Added music_note icon (#21459)
* Added music_note icon
2018-09-07 00:09:14 -07:00
CaiJingLong
c5d16612a5 Fix ThemeData's cursorColor doesn't work. (#21142) 2018-09-06 21:13:11 -07:00
Mehmet Fidanboylu
0235ec59d1
Revert "InheritedModel - an InheritedWidget for data models (#19739)" (#21523)
This reverts commit 343b57036a94ee9b0131d4d957372a147f8d838d.

Reverting because the assert introduced in framework.dart(inheritFromElement) is breaking certain Mulligan pages. @hixie suspects it might be due to global keys.
2018-09-06 20:23:13 -07:00
Jonah Williams
b53ac0ddce
change expand icon to use default icon colors (#21328) 2018-09-06 12:59:01 -07:00
sir-boformer
a4838a2adc Scale high-pixel-ratio images with BoxFit.none/BoxFit.scaleDown correctly (#20791)
* Scale high-pixel-ratio images with BoxFit.none/BoxFit.scaleDown correctly

* add test cases for image scale

* make analyzer happy

* Make sure that test images always have a scale to make all tests pass

* add a new author

* use new keyword in tests
2018-09-06 12:29:05 -07:00
Hans Muller
7a950eb3a7
Update InheritedModel doc (#21501) 2018-09-06 12:28:51 -07:00
Amir Hardon
9506d1e15b
Add an EagerGestureRecognizer. (#21407)
This recognizer can be passed in AndroidView's gesureRecognizers when we
want all touch events in the view bounds to be immediately dispatched
to the Android view.
2018-09-06 11:18:55 -07:00
jslavitz
7c477b9311
monodrag fix (#21138)
* monodrag fix

* added a test

* added test and changes

* fixed import

* removed comments
2018-09-06 11:04:43 -07:00
Jason Simmons
992f266208
Update animateToItem for new behavior of Future<void> in Dart 2 (#21446) 2018-09-06 11:03:03 -07:00
liyuqian
6c4b38b707
Enable fading animation during page transitions. (#21394)
The average frame time of page transitions on Moto G4 is now very
close to 16ms (the last 10 measurements on our dashboard are
between 15.5ms to 16.7ms and half of them are below 16ms).

It is now much faster than when we disabled it (which was at about
35ms). So I think that we should be able to enable it by default.
I'll leave the flag there until we implement the retained rendering
to bring the frame time comfortably below 16ms.

See https://github.com/flutter/flutter/issues/13736
2018-09-06 09:26:52 -07:00
Amir Hardon
3e7f8b8bb5
Add a clipBehavior parameter to BottomAppBar. (#21461)
Setting the default clip behavior made bottom app bar to no longer clip
its children.
With this parameter users could opt-in to clipping.
2018-09-06 08:48:12 -07:00
Amir Hardon
bae44b29df
Add a note about the Android API level requirement for AndroidView. (#21386) 2018-09-05 11:33:19 -07:00
Ian Hickson
88c94f57c7
Remove unnecessary consts (#21410) 2018-09-04 17:05:30 -07:00
Marcin Szałek
1658fd9412 Added size to stepper icons (#19313)
* Added size to stepper icons

* Added Stepper icons size test
2018-09-04 16:51:39 -07:00
Will Larche
2ef7cd649c
[Icons] Updating default icon theme values. (#20840)
Closes #3188
2018-09-04 19:26:52 -04:00
Jonah Williams
3cd6f40a34
wire bold text flag to text widget (#21325) 2018-09-04 13:49:20 -07:00
Jonah Williams
5b5a5b8228
Revert "Enable taking screenshots of arbitrary RenderObjects from a running a… (#20637)" (#21395)
This reverts commit 3306fc10421cfbad8f772d23c02aca27c7ca1d76.
2018-09-04 12:40:40 -07:00
Jacob Richman
3306fc1042
Enable taking screenshots of arbitrary RenderObjects from a running a… (#20637)
Enable taking screenshots of arbitrary RenderObjects from a running application from within the inspector.

Key functionality is in the added _ScreenshotPaintingContext class.
2018-09-04 10:50:04 -07:00
Hans Muller
343b57036a
InheritedModel - an InheritedWidget for data models (#19739)
Added InheritedModel:  An InheritedWidget that's intended to be used as the base class for models whose dependents may only depend on one part or "aspect" of the overall model.
2018-09-04 09:31:52 -07:00
Viet Do
26b2909077
Cupertino Countdown Timer Picker doc fix (#21299) 2018-09-02 11:29:10 -07:00
xster
457e7b23df
Fix FixedExtentScrollController.animateToItem (#20618) 2018-09-01 04:06:46 -07:00
Amir Hardon
4aaa5dfe31
Don't reject the gesture after all pointers are up on AndroidView. (#21295)
This was a bug, when e.g a LongPressGestureRecognizer was in the gesture
arena, the android view gesture team may not yet win the arena when the
last pointer was up. This change allows AndroidView to win the gesture
even after all pointers are up.
2018-08-31 16:32:21 -07:00
Amir Hardon
abb55cb649
fix wrong hashCode implementation in FakeMotionEvent (#21291) 2018-08-31 16:16:37 -07:00
liyuqian
f7b2722d50
Add clipBehavior to Chips and update documents (#21231)
This fixes https://github.com/flutter/flutter/issues/20746
2018-08-30 23:27:37 -07:00
Jonah Williams
f2442b8a13
Fix traversal order issues caused by intersecting or overlapping child rects (#21235) 2018-08-30 19:55:07 -07:00
Todd Volkert
2f32166f4b
Update packges (#21241)
https://github.com/flutter/flutter/issues/19578
2018-08-30 18:16:23 -07:00
Alan Russian
7306ac95d5
Fix spellings of AppBar (#21197) 2018-08-30 10:41:34 -07:00
Hans Muller
ce51e71d19
Add Card clipBehavior pass-through property (#21187) 2018-08-30 10:09:44 -07:00
Greg Spencer
ec5c2e3e0c
Add links to implicit animation illustrations. (#21092)
This adds links to the already existing animated diagrams in the asset-for-api-docs repo.
2018-08-30 10:09:22 -07:00
MH Johnson
19c9628256
[Material] Fix 20051 FAB tooltip touch target (#21084)
* [FAB] Updated tooltip touch target.

* Remove "new" keyword

* [FAB] Updated tooltip touch target.

* "long press button edge"

* remove new

* remove new

* put "new" keywords back in

* Remove check for childless tooltip

* Added regression test - tooltip works on edge of FAB which has no child.

Added helper method to find the right edge of a in the tests.

* Changed "find.byType(text)" to "find.text('Add')"
2018-08-30 09:59:13 -04:00
Jonah Williams
f353c308a1
remove flaky rects (#21194) 2018-08-29 17:21:08 -07:00
Jonah Williams
0e9cfe7df1
Address follow up to https://github.com/flutter/flutter/pull/20354 (#21181) 2018-08-29 16:48:23 -07:00
Jonah Williams
44cdb049d8
Update Text/Rich text to describe recognizers in semantics (#20676) 2018-08-29 13:55:48 -07:00
Alexander Aprelev
a7d954eb31
Add TODOs to remove lint ignore directives. (#21170)
This is follow-up to https://github.com/flutter/flutter/pull/21143.
2018-08-29 10:25:19 -07:00
Alexander Aprelev
abc17236f7
Roll engine to f3ff83a5db71262d240aa5337a2a9a22c73c4749. (dart roll). (#21143)
* Roll engine to 56139397e6ae1257bdabd1ef79ff7aca96c67d4.6

Changes since last roll:
```
56139397e Roll src/third_party/skia 7ba1d64f0706..5f0726b01019 (12 commits) (#6104)
47a1ce0e6 Allow embedders to set the root surface transformation. (#6085)
```

* Roll engine to f3ff83a5db71262d240aa5337a2a9a22c73c4749. (dart roll).

* Add const

* Add ignore analyzer prefer_const_constructors_in_immutables
2018-08-28 21:30:36 -07:00
Jonah Williams
bf5e4b45fe
Make sure modal BottomSheets routes are identified as dialog routes (#21075) 2018-08-28 19:21:00 -07:00
xster
373243bcf8
make /timeline-dashboard consistent between build and paint profiles (#21099) 2018-08-28 16:48:58 -07:00
xster
f23c9ae5f8
Cupertino nav bar transitions between routes (#20322) 2018-08-28 16:44:34 -07:00
Janice Collins
5e39476aef
Remove workaround for markup stripping dartdoc bug (#20748)
* Remove workaround for dart-lang/dartdoc#1125

* Update update_icons.dart for optional const and to remove markup stripping workaround
2018-08-28 13:23:07 -07:00
Jonah Williams
3b309bda07
Add a localization for counter text, separate into own semantic node (#21029) 2018-08-28 12:39:24 -07:00
Ian Hickson
53b635817c
Re-enable missing_return (#20844) 2018-08-28 11:22:57 -07:00
David Shuckerow
458d0b3d21
Update the reorderable list to use the primary scroll controller when… (#20895) 2018-08-28 12:08:41 -06:00
Greg Spencer
7a07b28c93
Fix typo in AnimatedWidget (#21091) 2018-08-28 09:12:16 -07:00