37154 Commits

Author SHA1 Message Date
Xilai Zhang
67457e669f
[flutter_releases] Flutter stable 3.16.8 Framework Cherrypicks (#141648)
# Flutter stable 3.16.8 Framework

## Scheduled Cherrypicks
3.16.8
2024-01-17 00:22:29 +00:00
Kevin Chisholm
ef1af02aea
[flutter_releases] Flutter stable 3.16.7 Framework Cherrypicks (#141406)
# Flutter stable 3.16.7 Framework

## Scheduled Cherrypicks
3.16.7
2024-01-11 21:19:26 +00:00
Jenn Magder
46787ee49c
Set template and migrate apps to iOS 12 minimum (#140921)
Cherry-pick https://github.com/flutter/flutter/pull/140823

Issue https://github.com/flutter/flutter/issues/140923

This looks like a lot of files, but most of them are updating the version on our integration/examples apps.
3.16.6
2024-01-09 22:36:07 +00:00
Elias Yishak
019fc5d65f
[CP] Migrate command usage values (#139383) (#141019)
Fixes:
- https://github.com/flutter/flutter/issues/141017
2024-01-09 20:21:10 +00:00
Christopher Fujino
4ec0689fa1
[CP] Fix tool crash while debugging an iOS device and deleting a temp directory fails (#140842)
Original issue: https://github.com/flutter/flutter/issues/140416
Original PR: https://github.com/flutter/flutter/pull/140415
CP request issue: https://github.com/flutter/flutter/issues/140843
2024-01-08 22:59:27 +00:00
Victoria Ashworth
4476a6d138
[CP] Run tests on either macOS 12 or 13 (#140892)
In preparation for migrating our fleet to macOS 13, we're updating tests to run on either macOS 12 or macOS 13.

These tests have been running on master since Nov 28 and the change is already in 3.18 beta. We want to make this change to stable so we can upgrade more bots to macOS 13.

Original PR: https://github.com/flutter/flutter/pull/137365

Fixes https://github.com/flutter/flutter/issues/140895
2024-01-08 22:51:36 +00:00
Elliott Brooks
5a21b628c3
CP: Manually update DWDS to 21.0.0+1 to fix null-cast error when debugging from VS Code (#140711)
Update DWDS version on Flutter stable to a hotfix release to resolve https://github.com/dart-lang/webdev/issues/2297

See https://github.com/dart-lang/webdev/pull/2319
2024-01-03 17:33:07 +00:00
Xilai Zhang
78666c8dc5
[flutter release] Update Engine revision to 3f3e560236539b7e2702f5ac790b2a4691b32d49 fo… (#140424)
…r stable release 3.16.5

roll engine version into framework. (for some reasons conductor didn't auto generate this PR)
3.16.5
2023-12-20 00:14:14 +00:00
Elias Yishak
2e9cb0aa71
[CP] Catch error for missing directory in FontConfigManager (#138496) (#139743)
Closes:
- https://github.com/flutter/flutter/issues/138434

We will catch any errors while attempting to clear the temp directories that don't exist for the `FontConfigManager` class
3.16.4
2023-12-11 21:35:13 +00:00
Andrew Kolos
7417c4eaeb
[CP] have Java.version return null if java --version fails or cannot be run (#139698)
cherry-picks changes from https://github.com/flutter/flutter/pull/139614 onto the stable channel
2023-12-11 18:28:18 +00:00
Chris Bracken
3b804f183b
[macOS] Suppress Xcode 15 createItemModels warning (#138243) (#139782)
As of Xcode 15 on macOS Sonoma, the following message is (repeatedly) output to stderr during builds (repros on non-Flutter apps). It is supppressed in xcode itself, but not when run from the command-line.

```
2023-11-10 10:44:58.031 xcodebuild[61115:1017566] [MT] DVTAssertions: Warning in /System/Volumes/Data/SWE/Apps/DT/BuildRoots/BuildRoot11/ActiveBuildRoot/Library/Caches/com.apple.xbs/Sources/IDEFrameworks/IDEFrameworks-22267/IDEFoundation/Provisioning/Capabilities Infrastructure/IDECapabilityQuerySelection.swift:103
Details:  createItemModels creation requirements should not create capability item model for a capability item model that already exists.
Function: createItemModels(for:itemModelSource:)
Thread:   <_NSMainThread: 0x6000027c0280>{number = 1, name = main}
Please file a bug at https://feedbackassistant.apple.com with this warning message and any useful information you can provide.
```

This suppresses this message from stderr in our macOS build logs.

Issue: https://github.com/flutter/flutter/issues/135277  
Cherry-pick: https://github.com/flutter/flutter/issues/139284

https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2023-12-08 16:21:18 +00:00
Kate Lovett
54f1b881bd
[CP] Gold fix for stable branch (#139764)
Fixes https://github.com/flutter/flutter/issues/139673
Cherry picks https://github.com/flutter/flutter/pull/139706 to the stable branch to fix the tree.
2023-12-07 21:42:06 +00:00
Casey Hillers
b0366e0a3f
[flutter_releases] Flutter stable 3.16.3 Framework Cherrypicks (#139618)
# Flutter stable 3.16.3 Framework

## Scheduled Cherrypicks
3.16.3
2023-12-06 03:46:39 +00:00
Kate Lovett
6d998fe6c0
[CP] Add ability to customize NavigationBar indicator overlay and fix in… (#139162)
…dicator shape for the overlay (#138901)

fixes [Provide ability to override `NavigationBar` indicator ink response overlay](https://github.com/flutter/flutter/issues/138850) fixes [`NavigationBar.indicatorShape` is ignored, `NavigationBarThemeData.indicatorShape` is applied to the indicator inkwell](https://github.com/flutter/flutter/issues/138900)

---

Cherry pick fixes https://github.com/flutter/flutter/issues/139159

---

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Scaffold(
        bottomNavigationBar: NavigationBarExample(),
      ),
    );
  }
}

class NavigationBarExample extends StatefulWidget {
  const NavigationBarExample({super.key});

  @override
  State<NavigationBarExample> createState() => _NavigationBarExampleState();
}

class _NavigationBarExampleState extends State<NavigationBarExample> {
  int index = 0;

  @override
  Widget build(BuildContext context) {
    return NavigationBar(
      elevation: 0,
      overlayColor: const MaterialStatePropertyAll<Color>(Colors.transparent),
      // indicatorShape: RoundedRectangleBorder(
      //   borderRadius: BorderRadius.circular(4.0),
      // ),
      indicatorColor: Colors.transparent,
      selectedIndex: index,
      onDestinationSelected: (int index) {
        setState(() {
          this.index = index;
        });
      },
      destinations: const <Widget>[
        NavigationDestination(
          selectedIcon: Icon(Icons.home_filled),
          icon: Icon(Icons.home_outlined),
          label: 'Home',
        ),
        NavigationDestination(
          selectedIcon: Icon(Icons.favorite),
          icon: Icon(Icons.favorite_outline),
          label: 'Favorites',
        ),
      ],
    );
  }
}

```

</details>

### Before

#### Cannot override `NavigationBar` Indicator ink well overlay

![Screenshot 2023-11-22 at 18 22 48](https://github.com/flutter/flutter/assets/48603081/06f54335-71ee-4882-afb0-53b614933c38)

#### Indicator shape is ignored for the indicator overlay

![Screenshot 2023-11-22 at 15 29 52](https://github.com/flutter/flutter/assets/48603081/913e0f77-48f4-4c6e-87f3-52c81b78f3d9)

### After

#### Can use `NavigationBar.overlayColor` or `NavigationBarThemeData.NavigationBar` to override default indicator overlay

`overlayColor: MaterialStatePropertyAll<Color>(Colors.red.withOpacity(0.33)),`

![Screenshot 2023-11-22 at 18 22 08](https://github.com/flutter/flutter/assets/48603081/28badae4-a7c7-4bf0-8bcc-278a1f84729d)

`overlayColor: MaterialStatePropertyAll<Color>(Colors.transparent),`

![Screenshot 2023-11-22 at 18 22 25](https://github.com/flutter/flutter/assets/48603081/674b48b1-f66a-4d91-9f10-ad307416ac32)

#### Indicator shape is respected for the indicator overlay

![Screenshot 2023-11-22 at 15 30 36](https://github.com/flutter/flutter/assets/48603081/ae9a3627-787e-45ac-9319-2ea8ea1e6ae6)

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2023-12-05 18:22:07 +00:00
Christopher Fujino
784a44f6f6
CP bump DDS to fix DAP threadID integer parsing bug (#139158)
CP request: https://github.com/flutter/flutter/issues/139177
Upstream tracking issue: https://github.com/dart-lang/sdk/issues/53086
2023-12-05 17:04:51 +00:00
Jesús S Guerrero
9e1c857886
[flutter_releases] Flutter stable 3.16.2 Framework Cherrypicks (#139273)
# Flutter stable 3.16.2 Framework

## Scheduled Cherrypicks
3.16.2
2023-11-30 17:51:18 +00:00
Casey Hillers
7f20e5d18c
[flutter_releases] Flutter stable 3.16.1 Framework Cherrypicks (#139075)
# Flutter stable 3.16.1 Framework

## Scheduled Cherrypicks
3.16.1
2023-11-27 17:47:30 +00:00
Victoria Ashworth
6f753f71b2
[CP] Fix file deletion crash in BuildIOSArchiveCommand.runCommand (#138752)
Original PR: https://github.com/flutter/flutter/pull/138734
2023-11-21 17:11:04 +00:00
Andrew Kolos
d17e4184ec
[CP] prevent tool crash when IntelliJValidatorOnMac encounters an installation with a missing CFBundleIdentifier (#138176)
Cherry-picks #138095 onto beta
2023-11-20 18:07:30 +00:00
Christopher Fujino
20467ba0cd
CP catch StdinException when setting terminal to SingleCharMode (#138032)
Original tracking issue: https://github.com/flutter/flutter/issues/129198
Original PR: https://github.com/flutter/flutter/pull/136283
CP Request: https://github.com/flutter/flutter/issues/138040
2023-11-20 18:04:13 +00:00
Jesús S Guerrero
db7ef5bf9f
[flutter_releases] Flutter stable 3.16.0 Framework Cherrypicks (#138506)
# Flutter stable 3.16.0 Framework

## Scheduled Cherrypicks
3.16.0
2023-11-15 11:25:44 -08:00
Xilai Zhang
adc7dfe87e
[flutter release] update engine version of Flutter 3.16 candidate.0 (#138045)
Roll engine version on branch Flutter 3.16 candidate.0
3.16.0-0.5.pre
2023-11-08 02:30:33 +00:00
yusuf-goog
092a710c64
Bumping version tag of provisioning profile cipd package. (#137710) (#137782)
Bug:https://github.com/flutter/flutter/issues/137166

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2023-11-07 22:33:14 +00:00
Xilai Zhang
4822f901d1
[flutter release cp] Reland "Fixes ability to call nextFocus() on a node to focus its desc… (#138014)
…… (#136898)

…endant" (#136894)"

This reverts commit c2bd2c1175f5b81e9543955760aec5b876b4e57e.

fixes https://github.com/flutter/flutter/issues/134854

Context: https://github.com/flutter/flutter/issues/137071. Updated from [commit in chunhtai/flutter](adacf2227e)
2023-11-07 19:24:03 +00:00
Casey Hillers
379c3f4d37
[flutter_releases] Flutter beta 3.16.0-0.4.pre Framework Cherrypicks (#137709)
# Flutter beta 3.16.0-0.4.pre Framework

## Scheduled Cherrypicks
3.16.0-0.4.pre
2023-11-01 18:34:49 +00:00
Srujan Gaddam
4e5e12e933
Cherry-pick package:web update to version 0.3.0 from 0.2.1-beta (#137195)
This cherry-picks only the package:web version changes from #132445, and any changes needed to work with the new version.

Helps enable https://github.com/flutter/flutter/issues/136405.
2023-10-25 00:15:07 +00:00
Kevin Chisholm
476aa717cd
[flutter_releases] Flutter beta 3.16.0-0.3.pre Framework Cherrypicks (#136932)
# Flutter beta 3.16.0-0.3.pre Framework

## Scheduled Cherrypicks
3.16.0-0.3.pre
2023-10-19 20:10:52 -05:00
Camille Simon
f00b8f5100
[CP][Android] Update Java/AGP/Gradle warning compatible Java range (#136766)
Cherry-pick for https://github.com/flutter/flutter/issues/136388.
2023-10-18 05:14:19 +00:00
Christopher Fujino
180a8582e4
update analytics in generate api docs site to use new UA4 (#136497) (#136742)
Original tracking issue: https://github.com/flutter/flutter/issues/136741
CP request: https://github.com/flutter/flutter/issues/136743

Change the analytics instance that the generated api.flutter.dev and master-api.flutter.dev use.
2023-10-18 01:02:16 +00:00
Christopher Fujino
cd285a9aa8
[flutter_tools] handle ERROR_INVALID_FUNCTION when trying to symlink across drives (#136681)
CP of 9751fe6449
Original issue: https://github.com/flutter/flutter/issues/66224
CP Request: https://github.com/flutter/flutter/issues/136680
2023-10-17 12:28:30 +00:00
godofredoc
fe6553b689
Roll engine to 249cc9b8. (#136428)
Rolls engine to 249cc9b86c45acb7e32b4097bc8a5059b91c888e.
3.16.0-0.2.pre
2023-10-12 02:07:11 +00:00
Xilai Zhang
f0abad66b2
[flutter_releases] Flutter beta 3.16.0-0.1.pre Framework Cherrypicks (#136303)
# Flutter beta 3.16.0-0.1.pre Framework

## Scheduled Cherrypicks
3.16.0-0.1.pre
2023-10-10 19:29:41 -07:00
keyonghan
951653a1c0
Add arch property for windows_arm64 platform (#135725)
Window arm64 bots are using x64 built python, which gave incorrect arch info. This PR adds the arch info explicitly so that recipes can get this value and populate to benchmark tags.

Part of https://github.com/flutter/flutter/issues/135722
3.16.0-0.0.pre 3.15.0-12.0.pre
2023-09-29 00:57:06 +00:00
Jonah Williams
d13cd8846e
[flutter_tools] remove VmService screenshot for native devices. (#135462)
* This is completely broken on the Impeller renderer, see: https://github.com/flutter/flutter/issues/135052
* Even on the Skia renderer, this gives a software rasterized screenshot which will absolutely look different from a native rendering screenshot.

I plan to remove this functionality from the engine.
2023-09-29 00:21:14 +00:00
Polina Cherkasova
e5d3b704da
Pin leak_tracker before publishing breaking change. (#135720) 2023-09-28 17:03:23 -07:00
engine-flutter-autoroll
de20e74a9a
Roll Flutter Engine from cc7c3c1f0f41 to 485543c6765a (8 revisions) (#135717)
cc7c3c1f0f...485543c676

2023-09-28 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from cu6apvEZ2P6zhishc... to l2RxJKPfYn7QzGOoL... (flutter/engine#46382)
2023-09-28 30870216+gaaclarke@users.noreply.github.com Remove opacity layer dcheck. (flutter/engine#46160)
2023-09-28 matanlurey@users.noreply.github.com Add initial support for 4x MSAA in OpenGLES backend. (flutter/engine#46381)
2023-09-28 matej.knopp@gmail.com Reland: [macOS] performKeyEquivalent cleanup (flutter/engine#46377)
2023-09-28 matej.knopp@gmail.com [macOS] TextInputPlugin should mark navigation events in IME popover as handled (flutter/engine#46141)
2023-09-28 30870216+gaaclarke@users.noreply.github.com Removed unnecessary dynamic dispatch (flutter/engine#46369)
2023-09-28 joel.winarske@gmail.com [Impeller] Fix OpenGLES EGL_BAD_ACCESS due to context being current on multiple threads. (flutter/engine#46287)
2023-09-28 ajihyf@gmail.com Fix damage calculation when not providing populate_existing_damage for gl embedder (flutter/engine#45611)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from cu6apvEZ2P6z to l2RxJKPfYn7Q

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-28 23:42:11 +00:00
Kate Lovett
3509a1dfb7
Remove assertions on getOffsetToReveal (#135634) 2023-09-28 18:01:46 -05:00
Flutter GitHub Bot
55c7a2efc4
Marks Linux_android flutter_gallery__start_up_delayed to be unflaky (#135565)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_android flutter_gallery__start_up_delayed"
}
-->
The issue https://github.com/flutter/flutter/issues/134631 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_android%20flutter_gallery__start_up_delayed%22).
This test can be marked as unflaky.
2023-09-28 22:44:52 +00:00
engine-flutter-autoroll
4968963290
Roll Flutter Engine from dbb60932a6ab to cc7c3c1f0f41 (2 revisions) (#135701)
dbb60932a6...cc7c3c1f0f

2023-09-28 matej.knopp@gmail.com [macOS] FlutterTextInputPlugin should clip to bounds (flutter/engine#46142)
2023-09-28 skia-flutter-autoroll@skia.org Roll Skia from d8a71d549262 to 33502f9b0c7d (2 revisions) (flutter/engine#46375)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-28 22:37:17 +00:00
Yegor
371aadd822
[tool] fallback to sigkill when closing Chromium (#135521)
This implements https://github.com/flutter/flutter/issues/132654#issuecomment-1738221257, namely:

Make `Chromium.close` more robust:

* Send `SIGTERM` and wait up to 5 seconds, if the process exited, great! Return from the function.
* If the process has not exited, then send a `SIGKILL`, which is a much firmer way to exit a process. Same as before, wait up to 5 seconds, if the process exited, great! Return from the function.
* If it still hasn't exited then give up trying to exit Chromium, just print a warning to the console and return from the function.

Bonus: a few nullability fixes and extra `-v` logging.

Fixes https://github.com/flutter/flutter/issues/132654
2023-09-28 22:28:31 +00:00
flutter-pub-roller-bot
b5c8fd11e4
Roll pub packages (#135455)
This PR was generated by `flutter update-packages --force-upgrade`.
2023-09-28 21:00:28 +00:00
engine-flutter-autoroll
97847e099a
Roll Flutter Engine from 9789dbc2ec3f to dbb60932a6ab (2 revisions) (#135694)
9789dbc2ec...dbb60932a6

2023-09-28 chris@bracken.jp Revert "[macOS] performKeyEquivalent cleanup (#45946)" (flutter/engine#46374)
2023-09-28 matej.knopp@gmail.com [macOS] performKeyEquivalent cleanup (flutter/engine#45946)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-28 20:10:11 +00:00
Bruno Leroux
e61f9e0ce5
Fix TabBarView.viewportFraction change is ignored (#135590)
## Description

This PR updates `_TabBarViewState.didUpdateWidget` in order to react to `TabBarView.viewportFraction`change.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/135557.

## Tests

Adds 1 test.
2023-09-28 19:56:15 +00:00
engine-flutter-autoroll
8860dd21d8
Roll Flutter Engine from d9eaebd05851 to 9789dbc2ec3f (2 revisions) (#135688)
d9eaebd058...9789dbc2ec

2023-09-28 skia-flutter-autoroll@skia.org Roll Skia from bcbcb109bad6 to d8a71d549262 (1 revision) (flutter/engine#46367)
2023-09-28 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 7c3588c05f87 to 077d768accfa (11 revisions) (flutter/engine#46366)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-28 19:01:12 +00:00
Matheus Kirchesch
9fdb167183
Added option to disable [NavigationDestination]s ([NavigationBar] destination widget) (#132361)
This PR adds a new option in the NavigationDestination api (the destination widget for the NavigationBar) allowing it to be disabled.

As the issue states this PR is the NavigationBar's version of these two PRs (https://github.com/flutter/flutter/pull/132349 and https://github.com/flutter/flutter/pull/127113)

* https://github.com/flutter/flutter/issues/132359
2023-09-28 18:41:18 +00:00
auto-submit[bot]
f76c150cc8
Reverts "Marks Windows module_custom_host_app_name_test to be unflaky" (#135692)
Reverts flutter/flutter#135567
Initiated by: ricardoamador
This change reverts the following previous change:
Original Description:
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows module_custom_host_app_name_test"
}
-->
The issue https://github.com/flutter/flutter/issues/134644 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20module_custom_host_app_name_test%22).
This test can be marked as unflaky.
2023-09-28 18:36:26 +00:00
Alex Li
4ed9ab8b23
🚀 Add more fields to RefreshProgressIndicator (#135207)
Resolves #134494
2023-09-28 18:21:58 +00:00
engine-flutter-autoroll
6cde5da5ea
Roll Flutter Engine from 82b69dadc07a to d9eaebd05851 (1 revision) (#135679)
82b69dadc0...d9eaebd058

2023-09-28 skia-flutter-autoroll@skia.org Roll Skia from 267bb43e822d to bcbcb109bad6 (1 revision) (flutter/engine#46365)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-28 17:44:46 +00:00
Andrew Kolos
aa498cd51a
Add API to read flavor from framework at run time (#134179)
Resolves #128046.

Adds a services API that allows flutter app developers to write app code that determines `--flavor` the app was built with.

This is implemented by having the tool adding the value of `--flavor` to its list of dart environment declarations, which will be available to the app at run time. Specifically,`FLUTTER_APP_FLAVOR` is set. I chose this implementation for its simplicity. There is some precedent for this, but only for web ([example](cd2f3f5e78/packages/flutter_tools/lib/src/runner/flutter_command.dart (L1231))).
2023-09-28 17:38:54 +00:00
Flutter GitHub Bot
c35515a079
Marks Windows module_custom_host_app_name_test to be unflaky (#135567)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows module_custom_host_app_name_test"
}
-->
The issue https://github.com/flutter/flutter/issues/134644 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20module_custom_host_app_name_test%22).
This test can be marked as unflaky.
2023-09-28 17:38:51 +00:00