This modifies the MaterialButton to expand vertically to fit the size of the contained child, no matter what the child widget is. It tries to be as close as possible to the minHeight constraint.
Also updated some doc comments to have headers (extra blank line after first sentence), and to wrap at 80 cols.
Addresses #12311
* Keep Icon's subtree structure the same with and without a semanticLabel.
This avoids rebuilding the subtree when a semanticLabel is set/unset.
Also updated some doc comments.
(This is a followup on post-merge comments for #12475)
* Roll engine
* Move assert requiring 'this' from initializer to constructor body
* Update test expected message
* Relax regexp to allow wider array of dart uris
Also:
* Provide a better message when you lerp from infinity to finity
constraints.
* Make the striped marker support RTL.
* By popular demand, dump a warning to the console the first time
a particular Flex overflows. (Resets on hot reload.)
This updates the bottom navigation bar to be able to handle more general widgets in the place of the label in the bottom navigation bar, so that Text with a textScaleFactor larger than 1.0 will behave nicely in a bottom navigation bar.
It also means that other widgets given instead of a Text widget for the label will work more predictably.
I also vastly simplified the layout logic, eliminating many computations that were not needed, and refactored the build function to use a separate private navigation tile widget.
Also, the color splash animations were coming from the wrong location (they were coming from far to the right of the touched widget), so that works as specified now.
* Changed PageController #nextPage & #previousPage to return a Future after completing.
* Removed false statement about returning a Future in PageController#jumpToPage
* Added tests to make sure nextPage & previousPage return Futures.
* Tested that the Futures returned by nextPage & previousPage actually resolve.
* Renaming *pageCalled to *pageCompleted, since that's what it's actually for.
* Revert "When parts of the program are changed in a hot reload, but not executed during the reassemble, warn that a restart may be needed. (#12304)"
This reverts commit 90028813a89a3de8154144e6e0f1edbe90dc2e4f.
* fix _debugCheckOwnerBuildTargetExists; sync localizations and tests
* address comments
* optimize ThemeData: make it monomorphic, memoize result
* address comments
* RLU cache; fix text theme merging
* use FIFO cache for ThemeData; use HashMap to store inherited widgets
* address comments
* Drop invisible SemanticsNodes from tree
A node is invisible if it is outside of the bounds of the screen and if it is not merged into its (partially) visible parent.
Also in this PR: only set `wasAffectedByClip` to true if the nodes has actually been clipped.
* Fix other failing tests
* renaming
* review feedback
* more doc
Previously, we used `Alignment`, which was difficult to understand. Now,
we just use an `Offset` scaled to the child's size, which is much easier
to understand.
These now act the way they used to act if both operands are
FractionalOffsets. Once you mix in some other AlignmentGeometry
objects, everything gets converted to the AlignmentGeometry coordinate
system.
I'm about to add the BoxBorder and BorderDirectional classes to
this new file, but figured it would make review easier if the move
of the existing class happened first.
* Roll engine
* Pick up updated engine with analyzer fix
* Add new typeArguments override
* Update engine dep
* Up dartdoc version to fix name resolution issues
