DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Roll engine after dart roll (#12473)

Browse Source 
* Roll engine

* Move assert requiring 'this' from initializer to constructor body

* Update test expected message

* Relax regexp to allow wider array of dart uris
This commit is contained in:
Alexander Aprelev 2017-10-10 06:38:51 -07:00 committed by GitHub
parent 4023b7cad8
commit e706169814
5 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
bin/internal/engine.version
View File

@ -1 +1 @@
459f722b86415da01386fe41f37bafa842f11ae8
74e58f66d492a28a2c47ac5402d0b8b8a740cf62

5
packages/flutter/lib/src/cupertino/route.dart
View File

@ -88,8 +88,9 @@ class CupertinoPageRoute<T> extends PageRoute<T> {
assert(settings != null),
assert(maintainState != null),
assert(fullscreenDialog != null),
assert(opaque), // PageRoute makes it return true.
super(settings: settings, fullscreenDialog: fullscreenDialog);
super(settings: settings, fullscreenDialog: fullscreenDialog) {
assert(opaque); // PageRoute makes it return true.
}
/// Builds the primary contents of the route.
final WidgetBuilder builder;

2
packages/flutter/lib/src/foundation/assertions.dart
View File

@ -329,7 +329,7 @@ class FlutterError extends AssertionError {
'_FakeAsync',
'_FrameCallbackEntry',
];
final RegExp stackParser = new RegExp(r'^#[0-9]+ +([^.]+).* \(([^/]*)/[^:]+:[0-9]+(?::[0-9]+)?\)$');
final RegExp stackParser = new RegExp(r'^#[0-9]+ +([^.]+).* \(([^/]*)/.+:[0-9]+(?::[0-9]+)?\)$');
final RegExp packageParser = new RegExp(r'^([^:]+):(.+)$');
final List<String> result = <String>[];
final List<String> skipped = <String>[];

5
packages/flutter/lib/src/material/page.dart
View File

@ -70,8 +70,9 @@ class MaterialPageRoute<T> extends PageRoute<T> {
this.maintainState: true,
bool fullscreenDialog: false,
}) : assert(builder != null),
assert(opaque),
super(settings: settings, fullscreenDialog: fullscreenDialog);
super(settings: settings, fullscreenDialog: fullscreenDialog) {
assert(opaque);
}
/// Builds the primary contents of the route.
final WidgetBuilder builder;

5
packages/flutter/lib/src/widgets/pages.dart
View File

@ -81,10 +81,11 @@ class PageRouteBuilder<T> extends PageRoute<T> {
this.maintainState: true,
}) : assert(pageBuilder != null),
assert(transitionsBuilder != null),
assert(opaque != null),
assert(barrierDismissible != null),
assert(maintainState != null),
super(settings: settings);
super(settings: settings) {
assert(opaque != null);
}
/// Used build the route's primary contents.
///