CMAP tables are a component of fonts which map character codes to glyph
indices used in the font. In cases where this is missing for a font that
we attempt to load, there is not much gained by logging this. It's also
a common source of false positive bug reports and bug reports with
misleading symptoms in Flutter, such as
https://github.com/flutter/flutter/issues/78929
Instead of logging the error, simply suppress it, since it's not
actionable by the user.
CMAP Reference:
https://docs.microsoft.com/en-us/typography/opentype/spec/cmap
In UWP, GetFinalPathNameByHandle requires the app to declare appropriate
capabilities in the app's package manifest. Some of these capabilities are not
permitted in shipping apps on the app store, but may be fine for
development/debugging scenarios. If we can't resolve the full path due to
insufficient access, but have verified the handle is valid, return the original
path.
This gets hot reload requests working in the UWP embedder.
https://github.com/flutter/flutter/issues/79609
Used the the `misspell` tool available at
https://github.com/client9/misspell, then applied hand-corrections. It's
possible we could adopt this as a presubmit, but there are still enough
false positives that it may not be worth the effort.
* Remove IAccessible and IChromeAccessible from AXPlatformNodeWin
* Fixes to make AXPlatformNodeWin, AXFragmentRootWin and associated unit
tests work and pass in Flutter/Windows
We currently use a mix of C standard includes (e.g. limits.h) and their
C++ variants (e.g. climits) in //flutter/third_party/accessibility. This
migrates to a consistent style for all cases where the C++ variants are
acceptable. C equivalents remain in place only where they are required,
such as in the embedder API and other headers that may be used from C.
This commit is analogous to d03692449b014377b0a9f5aded075a9515a268db.
* Modifications to gtest_util.h to build in Flutter
* Modifications to Range to build in Flutter
* Modifications to UiaRegistrarWin to build in Flutter
* Modifications to EnumVariant to build in Flutter
* Modifications to AXActivePopup to build in Flutter
* Modifications to ScopedBstr to build in Flutter
* Modifications to atl.h/atl_module.h to build in Flutter
* Modifications to ScopedVariant to build in Flutter
* Modifications to VariantUtil to build in Flutter
* Modifications to ScopedSafearray to build in Flutter
* Modifications to VariantVector to build in Flutter
* Add BASE_UNLIKELY, BASE_LIKELY and BASE_FALLTHROUGH macros to compiler_specific.h
* Update BUILD files for Windows base/ and gfx/ unittests
Co-authored-by: Chris Bracken <chris@bracken.jp>
* Add the following APIs to StringUtils:
- NumberToString16
- JoinString
- ReplaceChars
- WideToUTF16
- UTF16ToWide
Implement the following APIs for Windows:
- UTF8ToUTF16
- UTF16ToUTF8
* Review comments
Add a couple TODOs for decimal formatting and use std::u16string::npos
rather than std::string::npos.
* Update licences_flutter
Co-authored-by: Chris Bracken <chris@bracken.jp>
When replacing an int/float/bool attribute on the test node, we want to
erase the range from the iterator returned by remove_if to end(), which
may be an empty range. In the case where remove_if() returns end(), the
single-parameter variant of erase() attempts to remove an element past
the end of the container.
Corrects uses of setup as a verb to 'set up', leaves noun/noun-phrase
forms of setup as 'setup'. Also settles on 'teardown' as opposed to
tear-down for consistency across the codebase.
A few other minor comment/wording corrections.
