DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add fallback for GetAbsoluteFilePath in UWP (flutter/engine#25379)

Browse Source 
In UWP, GetFinalPathNameByHandle requires the app to declare appropriate
capabilities in the app's package manifest. Some of these capabilities are not
permitted in shipping apps on the app store, but may be fine for
development/debugging scenarios. If we can't resolve the full path due to
insufficient access, but have verified the handle is valid, return the original
path.

This gets hot reload requests working in the UWP embedder.

https://github.com/flutter/flutter/issues/79609
This commit is contained in:
Chris Bracken 2021-04-01 23:34:59 -07:00 committed by GitHub
parent 05b6f293f4
commit 2797aa9c99
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
engine/src/flutter/third_party/tonic/filesystem/filesystem/path_win.cc vendored
View File

@ -215,8 +215,20 @@ std::string GetAbsoluteFilePath(const std::string& path) {
DWORD ret =
GetFinalPathNameByHandleA(file, buffer, MAX_PATH, FILE_NAME_NORMALIZED);
if (ret == 0 || ret > MAX_PATH) {
std::string result;
if (GetLastError() == ERROR_ACCESS_DENIED) {
// In UWP, GetFinalPathNameByHandle requires the app to declare
// appropriate capabilities in the app's package manifest. Some of these
// capabilities are not permitted in shipping apps on the app store, but
// may be fine for development/debugging scenarios. If we can't resolve
// the full path due to insufficient access, but have verified the handle
// is valid, return AbsolutePath of the original path.
//
// https://github.com/flutter/flutter/issues/79609
result = AbsolutePath(path);
}
CloseHandle(file);
return std::string();
return result;
}
std::string result(buffer);
result.erase(0, strlen("\\\\?\\"));