2239 Commits

Author SHA1 Message Date
Adam Barth
fdb030a242 demo_launcher/lib/main.dart does not have bottom-overscroll
Rather than trying to clamp the scroll offset during scrolling, we detect when
we might have exceeded our maxScrollOffset and settle the scroll offset back in
bounds.

Fixes #287

R=eseidel@chromium.org, eseidel@google.com

Review URL: https://codereview.chromium.org/1226373003 .
2015-07-09 13:43:30 -07:00
Hixie
61c2a1695b Make sure to sync the widgets even when we don't do a relayout.
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1225093007 .
2015-07-09 13:06:36 -07:00
Matt Perry
c73f65312b Fix test failures from AnimatedContainer patch.
- Needed to move properties into AnimatedContainer to create a full BoxDecoration.
- Updated test expectations because backgroundColor animates now.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1224223004 .
2015-07-09 15:26:39 -04:00
Adam Barth
86cbaead14 Break dependency of AnimationPerformance on AnimatedValue
This CL decouples the new animation system (based on AnimationPerformance and
AnimatedVariable) from the old animation system (based on AnimatedValue). It
introduces a new Ticker and Timeline class to drive AnimationPerformance and
makes it possible for AnimatedComponent to watch performances directly.

R=eseidel@chromium.org, mpcomplete@chromium.org, mpcomplete@google.com

Review URL: https://codereview.chromium.org/1226263003 .
2015-07-09 12:16:55 -07:00
Adam Barth
92132213f1 Rebaseline tests after f66984e72a2b5db0f7c4db4f05829118defe6640
TBR=mpcomplete@google.com

Review URL: https://codereview.chromium.org/1230893002 .
2015-07-09 12:11:16 -07:00
Matt Perry
301194ed41 AnimatedContainer: generalized Container widget that handles animating values
when they change via syncFields.

Very early so far. Only supports animating shadow, position, and backgroundColor.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1223073002 .
2015-07-09 14:12:27 -04:00
Chinmay Garde
961d0c428e [Sky] Fix iOS build breaks
R=abarth@chromium.org, eseidel@chromium.org

Review URL: https://codereview.chromium.org/1229093002 .
2015-07-09 11:10:43 -07:00
Chinmay Garde
321131b32a Update cassowary dependency to 0.1.7
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1231903003 .
2015-07-09 11:10:08 -07:00
Hixie
05668e5ee2 Implement hit testing and baseline alignment for RenderBlockViewport.
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1231943002 .
2015-07-09 10:55:33 -07:00
Chinmay Garde
319c94e041 Add generated files to Sky .gitignore when working on the same using Dart IDEs
R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1231913002 .
2015-07-09 10:24:10 -07:00
Adam Barth
566110a8f8 Stop leaking temp directories in SkyShell
At startup, we make a list of all the temp directories that already exist and
then nuke them on a background thread after a five second delay. The five
second delay isn't particularly satisfying, but I think it's wortwhile to get
this work off the critical path of startup.

R=eseidel@chromium.org, eseidel@google.com

Review URL: https://codereview.chromium.org/1228083003 .
2015-07-09 09:57:41 -07:00
Hixie
09ee39f744 BlockViewport didn't implement the intrinsic dimension functions correctly.
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1230833002 .
2015-07-09 09:57:03 -07:00
Hixie
2a8077f15d Introduce BlockViewport. This class lets you build Widgets dynamically during layout.
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1222913013 .
2015-07-09 09:20:53 -07:00
Adam Barth
a40fd86bb3 Build skyx packages by default
Now that we have all the Dart packages we need in //third_party, we can build
skyx bundles by default.

As part of this change, I've made it possible to build skyx bundles on Linux
and I've made the gn target names of the mojoms in //sky/services consistent
with each other and with //mojo/services/public.

TBR=eseidel@google.com

Review URL: https://codereview.chromium.org/1227973002 .
2015-07-09 08:39:45 -07:00
Hans Muller
c61f5461f7 Card "swipe-away" dismiss version 2
Some minor cleanup. Also created a small mess to work around
https://github.com/domokit/mojo/issues/312

- Track event.dx sum; don't listen to the card container
- Support dismissing to the left (too)
- Slow the dismiss "fling" animation down a little.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1231693003 .
2015-07-09 08:13:56 -07:00
John McCutchan
fbf5b40995 Pub needs an SDK constraint because we use ^ version constraints
---

Missing requirements:
* Older versions of pub don't support ^ version constraints.
  Make sure your SDK constraint excludes those old versions:

  environment:
    sdk: ">=1.8.0 <2.0.0"

  Or use a fully-expanded constraint:

  dependencies:
    cassowary: ">=0.1.6 <0.2.0"
...
Sorry, your package is missing a requirement and can't be published yet.

Review URL: https://codereview.chromium.org/1225303002 .
2015-07-09 07:19:16 -07:00
John McCutchan
0fa1e9fd45 Bump versions to v17
BUG=

Review URL: https://codereview.chromium.org/1231803003 .
2015-07-09 07:08:27 -07:00
John McCutchan
f8e38784f2 Rename .sdkext to _sdkext and fix sky_tool
- Pub doesn't publish dot files (who knew?!)
- sky_tool was referencing a variable that doesn't exist

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1223173003 .
2015-07-09 06:49:45 -07:00
Adam Barth
e0d06791ef Fix test failures from b9e2a7fd2bb21933c4dd23354a35a2d83bdc3be8
We need to test for visual overflow after writing size because we need to use
the up-to-date value of size.

TBR=ianh@google.com

Review URL: https://codereview.chromium.org/1230733002 .
2015-07-08 20:31:20 -07:00
Hixie
9bf06b6c1b Add a function to Offset to get a new offset that is the old offset translated by some given values.
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1229783002 .
2015-07-08 17:55:10 -07:00
Hixie
b00f767d6a Factor RenderBlock out into a base class and a subclass.
The core parts of RenderBlock will be reused by: https://codereview.chromium.org/1222913013/

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1226103003 .
2015-07-08 17:54:56 -07:00
Hixie
43bce9d735 Provide an API that allows a RenderObject's performLayout() function to call a callback that mutates the render tree during layout.
Also, provide a removeAll() function on ContainerRenderObjectMixin.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1229793002 .
2015-07-08 17:54:47 -07:00
Hixie
db2e59a994 Teach Widget some new tricks to enable build-during-layout.
There are basically three tricks here:
- Making retainStatefulNodeIfPossible non-private, so that
  RenderObjectWrappers in other files can use it.
- RenderObjectWrappers have a utility function that subclasses
  can call (retainStatefulRenderObjectWrapper()) to enable them
  to be retained, when they override retainStatefulNodeIfPossible.
- enterLayoutCallbackBuilder()/exitLayoutCallbackBuilder() API to set
  the right flags so that you can build Widget nodes outside a
  regular build cycle

Also:
- Widget.toStringName(), for debugging when you don't want the whole
  subtree printed.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1225123005 .
2015-07-08 17:54:25 -07:00
Adam Barth
a2d4f85b61 Remove dart:mirrors from Sky framework
Using mirrors prevents some static analysis tools from working on Sky.

R=ianh@google.com

Review URL: https://codereview.chromium.org/1224133002 .
2015-07-08 17:24:25 -07:00
Chinmay Garde
f5bb356756 Integrate the linear constraint solver into Sky as a RenderBox subclass.
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1230583003 .
2015-07-08 16:11:30 -07:00
Adam Barth
1bc13e1c63 Teach sky_shell.exe to run from a snapshot
Also, make stocks robust to failing network connections.

TBR=eseidel@google.com

Review URL: https://codereview.chromium.org/1229743002 .
2015-07-08 15:50:06 -07:00
Ian Fischer
79554dd88c Turn on createNewDisplayList for two obvious use cases: RenderInkWell and RenderTransform.
R=abarth@chromium.org, abarth@google.com, ianh@google.com

Review URL: https://codereview.chromium.org/1227843002 .
2015-07-08 15:21:36 -07:00
Ian Fischer
b286f72509 Make rendering use PaintingNodes for increased efficiency.
WIP -- need to update some tests at the least.

R=abarth@chromium.org, abarth@google.com, ianh@google.com

Review URL: https://codereview.chromium.org/1216833003 .
2015-07-08 15:08:20 -07:00
John McCutchan
c247eeea92 Roll to v16 for republishing with .sdkext support
BUG=
R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1231653002 .
2015-07-08 14:57:05 -07:00
Hans Muller
ca0a1e17bf An example prototype of adding support for
Material-style card dismissal. Many things remain to be done:

- Track event.dx sum; don't listen to the card container
- Make this a feature of Card
- Support dismissing to the left (too)
- Animate the layout change caused by dismissing the card
- Deal with many cards animating away at the same time
- Integrate with TBD VariableHeightScrollable

This version just exists to collect a little feedback,
including about the use of AnimationPerformance

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1231603003 .
2015-07-08 14:31:26 -07:00
John McCutchan
a6dcaf967c Some fixes for big_red_button.py
BUG=
R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1227803002 .
2015-07-08 14:07:04 -07:00
Eric Seidel
2e8e2d0b72 Make RenderBlock painting match its hittesting
I added a clip in RenderBlock to make the painted pixels
match the hittesting logic.  This at least makes obvious
all the numerous hittesting bugs in our system. :)

I also moved demo_launcher to ScrollableList awesomeness.

R=abarth@chromium.org, abarth@google.com

Review URL: https://codereview.chromium.org/1223083002 .
2015-07-08 13:47:39 -07:00
Adam Barth
427f162519 mv //sky/services/intents //sky/services/activity
This interface is growing to expose many activity-related functions, more than
just intents.

R=eseidel@chromium.org, eseidel@google.com

Review URL: https://codereview.chromium.org/1223053002 .
2015-07-08 13:37:22 -07:00
John McCutchan
c1c922465a Allow big_red_button to take path arguments
BUG=
R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1227103002 .
2015-07-08 13:17:42 -07:00
Ian Fischer
caafb616dc Change all child.paint calls to canvas.paintChild and update the test results.
R=abarth@chromium.org, abarth@google.com, ianh@google.com

Review URL: https://codereview.chromium.org/1208993020 .
2015-07-08 12:48:20 -07:00
John McCutchan
294497b044 Add dart:sky.internals and dart:sky_builtin_natives to Sky sdk_ext
BUG=
R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1225923009 .
2015-07-08 12:08:39 -07:00
Eric Seidel
37fba23b21 Roll to v15 for republishing with skyx enabled
TBR=abarth@google.com

Review URL: https://codereview.chromium.org/1222193008 .
2015-07-08 10:41:33 -07:00
Ian Fischer
864d76f3b1 Remove reference to deleted “win” python file to prevent crash when running test_sky
R=abarth@chromium.org, abarth@google.com

Review URL: https://codereview.chromium.org/1227053002 .
2015-07-08 10:19:06 -07:00
Adam Barth
5d7a476bc5 Add skydoc.py, a tool for running dartdoc
This CL starts us down the path of generating documentation from our source.

R=eseidel@chromium.org, eseidel@google.com

Review URL: https://codereview.chromium.org/1218663011 .
2015-07-08 08:26:11 -07:00
Benjamin Lerman
340db897c2 Remove unused variable.
TBR=abarth@chromium.org

Review URL: https://codereview.chromium.org/1223003002 .
2015-07-08 15:00:38 +02:00
Przemyslaw Pietrzkiewicz
dd758a1970 Make download_material_design_icons work in a clean checkout.
This patch makes the call to rmtree that wipes the already downloaded
icons pass if the directory is not present yet.

R=qsr@chromium.org

Review URL: https://codereview.chromium.org/1226833009 .
2015-07-08 14:39:57 +02:00
Adam Barth
fd85081867 Add some dartdoc comments
This CL is an experiment in adding some dartdoc comments in a few places. It's
unclear how extensively we'll use dartdoc.

TBR=ianh@google.com

Review URL: https://codereview.chromium.org/1207373005 .
2015-07-07 21:37:27 -07:00
Collin Jackson
ab2722f92d Initial fitness app
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1213603006 .
2015-07-07 17:14:45 -07:00
Eric Seidel
a62b3b2514 Update skyx after material design update d86123d4c71d28
R=abarth@chromium.org, abarth@google.com

Review URL: https://codereview.chromium.org/1225593004 .
2015-07-07 17:07:19 -07:00
Collin Jackson
d331a98c22 Support for selected menu items
R=ianh@google.com

Review URL: https://codereview.chromium.org/1226583005 .
2015-07-07 16:44:29 -07:00
Viet-Trung Luu
bd499730b7 Delete interface_impl.h.
R=rudominer@chromium.org

Review URL: https://codereview.chromium.org/1219893005 .
2015-07-07 16:37:47 -07:00
Collin Jackson
509cdbf2c5 Update material design icons
R=abarth@chromium.org, abarth

Review URL: https://codereview.chromium.org/1223843014 .
2015-07-07 16:28:45 -07:00
Eric Seidel
766bbf5e33 Add big_red_button script so that others can deploy
R=abarth@chromium.org, abarth@google.com

Review URL: https://codereview.chromium.org/1214193007 .
2015-07-07 16:28:13 -07:00
Eric Seidel
00adca7710 Roll versions in preparation for deploying demos/packages
TBR=abarth@google.com

Review URL: https://codereview.chromium.org/1216053015 .
2015-07-07 16:23:57 -07:00
Eric Seidel
c1ebc56e38 Fix demo_launcher location for realz
TBR=abarth@google.com

Review URL: https://codereview.chromium.org/1222313014 .
2015-07-07 16:22:52 -07:00