skia-flutter-autoroll
fd019fbb82
Roll Skia from a72649f13420 to 0a1e7aeb29b5 (1 revision) ( flutter/engine#43505 )
...
https://skia.googlesource.com/skia.git/+log/a72649f13420..0a1e7aeb29b5
2023-07-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 72c269263c2f to 6ee402f6c133 (18 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-10 07:33:06 +00:00
skia-flutter-autoroll
37e35140aa
Roll Skia from ab7f95f52ea6 to a72649f13420 (3 revisions) ( flutter/engine#43504 )
...
https://skia.googlesource.com/skia.git/+log/ab7f95f52ea6..a72649f13420
2023-07-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from d5207f6cef93 to 03f1674c4d91
2023-07-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from f72770b2c35d to d5207f6cef93 (2 revisions)
2023-07-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 3b9aa123c9d9 to d94b6fd1904f (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-10 06:55:13 +00:00
Dan Ballard
ac192f333c
[linux] Allow overriding aot_library_path ( flutter/engine#42555 )
...
Support overriding `aot_library_path` in `FLDartProject` on Linux.
Fixes: https://github.com/flutter/flutter/issues/128213
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-07-10 16:11:53 +12:00
skia-flutter-autoroll
1e288b7243
Roll Fuchsia Linux SDK from E9CEA-wZJ9VgSP80c... to eRSQn0XKuI7byK2i_... ( flutter/engine#43498 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-09 23:05:30 +00:00
skia-flutter-autoroll
288a57390c
Roll Fuchsia Mac SDK from UKVzvetd5M4SA_ufb... to aQqgcKf1EwSoRWDet... ( flutter/engine#43497 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-09 16:03:18 +00:00
skia-flutter-autoroll
7ff2ddb9e9
Roll Skia from 05ce4af04609 to ab7f95f52ea6 (1 revision) ( flutter/engine#43496 )
...
https://skia.googlesource.com/skia.git/+log/05ce4af04609..ab7f95f52ea6
2023-07-09 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-09 11:01:24 +00:00
skia-flutter-autoroll
da3dd849c5
Roll Fuchsia Linux SDK from 8X61T1htYuHQtWtFv... to E9CEA-wZJ9VgSP80c... ( flutter/engine#43495 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-09 10:21:32 +00:00
skia-flutter-autoroll
24b9f680ec
Roll Fuchsia Mac SDK from TSpkNWkgR0F7xl8q5... to UKVzvetd5M4SA_ufb... ( flutter/engine#43494 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-09 03:09:22 +00:00
skia-flutter-autoroll
70f92e124c
Roll Fuchsia Linux SDK from Q4Oq8NRW2yeBrgy4b... to 8X61T1htYuHQtWtFv... ( flutter/engine#43492 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-08 21:39:24 +00:00
skia-flutter-autoroll
f28762469c
Roll Fuchsia Mac SDK from 8YPOimmJgaAd5SlAT... to TSpkNWkgR0F7xl8q5... ( flutter/engine#43490 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-08 14:29:24 +00:00
Jason Simmons
0f179b102a
[Impeller] Check for a null command buffer in InlinePassContext::EndPass ( flutter/engine#43485 )
...
This could happen if the pass is immediately ended due to clear color
optimization.
Fixes https://github.com/flutter/flutter/issues/130167
2023-07-08 07:14:57 -07:00
skia-flutter-autoroll
198f0d9628
Roll Skia from 6d733caa0d3f to 05ce4af04609 (1 revision) ( flutter/engine#43489 )
...
https://skia.googlesource.com/skia.git/+log/6d733caa0d3f..05ce4af04609
2023-07-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 95bbe1dda9b7 to dda88e93be7e (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-08 12:28:17 +00:00
skia-flutter-autoroll
ac1d1acd5d
Roll Fuchsia Linux SDK from vee6hAD_43mq_4FS7... to Q4Oq8NRW2yeBrgy4b... ( flutter/engine#43486 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-08 07:30:05 +00:00
Tong Mu
489f9c3d01
Make updating window metrics multi-view ( flutter/engine#43366 )
...
This PR adds multi-view support to various methods that updates the window metrics by adding a `view_id` parameter.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-07-08 05:54:16 +00:00
Tong Mu
9cd4338940
Rename default views to implicit views ( flutter/engine#43364 )
...
This PR renames a number of internal variables from "default view ID" to
"implicit view ID", as we have pretty much settled on naming this
mechanism. Some docs are also fixed accordingly.
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-07-07 20:44:37 -07:00
Ricardo Amador
1e09efb815
Remove unused autosubmit configuration file ( flutter/engine#43483 )
...
Remove autosubmit config files that are no longer being used. This was from a previous design and not longer used.
List which issues are fixed by this PR. You must list at least one issue.
Part of https://github.com/flutter/flutter/issues/130182
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-07-08 00:34:04 +00:00
skia-flutter-autoroll
c9eb94ad87
Roll Skia from 2885452c3fb1 to 6d733caa0d3f (1 revision) ( flutter/engine#43482 )
...
https://skia.googlesource.com/skia.git/+log/2885452c3fb1..6d733caa0d3f
2023-07-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 869b279baef4 to 95bbe1dda9b7 (7 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-07 23:47:55 +00:00
David Worsham
b400037017
[fuchsia] Fix tests; remove fuchsia dart SDK deps ( flutter/engine#43461 )
...
Dart is being removed from the Fuchsia SDK, so remove references to it
here.
Also remove references to workstation_eng and replace with terminal.
workstation_eng is no longer a thing.
2023-07-08 09:37:34 +10:00
skia-flutter-autoroll
ea932582ff
Roll Fuchsia Mac SDK from MPy31yjgPV-d_YJq0... to 8YPOimmJgaAd5SlAT... ( flutter/engine#43481 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-07 23:21:15 +00:00
skia-flutter-autoroll
fbdfb8476e
Roll Skia from 93c92f97f5ab to 2885452c3fb1 (2 revisions) ( flutter/engine#43478 )
...
https://skia.googlesource.com/skia.git/+log/93c92f97f5ab..2885452c3fb1
2023-07-07 brianosman@google.com Don't try to create a lighting image filter if the buffer failed
2023-07-07 drott@google.com Revert "Avoid crash in Viewer when viewing shaders in Graphite."
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-07 22:03:34 +00:00
skia-flutter-autoroll
86ebad1838
Roll Dart SDK from 0b07debd5862 to 4998bf65f91c (2 revisions) ( flutter/engine#43480 )
...
https://dart.googlesource.com/sdk.git/+log/0b07debd5862..4998bf65f91c
2023-07-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-285.0.dev
2023-07-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-284.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-07 21:58:06 +00:00
skia-flutter-autoroll
1af0504d6e
Roll Fuchsia Linux SDK from Cfxhimvf7nMO99ky_... to vee6hAD_43mq_4FS7... ( flutter/engine#43475 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-07 18:43:05 +00:00
Alexander Aprelev
afe9d86412
Reland "Manual roll Dart SDK from 2d98d9e27dae to 0b07debd5862 (21 revisions) ( #43457 )" ( flutter/engine#43472 )
...
This reverts commit c99de0f668675b5e045b23a5fd5f9fca79ae297c as the path forward is to roll manually to framework updating dependencies in the same PR.
Roll of updated Dart SDK requires simultaneous update of flutter framework vm_snapshot_analysis dependency to 0.7.4. Trial run of that is https://github.com/flutter/flutter/pull/130032
2023-07-07 18:15:07 +00:00
skia-flutter-autoroll
08a54992ab
Roll Skia from 5eba922297bb to 93c92f97f5ab (2 revisions) ( flutter/engine#43471 )
...
https://skia.googlesource.com/skia.git/+log/5eba922297bb..93c92f97f5ab
2023-07-07 cmumford@google.com [infra] update GTX960 driver to 31.0.15.3179
2023-07-07 jvanverth@google.com [graphite] Another fix for async_rescale_and_read_dog_up.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-07 18:07:59 +00:00
Alexander Aprelev
c99de0f668
Revert "Manual roll Dart SDK from 2d98d9e27dae to 0b07debd5862 (21 revisions) ( #43457 )" ( flutter/engine#43466 )
...
This reverts commit 7ecd2537d81b5c8967e8bc4367e2c5f29f5340eb as it breaks flutter framework tests during subsequent roll.
From https://github.com/flutter/flutter/pull/130138 :
_TypeError: (#0 _ProgramInfoBuilder.createInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:450:53))
```
#0 _ProgramInfoBuilder.createInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:450:53)
#1 _ProgramInfoBuilder.getInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:374:14)
#2 _ProgramInfoBuilder.createInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:444:23)
#3 _ProgramInfoBuilder.getInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:374:14)
#4 _ProgramInfoBuilder.createInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:419:54)
#5 _ProgramInfoBuilder.getInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:374:14)
#6 ListIterable.forEach (dart:_internal/iterable.dart:39:13)
#7 _ProgramInfoBuilder.build (package:vm_snapshot_analysis/v8_profile.dart:338:16)
#8 toProgramInfo (package:vm_snapshot_analysis/v8_profile.dart:282:8)
#9 _treemapFromSnapshot (package:vm_snapshot_analysis/treemap.dart:158:27)
#10 treemapFromJson (package:vm_snapshot_analysis/treemap.dart:85:5)
#11 SizeAnalyzer.analyzeZipSizeAndAotSnapshot (package:flutter_tools/src/base/analyze_size.dart:123:59)
#12 AndroidGradleBuilder._performCodeSizeAnalysis (package:flutter_tools/src/android/gradle.dart:623:60)
#13 AndroidGradleBuilder.buildGradleApp (package:flutter_tools/src/android/gradle.dart:604:15)
<asynchronous suspension>
#14 AndroidGradleBuilder.buildApk (package:flutter_tools/src/android/gradle.dart:242:5)
<asynchronous suspension>
#15 BuildApkCommand.runCommand (package:flutter_tools/src/commands/build_apk.dart:116:5)
<asynchronous suspension>
#16 FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1297:27)
<asynchronous suspension>
#17 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>
#18 CommandRunner.runCommand (package:args/command_runner.dart:212:13)
<asynchronous suspension>
```
2023-07-07 15:16:59 +00:00
skia-flutter-autoroll
36bc73eb8c
Roll Skia from 7a3a89fadc25 to 5eba922297bb (1 revision) ( flutter/engine#43464 )
...
https://skia.googlesource.com/skia.git/+log/7a3a89fadc25..5eba922297bb
2023-07-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from ab239f985f10 to 869b279baef4 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-07 10:55:35 +00:00
skia-flutter-autoroll
c97ca6f9f7
Roll Skia from adf5b9c27c33 to 7a3a89fadc25 (1 revision) ( flutter/engine#43462 )
...
https://skia.googlesource.com/skia.git/+log/adf5b9c27c33..7a3a89fadc25
2023-07-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from d2d44dda1caa to 72c269263c2f (11 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-07 07:32:19 +00:00
skia-flutter-autoroll
3f204cd11c
Roll Fuchsia Mac SDK from 3D0ft09qP4-Hp_3mQ... to MPy31yjgPV-d_YJq0... ( flutter/engine#43460 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-07 07:12:05 +00:00
skia-flutter-autoroll
05bc4fa653
Roll Skia from 57dc2a31bf26 to adf5b9c27c33 (2 revisions) ( flutter/engine#43459 )
...
https://skia.googlesource.com/skia.git/+log/57dc2a31bf26..adf5b9c27c33
2023-07-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from f72770b2c35d to 8a55336d8456
2023-07-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 501f4e7b8e22 to f72770b2c35d (10 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-07 06:48:22 +00:00
skia-flutter-autoroll
439e7d07ff
Roll Skia from 11a2eefe4c61 to 57dc2a31bf26 (1 revision) ( flutter/engine#43456 )
...
https://skia.googlesource.com/skia.git/+log/11a2eefe4c61..57dc2a31bf26
2023-07-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 9a590d3da398 to 3b9aa123c9d9 (7 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-07 05:51:32 +00:00
skia-flutter-autoroll
7ecd2537d8
Manual roll Dart SDK from 2d98d9e27dae to 0b07debd5862 (21 revisions) ( flutter/engine#43457 )
...
Manual roll requested by aam@google.com
https://dart.googlesource.com/sdk.git/+log/2d98d9e27dae..0b07debd5862
2023-07-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-283.0.dev
2023-07-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-282.0.dev
2023-07-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-281.0.dev
2023-07-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-280.0.dev
2023-07-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-279.0.dev
2023-07-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-278.0.dev
2023-07-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-277.0.dev
2023-07-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-276.0.dev
2023-07-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-275.0.dev
2023-07-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-274.0.dev
2023-07-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-273.0.dev
2023-07-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-272.0.dev
2023-07-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-271.0.dev
2023-07-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-270.0.dev
2023-07-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-269.0.dev
2023-07-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-268.0.dev
2023-06-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-267.0.dev
2023-06-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-266.0.dev
2023-06-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-265.0.dev
2023-06-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-264.0.dev
2023-06-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-263.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,aam@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-07 05:37:37 +00:00
Dan Field
4fdacfb6bc
[Impeller] Duplicate include removal from lazy_glyph_atlas.cc. ( flutter/engine#43453 )
2023-07-07 03:57:18 +00:00
skia-flutter-autoroll
7aa0e36420
Roll Fuchsia Linux SDK from MEXi9Xyj7u24PSx_J... to Cfxhimvf7nMO99ky_... ( flutter/engine#43454 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-07 02:35:21 +00:00
Zachary Anderson
daf8a25142
Reduce redundant Linux clang-tidy work and run on more cores ( flutter/engine#43448 )
...
This PR runs the android_debug_arm64 clang-tidy job on a machine with
more cores, and reduces the number of files linted that are redundant
with the `host_debug` clang-tidy jobs.
2023-07-06 18:54:39 -07:00
Jason Simmons
2c360b26f3
[Impeller] Set up the clear color for non-MSAA render targets. ( flutter/engine#43452 )
...
This is needed when using the "collapse DrawRects into clear colors"
optimization on GLES.
2023-07-06 18:14:30 -07:00
skia-flutter-autoroll
48a5b83ded
Roll Skia from 072dfcc435de to 11a2eefe4c61 (5 revisions) ( flutter/engine#43451 )
...
https://skia.googlesource.com/skia.git/+log/072dfcc435de..11a2eefe4c61
2023-07-06 jvanverth@google.com [graphite] Disable async_rescale_and_read_dog_up on Test jobs.
2023-07-06 nscobie@google.com Fix deleteImageProc call in WrapAndroidHardwareBuffer
2023-07-06 brianosman@google.com Revert "Reland "Fix link errors when XML (expat) is not included""
2023-07-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 654dff5c995f to ab239f985f10 (3 revisions)
2023-07-06 jvanverth@google.com [graphite] Enable linear gamma in rescale operation
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-06 22:49:57 +00:00
Chinmay Garde
6d3d51d086
Account for updated Impeller label. ( flutter/engine#43450 )
...
The label was updated per flutter.dev/go/triage-2023-rfc
2023-07-06 22:39:07 +00:00
Brandon DeRosier
2d78317307
[Impeller] Fix DrawPicture. ( flutter/engine#43446 )
...
Prior to this patch, `DrawPicture` was untested and a no-op.
We needed a new routine to absorb Elements of a cloned pass into another pass, since appending a `Picture` as a subpass would be incorrect behavior for drawing a picture (since subpasses start with a blank image, which gets drawn to and then composited with the parent pass via a separate blending operation).
2023-07-06 22:35:46 +00:00
John McCutchan
2f7b05c650
Eagerly remove the PlatformView from the view hierarchy on Android ( flutter/engine#43423 )
...
Eagerly remove the PlatformView from the view hierarchy on Android.
Fixes [#107297 ](https://github.com/flutter/flutter/issues/107297 )
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
2023-07-06 15:28:10 -07:00
skia-flutter-autoroll
271a554d85
Roll Skia from 10a43e57e0a6 to 072dfcc435de (2 revisions) ( flutter/engine#43445 )
...
https://skia.googlesource.com/skia.git/+log/10a43e57e0a6..072dfcc435de
2023-07-06 jamesgk@google.com Only allow building svg_tool if all necessary deps are available
2023-07-06 jvanverth@google.com [graphite] Add more support in asyncrescaleandread GMs.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-06 20:41:06 +00:00
Tong Mu
f4bd2708cf
Remove dead code for recreating a11y node delegates ( flutter/engine#43359 )
...
This PR removes some dead code for recreating a11y node delegates. These
code was used to refresh a11y information when the macOS embedder live
swapped view controllers, but have become obsolete since
https://github.com/flutter/engine/pull/39145 removed the support for
such live swapping.
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-07-06 13:10:02 -07:00
Loïc Sharma
27e0ef62d8
[macOS] Fix assertion typo ( flutter/engine#43179 )
2023-07-06 20:02:18 +00:00
Dan Field
f247c1a329
Handle nested display list clips in Impeller dispatcher ( flutter/engine#43442 )
...
Fixes https://github.com/flutter/flutter/issues/130084
If a display list is drawn into another display list and the child display list establishes a small clip, subsequent drawing operations are discarded when really they should not be.
The test is expected to render both a blue and a red square; before the fix it renders only the blue square since the red square is incorrectly clipped out.
See also https://github.com/dnfield/flutter_svg/issues/938
2023-07-06 19:47:55 +00:00
LouiseHsu
9e79a79066
Add Look Up to iOS selection controls ( flutter/engine#43308 )
...
In native iOS, when Look Up is initiated on highlighted text, a view DDParsecCollectionViewController is presented with definitions of the the selected text if available, as well as Siri integrated suggestions. However, since the view controller is gated behind a private API, we will use [UIReferenceLibraryViewController](https://developer.apple.com/documentation/uikit/uireferencelibraryviewcontroller ) instead, which is functionally identical and visually very similar.
| Native | UIReferenceLibraryViewController|
| ------------- | ------------- |
| <img src="https://github.com/flutter/engine/assets/36148254/763004f0-970f-4d8a-9a9a-133401ef0c1b " width="360" />| <img src="https://github.com/flutter/engine/assets/36148254/b20fe03f-6c9d-4a4a-98dc-8bcd840406db " width="360" />|
This PR is the engine portion of the changes that will allow this feature change.
This PR addresses https://github.com/flutter/flutter/issues/82907
More details are available in this [design doc](flutter.dev/go/add-missing-features-to-selection-controls)
2023-07-06 19:38:48 +00:00
skia-flutter-autoroll
1f859f035a
Roll Skia from 6aaef9cbc3af to 10a43e57e0a6 (1 revision) ( flutter/engine#43444 )
...
https://skia.googlesource.com/skia.git/+log/6aaef9cbc3af..10a43e57e0a6
2023-07-06 brianosman@google.com Reland "Fix link errors when XML (expat) is not included"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-06 19:25:38 +00:00
skia-flutter-autoroll
3d6a08f427
Roll Skia from 620de5ac9f6b to 6aaef9cbc3af (1 revision) ( flutter/engine#43441 )
...
https://skia.googlesource.com/skia.git/+log/620de5ac9f6b..6aaef9cbc3af
2023-07-06 jvanverth@google.com [graphite] Remove vanilla asyncReadPixels interface from Context.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-06 17:37:21 +00:00
Chris Yang
f265745bc2
Revert "[iOS][Keyboard] Wait vsync on UI thread and update viewport inset to avoid jitter." ( flutter/engine#43422 )
...
Reverts flutter/engine#42312
Original PR caused crash https://github.com/flutter/flutter/issues/130028
Will reopen https://github.com/flutter/flutter/issues/120555
2023-07-06 17:33:07 +00:00
skia-flutter-autoroll
876be53248
Roll ICU from a2961dc659b4 to e8c3bc9ea97d (7 revisions) ( flutter/engine#43440 )
...
a2961dc659..e8c3bc9ea9
2023-06-14 dayeung@chromium.org [ICU 73-1] Update main to 73-1
2023-06-03 megjablon@google.com Add language names for Translate
2023-06-02 megjablon@chromium.org Revert "[ICU 73-1] Update main to 73-1"
2023-06-02 megjablon@chromium.org Revert "Add language names for Translate"
2023-05-31 megjablon@google.com Add language names for Translate
2023-05-30 dayeung@chromium.org [ICU 73-1] Update main to 73-1
2023-05-26 megjablon@google.com Clean up language filters
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/icu-sdk-flutter-engine
Please CC aaclarke@google.com ,tq-i18n-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ICU: https://github.com/unicode-org/icu
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-06 16:26:22 +00:00
Zachary Anderson
32e67cfe77
Further shard clang-tidy runs ( flutter/engine#43428 )
...
The clang-tidy shards have crept up to 60 minutes on some runs. This PR
will bring them back down to around 30 minutes.
It does this by sharding the work for Mac/Linux `host_debug` across 4
shards. The clang-tidy work for ios/Android remains constrained to one
shard. Unfortunately, the clang-tidy script sharding isn't smart enough
to allow the ios/Android shards to participate in the `host_debug`
sharding. This PR leaves that shard as-is, but we could further improve
the runtime there if needed.
2023-07-06 08:56:20 -07:00
Dan Field
f7ba78c7b0
Release log capture at end of test ( flutter/engine#43429 )
...
Fixes https://github.com/flutter/flutter/issues/130036
Also fixes a potential issue where the shell wasn't getting destroyed at the end of the test.
Since no log is actually printed ont he second go, the destructor of `LogMessage` never clears the static pointer, and the next test that tries to print a log tries to print to that pointer which is now garbage.
2023-07-06 15:05:01 +00:00