110 Commits

Author SHA1 Message Date
Adam Barth
fc451b47eb Unfork Sky's trace events
This CL remove the body of Sky's TraceEvent.h in favor of the version in base.
There's still some more of the system to unwind before we can remove all the
other boilerplate.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/691663002
2014-10-30 09:39:46 -07:00
Ojan Vafai
0dfbf8aa38 Remove writing mode code from the linebox tree.
Yo dawg, I heard you like ternaries.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/688233002
2014-10-29 20:29:59 -07:00
Ojan Vafai
21bde7479d Remove final instances of WritingMode in Sky.
After this patch, the only instance of WritingMode is in a comment.
No change in behavior.

TBR=esprehn@chromium.org

Review URL: https://codereview.chromium.org/674073005
2014-10-29 19:58:14 -07:00
Ojan Vafai
86ed666dc2 Get rid of isWritingModeRoot.
This function always returns false now that we don't have writing modes.

TBR=esprehn@chromium.org

Remove flipForWritingMode.

It's a noop now that we don't have writing modes.

Review URL: https://codereview.chromium.org/688223002
2014-10-29 19:53:05 -07:00
Ojan Vafai
13ffe46a43 Remove flipForWritingMode.
It's a noop now that we don't have writing modes.

TBR=esprehn@chromium.org

Review URL: https://codereview.chromium.org/684393002
2014-10-29 19:45:15 -07:00
Ojan Vafai
90b8d2e589 Remove text-combine.
This is a vertical writing mode feature. Sky doesn't support
vertical writing mode.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/677843004
2014-10-29 19:30:32 -07:00
Ojan Vafai
3b628f7d39 Delete a ton more dead vertical writing mode code.
No change in behavior.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/684383002
2014-10-29 19:08:09 -07:00
Ojan Vafai
afa0148e0b First pass at removing dead vertical writing mode code.
This just removes a random subset of vertical writing mode bits
that I grepped for. There's a ton more to do, but it seems best to
do it in chunks.

The key things for understanding this patch, isWritingModeRoot is
always false and isHorizontalWritingMode is always true. Also,
we're never flipped* modes of any kind, so we can undo any flipping.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/688213002
2014-10-29 19:06:59 -07:00
Adam Barth
a9c5a685c1 Remove a number of frontends to ResourceFetcher
We no longer fetch any of these types from the ResourceFetcher.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/690823002
2014-10-29 16:26:34 -07:00
Elliott Sprehn
c9e551fda5 Remove more stuff from Widget.
This removes even more APIs from widget. This also removes some methods
that had been broken and made infinitely recursive on FrameView.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/684353002
2014-10-29 15:57:18 -07:00
Adam Barth
e000e53207 Remove Platform::cryptographicallyRandomValues
We can just call the base API directly.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/691483005
2014-10-29 15:55:19 -07:00
Elliott Sprehn
ca6775b3da Remove a lot of Widget APIs.
We don't need a lot of the Widget API. I also removed the
visibility code which seems to have been broken when we
removed FrameView::show and hide(), which looks like it
would have broken image loading. Unfortuantely we don't
have pixel tests or tests that load images so I can't
test this yet. Even so it's a good simplificatin since
our system has no concept of hidden widgets.

R=abarth@chromium.org, ojan@chromium.org

Review URL: https://codereview.chromium.org/691453002
2014-10-29 15:23:10 -07:00
Elliott Sprehn
7c0366d891 Remove most of FloatingObject.
This leaves some uses of FloatingObject*, but it doesn't
leave the impl of the class so it's all dead code passing
around null pointers. I'll remove that in a future patch.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/689733003
2014-10-29 15:04:40 -07:00
Elliott Sprehn
e47b2bdb5f Remove a lot of floats related code.
R=eseidel@chromium.org, ojan@chromium.org

Review URL: https://codereview.chromium.org/678113005
2014-10-29 14:08:55 -07:00
Adam Barth
8385799d73 Fix line numbers in JavaScript stack traces
Instead of calling the function constructor to compile script in Sky, we now
concatenate strings. This has the advantage of making the line numbers
generated in error messages correct but the disadvantage of being a hack. I've
filed https://code.google.com/p/v8/issues/detail?id=3624 to request a proper
API for this purpose.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/688033003
2014-10-29 14:00:57 -07:00
Ojan Vafai
959c404854 Remove all writing mode function arguments and remove writing mode from RenderStyle.
R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/683803006
2014-10-29 12:18:30 -07:00
Ojan Vafai
8b0d9e8ac9 First past at removing writing mode.
This removes the parsing and the enum. This leaves a bunch of
dead code around to fix in a followup.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/689743002
2014-10-29 12:17:11 -07:00
Scott Violet
e782924013 Fixes release build
Only fails in release.

R=abarth@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/684123003
2014-10-29 09:00:25 -07:00
Elliott Sprehn
3ad63531da Remove Nine Patch layers.
These were only used for doing effects in Clank and the
shadows around the page when bouncing on the Mac. Now
they're dead code.

In the future if we decide nine patch is an API we really
want we should expose web platform primitives instead of
having a special API on layer.

R=ojan@chromium.org, abarth@chromium.org

Review URL: https://codereview.chromium.org/685983002
2014-10-28 20:13:46 -07:00
Ojan Vafai
53638e9784 Remove more frame-level scrolling machinery.
We don't need to know anymore whether the scroll was programmatic.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/684063002
2014-10-28 20:10:59 -07:00
Ojan Vafai
ce9aa787cb Remove more frame-level scrolling machinery.
This is all dead code. No change in behavior.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/678193005
2014-10-28 19:27:52 -07:00
Elliott Sprehn
82245c19f8 Remove getTickmarks.
R=ojan@chromium.org

Review URL: https://codereview.chromium.org/681293005
2014-10-28 19:22:17 -07:00
Ojan Vafai
e246934fb9 Remove more scrolling methods from FrameView.
No change in behavior. Just deleting dead code.
Also removes ScrollAnimatorNone since it's unused.
We'll need to bring some of this back, but we'll
do that when we get rid of composited scrolling.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/682363002
2014-10-28 17:38:08 -07:00
Ojan Vafai
a10806067d Get rid of ScrollbarGroup. Sky doesn't use it.
More cleanup of dead code now that we don't have frame-level scrolling.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/687553006
2014-10-28 17:37:23 -07:00
Elliott Sprehn
dc00d6678b Remove a lot of dead Scrollbar methods.
R=ojan@chromium.org

Review URL: https://codereview.chromium.org/685003003
2014-10-28 17:29:41 -07:00
Adam Barth
74db9da5e1 Add inspect command to skydb
This CL adds an "inspect" command to skydb that injects the inspector module
into the page and prints some instructions for opening the inspector.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/690433004
2014-10-28 17:08:25 -07:00
Ojan Vafai
423d08cc86 More cleanup of dead code now that we don't have frame-level scrolling.
No change in behavior. The overflowchanged event was never fired.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/687783003
2014-10-28 16:53:47 -07:00
Elliott Sprehn
b8843caa44 Remove concept of child Widgets.
FrameView doesn't really need to know about the child widgets,
which are just Scrollbars now.

I also deleted some dead code from Widget and removed FrameWidget
since we don't need that abstraction now.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/685593005
2014-10-28 16:53:12 -07:00
Elliott Sprehn
e379c7382a Remove PageOverlays.
These were related to the inspector overlays, if we want to
do this in the future we should place mojo::Views over the
page in the sky debugger so sky itself doesn't need to manage
the overlay views.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/687003002
2014-10-28 15:44:00 -07:00
Elliott Sprehn
63d21b0287 Remove RenderWidget.
This is part of the old iframe and plugin system, we don't need it.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/682263003
2014-10-28 15:10:32 -07:00
Elliott Sprehn
2f329e05b0 Remove RenderPart.
This was part of the old plugin system, we don't need it.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/686903003
2014-10-28 15:01:27 -07:00
Ojan Vafai
c2ceb794d5 Get rid of slow repaint objects and main thread scrolling reasons.
We will only have one scrolling path in Sky, so we don't need
machinery for mutiple scrolling codepaths.

Remove viewportConstrained plumbing.

Sky doesn't have viewport constrained elements (no position:fixed).

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/661633003
2014-10-28 14:57:38 -07:00
Ojan Vafai
223c532e5f Remove viewportConstrained plumbing.
Sky doesn't have viewport constrained elements (no position:fixed).

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/688433003
2014-10-28 14:28:39 -07:00
Elliott Sprehn
4aa67a30c5 Remove AllowUserAgentScript.
This was only used for deprecated plugins in blink,
we don't need it now.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/687803002
2014-10-28 14:28:30 -07:00
Adam Barth
f3e367c383 Don't crash when importing a module that doesn't export
Instead of crashing, we should use the value "undefined". There's some question
as to whether we should default to the document, but we can resolve that later.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/690483002
2014-10-28 14:13:31 -07:00
Ojan Vafai
f11504f4e8 Remove layerIsContainerForFixedPositionLayers.
We don't have fixed position. We'll later need to remove this
functionality from cc as well.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/680263005
2014-10-28 13:59:57 -07:00
Ojan Vafai
054799183a Remove a bit more position:fixed plumbing.
No change in behavior.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/688443003
2014-10-28 12:56:42 -07:00
Eric Seidel
70c382c012 Remove wtf/Functional.h
The background parser was the last client.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/684813003
2014-10-28 10:41:02 -07:00
Eric Seidel
c32433111b Remove almost all of Oilpan
The only things left are all the baseclasses
and macros in heap/Handle.h which are referenced
throughout all of core.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/686783002
2014-10-28 09:36:50 -07:00
Ojan Vafai
42ea48b379 Remove a bunch of fixed position dead code.
There is not change in behavior here. Just removing dead
code now that we no longer support position:fixed.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/686653002
2014-10-28 09:34:19 -07:00
Adam Barth
373117fdb8 Delete WebWaitableEvent
We don't use this interface. In the future, we can just use the base version
directly.

R=eseidel@chromium.org, ojan@chromium.org

Review URL: https://codereview.chromium.org/681173002
2014-10-27 21:50:35 -07:00
Eric Seidel
4d27846f85 Remove Heap.h
Had to move a couple macros into Handle.h
(which we won't be able to remove for
a while yet), but otherwise Heap is dead.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/681113004
2014-10-27 21:04:58 -07:00
Adam Barth
26813e1c3c Update tokenizer to match spec
This CL is a rough pass over the HTMLTokenizer to align it with parsing.md.
We'll need to do another pass more carefully in the future, but this CL gets us
roughly in the right ballpark.

We're not handling EOF properly. The parsing.md spec doesn't push the EOF
though the parser, which breaks our current way of handling EOF. We do ok if we
get EOF in the DataState, and that's enough to pass the tests for now.

Also, update camel-case.sky to reflect the fact that the parser doesn't
lower-case tag names anymore.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/678263002
2014-10-27 20:38:29 -07:00
Ojan Vafai
9423819dcc First pass at removing position:fixed.
The root is never scrollable, so position:fixed doesn't
do anything anymore.

Also remove some dead frame-level scrolling code that interacted
with fixed position things.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/686633002
2014-10-27 19:42:46 -07:00
Eric Seidel
6b82826198 Remove various Heap* types.
Also removed a bunch of trace() methods which
I touched by accident.  Turns out they're
all very interconnected sadly.

I re-wrote Supplement to not use templates
in an earlier version of this patch
but hit some trouble with vtables
and decided to table that work
for a later time once more of oilpan
has been unwound.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/683703003
2014-10-27 18:19:46 -07:00
Eric Seidel
e9e27699ad Remove GarbageCollectedFinalized
This class didn't actually do anything anymore.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/655083003
2014-10-27 17:41:38 -07:00
Adam Barth
c198c32164 Don't crash when importing a 404
Now we have a test for this case.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/682913002
2014-10-27 17:22:55 -07:00
Eric Seidel
de93d90cda Remove heap/*.cpp files
Nothing in heap/ is called anymore, but it
still has its claws deep into many of the
base classes for the rest of Sky, so I've left
the (largely unmodified) headers for now.

We'll trim the headers further in later patches.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/681963002
2014-10-27 17:13:36 -07:00
Adam Barth
7639e0fe39 Simplify HTMLInputStream
We don't need to deal with all the insertion point complexity.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/683693002
2014-10-27 17:06:10 -07:00
Adam Barth
82cdb4de3b Remove HTMLTokenizerNames
We don't need these anymore.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/682903002
2014-10-27 17:05:46 -07:00