Adam Barth
fc451b47eb
Unfork Sky's trace events
...
This CL remove the body of Sky's TraceEvent.h in favor of the version in base.
There's still some more of the system to unwind before we can remove all the
other boilerplate.
R=eseidel@chromium.org
Review URL: https://codereview.chromium.org/691663002
2014-10-30 09:39:46 -07:00
Ojan Vafai
0dfbf8aa38
Remove writing mode code from the linebox tree.
...
Yo dawg, I heard you like ternaries.
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/688233002
2014-10-29 20:29:59 -07:00
Ojan Vafai
21bde7479d
Remove final instances of WritingMode in Sky.
...
After this patch, the only instance of WritingMode is in a comment.
No change in behavior.
TBR=esprehn@chromium.org
Review URL: https://codereview.chromium.org/674073005
2014-10-29 19:58:14 -07:00
Ojan Vafai
86ed666dc2
Get rid of isWritingModeRoot.
...
This function always returns false now that we don't have writing modes.
TBR=esprehn@chromium.org
Remove flipForWritingMode.
It's a noop now that we don't have writing modes.
Review URL: https://codereview.chromium.org/688223002
2014-10-29 19:53:05 -07:00
Ojan Vafai
13ffe46a43
Remove flipForWritingMode.
...
It's a noop now that we don't have writing modes.
TBR=esprehn@chromium.org
Review URL: https://codereview.chromium.org/684393002
2014-10-29 19:45:15 -07:00
Ojan Vafai
90b8d2e589
Remove text-combine.
...
This is a vertical writing mode feature. Sky doesn't support
vertical writing mode.
R=esprehn@chromium.org
Review URL: https://codereview.chromium.org/677843004
2014-10-29 19:30:32 -07:00
Ojan Vafai
3b628f7d39
Delete a ton more dead vertical writing mode code.
...
No change in behavior.
R=esprehn@chromium.org
Review URL: https://codereview.chromium.org/684383002
2014-10-29 19:08:09 -07:00
Ojan Vafai
afa0148e0b
First pass at removing dead vertical writing mode code.
...
This just removes a random subset of vertical writing mode bits
that I grepped for. There's a ton more to do, but it seems best to
do it in chunks.
The key things for understanding this patch, isWritingModeRoot is
always false and isHorizontalWritingMode is always true. Also,
we're never flipped* modes of any kind, so we can undo any flipping.
R=esprehn@chromium.org
Review URL: https://codereview.chromium.org/688213002
2014-10-29 19:06:59 -07:00
Adam Barth
a9c5a685c1
Remove a number of frontends to ResourceFetcher
...
We no longer fetch any of these types from the ResourceFetcher.
R=esprehn@chromium.org
Review URL: https://codereview.chromium.org/690823002
2014-10-29 16:26:34 -07:00
Elliott Sprehn
c9e551fda5
Remove more stuff from Widget.
...
This removes even more APIs from widget. This also removes some methods
that had been broken and made infinitely recursive on FrameView.
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/684353002
2014-10-29 15:57:18 -07:00
Adam Barth
e000e53207
Remove Platform::cryptographicallyRandomValues
...
We can just call the base API directly.
R=esprehn@chromium.org
Review URL: https://codereview.chromium.org/691483005
2014-10-29 15:55:19 -07:00
Adam Barth
e3d78d7306
Convert more this.exports to module.exports
...
TBR=esprehn@chromium.org
Review URL: https://codereview.chromium.org/685323003
2014-10-29 15:25:41 -07:00
Elliott Sprehn
ca6775b3da
Remove a lot of Widget APIs.
...
We don't need a lot of the Widget API. I also removed the
visibility code which seems to have been broken when we
removed FrameView::show and hide(), which looks like it
would have broken image loading. Unfortuantely we don't
have pixel tests or tests that load images so I can't
test this yet. Even so it's a good simplificatin since
our system has no concept of hidden widgets.
R=abarth@chromium.org , ojan@chromium.org
Review URL: https://codereview.chromium.org/691453002
2014-10-29 15:23:10 -07:00
Adam Barth
83f05ff8bf
Use module.exports rather than this.exports
...
R=esprehn@chromium.org
Review URL: https://codereview.chromium.org/687263005
2014-10-29 15:21:28 -07:00
Elliott Sprehn
7c0366d891
Remove most of FloatingObject.
...
This leaves some uses of FloatingObject*, but it doesn't
leave the impl of the class so it's all dead code passing
around null pointers. I'll remove that in a future patch.
R=eseidel@chromium.org
Review URL: https://codereview.chromium.org/689733003
2014-10-29 15:04:40 -07:00
Hixie
880aa97442
Specs: Add a way for the inspector to see the registered event listeners
...
Review URL: https://codereview.chromium.org/687353003
2014-10-29 14:15:04 -07:00
Eric Seidel
46a584b4d3
Add a very minimal CSSAgent
...
Also fixed the exception caused by IndexedDB being
missing. It was there, just not used by inspector.sky.
R=esprehn@chromium.org , abarth@chromium.org
Review URL: https://codereview.chromium.org/662523003
2014-10-29 14:14:06 -07:00
Elliott Sprehn
e47b2bdb5f
Remove a lot of floats related code.
...
R=eseidel@chromium.org , ojan@chromium.org
Review URL: https://codereview.chromium.org/678113005
2014-10-29 14:08:55 -07:00
Adam Barth
8385799d73
Fix line numbers in JavaScript stack traces
...
Instead of calling the function constructor to compile script in Sky, we now
concatenate strings. This has the advantage of making the line numbers
generated in error messages correct but the disadvantage of being a hack. I've
filed https://code.google.com/p/v8/issues/detail?id=3624 to request a proper
API for this purpose.
R=esprehn@chromium.org
Review URL: https://codereview.chromium.org/688033003
2014-10-29 14:00:57 -07:00
Hixie
50914a1e1e
Docs: call superclass constructors in radio.sky example
...
Review URL: https://codereview.chromium.org/689763003
2014-10-29 13:45:20 -07:00
Hixie
6b0a6770ba
Specs: Expose the currently running script so that you can do Polymer-style magic
...
Review URL: https://codereview.chromium.org/687353002
2014-10-29 13:42:42 -07:00
Hixie
5f9ecf9f72
Specs: Pass the module last so that if we add other values later we don't shift things in the arguments array
...
Review URL: https://codereview.chromium.org/689763002
2014-10-29 13:37:31 -07:00
Hixie
25934ac040
Docs: Update radio.sky to use the specced API for shadow roots
...
Review URL: https://codereview.chromium.org/692563003
2014-10-29 13:10:33 -07:00
Adam Barth
243555a99e
Add a basic XMLHttpRequest implementation
...
R=esprehn@chromium.org
Review URL: https://codereview.chromium.org/690803002
2014-10-29 12:48:16 -07:00
Hixie
945193eb86
Specs: Make it possible to import a module from a module or application by calling module.import(url)
...
Review URL: https://codereview.chromium.org/690793002
2014-10-29 12:29:41 -07:00
Hixie
b50d01ca6b
Specs: move findId() to TreeScope since it wouldn't be O(1) on Element
...
Review URL: https://codereview.chromium.org/686243002
2014-10-29 12:22:13 -07:00
Ojan Vafai
959c404854
Remove all writing mode function arguments and remove writing mode from RenderStyle.
...
R=esprehn@chromium.org
Review URL: https://codereview.chromium.org/683803006
2014-10-29 12:18:30 -07:00
Ojan Vafai
8b0d9e8ac9
First past at removing writing mode.
...
This removes the parsing and the enum. This leaves a bunch of
dead code around to fix in a followup.
R=esprehn@chromium.org
Review URL: https://codereview.chromium.org/689743002
2014-10-29 12:17:11 -07:00
Eric Seidel
eb58358bab
Slight simplification to prompt code
...
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/678833004
2014-10-29 12:15:34 -07:00
Eric Seidel
cc5219a17f
Don't show sky_server logs to the skydb console
...
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/692593004
2014-10-29 11:03:54 -07:00
Scott Violet
e782924013
Fixes release build
...
Only fails in release.
R=abarth@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/684123003
2014-10-29 09:00:25 -07:00
Eric Seidel
9e09e175f9
Add basic console support to Sky's inspector.
...
I think longer-term we want to instead fork
InjectedScriptSource.js:
http://blink.lc/blink/tree/Source/core/inspector/InjectedScriptSource.js
since a ton of the "remote object" logic could be shared
between Blink and Sky here.
Since we're trying to talk exactly Chrome's inspector
protocol we should start from the Blink JS as much as possible.
That said, this is enough to get the Chrome devtools
inspector to talk to sky and have the console handle
basic commands!
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/674823003
2014-10-29 08:47:10 -07:00
Elliott Sprehn
3ad63531da
Remove Nine Patch layers.
...
These were only used for doing effects in Clank and the
shadows around the page when bouncing on the Mac. Now
they're dead code.
In the future if we decide nine patch is an API we really
want we should expose web platform primitives instead of
having a special API on layer.
R=ojan@chromium.org , abarth@chromium.org
Review URL: https://codereview.chromium.org/685983002
2014-10-28 20:13:46 -07:00
Ojan Vafai
53638e9784
Remove more frame-level scrolling machinery.
...
We don't need to know anymore whether the scroll was programmatic.
R=esprehn@chromium.org
Review URL: https://codereview.chromium.org/684063002
2014-10-28 20:10:59 -07:00
Ojan Vafai
6b0469399e
Make printing limbo lines in test_sky only print the prefix once.
...
This makes the output much more readable and you can actually see
stacktraces. Long-term, we need to stick this output into the result
of the previous test instead of having them be printed to stderr.
R=esprehn@chromium.org
Review URL: https://codereview.chromium.org/686723004
2014-10-28 19:44:29 -07:00
Elliott Sprehn
83ea6e812c
Mark hixie's tests as Skip so they don't spam the console.
...
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/687893003
2014-10-28 19:36:12 -07:00
Ojan Vafai
ce9aa787cb
Remove more frame-level scrolling machinery.
...
This is all dead code. No change in behavior.
R=esprehn@chromium.org
Review URL: https://codereview.chromium.org/678193005
2014-10-28 19:27:52 -07:00
Elliott Sprehn
82245c19f8
Remove getTickmarks.
...
R=ojan@chromium.org
Review URL: https://codereview.chromium.org/681293005
2014-10-28 19:22:17 -07:00
Hixie
d7dbe841b4
This CL provides a bunch of new parser tests, and updates the
...
TestExpectations file to skip the ones that fail or crash. It also
updates the TestExpectations parser to support URLs pointing to the
mojo repo's issue tracker.
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/685593006
2014-10-28 18:58:18 -07:00
Ojan Vafai
e246934fb9
Remove more scrolling methods from FrameView.
...
No change in behavior. Just deleting dead code.
Also removes ScrollAnimatorNone since it's unused.
We'll need to bring some of this back, but we'll
do that when we get rid of composited scrolling.
R=esprehn@chromium.org
Review URL: https://codereview.chromium.org/682363002
2014-10-28 17:38:08 -07:00
Ojan Vafai
a10806067d
Get rid of ScrollbarGroup. Sky doesn't use it.
...
More cleanup of dead code now that we don't have frame-level scrolling.
R=esprehn@chromium.org
Review URL: https://codereview.chromium.org/687553006
2014-10-28 17:37:23 -07:00
Elliott Sprehn
dc00d6678b
Remove a lot of dead Scrollbar methods.
...
R=ojan@chromium.org
Review URL: https://codereview.chromium.org/685003003
2014-10-28 17:29:41 -07:00
Adam Barth
74db9da5e1
Add inspect command to skydb
...
This CL adds an "inspect" command to skydb that injects the inspector module
into the page and prints some instructions for opening the inspector.
R=eseidel@chromium.org
Review URL: https://codereview.chromium.org/690433004
2014-10-28 17:08:25 -07:00
James Robinson
e061930d2b
Update from chromium https://crrev.com/301725/
...
This updates DEPS to reflect changes in 301725 /
90a7c4e3fdeb82a18e17f24e56345b9086a8308b, imports changes, and adds
a patch file for our ui/gl/gl_surface modifications.
Review URL: https://codereview.chromium.org/669813003
2014-10-28 17:00:48 -07:00
Ojan Vafai
423d08cc86
More cleanup of dead code now that we don't have frame-level scrolling.
...
No change in behavior. The overflowchanged event was never fired.
R=esprehn@chromium.org
Review URL: https://codereview.chromium.org/687783003
2014-10-28 16:53:47 -07:00
Elliott Sprehn
b8843caa44
Remove concept of child Widgets.
...
FrameView doesn't really need to know about the child widgets,
which are just Scrollbars now.
I also deleted some dead code from Widget and removed FrameWidget
since we don't need that abstraction now.
R=ojan@chromium.org
Review URL: https://codereview.chromium.org/685593005
2014-10-28 16:53:12 -07:00
Elliott Sprehn
e379c7382a
Remove PageOverlays.
...
These were related to the inspector overlays, if we want to
do this in the future we should place mojo::Views over the
page in the sky debugger so sky itself doesn't need to manage
the overlay views.
R=ojan@chromium.org
Review URL: https://codereview.chromium.org/687003002
2014-10-28 15:44:00 -07:00
Adam Barth
b1f39b7c1b
Move framework/inspector/server to services/inspector
...
Moving the inspector WebSocket proxy server out of the framework directory
simplifies the mappings for the HTTP servers.
R=eseidel@chromium.org
Review URL: https://codereview.chromium.org/687673004
2014-10-28 15:38:23 -07:00
Hixie
28fab08e02
Specs: Parser fixes for issues Adam found
...
Review URL: https://codereview.chromium.org/682283002
2014-10-28 15:15:52 -07:00
Elliott Sprehn
63d21b0287
Remove RenderWidget.
...
This is part of the old iframe and plugin system, we don't need it.
R=ojan@chromium.org
Review URL: https://codereview.chromium.org/682263003
2014-10-28 15:10:32 -07:00
