DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
28,728 Commits 882 Branches 1,069 Tags
Commit Graph

28728 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
skia-flutter-autoroll
fbc6f9f936 Roll Dart SDK from eff8f62a7bc7 to 07016e96b9ed (1 revision) (flutter/engine#41770) 
https://dart.googlesource.com/sdk.git/+log/eff8f62a7bc7..07016e96b9ed

2023-05-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-80.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,dart-vm-team@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-05 11:17:34 +00:00
skia-flutter-autoroll
5be5a3d00c Roll Skia from edc4ee2e286e to d71ece9f9f1a (2 revisions) (flutter/engine#41768) 
https://skia.googlesource.com/skia.git/+log/edc4ee2e286e..d71ece9f9f1a

2023-05-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from cd171d2ef3ca to dd7eb1d8e8dc (14 revisions)
2023-05-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 5894e1e3e47d to 2cde5edfb81e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-05 09:54:34 +00:00
skia-flutter-autoroll
1b9b698951 Roll Fuchsia Linux SDK from m0-fwGyFnoDVAvxgk... to jbpFz7qSikrKiRanC... (flutter/engine#41769) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-05 09:40:21 +00:00
skia-flutter-autoroll
c4d5616ed5 Roll Dart SDK from afeed9f8701e to eff8f62a7bc7 (2 revisions) (flutter/engine#41764) 
https://dart.googlesource.com/sdk.git/+log/afeed9f8701e..eff8f62a7bc7

2023-05-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-79.0.dev
2023-05-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-78.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,dart-vm-team@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-05 07:28:22 +00:00
skia-flutter-autoroll
330fc18be0 Roll Skia from bf4217c3f0da to edc4ee2e286e (1 revision) (flutter/engine#41763) 
https://skia.googlesource.com/skia.git/+log/bf4217c3f0da..edc4ee2e286e

2023-05-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from d6fb4eb8ccb8 to 5894e1e3e47d (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-05 07:00:21 +00:00
Tong Mu
0d1d5a7d34 [macOS] Change view ID's type to signed and a typedef (flutter/engine#41653) 
This PR changes the view ID type to `int64_t` and typedef it to
`FlutterViewId`

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-05-04 23:08:57 -07:00
skia-flutter-autoroll
71c4831258 Roll Skia from 6577130e14b6 to bf4217c3f0da (1 revision) (flutter/engine#41762) 
https://skia.googlesource.com/skia.git/+log/6577130e14b6..bf4217c3f0da

2023-05-05 michaelludwig@google.com Reland "[skif] Use FilterResult::applyColorFilter in SkColorFilterImageFilter"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-05 04:02:09 +00:00
陈昱
aa95b83a0d Close connection on keyboard close (flutter/engine#41500) 
Fix:
- https://github.com/flutter/flutter/issues/123523
- https://github.com/flutter/flutter/issues/124890

### Before this patch:

https://user-images.githubusercontent.com/30322203/228413196-29c57bb0-3220-495b-9e73-f58777de440f.mp4

### After this patch:

https://user-images.githubusercontent.com/30322203/228413249-fc06f49d-6579-4476-9788-90f12a53b8c3.mp4
 2023-05-05 02:55:05 +00:00
skia-flutter-autoroll
24a866fe8e Roll Fuchsia Mac SDK from SD8Q_B7eWZqLgqo0f... to de2Eqw0IsOzTq15m3... (flutter/engine#41755) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-05 00:17:02 +00:00
skia-flutter-autoroll
7e16e1d4a2 Roll Skia from 00693e987828 to 6577130e14b6 (1 revision) (flutter/engine#41752) 
https://skia.googlesource.com/skia.git/+log/00693e987828..6577130e14b6

2023-05-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 9b1cd443e07a to 3ef8bd4528d0 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-04 23:55:39 +00:00
Jackson Gardner
f2970b73b0 Revert "Skwasm Font Loading" (flutter/engine#41750) 
Reverts flutter/engine#41246

The new font manifest parsing fails in some cases.
 2023-05-04 23:54:18 +00:00
skia-flutter-autoroll
f19f8994e8 Roll Dart SDK from 95e133dbd3a6 to afeed9f8701e (1 revision) (flutter/engine#41749) 
https://dart.googlesource.com/sdk.git/+log/95e133dbd3a6..afeed9f8701e

2023-05-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-77.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,dart-vm-team@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-04 23:38:37 +00:00
Jenn Magder
29dc3361f0 Fix flaky FlutterChannelsTests, stop mocking NSObject (flutter/engine#41747) 
I don't know why this is only flaking on arm64 Macs, but instead of mocking out `NSObject` which seems to continue to be mocked on some background thread, instead mock out the more-specific `FlutterTaskQueue` protocol.  Turn the tests back on.

Fixes https://github.com/flutter/flutter/issues/126013
Reverts https://github.com/flutter/engine/pull/41740

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-04 22:58:12 +00:00
skia-flutter-autoroll
c8110a1cb7 Roll Skia from a4828415b4af to 00693e987828 (6 revisions) (flutter/engine#41746) 
https://skia.googlesource.com/skia.git/+log/a4828415b4af..00693e987828

2023-05-04 johnstiles@google.com Remove unused flag from VarDeclaration::Convert.
2023-05-04 johnstiles@google.com Use packed contexts for ternary ops in SkRP.
2023-05-04 michaelludwig@google.com [skif] Automatically switch to NN sampling when possible
2023-05-04 johnstiles@google.com Create test case demonstrating inliner issue.
2023-05-04 johnstiles@google.com Generate simpler code when SkArenaAlloc makes a POD type.
2023-05-04 michaelludwig@google.com Add skia_use_legacy_colorfilter_imagefilter GN arg for flutter roll

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-04 22:58:10 +00:00
godofredoc
67ff63e16a Migrate linux unopt to engine_v2. (flutter/engine#41658) 
Migrates linux unopt to use engine v2 recipes.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-04 21:59:52 +00:00
Jonah Williams
11bd4c8bb3 [Impeller] check if path is Rect/RRect/Oval (flutter/engine#41744) 
This avoids tessellation if the application draws a Rect or RREct with Path.addRect or Path.addRREct.
 2023-05-04 20:51:21 +00:00
Michael Ludwig
4a82a1b867 Add temporary staging GN arg for Skia roll (flutter/engine#41743) 
In order to enable the new behavior, dl_imagefilter_unittests need to be
updated to reflect new bounds mapping values. This requires an atomic PR
to disable the legacy arg and update after skia rolls.

Required to land https://skia-review.googlesource.com/c/skia/+/693058
and progress on https://skbug.com/9283

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-05-04 13:38:01 -07:00
Jason Simmons
f9a3a4889f Roll buildroot to 05ec9f7124191c7ba354521f3ffd34b09af872e7 (flutter/engine#41736) 2023-05-04 20:03:19 +00:00
skia-flutter-autoroll
14647eace4 Roll Dart SDK from 7b56aac98a5a to 95e133dbd3a6 (1 revision) (flutter/engine#41741) 
https://dart.googlesource.com/sdk.git/+log/7b56aac98a5a..95e133dbd3a6

2023-05-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-76.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,dart-vm-team@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-04 19:51:57 +00:00
Dan Field
ee7376a670 Disable flaky tests on arm64 (flutter/engine#41740) 
Reduces severity of https://github.com/flutter/flutter/issues/126013
 2023-05-04 12:22:18 -07:00
skia-flutter-autoroll
e6ece101f0 Roll Skia from 6950f56ad2ec to a4828415b4af (2 revisions) (flutter/engine#41737) 
https://skia.googlesource.com/skia.git/+log/6950f56ad2ec..a4828415b4af

2023-05-04 johnstiles@google.com Use a packed context for SkRP case_op.
2023-05-04 johnstiles@google.com Ensure linear-SRGB conversion is free when it's a no-op.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-04 19:11:41 +00:00
skia-flutter-autoroll
7a7f907adf Roll Fuchsia Linux SDK from LIacrdFhuTuHnYh0B... to m0-fwGyFnoDVAvxgk... (flutter/engine#41738) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-04 18:37:59 +00:00
Jackson Gardner
6f5ad9737e Skwasm Font Loading (flutter/engine#41246) 
This implements font loading for the skwasm renderer.

In addition, it does some pretty major refactors:
1) Simplified the font collection interface to just have a single `loadAssetFonts` call, without the separate registration and debug fonts loading stuff
2) Debug fonts load now through http/asset mocking mechanisms instead of having a separate `downloadDebugTestFonts` call
3) Consolidated a few of our different unit test setup functions into a single `setUpUnitTests` function
 2023-05-04 18:22:53 +00:00
godofredoc
a21064fb0a Migrate linux_host_engine to engine v2. (flutter/engine#41715) 
The artifacts generated by legacy and engine v2 are identical. This PR is moving linux host engine to staging and starts uploading engine v2 artifacts to production.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-04 16:23:51 +00:00
skia-flutter-autoroll
f6636f5cdc Roll Dart SDK from 47da769ae13a to 7b56aac98a5a (1 revision) (flutter/engine#41731) 
https://dart.googlesource.com/sdk.git/+log/47da769ae13a..7b56aac98a5a

2023-05-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-75.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,dart-vm-team@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-04 13:25:39 +00:00
skia-flutter-autoroll
181a24db84 Roll Fuchsia Mac SDK from LCajvqTauUudC-7RW... to SD8Q_B7eWZqLgqo0f... (flutter/engine#41730) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-04 11:31:15 +00:00
skia-flutter-autoroll
b667d0150d Roll Skia from 02e4b3087869 to 6950f56ad2ec (1 revision) (flutter/engine#41729) 
https://skia.googlesource.com/skia.git/+log/02e4b3087869..6950f56ad2ec

2023-05-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from a73e546cf108 to cd171d2ef3ca (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-04 10:49:05 +00:00
skia-flutter-autoroll
d8f5dc2f53 Roll Skia from 5c0f4c9bdc35 to 02e4b3087869 (1 revision) (flutter/engine#41728) 
https://skia.googlesource.com/skia.git/+log/5c0f4c9bdc35..02e4b3087869

2023-05-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4ec2a864c052 to 9b1cd443e07a (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-04 09:59:31 +00:00
skia-flutter-autoroll
48067b7585 Roll Skia from 9b19c0a0acf0 to 5c0f4c9bdc35 (1 revision) (flutter/engine#41727) 
https://skia.googlesource.com/skia.git/+log/9b19c0a0acf0..5c0f4c9bdc35

2023-05-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 23d269a0c00a to b9a33c8cf785

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-04 07:47:05 +00:00
skia-flutter-autoroll
25a5af26cb Roll Dart SDK from 59787216f670 to 47da769ae13a (2 revisions) (flutter/engine#41726) 
https://dart.googlesource.com/sdk.git/+log/59787216f670..47da769ae13a

2023-05-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-74.0.dev
2023-05-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-73.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,dart-vm-team@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-04 07:45:04 +00:00
skia-flutter-autoroll
c9a790b448 Roll Skia from 93c869da03f5 to 9b19c0a0acf0 (14 revisions) (flutter/engine#41725) 
https://skia.googlesource.com/skia.git/+log/93c869da03f5..9b19c0a0acf0

2023-05-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 502a387d3238 to d6fb4eb8ccb8 (11 revisions)
2023-05-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from b89ed2f23a03 to ecefa6c65969 (1 revision)
2023-05-04 michaelludwig@google.com Revert "[skif] Use FilterResult::applyColorFilter in SkColorFilterImageFilter"
2023-05-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from fc9661a5b52e to eca6699311e8 (1 revision)
2023-05-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from ba39d81f9797 to fc9661a5b52e (1 revision)
2023-05-03 johnstiles@google.com Add realistic/ directory to golden outputs.
2023-05-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 25854b6d2ad9 to 4ec2a864c052 (5 revisions)
2023-05-03 jvanverth@google.com [graphite] A couple more minor Vulkan issues.
2023-05-03 michaelludwig@google.com [skif] Use FilterResult::applyColorFilter in SkColorFilterImageFilter
2023-05-03 michaelludwig@google.com [skif] Re-implement Magnifier image filter
2023-05-03 fmalita@chromium.org [svg] Add SK_API to public classes
2023-05-03 johnstiles@google.com Use padding to save an op when invoking to/fromLinearSrgb.
2023-05-03 herb@google.com constify FindEnclosingEdges
2023-05-03 michaelludwig@google.com Add GM exploring SkImageFilters::Magnifier behavior

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-04 07:02:38 +00:00
skia-flutter-autoroll
b7e9833ca1 Roll Fuchsia Linux SDK from n1UnzmslAzt04yRv6... to LIacrdFhuTuHnYh0B... (flutter/engine#41724) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-04 05:48:20 +00:00
Jackson Gardner
5189eda98b Populate fallback fonts from CIPD in tests (flutter/engine#41656) 
This fixes https://github.com/flutter/flutter/issues/85793

The script that generates the font fallback data also rolls a package to CIPD with these files and updates the DEPS to download those files from CIPD. This makes sure that these tests are hermetic.
 2023-05-04 05:12:54 +00:00
Dan Field
1535542946 Make run_tests.py assert that the ios test dylib is at least as new as libFlutter.dylib (flutter/engine#41720) 
This would have helped me figure out why I wasn't getting the same failures as on CI more quickly.
 2023-05-04 01:49:22 +00:00
Brandon DeRosier
4f9622c56b [Impeller] Remove the DrawPaint->Clear optimization (flutter/engine#41711) 
Fixes https://github.com/flutter/flutter/issues/125906.
Fixes https://github.com/flutter/flutter/issues/125908.

Going to add this back once I'm able to work out why the clear colors
aren't working on GL/Vulkan. Stepping though with a debugger for both
GLES and Vulkan, the clear colors seems to be getting piped through as
expected. But the frame captures reveal that they're actually not.
 2023-05-03 17:16:38 -07:00
skia-flutter-autoroll
f279d735e8 Roll Dart SDK from 3cfcfb24bc6a to 59787216f670 (2 revisions) (flutter/engine#41718) 
https://dart.googlesource.com/sdk.git/+log/3cfcfb24bc6a..59787216f670

2023-05-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-72.0.dev
2023-05-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-71.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,dart-vm-team@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-03 23:54:34 +00:00
godofredoc
7a1eeaffae Add relative path support for malioc_diff. (flutter/engine#41703) 
Relative paths are required for integrating this tool as a test in engine v2.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-03 23:45:30 +00:00
skia-flutter-autoroll
8b0230dcc5 Roll Fuchsia Mac SDK from WAfNudyWPOGyWSpZD... to LCajvqTauUudC-7RW... (flutter/engine#41716) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-03 22:49:15 +00:00
Tong Mu
a7c3f6162c [macOS] Remove view ID from public (flutter/engine#41712) 
This is a reland of https://github.com/flutter/engine/pull/39958, but
only contains the minimal changes that removes all references to viewId
from public interfaces, reverting these changes from
https://github.com/flutter/engine/pull/39576.

Flutter doesn't really support multi-view anyway. These methods
currently only works for view 0. We better remove them until we mark
multi-view stable. It was a mistake that I decided to add them to public
interfaces.

For the reason why https://github.com/flutter/engine/pull/39958 failed,
I'm pretty sure it's the change to
[platform_dispatcher.dart](https://github.com/flutter/engine/pull/39958/files#diff-57d6953e215d0e5dd7260ee60b665c812aa730566ef0b30f7ff1e3d661143585)
that mysteriously and unintentionally appeared in the change list.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-05-03 15:40:14 -07:00
Brandon DeRosier
579c8fe3d8 [Impeller] Load instead of restore drawing for non-MSAA passes (flutter/engine#41676) 
This is essentially a revert of
https://github.com/flutter/engine/pull/41060 with better comments.
 2023-05-03 13:41:57 -07:00
Jonah Williams
dfff522046 Remove physical model layer (flutter/engine#41593) 
Removes the physical model layer and associated engine code. This was already deprecated and removed in the framework. By removing it in the engine, we can also remove the need for layer tree diff/paint/preroll to have the device pixel ratio. This will simplify some of the multi-view work

Fixes https://github.com/flutter/flutter/issues/125720
 2023-05-03 20:28:53 +00:00
Greg Spencer
18125adcfc Reland: "Determine lifecycle by looking at window focus also" (#41094) (flutter/engine#41702) 
## Description

This reverts commit e49577708d9d5315fa6c001d7dc20ee80d04cd35 to re-land #41094 because the Google test failures have been fixed. There are no changes to the original PR, since the fixes were in the Google code.
 2023-05-03 19:21:58 +00:00
skia-flutter-autoroll
a2b6651eeb Roll Skia from 887e58fff02f to 93c869da03f5 (12 revisions) (flutter/engine#41705) 
https://skia.googlesource.com/skia.git/+log/887e58fff02f..93c869da03f5

2023-05-03 kjlubick@google.com Move SkImageGenerator::MakeFromEncoded to private
2023-05-03 herb@google.com Take const ref in is(Right|Left)Of
2023-05-03 michaelludwig@google.com [skif] Add applyColorFilter to FilterResult
2023-05-03 johnstiles@google.com Add golden-output test for to/fromLinearSrgb.
2023-05-03 nicolettep@google.com [graphite] Make ResourceProvider's resource cache protected instead of private
2023-05-03 nicolettep@google.com [graphite] Add VulkanDescriptorPool, VulkanDescriptorSet classes
2023-05-03 johnstiles@google.com Add single-slot immediate min/max ops.
2023-05-03 jamesgk@google.com [graphite] Don't track snippet req flags on gatherer
2023-05-03 herb@google.com Handle more cases for sk_doubles_nearly_equal_ulps
2023-05-03 johnstiles@google.com Fix fuzzer-discovered error with repeated assignment.
2023-05-03 kjlubick@google.com Manually Roll Dawn from 22f70bb09892 to 2966d3ad08eb (35 revisions)
2023-05-03 kjlubick@google.com Fix typos in public.bzl

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-03 18:51:03 +00:00
Mouad Debbar
9ed3f6008e [web] Improve null safety for color->css (flutter/engine#41699) 
Turning `colorToCssString` into an extension method on `ui.Color` improves null safety and developer ergonomics.
 2023-05-03 18:15:04 +00:00
Mouad Debbar
9cb01b94d5 [web] Remove unused function parameter (flutter/engine#41700) 
The `hasAutofillOverlay` and `cssSelectorPrefix` parameters aren't really used in any useful way. Let's remove them.
 2023-05-03 17:57:21 +00:00
godofredoc
70a249203a Migrate Android Engine Debug to Engine V2. (flutter/engine#41687) 
Legacy and engine v2 builds artifacts are identical. This PR is moving the legacy build to staging and starts uploading engine v2 artifacts to production.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-03 17:19:04 +00:00
Kevin Lubick
e05e7a8552 Migrate SkSurface::getBackend* methods to static functions (flutter/engine#41693) 
In https://skia-review.googlesource.com/c/skia/+/687642, Skia moved some
gpu-related methods on SkSurface to be static functions in a different
header. This updates those callsites in Flutter.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-05-03 09:03:39 -07:00
skia-flutter-autoroll
8791badd5f Roll Dart SDK from 342dff83c38e to 3cfcfb24bc6a (1 revision) (flutter/engine#41698) 
https://dart.googlesource.com/sdk.git/+log/342dff83c38e..3cfcfb24bc6a

2023-05-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-70.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,dart-vm-team@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-03 15:58:52 +00:00
joshualitt
e370809b5e [web] Add dart:js_interop_unsafe to SDK. (flutter/engine#41591) 
Adds the `dart:js_interop_unsafe` library to the SDK.
 2023-05-03 08:38:33 -07:00
skia-flutter-autoroll
f2e169131e Roll Fuchsia Linux SDK from 9T4mGpfsJZO0KPtfp... to n1UnzmslAzt04yRv6... (flutter/engine#41697) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-03 14:54:05 +00:00