Jason Simmons
faf78247cb
Fix CkBrowserImageDecoder conversion of images to ImageByteFormat.rawRgba and rawStraightRgba ( flutter/engine#52089 )
...
VideoFrames of decoded images typically contain BGRA format. The CkBrowserImageDecoder implementation of toByteData needs to convert that into RGBA format. If the output format is rawRgba then it also needs to apply premultipled alpha.
Also fixes an issue where _bgrToRgba was not converting all pixels in the image.
Fixes https://github.com/flutter/flutter/issues/135409
Fixes https://github.com/flutter/flutter/issues/144770
2024-04-17 21:44:47 +00:00
skia-flutter-autoroll
e9c8bbee6c
Roll Skia from a78dec0c0538 to 5958cd52db48 (2 revisions) ( flutter/engine#52206 )
...
https://skia.googlesource.com/skia.git/+log/a78dec0c0538..5958cd52db48
2024-04-17 johnstiles@google.com Update format strings to take signedness into account.
2024-04-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 6bcdc072b044 to 6066c0d57a8b (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-17 21:30:05 +00:00
Robert Ancell
2ba71d60e9
Fix incorrect function name in documentation ( flutter/engine#52184 )
2024-04-18 09:23:21 +12:00
skia-flutter-autoroll
4d35fda4c8
Roll Skia from 0c56bd472923 to a78dec0c0538 (4 revisions) ( flutter/engine#52205 )
...
https://skia.googlesource.com/skia.git/+log/0c56bd472923..a78dec0c0538
2024-04-17 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Skia Infra from 61056bfd26b3 to 758eb2157020 (9 revisions)
2024-04-17 brianosman@google.com Add chaining capability to SkPath offset and transform
2024-04-17 jamesgk@google.com Move some Ganesh circle blur code to gpu/
2024-04-17 johnstiles@google.com Initialize more fields in VulkanBackendContext.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-17 20:31:08 +00:00
Brandon DeRosier
03328509fe
[Impeller] Delete EntityPass::AddSubpassInline. ( flutter/engine#52182 )
...
This is dead code now that we don't handle pictures with Aiks.
2024-04-17 19:54:07 +00:00
skia-flutter-autoroll
7419220286
Roll Skia from 2790777048d3 to 0c56bd472923 (4 revisions) ( flutter/engine#52203 )
...
https://skia.googlesource.com/skia.git/+log/2790777048d3..0c56bd472923
2024-04-17 michaelludwig@google.com [graphite] Combine YUVA and regular promise image callbacks
2024-04-17 jcgregorio@google.com Remove all Mac 10.13 and 10.14 jobs.
2024-04-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 9727f56830b9 to cfb2d3940fbd
2024-04-17 michaelludwig@google.com Discard data written to a null BufferWriter
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-17 19:29:03 +00:00
Matej Knopp
e016cf4d04
[macOS] Handle interleaved movement and gesture events ( flutter/engine#52201 )
...
Fixes https://github.com/flutter/flutter/issues/146893
The crash happens, because with magic mouse, it is quite common to
receive `mouseExited:` event while the gesture event is still in
progress. This would reset the gesture state while the gesture event is
still active, leading to assertion when the gesture event ends.
The state machine assumes that when mouse exists that also ends any
gesture events. However that is not the case with magic mouse, which
handles the movement and gesture events separately.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-04-17 21:25:18 +02:00
Brandon DeRosier
00b651e46a
[Impeller] Remove old clip height tracking from Entity. ( flutter/engine#52178 )
...
And rename clip depth accessors and members.
After this, I'm going to attempt to remove the need for tracking clip
height altogether in EntityPass as well.
2024-04-17 11:46:30 -07:00
Gray Mackall
49b9556e68
Replace LinkedLists that are used as a queue in android FlutterRenderer with ArrayDeques ( flutter/engine#51494 )
...
Inspired by https://github.com/flutter/engine/pull/50767 .
[As their documentation notes](https://docs.oracle.com/javase/8/docs/api/java/util/ArrayDeque.html ), `ArrayDeque`s are generally faster than LinkedList when used as a queue.
Fixes https://github.com/flutter/flutter/issues/143721
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-04-17 18:43:57 +00:00
Brandon DeRosier
df1248e088
[Impeller] Use booleans instead of counting backdrop reads. ( flutter/engine#52181 )
...
We don't need to track the actual number of reads anymore now that clips
are replayed (since we no longer ever store the stencil or depth
buffers).
Also, we don't need to pass this into `InlinePassContext` anymore.
2024-04-17 11:43:17 -07:00
bungeman
5c2ff391b5
Update Skia's BUILD.gn ( flutter/engine#52194 )
...
Remove references to `SkFontMgr_indirect` and `SkFontMgrRemotable`.
These are not used by Flutter and Skia is removing them.
2024-04-17 13:48:09 -04:00
Alexander Markov
4b268e1ac8
Cleanup obsolete Dart VM flags ( flutter/engine#52197 )
...
Remove obsolete Dart VM flags from the lists of allowed Dart VM flags in
the engine.
2024-04-17 10:18:19 -07:00
skia-flutter-autoroll
f6936d2baf
Roll Skia from 4b3b84c0beeb to 2790777048d3 (3 revisions) ( flutter/engine#52198 )
...
https://skia.googlesource.com/skia.git/+log/4b3b84c0beeb..2790777048d3
2024-04-17 bungeman@google.com Update documented minimum supported OSes
2024-04-17 borenet@google.com [recreate-skps] Sync depot_tools to most recent commit
2024-04-17 brianosman@google.com Remove unused constant from SkPathRef
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-17 17:08:19 +00:00
Yegor
2affc5230f
[web] move AccessibilityAnnouncements into SemanticsOwner ( flutter/engine#52138 )
...
Move `AccessibilityAnnouncements` into `SemanticsOwner`, effectively making it a singleton (because `SemanticsOwner` is).
Fixes https://github.com/flutter/flutter/issues/139272
2024-04-17 16:49:07 +00:00
Loïc Sharma
e1b38345d3
[Windows] Add/remove view failures should not hang ( flutter/engine#52164 )
...
If the embedder API's `FlutterEngineAddView` and `FlutterEngineRemoveView` don't return `kSuccess`, their callbacks won't be invoked. See: [flutter.dev/go/multi-view-embedder-apis](https://flutter.dev/go/multi-view-embedder-apis ).
Previously, the Windows embedder would hang in this scenario as it blocks until the callbacks are invoked. Now, the Windows embedder only blocks if these embedder APIs return `kSuccess`.
Kudos to @dkwingsmt for catching this!
Part of https://github.com/flutter/flutter/issues/144810
Part of https://github.com/flutter/flutter/issues/142845
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-04-17 16:44:28 +00:00
gaaclarke
e22b8448cb
[Impeller] added static check that fragment shader and vertex shaders slots match ( flutter/engine#52174 )
...
fixes https://github.com/flutter/flutter/issues/146452
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-04-17 08:18:40 -07:00
Matej Knopp
4eb6676253
[macOS] FlutterSurfaceManager should not return surfaces that are in use ( flutter/engine#52082 )
...
Fixes https://github.com/flutter/flutter/issues/138936
Currently the engine hold a single backbuffer per flutter view layer,
which gets swapped with front buffer. This however is too optimistic, as
the front buffer in some cases might not get immediately picked up by
the compositor. When that happens, during next frame the cache may
return a backbuffer that is in fact still being used by the compositor.
Rendering to such surface will result in artifacts seen in the video.
This seems more likely to happen with busy platform thread. It is also
more likely to happen with the presence of "heavy" platform views such
as `WKWebView`.
IOSurface is able to report when it is being used by the compositor
(`IOSurfaceIsInUse`). This PR ensures that the backing store cache never
returns surface that is being used by compositor. This may result in
transiently keeping more surfaces than before, as the compositor
sometimes seems to holds on to the surface longer than it is displayed,
but that's preferable outcome to visual glitches.
This PR adds `age` field to `FlutterSurface`. When returning buffers to
the surface cache (during compositor commit), the age of each surface
currently present in cache increases by one, while the newly returned
surfaces have their age set to 0.
When returning surfaces from cache, a surface with lowest age that is
not in use by compositor is returned.
Surfaces with age that reaches 30 are evicted from the pool. Reaching
this age means one of two things:
- When surface is still in use at age 30 it means the compositor is
holding on to it much longer than we expect. In this case just forget
about the surface, we can't really do anything about it.
- When surface is not in use at age 30, it means it hasn't been removed
from cache for 29 subsequent frames. That means the cache is holding more
surfaces than needed.
Removing all surfaces from cache after idle period remains unchanged.
Before:
https://github.com/flutter/engine/assets/96958/ba2bfc43-525e-4a88-b37c-61842994d3bc
After:
https://github.com/flutter/engine/assets/96958/8b5d393e-3031-46b1-b3f0-cb7f63f8d960
*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-04-17 15:22:20 +02:00
Matej Knopp
0dc6ed3af1
[macOS] FlutterView should not override platform view cursor ( flutter/engine#52159 )
...
This fixes an edge case that I've overlooked in
https://github.com/flutter/engine/pull/43101 .
It is possible to configure `FlutterViewController` tracking area with
`FlutterMouseTrackingModeAlways` option, in which case the tracking area
will call `[FlutterView cursorUpdate:]` unconditionally even if the
mouse cursor is over platform view and the platform view has already
handled the mouse update.
The solution is to prevent the `FlutterView` from updating the cursor
when the cursor is over a platform view. This can be accomplished by
doing a hitTest inside `[FlutterView cursorUpdate:]`.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-04-17 15:17:53 +02:00
Matej Knopp
ef0bc66c15
[macOS] Handle reparenting platform views ( flutter/engine#52152 )
...
Fixes https://github.com/flutter/flutter/issues/146810
This handles situation where the platform view reparents and replaces
itself with a placeholder view. This commonly happens with WKWebView
entering full screen.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-04-17 13:05:38 +02:00
skia-flutter-autoroll
1e6cdf37bd
Roll Skia from f404603cc9e7 to 2b32391252f3 (1 revision) ( flutter/engine#52189 )
...
https://skia.googlesource.com/skia.git/+log/f404603cc9e7..2b32391252f3
2024-04-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 80097301710b to 61056bfd26b3 (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-17 06:28:22 +00:00
skia-flutter-autoroll
24c7e6ea3b
Roll Skia from e6e9044ee10d to d9688b02def5 (1 revision) ( flutter/engine#52186 )
...
https://skia.googlesource.com/skia.git/+log/e6e9044ee10d..d9688b02def5
2024-04-17 bungeman@google.com Remove SkFontMgr_New_DirectWriteRenderer impl
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-17 04:12:05 +00:00
skia-flutter-autoroll
6227f86fb8
Roll Skia from e335a0a11aa0 to e6e9044ee10d (1 revision) ( flutter/engine#52183 )
...
https://skia.googlesource.com/skia.git/+log/e335a0a11aa0..e6e9044ee10d
2024-04-17 brianosman@google.com Rearrange fields to shrink SkPathRef
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-17 03:08:56 +00:00
skia-flutter-autoroll
1a11706168
Roll Dart SDK from 57d7cba5bc3d to 04e9eeaa7c78 (1 revision) ( flutter/engine#52179 )
...
https://dart.googlesource.com/sdk.git/+log/57d7cba5bc3d..04e9eeaa7c78
2024-04-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-68.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-17 00:13:01 +00:00
Jenn Magder
63e75efc51
Migrate FlutterChannelKeyResponder and FlutterSpellCheckPlugin to ARC ( flutter/engine#52148 )
...
Clean up headers in FlutterChannelKeyResponder and FlutterSpellCheckPlugin. Migrate to ARC.
Move `FlutterSpellCheckResult` interface into the .mm since it's only used there.
Part of https://github.com/flutter/flutter/issues/137801 .
Blocked by https://github.com/flutter/engine/pull/51633 `FlutterUIPressProxy`
2024-04-16 23:50:14 +00:00
auto-submit[bot]
e3a20e4fb6
Reverts "[Impeller] remove most temporary allocation during polyline generation. ( #52131 )" ( flutter/engine#52177 )
...
Reverts: flutter/engine#52131
Initiated by: jonahwilliams
Reason for reverting: breaking flutter logo rendering
Original PR Author: jonahwilliams
Reviewed By: {chinmaygarde}
This change reverts the following previous change:
Part of https://github.com/flutter/flutter/issues/143077
Only allocate into reused arenas instead of allocating a new vector of data. Fixes https://github.com/flutter/flutter/issues/133348
Also moves tessellation logic into the c/tessellator and out of the impeller tessellator. This was necessary to fix a compilation error. introduced by including host_buffer -> allocator -> fml mapping -> window.h include which has a function definition that conflicts with the c tessellator definition.
2024-04-16 22:55:47 +00:00
skia-flutter-autoroll
ba91beb2e8
Roll Skia from d506a3d526f7 to b83b6bf7174f (2 revisions) ( flutter/engine#52173 )
...
https://skia.googlesource.com/skia.git/+log/d506a3d526f7..b83b6bf7174f
2024-04-16 tangm@microsoft.com Address null colorSpace in PDF Device
2024-04-16 michaelludwig@google.com [graphite] Restructure tracked device cleanup in case its called multiple times
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-16 22:10:53 +00:00
Jenn Magder
05201a8018
Migrate FlutterUIPressProxy, ios_context*, rendering_api_selection, and a few other files to ARC ( flutter/engine#51633 )
...
Smart pointers support ARC as of https://github.com/flutter/engine/pull/47612 , and the unit tests were migrated in https://github.com/flutter/engine/pull/48162 .
Migrate some files from MRC to ARC. These files do not themselves import any MRC files, only ARC-ified files like `FlutterMetalLayer.h`, making them leaf nodes in the dependency graph of MRC files. Just doing a few at a time to make the dependency graph manageable, and to easily revert if this causes retain cycles or other memory management issues.
Part of https://github.com/flutter/flutter/issues/137801 .
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-04-16 21:45:50 +00:00
skia-flutter-autoroll
0972552b3a
Roll Skia from 98dbba281a84 to d506a3d526f7 (2 revisions) ( flutter/engine#52170 )
...
https://skia.googlesource.com/skia.git/+log/98dbba281a84..d506a3d526f7
2024-04-16 jzern@google.com update to libwebp 1.4.0
2024-04-16 johnstiles@google.com Move SkASAN.h to include/private/base.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-16 21:16:03 +00:00
skia-flutter-autoroll
1de3ea26ad
Roll Dart SDK from f2464b2892a1 to 57d7cba5bc3d (1 revision) ( flutter/engine#52168 )
...
https://dart.googlesource.com/sdk.git/+log/f2464b2892a1..57d7cba5bc3d
2024-04-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-67.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-16 20:13:05 +00:00
skia-flutter-autoroll
49e7ab6ba9
Roll Skia from 300741074b41 to 98dbba281a84 (11 revisions) ( flutter/engine#52167 )
...
https://skia.googlesource.com/skia.git/+log/300741074b41..98dbba281a84
2024-04-16 robertphillips@google.com [graphite] Add ImageFilter precompilation to PaintParamsKeyTest
2024-04-16 jsimmons@google.com In the Fuchsia font manager, add the style parameter that is now required by SkFontScanner_FreeType::computeAxisValues
2024-04-16 bungeman@google.com Allow old CoreText to return wrong style
2024-04-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from ea0fb515f594 to 8dc5cb57074c (2 revisions)
2024-04-16 michaelludwig@google.com [graphite] Impl. public image API in Image_Base via copies
2024-04-16 michaelludwig@google.com [graphite] Add PaintParamsKey to pipeline labels and traces
2024-04-16 tangm@microsoft.com Add SkColorSpace to SaveLayerRec
2024-04-16 bungeman@google.com Test variable font style
2024-04-16 bungeman@google.com DirectWrite to vary font style with variation
2024-04-16 bungeman@google.com FreeType to vary font style with variation
2024-04-16 robertphillips@google.com [graphite] Add minimal API to specify precompilation ImageFilters
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-16 20:11:25 +00:00
gaaclarke
ed0a9bd410
[Impeller] removes advanced plus blending ( flutter/engine#52163 )
...
Now that https://github.com/flutter/engine/pull/52019 has landed, we
shouldn't need it anymore.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-04-16 12:33:21 -07:00
Jonah Williams
e572ff5c6f
[Impeller] remove most temporary allocation during polyline generation. ( flutter/engine#52131 )
...
Part of https://github.com/flutter/flutter/issues/143077
Only allocate into reused arenas instead of allocating a new vector of data. Fixes https://github.com/flutter/flutter/issues/133348
Also moves tessellation logic into the c/tessellator and out of the impeller tessellator. This was necessary to fix a compilation error. introduced by including host_buffer -> allocator -> fml mapping -> window.h include which has a function definition that conflicts with the c tessellator definition.
2024-04-16 18:48:47 +00:00
Jason Simmons
50771f3ad4
Roll reclient, libpng, and zlib ( flutter/engine#52072 )
...
Based on https://github.com/flutter/engine/pull/52067
2024-04-16 18:31:30 +00:00
Jenn Magder
cd1aa8d667
Only print "gclient sync" warning once during rebase ( flutter/engine#52133 )
...
Skip the "pre-rebase" message since it will also be printed "post-checkout" at the end.
Fixes https://github.com/flutter/flutter/issues/146781
Before this PR:
On this PR it's only printed once
Fixes https://github.com/flutter/flutter/issues/146781
2024-04-16 18:03:20 +00:00
skia-flutter-autoroll
b23c0faf70
Roll Dart SDK from 99928bb7e8a4 to f2464b2892a1 (1 revision) ( flutter/engine#52157 )
...
https://dart.googlesource.com/sdk.git/+log/99928bb7e8a4..f2464b2892a1
2024-04-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-66.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-16 16:09:25 +00:00
skia-flutter-autoroll
f020164efa
Roll Skia from 50ac1117f159 to 8013b7f1dcd3 (5 revisions) ( flutter/engine#52149 )
...
https://skia.googlesource.com/skia.git/+log/50ac1117f159..8013b7f1dcd3
2024-04-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from f20a53466bc2 to 4cb74f447cb7 (21 revisions)
2024-04-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from ec0c320a8ca1 to ea0fb515f594 (8 revisions)
2024-04-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from f184d1bfa242 to 80097301710b (6 revisions)
2024-04-16 sharaks@google.com Merge 8 release notes into RELEASE_NOTES.md
2024-04-16 sharaks@google.com Update Skia milestone to 126
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-16 06:54:27 +00:00
dependabot[bot]
0cca5f3822
Bump google/osv-scanner-action from 1.6.2.pre.beta1 to 1.7.1 ( flutter/engine#52147 )
...
Bumps [google/osv-scanner-action](https://github.com/google/osv-scanner-action ) from 1.6.2.pre.beta1 to 1.7.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/google/osv-scanner-action/releases ">google/osv-scanner-action's releases</a>.</em></p>
<blockquote>
<h2>v1.7.1</h2>
<p>First full release of osv-scanner, currently using v1.7.1 of osv-scanner. See <a href="https://github.com/google/osv-scanner-action/blob/main/README.md ">README.md</a> or <a href="https://google.github.io/osv-scanner/github-action/ ">documentation</a> for usage instructions.</p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="1f1242919dhttps://redirect.github.com/google/osv-scanner-action/issues/4 ">#4</a> from google/update-to-v1.7.1</li>
<li><a href="5c2a8dd5cec94002860chttps://redirect.github.com/google/osv-scanner-action/issues/3 ">#3</a> from google/update-to-v.1.7.0</li>
<li><a href="604d5422a4d878ed5134fcd6c0a9e3https://github.com/google/osv-scanner-action/compare/v1.6.2-beta1...v1.7.1 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-04-16 06:10:14 +00:00
Jenn Magder
5f95d3b108
Migrate vsync_waiter_ios to ARC ( flutter/engine#52104 )
...
Smart pointers support ARC as of https://github.com/flutter/engine/pull/47612 , and the unit tests were migrated in https://github.com/flutter/engine/pull/48162 .
Migrate `vsync_waiter_ios` from MRC to ARC.
Part of https://github.com/flutter/flutter/issues/137801 .
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-04-16 06:01:08 +00:00
skia-flutter-autoroll
7037278acc
Roll Dart SDK from 5f03197b9992 to 7d02f18b8a84 (2 revisions) ( flutter/engine#52145 )
...
https://dart.googlesource.com/sdk.git/+log/5f03197b9992..7d02f18b8a84
2024-04-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-63.0.dev
2024-04-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-62.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-16 04:04:30 +00:00
gaaclarke
e359708723
Relands "[Impeller] moved to bgra10_xr ( #52019 )" ( flutter/engine#52142 )
...
relands https://github.com/flutter/engine/pull/52019
Patch addresses the compilation problem noted in https://github.com/flutter/engine/pull/52019#issuecomment-2058006113
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-04-16 00:59:09 +00:00
skia-flutter-autoroll
a670454a01
Roll Skia from f6a2a2af83f1 to b159229f2174 (1 revision) ( flutter/engine#52143 )
...
https://skia.googlesource.com/skia.git/+log/f6a2a2af83f1..b159229f2174
2024-04-15 kjlubick@google.com Remove old, private SkMultiPictureDocument
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-16 00:59:07 +00:00
Chinmay Garde
7f416b5b79
[Impeller] Update the readme to reflect current guidance on how to try Impeller. ( flutter/engine#52135 )
2024-04-16 00:10:05 +00:00
Jonah Williams
9c212d5d0d
[iOS] allow enabling asserts from Plist. ( flutter/engine#52069 )
...
Part of https://github.com/flutter/flutter/issues/145729 .
I don't believe (or wasn't able to find ) if there is a way to specify dart-vm flags from an iOS application. Once its installed, the tool provided process args won't work. By allowing this to be specified in the Plist, developers can ensure the value persists for subsequent launches.
2024-04-16 00:06:05 +00:00
skia-flutter-autoroll
d3232cba08
Roll Dart SDK from 3c2376cb9850 to 5f03197b9992 (5 revisions) ( flutter/engine#52134 )
...
https://dart.googlesource.com/sdk.git/+log/3c2376cb9850..5f03197b9992
2024-04-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-61.0.dev
2024-04-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-60.0.dev
2024-04-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-59.0.dev
2024-04-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-58.0.dev
2024-04-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-57.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-16 00:00:00 +00:00
skia-flutter-autoroll
c3edd7201c
Roll Skia from 0b5df0201734 to f6a2a2af83f1 (2 revisions) ( flutter/engine#52136 )
...
https://skia.googlesource.com/skia.git/+log/0b5df0201734..f6a2a2af83f1
2024-04-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 934b734ed72a to 9478a634ff6d (1 revision)
2024-04-15 fmalita@google.com [skottie] Text preshape experiment
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-15 23:59:57 +00:00
Jenn Magder
2d3cce14a1
Migrate FlutterDartVMServicePublisher to ARC ( flutter/engine#52081 )
...
Smart pointers support ARC as of https://github.com/flutter/engine/pull/47612 , and the unit tests were migrated in https://github.com/flutter/engine/pull/48162 .
Migrate `FlutterDartVMServicePublisher` from MRC to ARC. I validated `flutter attach` works on this engine PR, so the VM service URL is being advertised and the tool is discovering it.
Part of https://github.com/flutter/flutter/issues/137801 .
2024-04-15 23:55:27 +00:00
auto-submit[bot]
b4bad7f256
Reverts "[Impeller] moved to bgra10_xr ( #52019 )" ( flutter/engine#52140 )
...
Reverts: flutter/engine#52019
Initiated by: jonahwilliams
Reason for reverting: I believe the tree failures are due to changes in the build configuration this file introduced.
Original PR Author: gaaclarke
Reviewed By: {jonahwilliams}
This change reverts the following previous change:
fixes https://github.com/flutter/flutter/issues/145933
This required that we moved the golden image tests to arm64 since the wide gamut tests would now require BGRA10_XR and that's only available to arm64.
tests: in framework repo https://github.com/flutter/flutter/tree/master/dev/integration_tests/wide_gamut_test . There was a test added to that suite specifically for this case when we turned off BGRA10_XR the first time.
This has a dependency on https://github.com/flutter/engine/pull/51998 which includes the necessary skia change.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-04-15 22:50:46 +00:00
skia-flutter-autoroll
e27ec99b0c
Roll Skia from 0fe107da5a4e to d27e288efd54 (6 revisions) ( flutter/engine#52130 )
...
https://skia.googlesource.com/skia.git/+log/0fe107da5a4e..d27e288efd54
2024-04-15 egdaniel@google.com Be more consistent in nanobench across Ganesh and Graphite.
2024-04-15 michaelludwig@google.com Update libwebp version to match chromium's
2024-04-15 jcgregorio@google.com Revert "Roll ANGLE from 66bc9cfa0014 to 9bae58594634 (4 revisions)"
2024-04-15 kjlubick@google.com Fail SkParagraph GMs gracefully when unicode fails to be created
2024-04-15 jcgregorio@google.com Remove Test-Win10-Clang-RUBYR5-GPU-RadeonVega6-x86_64-Release-All-Direct3D from the tree for now.
2024-04-15 jamesgk@google.com [graphite] Analytic blur for rects
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-15 19:53:20 +00:00
gaaclarke
47ad73b01c
[Impeller] moved to bgra10_xr ( flutter/engine#52019 )
...
fixes https://github.com/flutter/flutter/issues/145933
This required that we moved the golden image tests to arm64 since the wide gamut tests would now require BGRA10_XR and that's only available to arm64.
tests: in framework repo https://github.com/flutter/flutter/tree/master/dev/integration_tests/wide_gamut_test . There was a test added to that suite specifically for this case when we turned off BGRA10_XR the first time.
This has a dependency on https://github.com/flutter/engine/pull/51998 which includes the necessary skia change.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-04-15 18:03:51 +00:00
skia-flutter-autoroll
6f2a94ded6
Roll Skia from 9e20a146c024 to 0fe107da5a4e (33 revisions) ( flutter/engine#52129 )
...
Roll Skia from 9e20a146c024 to 0fe107da5a4e (33 revisions)
https://skia.googlesource.com/skia.git/+log/9e20a146c024..0fe107da5a4e
2024-04-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 04aa78e8dbcb to ec0c320a8ca1 (2 revisions)
2024-04-15 brianosman@google.com Simplify special path type tracking
2024-04-15 jvanverth@google.com Revert "Add GN variable to disable iOS signing"
2024-04-15 kjlubick@google.com fix guard for skunicode
2024-04-15 robertphillips@google.com [graphite] Calve off PrecompileCombinations into its own helper
2024-04-15 kjlubick@google.com Expose the getClientICUData() to ParagraphBuilder
2024-04-15 bungeman@google.com Add job to test with checked-in FreeType
2024-04-15 kjlubick@google.com Fix up mac-related modules
2024-04-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from f184d1bfa242 to 80e2cdd73b81
2024-04-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from bae2b98850ac to f184d1bfa242 (7 revisions)
2024-04-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 0e14373fbbeb to f20a53466bc2 (10 revisions)
2024-04-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 5171f7f9892a to 04aa78e8dbcb (1 revision)
2024-04-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 46248e60c4fa to 5171f7f9892a (1 revision)
2024-04-13 jcgregorio@google.com Revert "Temporarily remove iOS bots from CQ."
2024-04-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 7922b393e32b to 46248e60c4fa (2 revisions)
2024-04-13 michaelludwig@google.com [graphite] Add Image::Copy to handle both blit and draw copies
2024-04-13 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll ANGLE from e41286e1092c to 5e790bfb16e8 (6 revisions)
2024-04-12 jvanverth@google.com [graphite] Move DrawAtlasMgr to PathAtlas.
2024-04-12 michaelludwig@google.com [graphite] Add CopyAsDraw helper to Image_Base
2024-04-12 michaelludwig@google.com [graphite] Add Device::isScratchDevice() helper
2024-04-12 michaelludwig@google.com [graphite] Add validation asserts to Device/Recorder flushing
2024-04-12 michaelludwig@google.com Reland "[graphite] Start with kDiscard load op in DrawContext; use clear op for floating-point textures"
2024-04-12 michaelludwig@google.com [graphite] Remove unique ID from Image[_YUVA] ctor, rename MakeView
2024-04-12 jvanverth@google.com Add GN variable to disable iOS signing
2024-04-12 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from a79a81394ea6 to 0e14373fbbeb (26 revisions)
2024-04-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f8fa42b1fbea to 7922b393e32b (10 revisions)
2024-04-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from cf3b51b7e14e to c150177839d1
2024-04-12 ccameron@chromium.org SkICC: Improve tonemapping precision
2024-04-12 fmalita@google.com [skottie wasm] Fix inline font decoding
2024-04-12 lehoangquyen@chromium.org Reland x2 "Graphite/Dawn: Eliminate Device::Tick() usages."
2024-04-12 kjlubick@google.com Remove SKCMS_REPLACE_IN_GOOGLE3_COMPATIBLE_WITH
2024-04-12 brianosman@google.com Another NaN guard in SkConic support code
2024-04-12 brianosman@google.com Guard against wild conics while stroking
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
...
2024-04-15 18:03:48 +00:00
