DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
85,653 Commits 882 Branches 1,069 Tags
Commit Graph

85653 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
engine-flutter-autoroll
fa56cbe2a1
Roll Packages from 092d83243c5f to fe661306f1da (4 revisions) (#174373) 
092d83243c...fe661306f1

2025-08-23 engine-flutter-autoroll@skia.org Roll Flutter from
26bb33b9572b to edd434af3e9d (14 revisions) (flutter/packages#9874)
2025-08-23 surajsinhrathod75@gmail.com [google_maps_flutter_web] Fix
consumeTapEvents for Circles, Polygons & Polylines (#173921)
(flutter/packages#9838)
2025-08-22 10687576+bparrishMines@users.noreply.github.com
[interactive_media_ads] Fixes Android IllegalStateException caused by
uninitalized `MediaPlayer` (flutter/packages#9861)
2025-08-22 engine-flutter-autoroll@skia.org Roll Flutter from
d2ac0210ee05 to 26bb33b9572b (20 revisions) (flutter/packages#9872)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-25 15:42:26 +00:00
engine-flutter-autoroll
ddfbad85dc
Roll Dart SDK from 4f9623f024ab to e283a9e88242 (8 revisions) (#174358) 
https://dart.googlesource.com/sdk.git/+log/4f9623f024ab..e283a9e88242

2025-08-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-135.0.dev
2025-08-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-134.0.dev
2025-08-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-133.0.dev
2025-08-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-132.0.dev
2025-08-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-131.0.dev
2025-08-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-130.0.dev
2025-08-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-129.0.dev
2025-08-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-128.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-25 10:32:31 +00:00
engine-flutter-autoroll
48d317c73e
Roll Skia from 3bcd0a1d8c48 to da724d312e65 (1 revision) (#174357) 
https://skia.googlesource.com/skia.git/+log/3bcd0a1d8c48..da724d312e65

2025-08-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from d0ba2fb9305a to 061a43c6b63f (13 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com,kjlubick@google.com,nicolettep@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-25 10:00:42 +00:00
engine-flutter-autoroll
eb56c010d5
Roll Skia from 8689a1169a32 to 3bcd0a1d8c48 (4 revisions) (#174353) 
https://skia.googlesource.com/skia.git/+log/8689a1169a32..3bcd0a1d8c48

2025-08-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from af771226e2ea to cdda346c7ce9 (7 revisions)
2025-08-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from ca735e09cecf to 36fbc53c546c (1 revision)
2025-08-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
debugger-app-base from 6943b399ac36 to 17223bbc481d
2025-08-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
skottie-base from d3e0a508e29c to af8d227d9756

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com,kjlubick@google.com,nicolettep@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-25 07:26:44 +00:00
engine-flutter-autoroll
9a459a4272
Roll Fuchsia Linux SDK from 21v1vYTYWmyEHu-eP... to UiY8gj468PZUj6QTm... (#174349) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jimgraham@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-25 04:57:28 +00:00
engine-flutter-autoroll
2a3f8dcc22
Roll Skia from 61169c1f6f7c to 8689a1169a32 (2 revisions) (#174343) 
https://skia.googlesource.com/skia.git/+log/61169c1f6f7c..8689a1169a32

2025-08-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 7ac7122db4db to ca735e09cecf (1 revision)
2025-08-24 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com
Update SKP version

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com,kjlubick@google.com,nicolettep@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-24 16:48:34 +00:00
engine-flutter-autoroll
3b6c0bff3e
Roll Fuchsia Linux SDK from XLSNQCsY1VkIthSjt... to 21v1vYTYWmyEHu-eP... (#174332) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jimgraham@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-24 03:03:26 +00:00
engine-flutter-autoroll
edd434af3e
Roll Skia from 6f710e0b38f7 to 61169c1f6f7c (1 revision) (#174325) 
https://skia.googlesource.com/skia.git/+log/6f710e0b38f7..61169c1f6f7c

2025-08-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from d74c51b56a14 to 7ac7122db4db (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC fmalita@google.com,jimgraham@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-23 09:38:27 +00:00
engine-flutter-autoroll
e64895f19c
Roll Fuchsia Linux SDK from Z-ZaFQ7jAqJ1OrIBf... to XLSNQCsY1VkIthSjt... (#174318) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jimgraham@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-23 00:59:27 +00:00
engine-flutter-autoroll
905a82f11a
Roll Skia from ebb6051e8bb1 to 6f710e0b38f7 (1 revision) (#174317) 
https://skia.googlesource.com/skia.git/+log/ebb6051e8bb1..6f710e0b38f7

2025-08-22
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC fmalita@google.com,jimgraham@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-23 00:43:37 +00:00
Harry Terkelsen
7d6d410dd3
[web] Expose rasterizers in Renderer (#174308) 
This is a small tweak to the Renderer API that exposes a `Rasterizer`
and a map of `View` to `ViewRasterizer` in the `Renderer`. The
`Renderer` handles creating and disposing the `ViewRasterizer`s in
response to `View`s being created and disposed.

This is a step towards https://github.com/flutter/flutter/issues/172311

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-08-22 23:50:24 +00:00
Hannah Jin
798ff5908e
Update some semantics flags updated to use enum (engine, framework, web) (#170696) 
issue: https://github.com/flutter/flutter/issues/166101,


new Updates :
Add new enum Tristate and CheckedState in  for 7 flags.
For CheckState, it used to use 3 bools (hasCheck, isChecked,
isCheckStateMixed) to represent check states, replace them with a
CheckState enum.
For other 6 flags, each has 2 bools (hasXXState and isXX), replace them
with a Tristate enum.

This will be a breaking changes to the SemanticsFlags class , which was
added in April in https://github.com/flutter/flutter/issues/166101 and
https://github.com/flutter/flutter/pull/167771 , will write a breaking
change doc for this PR




## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-08-22 22:38:17 +00:00
Ben Konyi
699f21a4fe
[ Tool ] Don't emit artifact downloading messages when --machine is provided (#174301) 
Fixes https://github.com/flutter/flutter/issues/154119
 2025-08-22 20:08:27 +00:00
engine-flutter-autoroll
5c23f4c7c3
Roll Skia from cb15e1452399 to ebb6051e8bb1 (5 revisions) (#174296) 
https://skia.googlesource.com/skia.git/+log/cb15e1452399..ebb6051e8bb1

2025-08-22 ccameron@google.com Revert "HDR v2: Change
SkNamedTransferFn::kHLG/kPQ to new version"
2025-08-22 fmalita@google.com Image shader + tiny scale GM
2025-08-22 bungeman@google.com Android NDK font manager variation cache
2025-08-22 bungeman@google.com FontMgr Android NDK automatic axes
2025-08-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 7e28c4c2f184 to d74c51b56a14 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC fmalita@google.com,jimgraham@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-22 20:02:58 +00:00
Matan Lurey
6c7d6429bd
_downloadArtifacts (Web SDK) uses content-aware hashing in post-submit (#174236) 
Towards https://github.com/flutter/flutter/issues/174225.

Will need to get cherry-picked into 3.35 and 3.36.
 2025-08-22 19:54:09 +00:00
Jackson Gardner
a24dbd551f
Refactor text and runtime effect to separate skia and impeller implementations. (#174219) 
This makes two refactors to the display list architecture:
* The concrete implementations of `DlRuntimeEffect` for skia and
impeller are separated, and the impeller implementation put into the
`impeller/display_list` target. This makes sure that a client can link
against the main `display_list` library without actually pulling in all
of impeller. (This is needed for
https://github.com/flutter/flutter/pull/172314)
* The `DrawTextBlob` and `DrawTextFrame` methods are consolidated into
one `DrawText` call, and that takes a `DlText` object. The `DlText`
object has two implementations, one for skia and one for impeller, and
the impeller one is moved into `impeller/display_list` for the same
reason mentioned above.
 2025-08-22 19:53:39 +00:00
engine-flutter-autoroll
62ea199650
Roll Packages from 58c02e056b92 to 092d83243c5f (4 revisions) (#174295) 
58c02e056b...092d83243c

2025-08-21 engine-flutter-autoroll@skia.org Roll Flutter from
960d1078f876 to d2ac0210ee05 (12 revisions) (flutter/packages#9866)
2025-08-21 jmccandless@google.com Handle automatic PopScope
(flutter/packages#9856)
2025-08-20 engine-flutter-autoroll@skia.org Manual roll Flutter from
e65380a22076 to 960d1078f876 (36 revisions) (flutter/packages#9862)
2025-08-20 10687576+bparrishMines@users.noreply.github.com
[interactive_media_ads] Updates ProxyApis to prepare to add support for
`AdEvent.ad` (flutter/packages#9785)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-22 18:39:10 +00:00
Ben Konyi
35eb77f9a1
[ Widget Preview ] Add support for DevTools configuration (#174272) 
Adds support for the `--devtools-server-address=<uri>` and `--devtools`
options.

Also fixes an issue where the VM service + DevTools connection
information was not printed to STDOUT for web devices.

Fixes https://github.com/flutter/flutter/issues/173617

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
 2025-08-22 17:27:51 +00:00
Valentin Vignal
f0f208deae
Migrate more files to WidgetStateProperty (#174268) 
Another batch of files migrated to use WidgetStateProperty

Follow up of https://github.com/flutter/flutter/pull/174176

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-08-22 17:23:53 +00:00
Ben Konyi
bdea526c66
[ Tool ] Ensure --dds-port=<port> is respected when targeting web devices (#174278) 
Fixes https://github.com/flutter/flutter/issues/159157
 2025-08-22 17:09:40 +00:00
Flutter GitHub Bot
73e39e964b
Marks Mac_ios ios_debug_workflow to be unflaky (#174104) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_ios ios_debug_workflow"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_ios%20ios_debug_workflow%22).
This test can be marked as unflaky.
 2025-08-22 17:02:12 +00:00
Gray Mackall
26bb33b957
[HCPP] Clean up overlay layer when last frame had overlay content and current doesn't (#173881) 
Fixes https://github.com/flutter/flutter/issues/173635

My current understanding of the issue is that we are never pushing a new
empty frame for this layer, so the texture gets stuck as shown in the
bug. If we keep track of when we had content last frame, and don't in
the current frame, we can push a single empty frame for that layer when
needed.

See example in
https://github.com/flutter/flutter/issues/173635#issuecomment-3192787040

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Gray Mackall <mackall@google.com>
 2025-08-22 16:39:11 +00:00
Valentin Vignal
7130981fe1
Migrate more files to use WidgetStateProperty (#174176) 
Follow up of https://github.com/flutter/flutter/pull/174109

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-08-22 12:18:43 +00:00
engine-flutter-autoroll
86281c3758
Roll Skia from 75fef9fb3ed7 to cb15e1452399 (1 revision) (#174255) 
https://skia.googlesource.com/skia.git/+log/75fef9fb3ed7..cb15e1452399

2025-08-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 995c4c4d89ed to d0ba2fb9305a (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC fmalita@google.com,jimgraham@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-22 10:02:24 +00:00
engine-flutter-autoroll
ac7a1f0e02
Roll Skia from 006241a7fbe1 to 75fef9fb3ed7 (1 revision) (#174254) 
https://skia.googlesource.com/skia.git/+log/006241a7fbe1..75fef9fb3ed7

2025-08-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 518c3165422f to af771226e2ea (18 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC fmalita@google.com,jimgraham@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-22 07:46:26 +00:00
Nate Biggs
2b82bc985b
Skip wasm build when dry run is disabled and --wasm is not specified. (#174184) 
This fixes an issue where the wasm build was still getting executed when
`--no-wasm-dry-run` was specified.

Also adds a test to verify the expected behavior.

Co-authored-by: Nate Biggs <natebiggs@google.com>
 2025-08-22 07:00:40 +00:00
engine-flutter-autoroll
d78cb7fa21
Roll Dart SDK from c153c5259e62 to 4f9623f024ab (2 revisions) (#174250) 
https://dart.googlesource.com/sdk.git/+log/c153c5259e62..4f9623f024ab

2025-08-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-127.0.dev
2025-08-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-126.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-22 05:19:22 +00:00
engine-flutter-autoroll
d9a597ea64
Roll Skia from d70087007490 to 006241a7fbe1 (2 revisions) (#174252) 
https://skia.googlesource.com/skia.git/+log/d70087007490..006241a7fbe1

2025-08-22
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-08-22
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC fmalita@google.com,jimgraham@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-22 05:17:27 +00:00
engine-flutter-autoroll
47b253fdeb
Roll Skia from c09589f7ca69 to d70087007490 (22 revisions) (#174245) 
https://skia.googlesource.com/skia.git/+log/c09589f7ca69..d70087007490

2025-08-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from db9c62a65630 to 7e28c4c2f184 (10 revisions)
2025-08-21 ccameron@chromium.org HDR v2: Change
SkNamedTransferFn::kHLG/kPQ to new version
2025-08-21 drafting@samizdat.co Fix SkOrderedFontMgr::onMatchFamily
2025-08-21
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-08-21 jmbetancourt@google.com [capture] record and collect SKPs in
the CaptureManager during capture
2025-08-21 alexandre_mutel@live.com Add support for configuring font
edging/hinting/subpixel to SkParagraph
2025-08-21 bungeman@google.com Update MODULE.bazel.lock
2025-08-21 bungeman@google.com Update cxx to 1.0.168
2025-08-21 bungeman@google.com Improve simple containers
2025-08-21 drott@chromium.org [Fontations] Roll Fontations
2025-08-21 fmalita@google.com Skip SurfaceBackendTextureTest on
protected contexts
2025-08-21
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-08-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 555275f0c242 to 518c3165422f (29 revisions)
2025-08-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 9d3db2fa8a2f to db9c62a65630 (2 revisions)
2025-08-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from dc24ecca9ed9 to 995c4c4d89ed (6 revisions)
2025-08-21
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-08-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from a1b94a283161 to 5b45bdb479fa (1 revision)
2025-08-21
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-08-21
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms
from 238fd0489c04 to c602c137fb05 (1 revision)
2025-08-20 syoussefi@google.com [vulkan] Add a way to disable
VK_EXT_graphics_pipeline_library
2025-08-20 michaelludwig@google.com [graphite] Add parentheses to
silence warning

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC fmalita@google.com,jimgraham@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-22 01:50:27 +00:00
Ben Konyi
9bf6e2661d
[ Widget Preview ] Add regression test for issue 173895 (#174037) 
Should have been included in
https://github.com/flutter/flutter/pull/173987

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
 2025-08-21 22:30:09 +00:00
Elijah Okoroh
45f8c327a5
Improve xcresult comment and naming (#173129) 
The function `_parseIssuesFromNewFormat` is renamed to
`_parseIssuesFromXcode16Format`. The term "new" is relative and would
become obsolete on the next format change, forcing a rename. The new
name is specific and stable.


Fixes #172596 

*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Jenn Magder <magder@google.com>
 2025-08-21 22:30:07 +00:00
Matan Lurey
f79602d6f9
Update .gemini/styleguide.md to encourage master-only (#174065) 
No idea if this will work.
 2025-08-21 22:26:03 +00:00
Ben Konyi
c3265413d5
[ Widget Preview ] Fix crash when attempting to provide non-const params to a Preview (#174242) 
Instead of crashing, invalid previews should just be ignored.

Fixes https://github.com/flutter/flutter/issues/173710
 2025-08-21 22:13:14 +00:00
engine-flutter-autoroll
8700465b52
Roll Skia from 721e68fe652a to c09589f7ca69 (12 revisions) (#174162) 
https://skia.googlesource.com/skia.git/+log/721e68fe652a..c09589f7ca69

2025-08-20 nicolettep@google.com Add instructions to trigger newly-added
tryjobs
2025-08-20
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 607fb6b15ab2 to 9d3db2fa8a2f (5 revisions)
2025-08-20 bungeman@google.com Properly handle value types in LRUCache
2025-08-20 syoussefi@google.com Skip ImageBackendTextureTest on
protected contexts
2025-08-20 fmalita@google.com [skcms] Update SHA to reflect actual
roller state
2025-08-20 thomsmit@google.com [graphite] Bubble up opacity in paint
params.
2025-08-20 syoussefi@google.com [graphite][vulkan] Enable skipped
BackendTextureTests
2025-08-20 michaelludwig@google.com [skif] Adjust overscaling logic for
periodic tiling
2025-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from ff95cc93afac to dc24ecca9ed9 (4 revisions)
2025-08-20
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-08-20
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC fmalita@google.com,jimgraham@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-21 22:13:13 +00:00
engine-flutter-autoroll
aeb2b12abd
Roll Dart SDK from 0d0a0c394381 to c153c5259e62 (7 revisions) (#174235) 
https://dart.googlesource.com/sdk.git/+log/0d0a0c394381..c153c5259e62

2025-08-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-125.0.dev
2025-08-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-124.0.dev
2025-08-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-123.0.dev
2025-08-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-122.0.dev
2025-08-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-121.0.dev
2025-08-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-120.0.dev
2025-08-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-119.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-21 22:09:36 +00:00
Ben Konyi
d88140fe5e
[ Tool ] Throw ToolExit when asset entries use absolute paths (#174230) 
Our documentation states that "the value of an asset is a relative path
from the pubspec.yaml file", but this was never actually verified by the
tool. On systems with POSIX semantics, this would simply result in
invalid asset paths being built, but on Windows this could cause an
exception to be thrown as the built URI would not be a valid `file://`
URI.

This change adds checks to ensure that asset paths are relative and that
they are valid file paths.

Fixes https://github.com/flutter/flutter/issues/173405
 2025-08-21 22:05:44 +00:00
engine-flutter-autoroll
6b12805b15
Roll Dart SDK from 0d0a0c394381 to c153c5259e62 (7 revisions) (#174227) 
https://dart.googlesource.com/sdk.git/+log/0d0a0c394381..c153c5259e62

2025-08-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-125.0.dev
2025-08-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-124.0.dev
2025-08-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-123.0.dev
2025-08-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-122.0.dev
2025-08-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-121.0.dev
2025-08-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-120.0.dev
2025-08-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-119.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-21 21:29:12 +00:00
Ben Konyi
19498462c7
[ Tool ] Cleanup widget preview and frontend server shutdown (#173863) 
Prevents the frontend server from throwing ToolExit with the "The Dart
compiler exited unexpectedly." on shutdown via a signal.
 2025-08-21 21:06:08 +00:00
Matan Lurey
e45fd36aac
Use an alternative to git describe for master version resolution (#174088) 
Closes https://github.com/flutter/flutter/issues/173904.

It's not clear to me how `git describe --tags HEAD` ever ... worked to
determine a fallback. From what I can tell, the _intent_ was to use the
latest (newest? closest?) tag as the base version, and then append
`-{commitCount}-{shortHash}` as the fallback version number when on
`master` (or any non-published branch).

So, I rewrote the implementation, unfortunately with 4 separate calls
out to `git ...` instead of a single one.

There are 20+ tests that fail as a result of this change, mostly because
they make specific expectations around `git describe` being invoked, and
of course that is no longer the case - putting those aside, I'd like to
double check that:

1. I understand what the original command was _intending_ to do
2. We like the _output_ of the updated command
3. ... we either are okay with the implementation, or have an
alternative in mind (I'm no `git` master)

Wdyt?

At this commit:
```sh
$ flutter-dev --version                                                            
Flutter 3.36.0-1.0.pre-170 • channel [user-branch] • https://github.com/matanlurey/flutter
Framework • revision 250381a185 (5 minutes ago) • 2025-08-19 18:57:36 -0700
Engine • hash f278b0aa3b8c6732ab636563eb8e896c35fc9c79 (revision 9ac4facf7e) (2 hours ago) • 2025-08-19 23:42:28.000Z
Tools • Dart 3.10.0 (build 3.10.0-115.0.dev) • DevTools 2.49.0
```

/cc @zanderso @jmagman for historics.
 2025-08-21 20:04:32 +00:00
Matthew Kosarek
4d4a69f14f
Report a correct display ID in the window metrics event on win32 (#174156) 
## What's new?
Now that we're sending down "true" display information to the framework,
we also need to send down the correct display id in the
WindowMetricsEvent for the view so that the display resolves properly.
This pull request adds that :)

## How to test
Here's a silly app that makes sure that our `Display` is legit:

```dart
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import 'package:flutter/widgets.dart';

void main() => runApp(W());

class W extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    final x = View.of(context);
    print(x.display.id);
    return const Center(
      child: Text('Hello, world!', key: Key('title'), textDirection: TextDirection.ltr),
    );
  }
}
```

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
 2025-08-21 18:38:06 +00:00
chunhtai
86327198ff
Revert "Update the AccessibilityPlugin::Announce method to account fo… (#174223) 
…r the view (#172669)"

This reverts commit e131243b0043f4f9944632acc734ea171c6b4105.

<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

pr causes internal breakage

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-08-21 16:52:46 +00:00
Mouad Debbar
d2ac0210ee
[web] Delete unused utils (#174160) 2025-08-21 15:13:09 +00:00
Tess Strickland
0c0148b00e
Directly generate a Mach-O dynamic library using gen_snapshot. (#171626) 
Instead of generating assembly code that is then compiled to a Mach-O
dynamic library, use the new app-aot-macho-dylib output option for
gen_snapshot to generate the Mach-O dynamic library without the assembly
step.

Related issues:

* https://github.com/dart-lang/sdk/issues/43299
* https://github.com/dart-lang/sdk/issues/60307

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
 2025-08-21 15:05:55 +00:00
Loïc Sharma
9330d4a716
Update the text input team's issue triage query (#173999) 
Before, we looked at all untriaged text input issues, regardless of
which team they’re assigned to.

Now, we look at all issues assigned to the text input team that have not
been triaged by the text input team yet.

### Motivation

The text input team missed July's triage process self-test:
https://github.com/flutter/flutter/issues/171486.

The previous triage query was incompatible with issues that are assigned
to another team. For example, an issue that is assigned to multiple
teams (https://github.com/flutter/flutter/issues/171486) or
`fyi-text-input` issues that another team marked as triaged.
 2025-08-21 14:59:09 +00:00
engine-flutter-autoroll
6ddbb81a22
Roll Fuchsia Linux SDK from V1A1J6uXZ62Q10i9u... to Z-ZaFQ7jAqJ1OrIBf... (#174170) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jimgraham@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-21 14:55:43 +00:00
John "codefu" McDole
38db233f4f
whitespace (#174210) 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

*Replace this paragraph with a description of what this PR is changing
or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*

*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-08-21 13:42:39 +00:00
Jenn Magder
91bc77d790
Add review agent style guidelines to .gemini/styleguide.md (#174000) 
A copy of @stuartmorgan-g change at
https://github.com/flutter/packages/pull/9805

> Initial attempt at adding guidance for GCAfGH to try cut down on the
behavior observed so far that it:
> - Almost always includes generic praise for the PR, which is unhelpful
since the agent has no context for evaluating what PRs we actually want
(see [this particularly problematic
example](https://github.com/flutter/packages/pull/9795#pullrequestreview-3113026764))
> - Appears to trust PR descriptions. E.g., recently praising a PR that
was missing tests of most of the PR, but had a PR description saying it
included extensive testing, as being extremely well tested.

Here are examples of summaries from the packages repo before and after
this change:

Before (praise like "great refactoring effort", "significantly improves
the modularity and maintainability", "extensive documentation updates
are also a major improvement"):
> This pull request is a great refactoring effort. Moving the ProxyAPI
generation logic into a dedicated helper file
(`proxy_api_generator_helper.dart`) significantly improves the
modularity and maintainability of the Dart generator. The extensive
documentation updates are also a major improvement, making the concepts
around ProxyAPIs much clearer for developers.

https://github.com/flutter/packages/pull/9756



After (drier, describing the actual change without making normative
evaluation):
> This pull request introduces a new `clearAuthorizationToken` method
across all layers of the `google_sign_in` plugin. This allows developers
to manually clear a cached authorization token if it becomes invalid.
The implementation is handled natively on Android, is a no-op on iOS (as
the SDK handles it), and clears a local cache on the web. The changes
include updates to the platform interface, implementations for each
platform, and corresponding tests and documentation.


https://github.com/flutter/packages/pull/9846#pullrequestreview-3129402056

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-08-21 00:27:09 +00:00
Matan Lurey
e757a22c32
Move Linux coverage back to bringup (#174171) 
Because this only runs every 6 commits, it being flaky takes a long time
to recover.

It's not a priority to keep green and un-flaky at the moment.
 2025-08-20 23:52:26 +00:00
Ryan Macnak
00590369f7
Engine build setup for Android RISCV64. (#173672) 
Bug: https://github.com/flutter/flutter/issues/117973
 2025-08-20 21:50:51 +00:00
hellohuanlin
70aea543b3
[ios][tools] do not print out bonjour key not found in non-verbose mode (#174001) 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

This tries https://github.com/flutter/flutter/pull/173569 again

That PR was reverted, because I didn't know that `streamOutput` was the
one used during non-verbose mode

The logging logic is a bit convoluted, see:
https://github.com/flutter/flutter/issues/173887


So this PR simply changes the condition from

```
if (!verbose && exitCode == 0)
```

To 

```
if (!verbose && exitCode == 0 && !skipErrorLog)
```

So that if we skipErrorLog (will be true for bonjour features), it
doesn't call `streamOutput`.

*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*

Fixes https://github.com/flutter/flutter/issues/172627

*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-08-20 21:00:09 +00:00