13504 Commits

Author SHA1 Message Date
Jonah Williams
fa52f345d6
fix for sometimes packages file is an APK (#29456) 2019-03-15 15:52:40 -07:00
Jonah Williams
cd803ac7f2
Improve hot reload performance (#28152) 2019-03-15 15:02:45 -07:00
engine-flutter-autoroll
bfac60485d
7da45be4a Roll src/third_party/skia 69600007e278..46f5ee156155 (8 commits) (flutter/engine#8178) (#29447)
cad97fe746...7da45be4a9

git log cad97fe7467c60de645d47acffd0e00cd83178ab..7da45be4a9afec572ebc110ad52511f5e2dc63e3 --no-merges --oneline
7da45be4a Roll src/third_party/skia 69600007e278..46f5ee156155 (8 commits) (flutter/engine#8178)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (jsimmons@google.com), and stop
the roller if necessary.
2019-03-15 18:00:36 -04:00
Shi-Hao Hong
2a21c1a188
add assert if length of TabController and number of tabs do not match (#29332) 2019-03-15 14:25:56 -07:00
Anthony
87e6beecad Fix Flex class docs by replacing 'vertical space' with 'space on its main axis' so that the language fits both column and row. (#29057) 2019-03-15 13:33:51 -07:00
Kate Lovett
71bd5d4f55
Sample code for Align class. ref:#13637 (#29442) 2019-03-15 13:32:03 -07:00
Mouad Debbar
5787fc3ae2
Fix text selection when user is dragging in the opposite direction (#29395) 2019-03-15 13:09:27 -07:00
engine-flutter-autoroll
28290f90de
Roll engine b36068c3778c..cad97fe7467c (2 commits) (#29441)
b36068c377...cad97fe746

git log b36068c3778c014ac999ce03412af2690bc713bc..cad97fe7467c60de645d47acffd0e00cd83178ab --no-merges --oneline
cad97fe74 Update overlays_gr_context_ correctly (flutter/engine#8175)
c0690e6ec Roll src/third_party/skia aefecad7c0d2..69600007e278 (2 commits) (flutter/engine#8177)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (jsimmons@google.com), and stop
the roller if necessary.
2019-03-15 15:50:34 -04:00
liyuqian
be5c83b9b8
Add dump-shader-skp flag to flutter tools (#29258)
This is the accompanying change for https://github.com/flutter/engine/pull/8148 and it needs the engine PR to land first.

For https://github.com/flutter/flutter/issues/813
2019-03-15 12:37:53 -07:00
xster
fa149eea9b
Cupertino localization step 1: add an English arb file (#29200) 2019-03-15 12:10:35 -07:00
liyuqian
0067efca61 No shrinking for BackdropFilter's cull rect (#28174)
* No shrinking for BackdropFilter's cull rect

This will be a breaking change. Our old behavior may generate confusions
for a sample app like our added golden test: Skia will shrink the cull
rect (and thus the filtered area) to the text. The new behavior will
fill the BackdropFilter to its parent/ancestor clip. This is more
in align with our clip behaviors (no clip by default).

If this breaks your app, wrap the BackdropFilter with a ClipRect.

[wip] The golden images are not uploaded yet. I'll wait for the initial
round of review to approve the golden test before uploading them.

* Statically define the callback

* Add TODO to remind the hacking code removal

* Nit fix

* Update goldens
2019-03-15 09:42:11 -07:00
Jason Simmons
e5696c2e7c
Use fs.identical to compare paths when finding the engine source path (#29386)
This will handle paths with symlinks that resolve to the same location.
2019-03-15 09:32:10 -07:00
Edman P. Anjos
bd50007f16 Paint backgroundColor in CircularProgressIndicator (#28004) 2019-03-15 09:26:39 -07:00
liyuqian
3202d228b7
--verbose-logging to verbose-logging in android (#29383)
Sorry that I missed the typo during the review of https://github.com/flutter/flutter/pull/29321
2019-03-15 09:20:15 -07:00
Christian Wenz
428d104054 Properly escape Android SDK Manager path in error message (#29134) 2019-03-15 08:58:33 -07:00
Dan Field
4906c7ea56 Update README.md (#29369) 2019-03-15 08:58:13 -07:00
Mike Leonhard
d6cc949970 [cupertino_icons] Add circle and circle_filled, for radio buttons. (#29407) 2019-03-15 08:57:45 -07:00
Efthymis Sarmpanis
955e004a13 Throw assertion error when a Hero has a Hero child. (#28470) 2019-03-15 08:55:27 -07:00
Brian Wilkerson
439fbbe69e
Update SDK constraints to reflect the fact that set literals are being used (#29389) 2019-03-15 07:53:27 -07:00
engine-flutter-autoroll
f6e9afa7d3
Roll engine 403337ebb893..b36068c3778c (10 commits) (#29429)
403337ebb8...b36068c377

git log 403337ebb893380101d1fa9cc435ce9b6cfeb22c..b36068c3778c014ac999ce03412af2690bc713bc --no-merges --oneline
b36068c37 Roll src/third_party/skia 05201fc7e77e..aefecad7c0d2 (5 commits) (flutter/engine#8176)
b32d0ab98 Bugfix: Prevent crash when responding to a platform message after FlutterJNI detaches from native (#28651). (flutter/engine#8170)
d9b2f0946 Roll src/third_party/skia 512e38091c85..05201fc7e77e (10 commits) (flutter/engine#8173)
4b01d795f Add frame and target time metadata to vsync events and connect platform vsync events using flows. (flutter/engine#8172)
f7a092262 [fuchsia] Remove deprecated libraries from snapshot (flutter/engine#8085)
09db84fad Android Embedding PR 19: Add accessibility to new FlutterView. (flutter/engine#8109)
246f0e3f4 Add an allocator specific check to ensure that strings passed to the timeline are not heap allocated. (flutter/engine#8168)
7a6bb9998 Roll src/third_party/skia feb720f746dc..512e38091c85 (11 commits) (flutter/engine#8169)
5825bdac9 Roll src/third_party/dart 7d560f8385..7418238239 (61 commits)
66fdeb163 Add dump-shader-skp switch to help ShaderWarmUp (flutter/engine#8148)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (jsimmons@google.com), and stop
the roller if necessary.
2019-03-15 09:51:36 -04:00
Jonah Williams
73fb457cae
Disable widget inspector scroll test (#29403) v1.3.11 2019-03-14 23:51:18 -07:00
Dan Field
a29906d5f5
Roll engine to 403337ebb893380101d1fa9cc435ce9b6cfeb22c (#29377)
* Manual engine roll with goldens
2019-03-14 19:06:23 -07:00
Justin McCandless
6d8f539971
Text field height attempt 2 (#29250)
Adds the `minLines` and `expands` parameters for controlling text height.  The original PR was reverted, so this one contains a few extra fixes for the tests that were broken.
2019-03-14 18:01:11 -07:00
Jonah Williams
7bed378e22
Only run codegen at start of flutter_test (#29171) 2019-03-14 17:12:40 -07:00
Jonah Williams
b74b960356
Skip Dialog interaction test (#29385) 2019-03-14 14:43:20 -07:00
Jonah Williams
8d5cb658fb
Revert "Manual engine roll with goldens (#29363)" (#29374)
This reverts commit c2e08913c063dea04f21b3e2db777146862c2f15.
2019-03-14 13:07:06 -07:00
Dan Field
c2e08913c0
Manual engine roll with goldens (#29363) 2019-03-14 11:35:01 -07:00
Shi-Hao Hong
c942ed4813
Implement labelPadding configuration in TabBarTheme (#29183) 2019-03-14 09:26:44 -07:00
Hans Muller
4e84256642
Error message when TextSelectionOverlay finds no Overlay (#29329) 2019-03-14 09:19:47 -07:00
Dan Field
97a8120969
guard new formatter behind env var (#29340)
* guard new formatter behind env var
2019-03-14 08:26:59 -07:00
rami-a
4feefa3c9a
[Material] Fix radio ink ripple to be centered (#28845) v1.3.10 2019-03-14 10:21:03 -04:00
Jonah Williams
25820ab2a4
add option for --verbose-system-logs (#29321) 2019-03-13 22:42:12 -07:00
Dan Field
7ac2486a4c Revert "Always composite PhysicalModels (#28919)" (#29314)
This reverts commit 58fb183298643bb0c57acd0b50b2480e9d1d5779.
2019-03-13 22:19:31 -04:00
Gary Qian
eb294a9c5b
Revert "Roll engine 31b289f277c6..b1b388f1c235 (7 commits)", Roll to 8b1a299ed instead. (#29330)
* Revert "Roll engine 31b289f277c6..b1b388f1c235 (7 commits) (#29323)"

This reverts commit 58ac12877d756804ad5f33e9f03c627fbde29b35.

Also rolls:
8b1a299ed [Skia] Rollback Skia to 29d5dec9a0783a033b921dc483fb98d565d684f6 (flutter/engine#8151)
9f50dae33 Look up ICU symbols based on the path to libflutter.so as a fallback (flutter/engine#8139)
59715b71d Disable build_ios task due to lack of credits. (flutter/engine#8150)
2019-03-13 18:08:57 -07:00
engine-flutter-autoroll
58ac12877d Roll engine 31b289f277c6..b1b388f1c235 (7 commits) (#29323)
* 59715b71d Disable build_ios task due to lack of credits. (flutter/engine#8150)

* 9f50dae33 Look up ICU symbols based on the path to libflutter.so as a fallback (flutter/engine#8139)

* 8b1a299ed [Skia] Rollback Skia to 29d5dec9a0783a033b921dc483fb98d565d684f6 (flutter/engine#8151)

* 8be2aca56 Roll src/third_party/dart 1bd36d694d..674fd0e060 (48 commits) #8152

* 2e427030f Revert "Disable build_ios task due to lack of credits. (#8150)" (flutter/engine#8153)

* 2daebebf4 Fix text.dart height docs (flutter/engine#8079)

* b1b388f1c Encode scroll motion events in the Android touch processor (flutter/engine#8149)
2019-03-13 18:24:25 -04:00
Dan Field
dcc965a38e
Revert "Speculative fix for #29262 (#29273)" (#29319)
This reverts commit 53d45258dc5d30b886ed5f29251d5e7d70bc78e1.
2019-03-13 12:58:10 -07:00
Dan Field
53d45258dc
Speculative fix for #29262 (#29273)
* Avoid writing to stderr before process has finished streaming
2019-03-13 12:27:05 -07:00
Gary Qian
96cb84a18c
Expose decorationThickness in TextStyle. Roll engine (12 commits) (#28751)
31b289f27 Fix indexing error in dart:ui TextStyle.toString (flutter/engine#8143)
fc2e6b61c Typo "fast an inline" to "fast and inline" (flutter/engine#8142)
0f19b2de0 Reland PerformanceOverlayLayer golden test (flutter/engine#8140)
073aadde1 Fix TextStyle decode misalignment (flutter/engine#8141)
d87d29054 Roll src/third_party/skia 406b068942f0..2eecc3ea3d71 (11 commits) (flutter/engine#8138)
5cef4a022 Use final state passed to dart before initialization as the initial lifecycleState. (flutter/engine#8124)
ffef51be6 Roll src/third_party/skia 665bc64a2dc4..406b068942f0 (8 commits) (flutter/engine#8137)
48efd0fb7 Roll src/third_party/skia 762ddd7e4352..665bc64a2dc4 (2 commits) (flutter/engine#8129)
f666adbbd Roll src/third_party/skia 2932a458957d..762ddd7e4352 (3 commits) (flutter/engine#8128)
8b0df6ded Bugfix #29203: NPE in getAccessibilityProvider in old FlutterView. (flutter/engine#8126)
8f7b18345 Roll src/third_party/skia c6d8781c4036..2932a458957d (2 commits) (flutter/engine#8125)
52b67fdd5 Expose decorationThickness to dart:ui (flutter/engine#8008)
2019-03-13 11:52:47 -07:00
Jonah Williams
275769b89d
Add skip to group in test_compat (#29236) 2019-03-13 10:13:51 -07:00
sjindel-google
88a477cace
Fix text selection handles showing outside the visible text region (#24476)
Don't show handles outside the text field's boundary.
2019-03-13 18:10:02 +01:00
Michael Goderbauer
89a51272d5
Fix DartDoc for UniqueKey (#29245) 2019-03-12 18:32:42 -07:00
Shi-Hao Hong
1ddd15ff49
Update README.md 2019-03-12 18:15:23 -07:00
Dan Field
58fb183298
Always composite PhysicalModels (#28919)
* Always composite PhysicalModels
* Update tests to check layer tree instead of canvas for Physical shadows
2019-03-12 16:34:13 -07:00
Hans Muller
fb3094a640
Update flutter_localizations translations (#29247) 2019-03-12 16:17:58 -07:00
guoskyhero
e82a7f06c6 Document that SearchDelegate.buildResults can be called multiple time… (#26785) 2019-03-12 16:17:33 -07:00
Sean D'Souza
a32810bc54 Docs edit for Tab Label Color (#29165) 2019-03-12 16:17:12 -07:00
liyuqian
8915cad443 No image shader caching in default shader warm-up (#29179)
* No image shader caching in default shader warm-up

It turns out that no matter how small the image is, too much memory will
be used. Hence remove the image shader caching and let the client
implement itself based on needs.

Fixes https://github.com/flutter/flutter/issues/29172

* Fix
2019-03-12 16:13:39 -07:00
Fedor Korotkov
1ab1fc6f70 Install JDK and Android SDK only for integration tests (#29229)
* Install JDK and Android SDK only for integration and build tests
2019-03-12 16:08:03 -07:00
Hans Muller
47f56712cc
Ensure that animated pairs of Tabs TextStyles have matching inherited values (#29175) 2019-03-12 12:27:30 -07:00
Michael Goderbauer
854d8bb0d9
Heroes and nested Navigators (#29069) 2019-03-12 11:49:17 -07:00