11704 Commits

Author SHA1 Message Date
Sebastian Podjasek
f8a2fc7c28 Implement resizeToAvoidBottomPadding in CupertinoPageScaffold (#20929) v0.7.2 2018-08-27 11:58:30 -07:00
liyuqian
38d155a421
Add default-no-clip tests to more buttons (#21012)
Note that such tests already exist for RaisedButton and MaterialButton
2018-08-27 11:25:47 -07:00
amirh
688d96b652
Add a creation parameters argument to AndroidView. (#21067)
This allows to pass construction parameters for the embedded Android
view from the Dart side.
2018-08-27 11:24:54 -07:00
Michael Thomsen
7f0f938de7
A few README fixes (#20985)
* Few readme fixes

* Fix link

* Make casing consistent
2018-08-27 11:11:14 +02:00
Danny Tuppeny
4466c9db4c
Re-enable integration tests (#20947)
* Unskip expression evaluation integration tests for non-Windows

* Add additional into to skip comments

* Add missing import
2018-08-27 09:29:07 +01:00
engine-flutter-autoroll
546449238a
Roll engine a52724fcf859..af42b6dc95bd (7 commits) (#21044)
Auto-roller completed checks. Merging.
2018-08-26 19:50:02 -04:00
engine-flutter-autoroll
b661886259
Roll engine 091492601479..a52724fcf859 (2 commits) (#21013)
Auto-roller completed checks. Merging.
2018-08-26 19:06:00 -04:00
amirh
510c0eeaff
Don't ignore the ByteData buffer offset in StringCodec.decode(). (#21011) 2018-08-24 17:19:30 -07:00
Greg Spencer
977da4fb20
Ignore pub-cache when analyzing (#20925)
This adds ".pub-cache" to the list of directories to ignore when checking for dependence upon dart:test, since when people install a downloadable package, their pub cache is in the flutter directory.

Also, I centralized the ANSI "red line" so that they would all use the same final string.
2018-08-24 14:06:25 -07:00
liyuqian
5d6707b78e
Expose clipBehavior to more buttons (#20538)
This allows developers to control the clipBehavior of those buttons.
2018-08-24 13:53:54 -07:00
amirh
fd44d0bb65
Update the android_views integration test to the new Android views API. (#20999)
This updates the test to match the engine API change introduced in:
https://github.com/flutter/engine/pull/6081

This also rolls the engine, the roll includes only the relevant engine commit:
```
091492601 Allow passing extra creation parameters for embedded Android views. (#6081)
```
2018-08-24 12:43:56 -07:00
Mehmet Fidanboylu
ac8d442a6f
Fix Dart check failure. (#20995) 2018-08-24 10:15:05 -07:00
engine-flutter-autoroll
20e019ef8d
Roll engine 0b728a314001..78e74d4d1816 (7 commits) (#20997)
Auto-roller completed checks. Merging.
2018-08-24 13:08:20 -04:00
Shams Zakhour
3c624f8b2c
Update README.md
Updating a few things on the README page. It needs more work.
v0.7.1
2018-08-23 19:23:02 -07:00
amirh
146b906bbb
Mark the embedded_android_views_test as non flaky. (#20962)
Was marked as flaky as that's our policy for assing new device lab
tests. It's been consistently green so marking as non flaky.
2018-08-23 19:01:28 -07:00
xster
c418b2f328
Auto populate nav bar title and previous from page route (#19637) 2018-08-23 18:24:30 -07:00
liyuqian
ce8ba6e8b3
Set the default clip to Clip.none again. (#20752)
This reverts commit 8de0e15e4fdd3a1be8878394a7f8c8bda948e59b and
updates the goldens versoin.

This requires https://github.com/flutter/flutter/pull/20751 to
land first.
2018-08-23 18:05:11 -07:00
jslavitz
3900d42bfa
Control, Shift and Arrow Key functionality for Chromebook (#20204)
* added keyboard functionatliy to android builds

* Added tests

* almost ready for review

* ready for review

* Fixes

* final comments

* final commit

* removing raw keyboard changes

* removing raw keyboard changes

* removing raw keyboard changes

* actual last commit

* fixed the imports

* a few more changes

* A few more changes

* a few changes

* Final changes

* Final changes2

* final actual commit for real

* final actual commit for real2

* final actual commit for real3

* final actual commit for real4

* final

* final 2

* f

* f2

* fin

* fin 2

* fin3

* fin4
2018-08-23 17:16:44 -07:00
Danny Tuppeny
dc5a5c18a9
Start logger in startProgress to avoid assertion failure (#20814)
* Start logger in startProgress to avoid assertion failure

There are lots of places that create a Status() and all but two of them call ..start() immediately. This is one of the places that doesn't, which causes an assertion failure when running with --enable-asserts and the other is in the same file (I suspect it's also incorrect, but possibly it's never used - I'll look at that separately when I can trace some code that calls it).

Fixes #20812.

* Enable asserts for tools tests

* Fix lint

* Rename enableAsserts -> enableFlutterToolAsserts

To make it clearer that it only enables asserts for flutter_tools when set.
2018-08-23 20:49:59 +01:00
amirh
1ba16d55f3
Don't size Android views to (0,0) (#20956)
Virtual displays must have a non zero size. This was causing a crash:
https://github.com/flutter/flutter/issues/20456
2018-08-23 12:29:29 -07:00
Hans Muller
3fcc1069e9
Made the memory_nav benchmark a little more robust (#20938) 2018-08-23 12:05:47 -07:00
Hans Muller
be601c26a5
Correct gen_date_localizations.dart supported locales computation (#20920) 2018-08-23 11:56:33 -07:00
Jonah Williams
e235ccd76f
Support disabled animations (#20354) 2018-08-23 11:50:04 -07:00
amirh
1f31c3b354
Run the embedded Android views integration test on the device lab. (#20841) 2018-08-23 10:26:00 -07:00
Janice Collins
d3844d7d9c
Strip upstream from footer (#20757)
* Strip upstream from footer

* cleanup (readd accidentally deleted whitespace)
2018-08-23 10:25:15 -07:00
Viet Do
8e70d54e81
add cupertino localizations (#20756)
add cupertino localizations abstract class and the default cupertino localizations in US English.
2018-08-23 10:10:57 -07:00
Günter Zöchbauer
bd0b666ad3
Fix image refs to moved image directory
fixes #20940
2018-08-23 08:46:56 +02:00
Jonah Williams
99b382953b
Create flutter_driver infra for testing the Android AccessibilityNodeInfo generated by Flutter (#19700) 2018-08-22 22:56:54 -07:00
engine-flutter-autoroll
676a33581c
Roll engine c62248bdd3f4..0b728a314001 (3 commits) (#20942)
Auto-roller completed checks. Merging.
2018-08-23 01:52:59 -04:00
amirh
1fc7814bb1
Add a layoutDirection parameter to AndroidView (#20838) 2018-08-22 21:42:40 -07:00
asiva
5d1f874075 Roll engine to version c62248bdd3f46794b78d1bd141e92691d539e56f
This includes the following changes
c62248bdd Roll src/third_party/skia 82cf64a0d317..33d5394d08f6 (14 commits) (#6068)
b0fb3e660 Roll src/third_party/skia 96597c22c344..82cf64a0d317 (12 commits) (#6067)
ea8b949a7 Roll src/third_party/skia 4d727c560b58..96597c22c344 (27 commits) (#6066)
4fde39583 Roll Dart to version ccb16f72824374163562364bf19dd18e8a882fab (#6065)
140a5b757 Alllow access to Flutter engine, Dart & Skia versions in the Shell API. (#6060)
2018-08-22 18:46:02 -07:00
asiva
107c750da6 Roll engine to version 4fde3958388cab4210d6f7da86ec78e32fc4e7ee
Contains the following changes:
4fde39583 Roll Dart to version ccb16f72824374163562364bf19dd18e8a882fab (#6065)
140a5b757 Alllow access to Flutter engine, Dart & Skia versions in the Shell API. (#6060)
2018-08-22 18:46:02 -07:00
Jonah Williams
f0e80933b0
Mark memory_nav as flaky (#20930) 2018-08-22 17:34:29 -07:00
Jonah Williams
09fe34708f
Add localization for expand icon collapse/expand tap hint (#20766) v0.7.0 2018-08-22 10:20:51 -07:00
Will Larche
47cffd160c
[Gallery] Material elevations (shadows) demo (#20842)
* [Gallery] Elevations demo. TODO: Correct icon.

* [Gallery] More elevations for the elevation demo.

* [Gallery] Elevation toggle for elevation demo.

* [Demos] Update temp icon on elevations demo.

* [Demos] Changing action icon.

* [Demos] Same.

* [Demos] Adding new and const.

* [Demos] Reverting formatting.

* [Gallery] PR Feedback.
2018-08-22 13:02:35 -04:00
sir-boformer
09e7902f5b Fix small TabBar inconsistencies (#20887)
Tabs are now padded by 16.0 on the left and right  (used to be 12.0).
2018-08-22 09:42:18 -07:00
amirh
e24ac50871
Add support for GestureArenaTeam captains. (#20883)
The team captain wins the arena on behalf of the team.
When any of the team members claims victory for the arena the captain
accepts the gesture.

This is used when embeddeding platform views - we allow configuring a
set of gestures that should be forwarded to the platform view.
We add the set of gesture recognizers to a GestureArenaTeam with a
captain, and if the captain accepts the gesture we forward it to the
platform view.
2018-08-22 09:31:56 -07:00
liyuqian
ee8754df4a
Add customBorder to InkWell so it can clip ShapeBorder (#20751)
This fixes #20483 by letting InkWell do its own clipping.

PathOp.intersect is not used because we have too many unit tests that rely on clipping (e.g., paints..clipXXX()..drawCircle())

The goldens are updated due to small AA changes of the additional clipPath.
2018-08-22 09:25:01 -07:00
Danny Tuppeny
363543fc19
Don't try to stop the same app twice in flutter_attach test (#20905)
This test is sometimes flaky (#20822) because the two processes try to stop the same app. This fix changes to just gracefully terminate the attach process without explicitly trying to stop and then uses the original spawning process to stop the app.

I can't repro the flake locally to be certain, but I've verified only one stop command is sent now so it *should* be good.
2018-08-22 17:13:34 +01:00
Danny Tuppeny
65985db142
Double all timeouts on flutter_tools integration tests (#20872)
Due to CPU contention we've seen these go really slow on Cirrus (see https://github.com/flutter/flutter/issues/19542#issuecomment-414265152), and there's also a chance our flakes are timeouts due to running slow rather than hanging.
2018-08-22 17:13:23 +01:00
Hans Muller
18e7549bc8
Update BottomNavigationBar.didUpdateWidget() (#20890)
BottomNavigationBar's state needs to update _backgroundColor when its configuration changes.
2018-08-21 17:10:31 -07:00
Ian Hickson
94f9604a96
Cleanup (#20754)
- remove an //ignore that is no longer needed
- fix some intrinsic methods that used the API incorrectly (shouldn't affect correctness but should make things a tiny bit more efficient)
- add some asserts to help track down bugs quicker
- update a TODO to point to the currently relevant bug
- fix some indenting
- improve the naming of some privates to improve readability
2018-08-21 14:02:48 -07:00
Ian Hickson
22f376418f
Track number of package dependencies in Flutter (#20831)
* Track number of package dependencies in Flutter

Relands #20774.

* Use evalFlutter instead of startProcess.

That way we don't need `flutter` on the PATH.
2018-08-21 14:02:33 -07:00
Ian Hickson
b7261586e5
Audit TODO syntax (#20837)
Fixes the pattern for some TODOs to match our style guide.

(Also, a couple of minor code order fixes.)
2018-08-21 14:02:11 -07:00
leoylung
adafaee0e3 Remove duplicated assets under /pkg/data (#20728)
Require componentName to ensure assets are placed under /pkg/data/<component-name>
2018-08-21 13:14:17 -07:00
liyuqian
bab0ce97bd
Clip the flutter_gallery front layer (#20836)
This will be needed once PhysicalShape sets the default clipBehavior
to Clip.none.
2018-08-21 12:56:01 -07:00
Danny Tuppeny
e870b1a20f
Provide better error messages in integration tests when apps don't launch successfully (#20813)
* Don't keep parsing results once we've had the event we expected

* Report errors if an app.stop event is received while waiting for another event

* Don't throw if we see app.stop event when we've just sent an app.stop request

* Improve debug print to include --start-paused if being used

* Improve wrapping
2018-08-21 20:39:35 +01:00
Devon Carew
392a178169
add a --use-cfe option to flutter analyze (#20742)
* add a --use-cfe option to flutter analyze

* useCFE ==> useCfe
v0.6.2
2018-08-21 10:45:37 -07:00
ebeem
9d6d03fc08 Add ability to set collapse mode in flexible space bar (#18526)
* Add ability to set collapse mode in flexible space bar

* Add tests to collapse mode in flexible space bar

* Fix minor style nit

* Fix getting collapse mode does not handle unknown values

* Change const key to final in space bar collapse mode test

* Return null collapse padding if mode is unknown
2018-08-21 10:26:08 -07:00
engine-flutter-autoroll
9a8ec4536d
Roll engine 4e845be0b1ac..4b271b2e0265 (3 commits) (#20873)
Auto-roller completed checks. Merging.
2018-08-21 13:24:59 -04:00