Taha Tesser
ec69f001fc
Fix SnackBar action text button overlay color ( #148961 )
...
fixes [`SnackBar` action hover state background too hard to see](https://github.com/flutter/flutter/issues/141343 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() {
runApp(const MyApp());
}
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return const MaterialApp(
home: Scaffold(
body: Center(
child: ScaffoldButton(),
),
),
);
}
}
class ScaffoldButton extends StatelessWidget {
const ScaffoldButton({super.key});
@override
Widget build(BuildContext context) {
return TextButton(
onPressed: () {
ScaffoldMessenger.of(context).showSnackBar(
SnackBar(
behavior: SnackBarBehavior.floating,
width: 320,
content: const Text('This is a snackbar!'),
action: SnackBarAction(
label: 'Close',
onPressed: () {},
),
),
);
},
child: const Text('Launch snackbar'),
);
}
}
```
</details>
### Before
<img src="https://github.com/flutter/flutter/assets/48603081/88b53c92-6184-4faf-88e1-ac70f78993b3 "/>
### After
<img src="https://github.com/flutter/flutter/assets/48603081/3e03c903-90c0-4da4-b49a-0070208d56d1 " />
2024-05-23 22:42:52 +00:00
wangyognqi
881e29f94a
Fix the second TextFormField to trigger onTapOutside ( #148930 )
...
This PR attempts to fix https://github.com/flutter/flutter/issues/127597
2024-05-23 22:25:51 +00:00
Renzo Olivares
b2eda0624a
Revert "Fix the second TextFormField to trigger onTapOutside" ( #148909 )
2024-05-22 13:40:59 -07:00
wangyognqi
9acbc1d4a2
Fix the second TextFormField to trigger onTapOutside ( #148206 )
...
This PR attempts to fix https://github.com/flutter/flutter/issues/127597
2024-05-22 18:33:14 +00:00
Taha Tesser
ea7cf54b42
Introduce WidgetStateBorderSide.lerp ( #148122 )
...
fixes [Consolidate `_LerpSides` classes with `WigetStateProperty<BorderSide?>` type into a new `WidgetStateBorderSide.lerp`](https://github.com/flutter/flutter/issues/148057 )
2024-05-22 07:11:07 +00:00
Bruno Leroux
7727ff46cc
Add DropdownButton.menuWidth ( #148125 )
...
## Description
This PRs add a new parameter to `DropdownButton` which allows to set the menu width.
This can be useful when `DropdownButton.selectedItemBuilder` is provided and builds small items, see https://github.com/flutter/flutter/issues/133267 .
Iâm not fond of adding new property, especially for a widget which is supposed to be replaced on M3, but in this case it might makes sense because it is a way to not break existing code while addressing a legitimate issue.
## Related Issue
Fixes https://github.com/flutter/flutter/issues/133267 .
## Tests
Adds 1 test.
2024-05-21 19:15:21 +00:00
Tirth
059189e756
Adds Missing onHover & onFocusChange for OutlinedButton.icon ( #144374 )
...
Adds Missing `onHover` & `onFocusChange` for `OutlinedButton.icon`.
I've copy-pasted the tests of OutlinedButton for OutlinedButton.icon.
Also, `onHover` & `onFocusChange` are already there in ElevatedButton.icon, FilledButton.icon & TextButton.icon, but tests files for these 3 doesn't test for icon variants.
Fixes #144256
2024-05-21 16:44:05 +00:00
Nate
870c5541c3
switch expressions: finale (#148711 )
...
### fixes #136139
<br>
<details open> <summary><b>getting sentimental in the PR description</b> (click to collapse)<br><br></summary>
The past 7 months have been quite the journeyâI made some huge blunders and some huge accomplishmentsâa very fun time overall.
I really appreciate the people who took the time to perform code review for my refactoring shenanigans: **christopherfujino**, **andrewkolos**, **LongCatIsLooong**, **gspencergoog**, **loic-sharma**, **Piinks**, **bernaferrari**, **bartekpacia**, **bleroux**, **kevmoo**, **rakudrama**, **XilaiZhang**, **QuncCccccc**, **MominRaza**, and **victorsanni**.
And a huge shoutout to 2 individuals:
- @justinmc, for offering to sponsor me for commit access (words could not describe my excitement)
- @goderbauer, for being super duper proactive and consistent with code review
<br>
</details>
This pull request makes 13 "switch statements â switch expressions" PRs in total, reducing the LOC in this repo by **1,974**!
From now on, I'll make sure to request a test exemption for each refactoring PR ð
2024-05-21 16:18:05 +00:00
davidhicks980
e6fa865581
Removed brand references from MenuAnchor.dart ( #148760 )
...
Rephrases identifier from _isApple to _isCupertino.
@gspencergoog and @victorsanni
2024-05-21 16:12:05 +00:00
Nate
76a07a1646
Implement new AnimationStatus getters ( #148570 )
...
PR #147801 introduced some convenient `AnimationStatus` getters, but I just realized that `AnimationController` now has 2 getters for the same thing: `isAnimating` and `isRunning`.
The intent of this pull request is to correct that mistake, and implement the getters in the appropriate places.
2024-05-20 17:43:03 +00:00
Victor Sanni
f7012db828
Move Feedback to widgets layer ( #148523 )
...
Currently, `Feedback` exists in the Material layer. However, not only is
`Feedback` not material-opinionated, but it is an abstract class that
defines its functionality depending on the user's platform.
It makes sense that `Feedback` should exist in the widgets layer
instead. This makes it easier to incorporate platform specific
`Feedback` updates as they arrive, fixing issues like #148391 .
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes
2024-05-18 10:41:56 -07:00
Nate
fa9992eff6
switch statement cleanup (#148382 )
...
This PR is step 12 in the journey to solve issue #136139 and make the
entire Flutter repo more readable.
Most of it involves implementing switch expressions, and there's also a
few other random things that I wanted to clean up a bit.
2024-05-16 17:16:06 -07:00
Dimil Kalathiya
0d22d9101a
fixes DialogRoute memory leak ( #147816 )
2024-05-16 08:10:51 -07:00
Pierre-Louis
92a46ae71e
ThemeData minor spring cleaning ( #148408 )
...
Do a bit of sprucing up of `ThemeData` in anticipation of future work
Related: https://github.com/flutter/flutter/issues/91772
2024-05-16 07:32:19 +00:00
Bruno Leroux
b1677f6c0f
Reland fix TextField helper top padding on M3 ( #146754 )
...
This is a reland of https://github.com/flutter/flutter/pull/145087 which was reverted in https://github.com/flutter/flutter/pull/145168 .
https://github.com/flutter/flutter/pull/146637 was merged and might help here.
## Description
`InputDecorator` adds a 8.0 gap beetween the container and the helper text.
From the Material 3 specification, this gap should be 4.0.
See https://m3.material.io/components/text-fields/specs#0c5c8d6d-2169-4d42-960c-51f6ee42eb57 .
This PR sets the correct values for M3 without changing the value for M2.
| Before | After | M3 Spec |
|--------|--------|--------|
|  | |  |
If this change is accepted, a future step will be to make this value configurable, probably by `InputDecorationTheme`.
## Related Issue
Fixes https://github.com/flutter/flutter/issues/144984
## Tests
Updates a value used by several existing tests.
2024-05-16 05:40:30 +00:00
FMorschel
cae2079ad2
Removing duplicate assert on VisualDensity constructor ( #148281 )
...
This PR only removes a duplicate assertion for `vertical <= maximumDensity` on `VisualDensity` constructor.
This is my first PR, do I need to do any of the non-checked items above, or anything else for this to be accepted?
2024-05-16 05:29:06 +00:00
Valentin Vignal
8b129b9b89
Fix memory leaks in _PopupMenuRoute ( #148373 )
2024-05-15 13:50:03 -07:00
Valentin Vignal
ffae7c60c2
Add clipBehavior to DrawerThemeData ( #148061 )
...
Fixes https://github.com/flutter/flutter/issues/148060
2024-05-15 18:37:07 +00:00
Valentin Vignal
f335145529
Fix memory leaks in SnackBar ( #147212 )
2024-05-14 15:26:10 -07:00
Valentin Vignal
b23f34657e
Fix memory leaks in open upwards page transition ( #148046 )
2024-05-14 15:25:58 -07:00
chunhtai
de9ca5c1c8
Fixes semantics ordering when there are multiple TextFields with pref… ( #148267 )
...
â¦ix and suffix
fixes https://github.com/flutter/flutter/issues/148248
2024-05-14 22:22:51 +00:00
Victor Sanni
7d92700042
Move toggleable to widget layer ( #148272 )
...
Currently, toggleable exists independently in the material and cupertino
libraries. Cupertino's toggleable is a minimal copy of material's, and
so it makes sense to have only one toggleable in the widgets layer.
This change makes it easier for cupertino's toggleables (switch, radio,
checkbox) to potentially have as many capabilities as material
toggleables (for example, resolving in different widget states), thus
increasing support for the cupertino library.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes
---------
Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com>
2024-05-14 13:46:35 -07:00
chunhtai
a36ff80cf6
Refactors page API ( #137792 )
...
fixes https://github.com/flutter/flutter/issues/137458
Chagnes:
1. Navigator.pop will always pop page based route
2. add a onDidRemovePage callback to replace onPopPage
3. Page.canPop and Page.onPopInvoked mirrors the PopScope, but in Page class.
migration guide https://github.com/flutter/website/pull/10523
2024-05-13 22:45:51 +00:00
Taha Tesser
c386acca54
Fix MaterialStateBorderSide lerp in the Checkbox and chips ( #148124 )
...
fixes [`Checkbox` and Chips side with `MaterialStateBorderSide` doesn't lerp in their theme](https://github.com/flutter/flutter/issues/135136 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
void main() {
testWidgets('test', (WidgetTester tester) async {
late ColorScheme colorScheme;
Widget buildCheckbox({required Color seedColor}) {
colorScheme = ColorScheme.fromSeed(seedColor: seedColor);
return MaterialApp(
theme: ThemeData(
colorScheme: colorScheme,
checkboxTheme: CheckboxThemeData(
side: MaterialStateBorderSide.resolveWith(
(Set<MaterialState> states) {
return BorderSide(
color: colorScheme.primary,
width: 4.0,
);
}),
),
),
home: Scaffold(
body: Center(
child: Checkbox(
value: false,
onChanged: (_) {},
),
),
),
);
}
await tester.pumpWidget(buildCheckbox(seedColor: Colors.red));
await tester.pumpAndSettle();
RenderBox getCheckboxRenderer() {
return tester.renderObject<RenderBox>(find.byType(Checkbox));
}
expect(getCheckboxRenderer(), paints..drrect(color: colorScheme.primary));
await Future<void>.delayed(const Duration(seconds: 3));
await tester.pumpWidget(buildCheckbox(seedColor: Colors.blue));
await tester.pump();
await Future<void>.delayed(const Duration(seconds: 3));
expect(getCheckboxRenderer(), paints..drrect(color: colorScheme.primary));
});
}
```
</details>
| Before | After |
| --------------- | --------------- |
| <img src="https://github.com/flutter/flutter/assets/48603081/6df34104-37ba-4a82-b5cb-7ed4f887992a " /> | <img src="https://github.com/flutter/flutter/assets/48603081/44359248-a101-46eb-a85a-77f976da5f0f " /> |
2024-05-10 23:37:05 +00:00
Justin McCandless
3e14f18178
Docs on TextField disposed by a scrollable ( #148149 )
...
Includes docs about the need to manually maintain a TextEditingController when using TextField in a ListView.builder (which was already documented on TextFormField).
2024-05-10 16:08:13 -07:00
Valentin Vignal
8e53ad917c
Add clipBehavior to DialogTheme ( #147635 )
...
Fixes https://github.com/flutter/flutter/issues/147634
2024-05-10 22:08:59 +00:00
PurplePolyhedron
fdfc408fd7
Fix DropdownMenu keyboard navigation ( #147294 )
...
Fix https://github.com/flutter/flutter/issues/147253
Fix https://github.com/flutter/flutter/issues/147516
Resubmitted https://github.com/flutter/flutter/pull/147285 because I accidentally added reviewer as contributor in a commit by using Github "add suggestion to batch". Which causing CLA check to fail and I cannot revert it.
I use exact match of label instead of contains to minimise possible change in actual user search.
I added the new test after the original keyboard navigation test to avoid merge conflict with another incoming PR.
Let me know if I need to make any changes.
Sorry for the inconvenience, I am new to the process.
2024-05-10 21:55:49 +00:00
Nate
94a7151eb8
Getting rid of containers ( #147432 )
...
This pull request aims to make the Flutter framework more efficient,
based on issue #147431 .
2024-05-09 16:31:54 -06:00
huycozy
bd44399865
Add Badge example ( #148053 )
...
### Demo screenshot
### Related issue
Fixes https://github.com/flutter/flutter/issues/144336
2024-05-09 16:47:16 +00:00
Benji Farquhar
a5e0c2ffe7
Fix ExpandIcon color when ExpansionPanel.canTapOnHeader true ( #147097 ) ( #147098 )
...
Fixes https://github.com/flutter/flutter/issues/147097 . The expand/collapse icon should not be the disabled color when ExpansionPanel.canTapOnHeader is true because the ExpansionPanel is active, and we may want to keep the icon there as a visual indicator to the user that it is expandable/collapsable.
2024-05-09 15:35:07 +00:00
Dimil Kalathiya
c97f22ec12
_RenderValueIndicator leak fix used on RangeSlider (#147581 )
...
Part of #141198
*Fixes memory leak on `RangeSlider`*
2024-05-08 19:04:17 +00:00
Aliasgar Vohra
4d6c00cc2b
🐛 : FIX : Long labels overflowing in extended navigation rail. ( #145474 )
...
It has been observed that while in extended navigation rail, if longer labels are given the it is overflowing. Problem identified in "NavigationRail" widget only in case of extended version of it. This PR includes the fix for the same.
Fixes https://github.com/flutter/flutter/issues/110901 .
*NO breaking changes.*
2024-05-08 11:05:24 +00:00
Bruno Leroux
86a2613cee
Fix floating SnackBar is not centered when RTL and Material 2 ( #147861 )
...
## Description
This PR fixes floating `SnackBar` positioning when the text direction is RTL and the theme uses Material 2.
In https://github.com/flutter/flutter/pull/140215 , I fixed the `SnackBar` position for M3/RTL, but while doing so I broke the positioning for M2/RTL... Unfortunately, there was no existing test for this case.
The solution is to not rely on `TextDirection` to compute the `SnackBar` position: the `SnackBar` is centered in both cases so the text direction has no impact on its positioning (it had some impact in the `SnackBar` content, but this is managed correctly).
## Related Issue
Fixes https://github.com/flutter/flutter/issues/147838 .
## Tests
Adds 1 test.
2024-05-08 07:34:05 +00:00
LongCatIsLooong
e37b29daa9
Implement computeDryBaseline for RenderChip ( #146224 )
...
Also, use `getDryLayout` for the first pass of the `label` layout.
The computeDryBaseline stuff doesn't have a test because there're asserts making sure it returns the same result as `computeDistanceToActualBaseline`. I have tried adding `+1` to the return expression and `flutter test` fails.
2024-05-08 00:27:59 +00:00
Taha Tesser
74356f30dd
Introduce TabBar.textScaler for tab label upper text scale limit ( #147232 )
...
fixes [Tab is hardcoding the height of the icons and the text ](https://github.com/flutter/flutter/issues/13322 )
### Description
This PR introduces `TabBar.textScaler` to provide upper text scale limit for tab label.
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
home: MediaQuery(
data: const MediaQueryData(textScaler: TextScaler.linear(3.0)),
child: DefaultTabController(
length: 3,
child: Scaffold(
appBar: AppBar(
title: const Text('Sample'),
bottom: const TabBar(
textScaler: TextScaler.linear(2.0),
tabs: <Widget>[
Tab(text: 'Tab 1'),
Tab(text: 'Tab 2'),
Tab(text: 'Tab 3'),
],
),
),
floatingActionButton: Builder(builder: (BuildContext context) {
return FloatingActionButton(
onPressed: () {
print(MediaQuery.textScalerOf(context));
},
child: const Icon(Icons.add),
);
}),
),
),
),
);
}
}
```
</details>
### Without `TabBar.textScaler`
### With `TabBar.textScaler`
```dart
bottom: const TabBar(
textScaler: TextScaler.linear(2.0),
tabs: <Widget>[
Tab(text: 'Tab 1'),
Tab(text: 'Tab 2'),
Tab(text: 'Tab 3'),
],
),
```
2024-05-07 20:54:09 +00:00
chunhtai
007faa980d
Reapply new PopScope API ( #147607 )
...
same as previous but with soft transition on modalroute
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes
2024-05-07 09:04:49 -07:00
Bruno Leroux
986c5a9d7f
DropdownMenu cleanup ( #147860 )
...
## Description
This PR cleans up some typos and formatting issues in `DropdownMenu` implementation.
## Tests
No semantic change.
2024-05-07 07:57:21 +00:00
zhengzeqin
23ae246a2e
fix MenuItemButton if child is null ( #147485 )
...
Fix https://github.com/flutter/flutter/issues/147479
Pre-launch Checklist
2024-05-07 02:39:09 +00:00
Karel Klíč
f94b1e1fc8
Fix Tooltip.decoration comment ( #147858 )
...
Tooltip decoration's comment had the backgrounds for Brightness.dark and Brightness.light swapped.
2024-05-06 13:13:19 +00:00
Valentin Vignal
02d239a098
Reland fix memory leaks for tab selector ( #147689 )
2024-05-04 18:23:39 -07:00
Kostia Sokolovskyi
145e94018c
Fix memory leak in ExpansionTile. ( #147596 )
2024-05-04 18:19:29 -07:00
Dimil Kalathiya
c1cafcce12
fixes SearchAnchor leak ( #147652 )
2024-05-03 09:34:11 -07:00
Bruno Leroux
99876ba2ce
Always relies on floatingLabelStyle when FloatingLabelBehavior.always ( #147374 )
...
## Description
With this PR, when `InputDecorator.floatingLabelBehavior` is set to `FloatingLabelBehavior.always` the label style is always set to `InputDecorator.floatingLabelStyle`, previously `InputDecorator.labelStyle` was used when the field was not focused or was empty.
## Related Issue
Fixes https://github.com/flutter/flutter/issues/147231
## Tests
Adds 1 test for this particular issue and several missing tests.
2024-05-03 15:16:05 +00:00
Nate
7436cc25eb
Add default arguments to AnimatedPhysicalModel ( #147424 )
...
Currently, `PhysicalModel` has [default arguments](2e806700b9/packages/flutter/lib/src/widgets/basic.dart (L1093)2e806700b9/packages/flutter/lib/src/widgets/implicit_animations.dart (L1998)
2024-05-02 21:59:07 +00:00
LongCatIsLooong
f76eda1e7f
_RenderDecorator.computeDryBaseline (#146365 )
...
Depends on https://github.com/flutter/flutter/pull/146363
No test because the consistency of the `computeDryBaseline` implementations is checked at paint time.
2024-05-02 20:56:11 +00:00
Ian Hickson
db4dfa0dde
Remove obsolete performance analysis tools. ( #147663 )
...
We're unlikely to support these reliably going forward.
2024-05-01 22:05:02 +00:00
PurplePolyhedron
68f8b536e2
fix DropdownMenu overflow ( #147233 )
...
fix `DropdownMenu` overflow issue in https://github.com/flutter/flutter/issues/147076 and https://github.com/flutter/flutter/issues/147173
However I believe the the menu placement issue in https://github.com/flutter/flutter/issues/147076 is a separate issue. It is not fixed here.
fixes https://github.com/flutter/flutter/issues/147173
2024-05-01 21:24:58 +00:00
Nate
586e1fce1b
flutter/lib/src/: refactoring if-chains into switch expressions (#147472 )
...
Cleans up some code by porting if chains to switch statements.
2024-05-01 12:58:35 -07:00
auto-submit[bot]
abbaaea8a1
Reverts "Fix memory leak in TabPageSelector ( #147403 )" ( #147622 )
...
Reverts: flutter/flutter#147403
Initiated by: chingjun
Reason for reverting: Causing an internal test to fail, see b/338159496 for details
Original PR Author: ValentinVignal
Reviewed By: {polina-c}
This change reverts the following previous change:
Part of https://github.com/flutter/flutter/issues/141198
2024-05-01 05:32:19 +00:00
chunhtai
3e399c1578
Revert "add a new PopScope.onPopWithResultInvoke widget to replace Po… ( #147597 )
...
…pScope.onPopInvoke (#147016 )"
This reverts commit 8031a3e30cf4adc13bedea0aa44c05a1cf8aa852.
Needs to migrate flutter_eval
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes
2024-04-30 13:25:24 -07:00
