DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
flutter_flutter/packages/flutter/lib/src/material
History
Bruno Leroux 86a2613cee
Fix floating SnackBar is not centered when RTL and Material 2 (#147861) 
## Description

This PR fixes floating `SnackBar` positioning when the text direction is RTL and the theme uses Material 2.

In https://github.com/flutter/flutter/pull/140215, I fixed the `SnackBar` position for M3/RTL, but while doing so I broke the positioning for M2/RTL... Unfortunately, there was no existing test for this case.
The solution is to not rely on `TextDirection` to compute the `SnackBar` position: the `SnackBar` is centered in both cases so the text direction has no impact on its positioning (it had some impact in the `SnackBar` content, but this is managed correctly).

## Related Issue

Fixes https://github.com/flutter/flutter/issues/147838.

## Tests

Adds 1 test.
2024-05-08 07:34:05 +00:00
..
animated_icons
…
shaders
…
about.dart
Reapply new PopScope API (#147607)
2024-05-07 09:04:49 -07:00
action_buttons.dart
Fix #141061: Add 'color' property to DrawerButton and EndDrawerButton (#141159)
2024-01-16 10:08:27 +00:00
action_chip.dart
Reland "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2" (#144273)
2024-02-28 13:55:50 -08:00
action_icons_theme.dart
…
adaptive_text_selection_toolbar.dart
Horizontally expand text selection toolbar buttons in overflow menu (#144391)
2024-03-01 06:40:47 +00:00
animated_icons.dart
…
app_bar_theme.dart
…
app_bar.dart
Add a custom shape example for AppBar.shape (#146421)
2024-04-08 18:42:07 +00:00
app.dart
Remove obsolete performance analysis tools. (#147663)
2024-05-01 22:05:02 +00:00
arc.dart
Implementing switch expressions in foundation/ and material/ (#142279)
2024-01-29 18:14:02 +00:00
autocomplete.dart
Fixes #138773, port autocomplete to OverlayPortal (#140285)
2024-01-24 16:49:18 +00:00
back_button.dart
…
badge_theme.dart
…
badge.dart
Makes badge to auto size with content (#146853)
2024-04-25 10:32:45 -07:00
banner_theme.dart
…
banner.dart
Fix memory leaks in MaterialBanner (#146963)
2024-04-18 07:21:18 -07:00
bottom_app_bar_theme.dart
Remove bottomAppBarColor from ThemeData (#144080)
2024-02-28 00:07:51 +00:00
bottom_app_bar.dart
Reland "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2" (#144273)
2024-02-28 13:55:50 -08:00
bottom_navigation_bar_theme.dart
…
bottom_navigation_bar.dart
Fix memory leaks in BottomNavigationBar (#147213)
2024-04-24 10:11:56 -07:00
bottom_sheet_theme.dart
…
bottom_sheet.dart
Fix typos in bottom_sheet.dart (#146188)
2024-04-03 15:18:06 +00:00
button_bar_theme.dart
Deprecate ButtonBar, ButtonBarThemeData, and ThemeData.buttonBarTheme (#145523)
2024-04-01 11:39:48 +00:00
button_bar.dart
Deprecate ButtonBar, ButtonBarThemeData, and ThemeData.buttonBarTheme (#145523)
2024-04-01 11:39:48 +00:00
button_style_button.dart
Implements RenderBox.computeDryBaseline for material render boxes (#146027)
2024-04-02 18:37:05 +00:00
button_style.dart
Mention visualDensity impact on ButtonStyle.padding documentation (#147048)
2024-04-23 08:15:53 +00:00
button_theme.dart
Remove deprecated TextTheme members (#139255)
2024-03-28 01:20:55 +00:00
button.dart
Implements RenderBox.computeDryBaseline for material render boxes (#146027)
2024-04-02 18:37:05 +00:00
calendar_date_picker.dart
flutter/lib/src/: refactoring if-chains into switch expressions (#147472)
2024-05-01 12:58:35 -07:00
card_theme.dart
Improve documentation of CardTheme.shape (#139096)
2023-11-29 09:54:59 +00:00
card.dart
Reland "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2" (#144273)
2024-02-28 13:55:50 -08:00
checkbox_list_tile.dart
Implementing switch expressions: everything in flutter/lib/src/ (#143634)
2024-02-20 21:02:47 +00:00
checkbox_theme.dart
…
checkbox.dart
flutter/lib/src/: refactoring if-chains into switch expressions (#147472)
2024-05-01 12:58:35 -07:00
chip_theme.dart
Introduce avatarBoxConstraints & deleteIconBoxConstraints for the chips (#143302)
2024-02-13 20:30:53 +00:00
chip.dart
Implement computeDryBaseline for RenderChip (#146224)
2024-05-08 00:27:59 +00:00
choice_chip.dart
Reland "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2" (#144273)
2024-02-28 13:55:50 -08:00
circle_avatar.dart
Implementing switch expressions in foundation/ and material/ (#142279)
2024-01-29 18:14:02 +00:00
color_scheme.dart
Enhance ColorScheme.fromSeed with a new variant parameter (#144805)
2024-04-03 15:54:34 +00:00
colors.dart
…
constants.dart
…
curves.dart
Deprecate M2 curves (#134417)
2024-01-18 18:38:00 +01:00
data_table_source.dart
…
data_table_theme.dart
Add DataColumn.headingRowAlignment for DataTable (#144006)
2024-04-01 09:42:51 +00:00
data_table.dart
Fix memory leak in paginated tables (#146755)
2024-04-17 11:03:48 -07:00
date_picker_theme.dart
chore: fix some comments (#145397)
2024-03-19 17:00:24 +00:00
date_picker.dart
flutter/lib/src/: refactoring if-chains into switch expressions (#147472)
2024-05-01 12:58:35 -07:00
date.dart
…
debug.dart
…
desktop_text_selection_toolbar_button.dart
…
desktop_text_selection_toolbar.dart
…
desktop_text_selection.dart
…
dialog_theme.dart
Fix insetPadding parameter nullability for dialogs (#143305)
2024-02-13 00:12:02 +00:00
dialog.dart
Update documentation of AlertDialog's default TextStyle for Material 3 (#144697)
2024-03-08 00:21:35 +00:00
divider_theme.dart
…
divider.dart
…
drawer_header.dart
…
drawer_theme.dart
…
drawer.dart
Reland "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2" (#144273)
2024-02-28 13:55:50 -08:00
dropdown_menu_theme.dart
…
dropdown_menu.dart
DropdownMenu cleanup (#147860)
2024-05-07 07:57:21 +00:00
dropdown.dart
Fix memory leak in paginated tables (#146755)
2024-04-17 11:03:48 -07:00
elevated_button_theme.dart
…
elevated_button.dart
Reland "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2" (#144273)
2024-02-28 13:55:50 -08:00
elevation_overlay.dart
…
expand_icon.dart
Implement switch expressions in lib/src/material/ (#142634)
2024-02-01 22:31:10 +00:00
expansion_panel.dart
…
expansion_tile_theme.dart
Add AnimationStyle to ExpansionTile (#139664)
2023-12-06 16:40:24 +00:00
expansion_tile.dart
Fix memory leak in ExpansionTile. (#147596)
2024-05-04 18:19:29 -07:00
feedback.dart
…
filled_button_theme.dart
…
filled_button.dart
Reland "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2" (#144273)
2024-02-28 13:55:50 -08:00
filter_chip.dart
Reland "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2" (#144273)
2024-02-28 13:55:50 -08:00
flexible_space_bar.dart
Implement switch expressions in lib/src/material/ (#142634)
2024-02-01 22:31:10 +00:00
floating_action_button_location.dart
Add ability to disable FloatingActionButton scale and rotation animations using FloatingActionButtonAnimator.noAnimation (#146126)
2024-04-29 08:26:19 +00:00
floating_action_button_theme.dart
…
floating_action_button.dart
Fix FloatingActionButton docs for background and foreground properties (#147372)
2024-04-26 04:38:22 +00:00
flutter_logo.dart
…
grid_tile_bar.dart
…
grid_tile.dart
…
icon_button_theme.dart
…
icon_button.dart
flutter/lib/src/: refactoring if-chains into switch expressions (#147472)
2024-05-01 12:58:35 -07:00
icons.dart
Bump DartDoc to 8.0.0 (#139088)
2023-11-27 15:33:07 -08:00
ink_decoration.dart
flutter/lib/src/: refactoring if-chains into switch expressions (#147472)
2024-05-01 12:58:35 -07:00
ink_highlight.dart
…
ink_ripple.dart
…
ink_sparkle.dart
Reland: Update link branches to main (#146882)
2024-04-17 13:16:33 +00:00
ink_splash.dart
…
ink_well.dart
Implementing switch expressions: everything in flutter/lib/src/ (#143634)
2024-02-20 21:02:47 +00:00
input_border.dart
Fix filled text field active indicator overflows container bounds (#146637)
2024-04-15 07:28:19 +00:00
input_chip.dart
Introduce avatarBoxConstraints & deleteIconBoxConstraints for the chips (#143302)
2024-02-13 20:30:53 +00:00
input_date_picker_form_field.dart
Reland [a11y] Fix date picker cannot focus on the edit field (#144198)
2024-02-29 15:16:53 -08:00
input_decorator.dart
Always relies on floatingLabelStyle when FloatingLabelBehavior.always (#147374)
2024-05-03 15:16:05 +00:00
list_tile_theme.dart
Add a minTileHeight to ListTile widget so its height can be customized to less than the default height. (#145244)
2024-03-19 17:58:16 +00:00
list_tile.dart
Implements RenderBox.computeDryBaseline for material render boxes (#146027)
2024-04-02 18:37:05 +00:00
magnifier.dart
Text editing inside of Transformed.scale (#146019)
2024-04-08 22:01:05 +00:00
material_button.dart
…
material_localizations.dart
CalendarDatePicker doesn't announce selected date on desktop (#143583)
2024-02-21 08:59:24 +00:00
material_state_mixin.dart
…
material_state.dart
Fixed few typos (#147087)
2024-04-22 16:49:19 +00:00
material.dart
Add default arguments to AnimatedPhysicalModel (#147424)
2024-05-02 21:59:07 +00:00
menu_anchor.dart
fix MenuItemButton if child is null (#147485)
2024-05-07 02:39:09 +00:00
menu_bar_theme.dart
…
menu_button_theme.dart
…
menu_style.dart
…
menu_theme.dart
…
mergeable_material.dart
flutter/lib/src/: refactoring if-chains into switch expressions (#146293)
2024-04-23 16:32:15 +00:00
motion.dart
…
navigation_bar_theme.dart
Add ability to customize NavigationBar indicator overlay and fix indicator shape for the overlay (#138901)
2023-11-27 21:02:35 +00:00
navigation_bar.dart
Turning if chains into shorter switch statements (#144977)
2024-03-13 17:16:17 +00:00
navigation_drawer_theme.dart
…
navigation_drawer.dart
Implementing control flow collections (#146601)
2024-04-15 16:06:07 +00:00
navigation_rail_theme.dart
…
navigation_rail.dart
Fix memory leaks in navigation rail (#146988)
2024-04-18 08:03:19 -07:00
no_splash.dart
Fix NoSplash not being disposed (#138542)
2023-11-17 18:50:33 +00:00
outlined_button_theme.dart
…
outlined_button.dart
Reland "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2" (#144273)
2024-02-28 13:55:50 -08:00
page_transitions_theme.dart
[WIP] Predictive back support for routes (#141373)
2024-03-27 16:43:10 -07:00
page.dart
…
paginated_data_table.dart
Use dart analyze package for num.clamp (#139867)
2023-12-11 20:25:26 +00:00
popup_menu_theme.dart
…
popup_menu.dart
Fix memory leaks in PopupMenu (#147174)
2024-04-22 20:40:33 -07:00
predictive_back_page_transitions_builder.dart
[WIP] Predictive back support for routes (#141373)
2024-03-27 16:43:10 -07:00
progress_indicator_theme.dart
…
progress_indicator.dart
Update tokens to v2.3.5 (#145356)
2024-03-28 22:22:20 +00:00
radio_list_tile.dart
chore: fix some comments (#145397)
2024-03-19 17:00:24 +00:00
radio_theme.dart
Remove toggleableActiveColor from ThemeData (#144178)
2024-02-29 20:58:11 +00:00
radio.dart
Remove toggleableActiveColor from ThemeData (#144178)
2024-02-29 20:58:11 +00:00
range_slider.dart
flutter/lib/src/: refactoring if-chains into switch expressions (#146293)
2024-04-23 16:32:15 +00:00
refresh_indicator.dart
Implementing switch expressions in lib/src/material/ (#142793)
2024-02-09 22:03:23 +00:00
reorderable_list.dart
Intensive if chain refactoring (#145194)
2024-03-22 13:55:06 +00:00
scaffold.dart
Fix floating SnackBar is not centered when RTL and Material 2 (#147861)
2024-05-08 07:34:05 +00:00
scrollbar_theme.dart
Remove showTrackOnHover from Scrollbar and ScrollbarTheme (#144180)
2024-03-13 16:31:50 +00:00
scrollbar.dart
flutter/lib/src/: refactoring if-chains into switch expressions (#147472)
2024-05-01 12:58:35 -07:00
search_anchor.dart
fixes SearchAnchor leak (#147652)
2024-05-03 09:34:11 -07:00
search_bar_theme.dart
Fix import pattern (#140425)
2023-12-21 00:18:09 +00:00
search_view_theme.dart
Add headerHeight for SearchAnchor (#141223)
2024-01-17 22:49:04 +00:00
search.dart
implemented leadingWidth and automaticallyImplyLeading options (#136165)
2023-11-29 08:29:06 +00:00
segmented_button_theme.dart
Style correctness improvements for toStrings and related fixes (#142485)
2024-01-30 22:41:15 +00:00
segmented_button.dart
Add missing overlayColor property in styleFrom methods (#146685)
2024-04-24 11:56:32 +00:00
selectable_text.dart
flutter/lib/src/: refactoring if-chains into switch expressions (#146293)
2024-04-23 16:32:15 +00:00
selection_area.dart
Mention SelectionArea in SelectableText docs (#143784)
2024-02-28 14:36:08 -08:00
shadows.dart
Magnifier cleanup (#143558)
2024-04-03 15:49:38 -07:00
slider_theme.dart
flutter/lib/src/: refactoring if-chains into switch expressions (#146293)
2024-04-23 16:32:15 +00:00
slider.dart
Fix _RenderValueIndicator leak (#147451)
2024-04-27 17:30:58 -07:00
snack_bar_theme.dart
Added Missing Field Name in Doc Comment in SnackBarThemeData (#143588)
2024-02-16 20:50:07 +00:00
snack_bar.dart
Fix floating SnackBar is not centered when RTL and Material 2 (#147861)
2024-05-08 07:34:05 +00:00
spell_check_suggestions_toolbar_layout_delegate.dart
…
spell_check_suggestions_toolbar.dart
Add timeline events for post frame callbacks (#136435)
2023-10-22 20:46:21 +00:00
stepper.dart
Fix vertical Stepper draws connector on the last step (#145703)
2024-03-25 21:47:05 +00:00
switch_list_tile.dart
Remove toggleableActiveColor from ThemeData (#144178)
2024-02-29 20:58:11 +00:00
switch_theme.dart
…
switch.dart
Fix memory leak in switch painter (#147228)
2024-04-23 11:14:19 -07:00
tab_bar_theme.dart
Introduce TabBar.textScaler for tab label upper text scale limit (#147232)
2024-05-07 20:54:09 +00:00
tab_controller.dart
Re-land fix for not disposed TabController (#146745)
2024-04-22 20:28:50 +00:00
tab_indicator.dart
Fixed a lot of typos (#141431)
2024-01-12 22:10:25 +00:00
tabs.dart
Introduce TabBar.textScaler for tab label upper text scale limit (#147232)
2024-05-07 20:54:09 +00:00
text_button_theme.dart
…
text_button.dart
Reland "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2" (#144273)
2024-02-28 13:55:50 -08:00
text_field.dart
Reland [a11y] Add isEnabled semantics flag to text field (#143601)
2024-02-27 22:49:13 +00:00
text_form_field.dart
Feat: TextField can scroll when disabled (#140922)
2024-01-29 20:22:19 +00:00
text_selection_theme.dart
…
text_selection_toolbar_text_button.dart
…
text_selection_toolbar.dart
Horizontally expand text selection toolbar buttons in overflow menu (#144391)
2024-03-01 06:40:47 +00:00
text_selection.dart
Horizontally expand text selection toolbar buttons in overflow menu (#144391)
2024-03-01 06:40:47 +00:00
text_theme.dart
Remove deprecated TextTheme members (#139255)
2024-03-28 01:20:55 +00:00
theme_data.dart
Deprecate ButtonBar, ButtonBarThemeData, and ThemeData.buttonBarTheme (#145523)
2024-04-01 11:39:48 +00:00
theme.dart
…
time_picker_theme.dart
chore: fix some comments (#145397)
2024-03-19 17:00:24 +00:00
time_picker.dart
Implements RenderBox.computeDryBaseline for material render boxes (#146027)
2024-04-02 18:37:05 +00:00
time.dart
Add missing parameter to TableBorder.symmetric, and improve class constructors (#144279)
2024-03-04 20:20:19 +00:00
toggle_buttons_theme.dart
…
toggle_buttons.dart
flutter/lib/src/: refactoring if-chains into switch expressions (#146293)
2024-04-23 16:32:15 +00:00
toggleable.dart
Add CurvedAnimation disposals in some widgets (#143790)
2024-02-22 19:16:25 +00:00
tooltip_theme.dart
Revise tooltip theme docs, including more cross-references (#137316)
2024-01-24 17:26:03 +00:00
tooltip_visibility.dart
…
tooltip.dart
Fix Tooltip.decoration comment (#147858)
2024-05-06 13:13:19 +00:00
typography.dart
Replace dead links (#144827)
2024-03-09 01:08:06 +00:00
user_accounts_drawer_header.dart
Fix leak memory in Tooltip and account detail (#146833)
2024-04-16 12:15:37 -07:00